Statistics
| Branch: | Revision:

root @ 81a97d9d

# Date Author Comment
94a420b1 09/10/2010 12:22 am Stefan Hajnoczi

trace: Add trace-events file for declaring trace events

This patch introduces the trace-events file where trace events can be
declared like so:

qemu_malloc(size_t size) "size %zu"
qemu_free(void *ptr) "ptr %p"

These trace event declarations are processed by a new tool called...

26f7227b 09/10/2010 12:22 am Stefan Hajnoczi

trace: Add simple built-in tracing backend

This patch adds a simple tracer which produces binary trace files. To
try out the simple backend:

$ ./configure --trace-backend=simple
$ make

After running QEMU you can pretty-print the trace:

$ ./simpletrace.py trace-events trace.log...

22890ab5 09/10/2010 12:22 am Prerna Saxena

trace: Support for dynamically enabling/disabling trace events

This patch adds support for dynamically enabling/disabling of trace events.
This is done by internally maintaining each trace event's state, and
permitting logging of data from a trace event only if it is in an...

1e2cf2bc 09/10/2010 12:22 am Stefan Hajnoczi

trace: Support disabled events in trace-events

Sometimes it is useful to disable a trace event. Removing the event
from trace-events is not enough since source code will call the
trace_*() function for the event.

This patch makes it easy to build without specific trace events by...

9410b56c 09/10/2010 12:22 am Prerna Saxena

trace: Specify trace file name

Allow users to specify a file for trace-outputs at configuration.
Also, allow trace files to be annotated by <pid> so each qemu instance has
unique traces.

The trace file name can be passed as a config option:
--trace-file=/path/to/file...

c5ceb523 09/10/2010 12:22 am Stefan Hajnoczi

trace: Add trace-file command to open/close/flush trace file

This patch adds the trace-file command:

trace-file [on|off|flush]
Open, close, or flush the trace file.  If no argument is given,
the status of the trace file is displayed.

The trace file is turned on by default but is only written out when the...

ab6540d5 09/10/2010 12:22 am Prerna Saxena

trace: Add trace file name command-line option

This patch adds an optional command line switch '-trace' to specify the
filename to write traces to, when qemu starts.
Eg, If compiled with the 'simple' trace backend,
[temp@system]$ qemu -trace FILENAME IMAGE...

7e24e92a 09/10/2010 12:22 am Stefan Hajnoczi

trace: Add LTTng Userspace Tracer backend

This patch adds LTTng Userspace Tracer (UST) backend support. The UST
system requires no kernel support but libust and liburcu must be
installed.

$ ./configure --trace-backend ust
$ make

Start the UST daemon:
$ ustd &...

81a97d9d 09/10/2010 12:22 am Stefan Hajnoczi

trace: Add user documentation

Signed-off-by: Stefan Hajnoczi <>

ef9d48da 09/09/2010 11:05 pm Edgar E. Iglesias

microblaze: Add support for fcmp.un

Signed-off-by: Edgar E. Iglesias <>

e403e433 09/09/2010 10:37 pm Stefan Weil

elf: Calculate symbol size if needed

Symbols with a size of 0 are unusable for the disassembler.

Example:

While running an arm linux kernel, no symbolic names are
used in qemu.log when the cpu is executing an assembler function.

Assume that the size of such symbols is the difference to the...

d7d9b528 09/09/2010 10:13 pm Blue Swirl

Fix OpenBSD build warning

Fix this warning:
CC savevm.o
/src/qemu/savevm.c: In function `do_savevm':
/src/qemu/savevm.c:1900: warning: passing arg 1 of `localtime_r' from incompatible pointer type

It looks like on OpenBSD the type of tv_sec in struct timeval is still...

b76da7e3 09/09/2010 11:24 am Edgar E. Iglesias

microblaze: User-mode emulation of hw-excp signals

Signed-off-by: Edgar E. Iglesias <>

97694c57 09/09/2010 11:20 am Edgar E. Iglesias

microblaze: Add basic FPU emulation

Missing:
  • fcmp.un insn
  • Denormalized exceptions
  • Exception model is not accurate

Signed-off-by: Edgar E. Iglesias <>

bdc0bf29 09/09/2010 10:58 am Edgar E. Iglesias

microblaze: Add definitions for FSR reg fields

Signed-off-by: Edgar E. Iglesias <>

8b33d9ee 09/09/2010 01:09 am Anthony Liguori

Revert "Make default invocation of block drivers safer (v3)"

This reverts commit 79368c81bf8cf93864d7afc88b81b05d8f0a2c90.

Conflicts:

block.c

I haven't been able to come up with a solution yet for the corruption caused by
unaligned requests from the IDE disk so revert until a solution can be written....

b19159e8 09/08/2010 10:55 pm Anthony Liguori

Revert "PPC: Qdev'ify e500 pci"

This reverts commit 13b7fdeffa68e3382231a70308593ae6a75d96c3.

Signed-off-by: Anthony Liguori <>

031c0c55 09/08/2010 10:54 pm Anthony Liguori

Revert "PPC: Make e500 pci byte swap config data"

This reverts commit cfb207e643d94e3e96d456b1df14c5e36f6aa9e5.

Signed-off-by: Anthony Liguori <>

53462f4a 09/08/2010 10:29 pm Anthony Liguori

Merge remote branch 'agraf/ppc-next' into staging

aab2e8f7 09/08/2010 10:26 pm Anthony Liguori

Merge remote branch 'kwolf/for-anthony' into staging

dccbe6fb 09/08/2010 10:26 pm Anthony Liguori

Merge remote branch 'mst/for_anthony' into staging

cf03eb2c 09/08/2010 08:28 pm Arun R Bharadwaj

[virtio-9p] Remove all instances of unnecessary dotu variable.

Signed-off-by: Arun R Bharadwaj <>
Signed-off-by: Venkateswararao Jujjuri <>

8f4d1ca5 09/08/2010 08:28 pm Arun R Bharadwaj

[virtio-9p] This patch implements TLERROR/RLERROR on the qemu 9P server.

Signed-off-by: Arun R Bharadwaj <>
Signed-off-by: Venkateswararao Jujjuri <>

630c2689 09/08/2010 08:28 pm Sripathi Kodi

virtio-9p: Change handling of flags in open() path for 9P2000.L

This patch applies on top of 9P2000.L patches that we have on the list.
I took a look at how 9P server is handling open() flags in 9P2000.L path.
I think we can do away with the valid_flags() function and simplify the...

61b6c499 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Hide user.virtfs xattr in case of mapped security.

With mapped security mode we use "user.virtfs" namespace is used
to store the virtFs related attributes. So hide it from user.

Signed-off-by: Aneesh Kumar K.V <>

12848bfc 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Add SM_NONE security model

This is equivalent to SM_PASSTHROUGH security model.
The only exception is, failure of privilige operation like chown
are ignored. This makes a passthrough like security model usable
for people who runs kvm as non root...

5c0f255d 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Use lchown which won't follow symlink

We should always use functions which don't follow
symlink on the server

Signed-off-by: Aneesh Kumar K.V <>

783f04e1 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Fix the memset usage

The arguments are wrong. Use qemu_mallocz directly

Signed-off-by: Aneesh Kumar K.V <>

9ed3ef26 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Add support for removing xattr

Signed-off-by: Aneesh Kumar K.V <>

c7b4b0b3 09/08/2010 08:26 pm M. Mohan Kumar

rename - change name of file or directory

size4 Trename tag2 fid4 newdirfid4 name[s]
size4 Rrename tag2

Implement the 2000.L rename operation. A new function
v9fs_complete_rename is introduced that acts as a common entry point
for 2000.L rename operation and 2000.U rename opearation (via wstat)....

771e9d4c 09/08/2010 08:26 pm M. Mohan Kumar

[virtio-9p] qemu: virtio-9p: Implement LOPEN

Implement 9p2000.L version of open(LOPEN) interface in qemu 9p server.

For LOPEN, no need to convert the flags to and from 9p mode to VFS mode.

Synopsis:

size[4] Tlopen tag[2] fid[4] mode[4]
size[4] Rlopen tag[2] qid[13] iounit[4]...
d62dbb51 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Add fidtype so that we can do type specific operation

We want to add type specific operation during read/write

Signed-off-by: Aneesh Kumar K.V <>

fa32ef88 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Implement TXATTRWALK

TXATTRWALK: Descend a ATTR namespace

size[4] TXATTRWALK tag[2] fid[4] newfid[4] name[s]
size[4] RXATTRWALK tag[2] size[8]

txattrwalk gets a fid pointing to xattr. This fid can later be
used to get read the xattr value. If name is NULL the fid returned...

10b468bd 09/08/2010 08:26 pm Aneesh Kumar K.V

virtio-9p: Implement TXATTRCREATE

TXATTRCREATE: Prepare a fid for setting xattr value on a file system object.

size[4] TXATTRCREATE tag[2] fid[4] name[s] attr_size[8] flags[4]
size[4] RXATTRWALK tag[2]

txattrcreate gets a fid pointing to xattr. This fid can later be...

8fc39ae4 09/08/2010 08:26 pm Sripathi Kodi

[virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat.

Currently v9fs_do_utimensat takes a V9fsStat argument and builds
timespec structures. It sets tv_nsec values to 0 by default. Instead
of this it should take struct timespec2 and pass it down to the...

c79ce737 09/08/2010 08:26 pm Sripathi Kodi

virtio-9p: Implement server side of setattr for 9P2000.L protocol.

SYNOPSIS

size[4] Tsetattr tag[2] attr[n]
size[4] Rsetattr tag[2]
DESCRIPTION
The setattr command changes some of the file status information.
attr resembles the iattr structure used in Linux kernel. It...
b2c224be 09/08/2010 08:26 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Implement TLINK for 9P2000.L

Create a Hardlink.

SYNOPSIS

size4 Tlink tag2 dfid4 oldfid4 newpath[s]

size4 Rlink tag2

DESCRIPTION

Create a link 'newpath' in directory pointed by dfid linking to oldfid path.

Signed-off-by: Venkateswararao Jujjuri <>

08c60fc9 09/08/2010 08:26 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Define and implement TSYMLINK for 9P2000.L

This patch implements creating a symlink for TSYMLINK request
and responds with RSYMLINK. In the case of error, we return RERROR.

SYNOPSIS

size[4] Tsymlink tag[2] fid[4] name[s] symtgt[s] gid[4]...
c1568af5 09/08/2010 08:26 pm Venkateswararao Jujjuri (JV)

[virtio-9p] This patch implements TLCREATE for 9p2000.L protocol.

SYNOPSIS

size[4] Tlcreate tag[2] fid[4] name[s] flags[4] mode[4] gid[4]
size[4] Rlcreate tag[2] qid[13] iounit[4]

DESCRIPTION

The Tlreate request asks the file server to create a new regular file with the...

5268cecc 09/08/2010 08:26 pm M. Mohan Kumar

qemu: virtio-9p: Implement TMKNOD

Implement TMKNOD as part of 2000.L Work

Synopsis

size[4] Tmknod tag[2] fid[4] name[s] mode[4] major[4] minor[4] gid[4]
size[4] Rmknod tag[2] qid[13]

Description

mknod asks the file server to create a device node with given device...
b67592ea 09/08/2010 08:26 pm M. Mohan Kumar

qemu: virtio-9p: Implement TMKDIR

Synopsis

size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4]
size[4] Rmkdir tag[2] qid[13]

Description

mkdir asks the file server to create a directory with given name,
mode and gid. The qid for the new directory is returned with...
be940c87 09/08/2010 08:26 pm M. Mohan Kumar

qemu: virtio-9p: Implement statfs support in server

Implement statfs support in qemu server based on Sripathi's
initial statfs patch.

Signed-off-by: M. Mohan Kumar <>
Signed-off-by: Sripathi Kodi <>
Signed-off-by: Venkateswararao Jujjuri <>

926487b7 09/08/2010 08:26 pm Sripathi Kodi

virtio-9p: Return correct error from v9fs_remove

Signed-off-by: Sripathi Kodi <>

In v9fs_remove_post_remove() we currently ignore the error returned by
the previous call to remove() and return an error only if freeing the
fid fails. However, the client expects to see the error from remove()....

c18e2f94 09/08/2010 08:26 pm Sripathi Kodi

[V4] virtio-9p: readdir implementation for 9p2000.L

This patch implements the server part of readdir() implementation for
9p2000.L

SYNOPSIS
size[4] Treaddir tag[2] fid[4] offset[8] count[4]
size[4] Rreaddir tag[2] count[4] data[count]
DESCRIPTION...
5e94c103 09/08/2010 08:26 pm M. Mohan Kumar

virtio-9p: Compute iounit based on host filesystem block size

Compute iounit based on the host filesystem block size and pass it to
client with open/create response. Also return iounit as statfs's f_bsize
for optimal block size transfers.

Signed-off-by: M. Mohan Kumar <>...

00ede4c2 09/08/2010 08:26 pm Sripathi Kodi

virtio-9p: getattr server implementation for 9P2000.L protocol.

SYNOPSIS
size[4] Tgetattr tag[2] fid[4] request_mask[8]
size[4] Rgetattr tag[2] lstat[n]
DESCRIPTION
The getattr transaction inquires about the file identified by fid....
74bc02b2 09/08/2010 08:26 pm M. Mohan Kumar

virtio-9p: Do not reset atime

Current code resets file's atime to 0 when there is a change in mtime.
This results in resetting the atime to "1970-01-01 05:30:00". For
example, truncate -s 0 filename results in changing the mtime to the
truncate time, but resets the atime to "1970-01-01 05:30:00". utime...
84151514 09/08/2010 08:26 pm M. Mohan Kumar

qemu: virtio-9p: Recognize 9P2000.L protocol

Make 9P server recognize 9P2000.L protocol version

Signed-off-by: M. Mohan Kumar <>
Signed-off-by: Venkateswararao Jujjuri <>

7ec5e6a4 09/08/2010 01:39 pm Kevin Wolf

qcow2: Remove unnecessary flush after L2 write

When a new cluster was allocated, we only need a flush after the write to the
L2 table if it was a COW and we need to decrease the refcounts of the old
clusters.

Signed-off-by: Kevin Wolf <>

ceb25e5c 09/08/2010 01:39 pm Kevin Wolf

block: Fix BDRV_O_CACHE_MASK

BDRV_O_CACHE_MASK should have been extended when cache=unsafe introduced a new
flag BDRV_O_NO_FLUSH. There are currently no users that would change their
behaviour because of this, but let's clean it up before things break.

Signed-off-by: Kevin Wolf <>

1bd8e175 09/08/2010 01:39 pm Kevin Wolf

qemu-img convert: Use cache=unsafe for output image

If qemu-img crashes during the conversion, the user will throw away the broken
output file anyway and start over. So no need to be too cautious.

Signed-off-by: Kevin Wolf <>

05acda4d 09/08/2010 01:39 pm Bernhard Kohl

raw-posix: improve detection of scsi-generic devices

Allow symbolic links which point to /dev/sgX devices.

Signed-off-by: Bernhard Kohl <>
Signed-off-by: Kevin Wolf <>

ebef0bbb 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: add some optional scsi commands

I use a legacy OS which depends on some optional SCSI commands.
In fact this implementation does nothing special, but provides minimum
support for the following commands:

REZERO UNIT
WRITE AND VERIFY
WRITE AND VERIFY...

79d1d331 09/08/2010 01:39 pm Jonathan A. Kollasch

Improve ATA IDENTIFY word 64 contents.

Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4.
This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

Signed-off-by: Jonathan A. Kollasch <>
Signed-off-by: Kevin Wolf <>

897804d6 09/08/2010 01:39 pm Kevin Wolf

raw-posix: Don't use file name for host_cdrom detection on Linux

On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose
anything but false positives by removing the check for a /dev/cd* path.

Signed-off-by: Kevin Wolf <>

b407a81e 09/08/2010 01:39 pm Stefan Hajnoczi

qemu-io: Make alloc output useful when nb_sectors=1

There is no indication whether or not the sector is allocated when
nb_sectors=1:

sector allocated at offset 64 KiB

This message is produced whether or not the sector is allocated.

Simply use the same message as the plural case, I don't think the...

aa2b1e89 09/08/2010 01:39 pm Bernhard Kohl

scsi: fix and improve debug prints

Some of them are not compile clean.

Signed-off-by: Bernhard Kohl <>
Signed-off-by: Kevin Wolf <>

333d50fe 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: fix the check of the DBD bit in the MODE SENSE command

The DBD bit does not work as expected.

SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
"A disable block descriptors (DBD) bit of zero indicates that the target
may return zero or more block descriptors in the returned MODE SENSE...

a9c17b2b 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command

SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
"An initiator may request any one or all of the supported mode pages
from a target. If an initiator issues a MODE SENSE command with a...

2488b740 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: fix the block descriptor returned by the MODE SENSE command

The block descriptor contains the number of blocks, not the highest LBA.
Real hard disks return 0 if the number of blocks exceed the maximum 0xFFFFFF.

SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3...

282ab04e 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: respect the page control (PC) field in the MODE SENSE command

The page control (PC) field defines the type of mode parameter values
to be returned in the mode pages:

PC=0 : Current values
PC=1 : Changeable values
PC=2 : Default values
PC=3 : Saved values...

ce512ee1 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: fix the mode data header returned by the MODE SENSE command

The header for the MODE SENSE command is 8 bytes long.

Signed-off-by: Bernhard Kohl <>
Signed-off-by: Kevin Wolf <>

78e70c30 09/08/2010 01:39 pm Bernhard Kohl

scsi-disk: fix the mode data length field returned by the MODE SENSE command

The MODE DATA LENGTH field indicates the length in bytes of the following
data that is available to be transferred. The mode data length does not include
the number of bytes in the MODE DATA LENGTH field....

a697a334 09/07/2010 08:29 pm Alex Williamson

virtio-net: Introduce a new bottom half packet TX

Based on a patch from Mark McLoughlin, this patch introduces a new
bottom half packet transmitter that avoids the latency imposed by
the tx_timer approach. Rather than scheduling a timer when a TX
packet comes in, schedule a bottom half to be run from the iothread....

4b4b8d36 09/07/2010 08:29 pm Alex Williamson

virtio-net: Rename tx_timer_active to tx_waiting

De-couple this from the timer since we might want to use
different backends to send the packet.

Signed-off-by: Alex Williamson <>
Signed-off-by: Michael S. Tsirkin <>

e3f30488 09/07/2010 08:29 pm Alex Williamson

virtio-net: Limit number of packets sent per TX flush

If virtio_net_flush_tx() is called with notification disabled, we can
race with the guest, processing packets at the same rate as they
get produced. The trouble is that this means we have no guaranteed...

f0c07c7c 09/07/2010 08:29 pm Alex Williamson

virtio-net: Make tx_timer timeout configurable

Add an option to make the TX mitigation timer adjustable as a device
option. The 150us hard coded default used currently is reasonable,
but may not be suitable for all workloads, this gives us a way to
adjust it using a single binary. We can't support any random option...

ca736c8e 09/07/2010 08:27 pm Michael S. Tsirkin

vhost_net: mergeable buffers support

use the new tap APIs to set header length

Signed-off-by: Michael S. Tsirkin <>

445d892f 09/07/2010 08:27 pm Michael S. Tsirkin

tap: add APIs for vnet header length

Add APIs to control host header length. First user
will be vhost-net.

Signed-off-by: Michael S. Tsirkin <>

ef4252b1 09/07/2010 08:27 pm Michael S. Tsirkin

tap: generalize code for different vnet header len

Make host vnet header length a structure field in
preparation for using this support in linux kernel.

Signed-off-by: Michael S. Tsirkin <>

42a87658 09/07/2010 02:46 pm Alexander Graf

PPC: Change PPC maintainer

Since nobody else seems interested in maintaining PPC, let's change the
maintainer to myself. I keep a staging tree anyways and am probably the
person touching most of that code these days.

This changes the maintainer entry for working ppc targets to myself....

a05e8a6e 09/06/2010 02:47 pm Michael S. Tsirkin

qemu: e1000 fix TOR math

Patch b0b900070c7cb29bbefb732ec00397abe5de6d73 made
TOR valuer incorrect: the spec says it should always
include the CRC field.
No one seems to use this field, but better to stick to spec.

Signed-off-by: Michael S. Tsirkin <>

fc87e185 09/05/2010 12:50 pm Alexander Graf

KVM: PPC: Add level based interrupt logic

KVM on PowerPC used to have completely broken interrupt logic. Usually,
interrupts work by having a PIC that pulls a line up/down, so the CPU knows
that an interrupt is active. This line stays active until some action is...

13b7fdef 09/05/2010 12:50 pm Alexander Graf

PPC: Qdev'ify e500 pci

The e500 PCI controller isn't qdev'ified yet. This leads to severe issues
when running with -drive.

To be able to use a virtio disk with an e500 VM, let's convert the PCI
controller over to qdev.

Signed-off-by: Alexander Graf <>

cfb207e6 09/05/2010 12:50 pm Alexander Graf

PPC: Make e500 pci byte swap config data

The config data field on the e500 pci controller is in little endian, so we need
to enable byte swap there.

Signed-off-by: Alexander Graf <>

ba5e7f82 09/04/2010 01:11 pm Izumi Tsutsui

vnc: use bswapNN() rather than bswap_NN()

bswap_NN() variants are not always available in CONFIG_MACHINE_BSWAP_H case
and bswapNN() are public APIs in "bswap.h".

Signed-off-by: Izumi Tsutsui <>
Signed-off-by: Blue Swirl <>

49e3fcc2 09/04/2010 12:55 pm Serge Ziryukin

vnc: tight: remove unused variable

Signed-off-by: Serge Ziryukin <>
Signed-off-by: Blue Swirl <>

ad0a4ac1 09/04/2010 12:53 pm Avi Kivity

Fix ivshmem build on 32-bit hosts

stat() fields can be more or less anything depending on configuration, cast
explicitly to uint64_t to avoid printf() format mismatches.

Signed-off-by: Avi Kivity <>
Signed-off-by: Blue Swirl <>

c93031e5 09/04/2010 12:52 pm Aneesh Kumar K.V

virtio-9p: Make sure -virtfs option works correctly

When making copy of arguments we were doing partial copy

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Blue Swirl <>

1b27d7a1 09/04/2010 12:52 pm Jes Sorensen

hw/ivshmem.c don't check for negative values on unsigned data types

There is no need to check for dest < 0 or vector >= 0 as both are
uint16_t.

This should fix problems with broken build with aggressive compiler
flags. Reported by Xudong Hao <>...

7390cdfb 09/04/2010 12:45 pm Jes Sorensen

Change DPRINTF to do{}while(0) to avoid compiler warning

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>

37a05af0 09/04/2010 12:45 pm Jes Sorensen

load_multiboot(): get_image_size() returns int

Do not store return of get_image_size() in a uint32_t as it makes it
impossible to detect error returns from get_image_size.

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>

2116eff9 09/04/2010 12:45 pm Jes Sorensen

size_t is unsigned, change to ssize_t to handle errors from tight_compress_data()

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>

26056e0c 09/04/2010 12:45 pm Jes Sorensen

Fix repeated typo: was "end if list" instead of "end of list"

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>

e301b13d 09/04/2010 12:45 pm Jes Sorensen

Respect return value from nbd_client()

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>

0a4eb864 09/04/2010 12:45 pm Jes Sorensen

Remove unused argument for nbd_client()

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>

cb93bbdd 08/31/2010 11:16 pm Blue Swirl

Fix OpenBSD linker warning

Fix a warning from OpenBSD linker:
../libhw32/vl.o(.text+0x5c3c): In function `main':
/src/qemu/vl.c:2335: warning: sprintf() is often misused, please use snprintf()

Signed-off-by: Blue Swirl <>

d729bb9a 08/30/2010 11:06 pm Isaku Yamahata

acpi: fix file size check with -acpitable.

acpi table file can be modified during load so file size check
should be more strict.
pointer calculation should be after qemu_realloc(). not before realloc().

Signed-off-by: Isaku Yamahata <>...

f9209915 08/30/2010 07:29 pm Miguel Di Ciurcio Filho

monitor: make 'info snapshots' show only fully available snapshots

The output generated by 'info snapshots' shows only snapshots that exist on the
block device that saves the VM state. This output can cause an user to
erroneously try to load an snapshot that is not available on all block devices....

7d631a11 08/30/2010 07:29 pm Miguel Di Ciurcio Filho

savevm: Generate a name when run without one

When savevm is run without a name, the name stays blank and the snapshot is
saved anyway.

The new behavior is when savevm is run without parameters a name will be
created automaticaly, so the snapshot is accessible to the user without needing...

b6a4805b 08/30/2010 07:29 pm Kevin Wolf

virtio-blk: Fix migration of queued requests

in_sg[].iovec and out_sg[].ioved are pointer to (source) host memory and
therefore invalid after migration. When loading the device state we must
create a new mapping on the destination host.

Signed-off-by: Kevin Wolf <>

ee181196 08/30/2010 07:29 pm Kevin Wolf

block: Fix image re-open in bdrv_commit

Arguably we should re-open the backing file with the backing file format and
not with the format of the snapshot image.

Signed-off-by: Kevin Wolf <>

010cb2b3 08/30/2010 07:29 pm Izumi Tsutsui

sheepdog: remove unnecessary includes

"qemu_socket.h" includes all necessary files and
including <netinet/tcp.h> without <netinet/in.h>
could cause errors on some systems.

Signed-off-by: Izumi Tsutsui <>
Signed-off-by: Kevin Wolf <>

cdbae851 08/30/2010 07:29 pm Kevin Wolf

qemu-img rebase: Open new backing file read-only

We never write to a backing file, so opening rw is useless. It just means that
you can't rebase on top of a file for which you don't have write permissions.

Signed-off-by: Kevin Wolf <>

2aa326be 08/30/2010 07:29 pm Loïc Minier

vvfat: fat_chksum(): fix access above array bounds

Signed-off-by: Loïc Minier <>
Signed-off-by: Kevin Wolf <>

1d45f8b5 08/30/2010 07:29 pm Laurent Vivier

nbd: Introduce NBD named exports.

This patch allows to connect Qemu using NBD protocol to an nbd-server
using named exports.

For instance, if on the host "isoserver", in /etc/nbd-server/config, you have:

[generic]
[debian-500-ppc-netinst]
exportname = /ISO/debian-500-powerpc-netinst.iso...

34cf0081 08/30/2010 07:29 pm Andrew de Quincey

posix-aio-compat: Fix async_conmtext for ioctl

Set the async_context_id field when queuing an async ioctl call

Signed-off-by: Andrew de Quincey <>
Signed-off-by: Kevin Wolf <>

42fb2e07 08/30/2010 07:29 pm Kevin Wolf

virtio: Factor virtqueue_map_sg out

Separate the mapping of requests to host memory from the descriptor iteration.
The next patch will make use of it in a different context.

Signed-off-by: Kevin Wolf <>

02a89b21 08/28/2010 11:50 am Isaku Yamahata

isapc: fix segfault.

https://bugs.launchpad.net/bugs/611646
reports that ./i386-softmmu/qemu -M isapc segfaults.
This patch fixes the segfault introduced by
f885f1eaa8711c06033ceb1599e3750fb37c306f

It's because i440fx_state in pc_init1() isn't initialized....

95c318f5 08/28/2010 11:47 am Gleb Natapov

Fix segfault in mmio subpage handling code.

It is possible that subpage mmio is registered over existing memory
page. When this happens "memory" will have real memory address and not
index into io_mem array so next access to the page will generate
segfault. It is uncommon to have some part of a page to be accessed as...