Statistics
| Branch: | Revision:

root / hw @ 8a231487

# Date Author Comment
8a231487 03/03/2011 04:13 pm Andrzej Zaborowski

pxa2xx: port pxa2xx_rtc to using qdev/vmstate

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

f114c826 03/03/2011 04:06 pm Andrzej Zaborowski

pxa2xx_dma: Get rid of a forward declaration.

2115c019 03/03/2011 04:04 pm Andrzej Zaborowski

pxa2xx_dma: port to qdev/vmstate

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

47188700 03/03/2011 03:54 pm Dmitry Eremin-Solenikov

vmstate: move VMSTATE_PCIE_AER_ERRS to hw/hw.h

VMSTATE_PCIE_AER_ERRS is indeed useful for other emulation drivers.
Move it to hw/hw.h under the name of VMSTATE_STRUCT_VARRAY_POINTER_UINT16.
Also add VMSTATE_STRUCT_VARRAY_POINTER_INT32 which is more or less...

ee2479d3 03/03/2011 03:50 pm Dmitry Eremin-Solenikov

pxa2xx_dma: drop unused pxa2xx_dma_handler_t/handler field

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

5251d196 03/03/2011 03:24 pm Andrzej Zaborowski

pxa2xx_timer: Store relevant irq line in each timer.

797e9542 03/03/2011 03:14 pm Dmitry Eremin-Solenikov

pxa2xx_timer: switch to using qdev/vmstate

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

d353eb43 03/03/2011 04:45 am Dmitry Eremin-Solenikov

pxa2xx_timer: change info struct name to comply with guidelines

It should be PXA2xxTimerInfo, not pxa2xx_timer_info. Replace all
occurences of old name with the new one.

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

0c69aa70 03/03/2011 04:43 am Andrzej Zaborowski

pxa2xx_pic: Set base address for sysbus device.

Thid device's registration was broken since
e1f8c729fa890c67bb4532f22c22ace6fb0e1aaf, this should fix it.

13801f32 03/03/2011 04:34 am Dmitry Eremin-Solenikov

vmstate: add VMSTATE_STRUCT_ARRAY_TEST

This is a _TEST variant of VMSTATE_STRUCT_ARRAY, necessary e.g.
for future patch changing pxa2xx_timer to use vmstate.

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

e1f8c729 02/25/2011 01:13 pm Dmitry Eremin-Solenikov

pxa2xx_pic: update to use qdev

Use qdev/sysbus framework to handle pxa2xx-pic. Instead of exposing IRQs
via array, reference them via qdev_get_gpio_in().

Patch has been modified by the committer.

Signed-off-by: Dmitry Eremin-Solenikov <>...

3e1dbc3b 02/25/2011 10:06 am Dmitry Eremin-Solenikov

mst_fpga: correct irq level settings

Final corrections for IRQ levels that are set by mst_fpga:

  • Don't retranslate IRQ if previously IRQ was masked.
  • After setting or clearing IRQs through register, apply mask
    before setting parent IRQ level.

Signed-off-by: Dmitry Eremin-Solenikov <>...

a43f9c90 02/24/2011 07:25 pm Gerd Hoffmann

virtio-serial: kill VirtIOSerialDevice

VirtIOSerialDevice is like VirtIOSerialPort with just the first two
fields, which makes it pretty pointless. Using VirtIOSerialPort
directly works equally well and is less confusing.

[Amit: - rebase
- rename 'dev' to 'port' in function params in virtio-serial.h ]...

fb1ba03a 02/24/2011 09:53 am Peter Maydell

hw/sd.c: Add missing state change for SD_STATUS, SEND_NUM_WR_BLOCKS

The SD_STATUS and SEND_NUM_WR_BLOCKS commands are supposed to cause
the card to send data back to the host. However sd.c was missing the
state change to sd_sendingdata_state for these commands, with the effect...

082e5be8 02/23/2011 01:31 pm Edgar E. Iglesias

pls3adsp1800: Base load_elf endianness on target endianness

Signed-off-by: Edgar E. Iglesias <>

9a31334f 02/21/2011 05:02 pm Peter Maydell

hw/irq.h: Remove unused SetIRQFunc typedef

Remove the typedef SetIRQFunc, as it is not used by anything.

Signed-off-by: Peter Maydell <>
Signed-off-by: Aurelien Jarno <>

81aa0647 02/21/2011 04:53 pm Aurelien Jarno

Revert "prep: Disable second IDE channel, as long as ISA IDE emulation doesn't support same irq for both channels"

This reverts commit 491e2a338fdf8310c84f6ebaed1683a871a0700e.

ee951a37 02/21/2011 04:46 pm Jan Kiszka

isa-bus: Remove bogus IRQ sharing check

Nothing prevented IRQ sharing on the ISA bus in principle. Not all
boards supported this, neither each and every card nor driver and OS.
Still, there existed valid IRQ sharing scenarios, (at least) two of them
can also be found in QEMU: >2 PC UARTs and the PREP IDE buses....

7096a96d 02/21/2011 04:41 pm Roy Tam

PS/2 keyboard Scancode Set 3 support

The following patch adds PS/2 keyboard Scancode Set 3 support.

Signed-off-by: Roy Tam <>
Signed-off-by: Aurelien Jarno <>

9dda2465 02/20/2011 09:28 pm Vasily Khoruzhick

Fix obvious mistake in pxa2xx i2s driver

RST bit is (1 << 4) bit, not (1 << 3), fix condition
that enables i2s if ENB is set and RST is not set.

Signed-off-by: Vasily Khoruzhick <>
Signed-off-by: Aurelien Jarno <>

582798b5 02/20/2011 08:53 pm Vasily Khoruzhick

pxa2xx_keypad: Handle 0xe0xx keycodes

Add handling of 0xe0xx keycodes to pxa2xx_driver.
Extended keycodes in keymap should be marked with most significant
bit set (i.e. 0x80). Without this patch it's not possible to handle
i.e. cursor keys.

Signed-off-by: Vasily Khoruzhick <>...

b976b4c0 02/20/2011 08:53 pm Vasily Khoruzhick

pxa2xx_keypad: enhance emulation of KPAS, KPASMKP regs

Add emulation of KPAS register and proper emulation of
KPASMKP regs, so now driver supports multipresses and properly
works with Linux driver.

Signed-off-by: Vasily Khoruzhick <>
Signed-off-by: Aurelien Jarno <>

5a5e3d55 02/20/2011 07:51 pm David 'Digit' Turner

qdev: Fix printout of bit device properties with bit index >= 8

Signed-off-by: David 'Digit' Turner <>
Acked-by: Markus Armbruster <>
Signed-off-by: Aurelien Jarno <>

e98ccb3f 02/20/2011 07:23 pm Stefan Weil

ppc405: Fix memory leak

Signed-off-by: Stefan Weil <>
Acked-by: Andreas Färber <>
Signed-off-by: Aurelien Jarno <>

9f953ca0 02/20/2011 07:23 pm Stefan Weil

s390: Fix memory leak

Signed-off-by: Stefan Weil <>
Signed-off-by: Aurelien Jarno <>

386bbf45 02/20/2011 07:23 pm Stefan Weil

pci: Fix memory leak

Signed-off-by: Stefan Weil <>
Signed-off-by: Aurelien Jarno <>

32993698 02/20/2011 07:06 pm Michael S. Tsirkin

vhost: disable on tap link down

qemu makes it possible to disable link at tap which is not communicated
to the guest but causes all packets to be dropped.

When vhost-net is enabled, vhost needs to be aware of both the virtio
link_down and the peer link_down. we switch to userspace emulation when...

322fd48a 02/20/2011 04:18 pm Michael S. Tsirkin

e1000: verify we have buffers, upfront

The spec says: Any descriptor with a non-zero status byte has been
processed by the hardware, and is ready to be handled by the software.

Thus, once we change a descriptor status to non-zero we should
never move the head backwards and try to reuse this...

ee912ccf 02/20/2011 04:18 pm Michael S. Tsirkin

e1000: clear EOP for multi-buffer descriptors

The e1000 spec says: if software statically allocates
buffers, and uses memory read to check for completed descriptors, it
simply has to zero the status byte in the descriptor to make it ready
for reuse by hardware. This is not a hardware requirement (moving the...

b19487e2 02/20/2011 04:18 pm Michael S. Tsirkin

e1000: multi-buffer packet support

e1000 supports multi-buffer packets larger than rxbuf_size.

This fixes the following (on linux):
- in guest: ifconfig eth1 mtu 16110
- in host: ifconfig tap0 mtu 16110
ping -s 16082 <guest-ip>

Signed-off-by: Michael S. Tsirkin <>...

1c693710 02/20/2011 04:13 pm Aurelien Jarno

pc: remove test on TARGET_PHYS_ADDR_BITS == 32

Both i386 and x86_64 targets are now using target_phys_bits=64. Remove
useless code.

Signed-off-by: Aurelien Jarno <>

64d7e9a4 02/20/2011 11:35 am Blue Swirl

i8254: convert to qdev

Convert to qdev. Don't expose PITState.

Signed-off-by: Blue Swirl <>

c74b88df 02/20/2011 11:34 am Blue Swirl

vga-isa: make optional

Ignore failure with vga-isa device creation, but print a warning
message.

Signed-off-by: Blue Swirl <>

7435b791 02/20/2011 11:34 am Blue Swirl

vga-isa: convert to qdev

Signed-off-by: Blue Swirl <>

17801c78 02/20/2011 11:34 am Blue Swirl

fdc: make optional

Ignore failure with fdc device creation.

Signed-off-by: Blue Swirl <>

63ffb564 02/20/2011 11:33 am Blue Swirl

fdc: refactor device creation

Turn fdc_init_isa into an inline function.

Get floppy geometry directly from the drives.

Don't expose FDCtrl.

Signed-off-by: Blue Swirl <>

d288c7ba 02/20/2011 11:33 am Blue Swirl

fdc: use FDriveType for floppy drive type

Signed-off-by: Blue Swirl <>

5bbdbb46 02/20/2011 11:33 am Blue Swirl

fdc: move floppy geometry guessing to block.c

Other geometry guessing functions already reside in block.c.

Remove some unused or debugging only fields.

Signed-off-by: Blue Swirl <>

9b13ef9f 02/20/2011 11:33 am Blue Swirl

serial: make optional

Ignore failure with serial device creation.

Signed-off-by: Blue Swirl <>

e22cf21e 02/20/2011 11:32 am Blue Swirl

serial: refactor device creation

Turn serial_init into an inline function.

Signed-off-by: Blue Swirl <>

cd1b8a8b 02/20/2011 11:32 am Blue Swirl

ne2000_isa: make optional

Ignore failure with ne2000_isa device creation.

Signed-off-by: Blue Swirl <>

60a14ad3 02/20/2011 11:32 am Blue Swirl

ne2000_isa: refactor device creation

Turn isa_ne2000_init into an inline function.

Signed-off-by: Blue Swirl <>

73531538 02/20/2011 11:31 am Blue Swirl

parallel: make optional

Ignore failure with parallel device creation.

Signed-off-by: Blue Swirl <>

defdb20e 02/20/2011 11:31 am Blue Swirl

parallel: refactor device creation

Turn parallel_init into an inline function.

Don't expose ParallelState.

Signed-off-by: Blue Swirl <>

e14da0af 02/17/2011 09:34 pm Marcelo Tosatti

Fix vmport segfault (v2)

Fix regression caused by qdev conversion.

Signed-off-by: Marcelo Tosatti <>
Signed-off-by: Blue Swirl <>

c5d69e6b 02/16/2011 04:47 pm Anthony Liguori

Merge remote branch 'qemu-kvm/uq/master' into staging

459505a2 02/16/2011 03:04 am Dmitry Eremin-Solenikov

Merge mainstone.h header into mainstone.c

Now the only user of mainstone.h is mainstone.c file. Merge header
into board file.

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

cb380f61 02/16/2011 03:04 am Dmitry Eremin-Solenikov

mainstone: convert FPGA emulation code to use QDev/SysBus

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

43d91709 02/16/2011 03:00 am Dmitry Eremin-Solenikov

mainstone: correct and simplify irq handling

Simplify IRQ handling to stop setting an input irq pin. As a win, also get
correct IRQ status after save/load cycle.

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

0fbfbb59 02/14/2011 04:43 pm Gleb Natapov

correctly check ppr priority during interrupt injection]

TPR blocks all interrupts in a priority class, so simple "less or
equal" check is not enough.

Signed-off-by: Gleb Natapov <>
Reviewed-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

0ec329da 02/14/2011 04:43 pm Jan Kiszka

kvm: x86: Introduce kvmclock device to save/restore its state

If kvmclock is used, which implies the kernel supports it, register a
kvmclock device with the sysbus. Its main purpose is to save and restore
the kernel state on migration, but this will also allow to visualize it...

e5896b12 02/14/2011 04:39 pm Anthony PERARD

Introduce log_start/log_stop in CPUPhysMemoryClient

In order to use log_start/log_stop with Xen as well in the vga code,
this two operations have been put in CPUPhysMemoryClient.

The two new functions cpu_physical_log_start,cpu_physical_log_stop are
used in hw/vga.c and replace the kvm_log_start/stop. With this, vga does...

638a84af 02/14/2011 04:39 pm Jan Kiszka

cirrus: Remove obsolete kvm.h include

Signed-off-by: Jan Kiszka <>
Signed-off-by: Marcelo Tosatti <>

e07bbac5 02/14/2011 04:39 pm Jan Kiszka

Improve vm_stop reason declarations

Define and use dedicated constants for vm_stop reasons, they actually
have nothing to do with the EXCP_* defines used so far. At this chance,
specify more detailed reasons so that VM state change handlers can
evaluate them....

8668f61d 02/12/2011 07:44 pm Blue Swirl

vmmouse: fix queue_size field initialization

Initialize the field queue_size, dropped by
91c9e09147ba1f3604a3d5d29b4de7702082a33f.

Signed-off-by: Blue Swirl <>

dd703b99 02/12/2011 11:45 am Blue Swirl

hpet: make optional

Ignore failure with hpet device creation.

Signed-off-by: Blue Swirl <>

4912371f 02/12/2011 11:45 am Blue Swirl

sysbus: add creation function that may fail

Signed-off-by: Blue Swirl <>

86d86414 02/12/2011 11:43 am Blue Swirl

x86: make vmmouse optional

Compile vmmouse in hwlib. Ignore failure if vmmouse device can't be
created.

Signed-off-by: Blue Swirl <>

86f4a9a5 02/12/2011 11:43 am Blue Swirl

isa: add creation function that may fail

Signed-off-by: Blue Swirl <>

91c9e091 02/12/2011 11:34 am Blue Swirl

vmmouse: convert to qdev

Convert to qdev, also add a proper reset function.

Signed-off-by: Blue Swirl <>

6872ef61 02/12/2011 10:28 am Blue Swirl

vmport: convert to qdev

Signed-off-by: Blue Swirl <>

7ba7e49e 02/12/2011 10:28 am Blue Swirl

x86,MIPS: make vmware_vga optional

Allow failure with vmware_vga device creation and use standard
VGA instead.

Signed-off-by: Blue Swirl <>

7cc050b1 02/12/2011 10:27 am Blue Swirl

pci: add creation functions that may fail

Signed-off-by: Blue Swirl <>

0bcdeda7 02/12/2011 10:27 am Blue Swirl

qdev: add creation function that may fail

Signed-off-by: Blue Swirl <>

5c81e4ca 02/12/2011 10:27 am Blue Swirl

vmware_vga: refactor device creation

Turn vmsvga_init into an inline function.

Signed-off-by: Blue Swirl <>

55619bb6 02/12/2011 12:35 am Andrzej Zaborowski

mst_fpga: Drop one more pxa.h inclusion.

Signed-off-by: Andrzej Zaborowski <>

987e8b3b 02/12/2011 12:31 am Dmitry Eremin-Solenikov

max7310: finish qdev'ication

1) Move GPIO-related functionality to qdev. Now one can use directly
qdev_get_gpio_in()/qdev_connect_gpio_out() on max7310 devices.

2) Make reset to be called through qdev.reset callback.

Signed-off-by: Dmitry Eremin-Solenikov <>...

c8ba63f8 02/12/2011 12:31 am Dmitry Eremin-Solenikov

pxa2xx: convert i2c master to use qdev/vmsd

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

7fe63a17 02/12/2011 12:31 am Dmitry Eremin-Solenikov

Add scoop post_load callback that sets IRQs to loaded levels

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

21c75ddb 02/12/2011 12:31 am Dmitry Eremin-Solenikov

Drop unnecessary inclusions of pxa.h header

Seceral files contained onnecessary dependencies on hw/pxa.h header.
Drop unused references.

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

bb70651e 02/12/2011 12:31 am Dmitry Eremin-Solenikov

mainstone: pass one irq to the mst_fpga instead of the whole PIC

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

2e4b4e79 02/12/2011 12:31 am Dmitry Eremin-Solenikov

tosa: we aren't connected to VBus, pass this info to Linux kernel

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

f23c1b2a 02/11/2011 02:52 am Dmitry Eremin-Solenikov

tc6393xb: correct NAND isr assertion

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

0fba9fd6 02/11/2011 02:13 am Dmitry Eremin-Solenikov

sysbus: print number of irqs in dev_print

Signed-off-by: Dmitry Eremin-Solenikov <>
Signed-off-by: Andrzej Zaborowski <>

84fb3925 02/07/2011 01:51 pm Marcelo Tosatti

blockdev: add refcount to DriveInfo

The host part of a block device can be deleted with in progress
block migration.

To fix this, add a reference count to DriveInfo, freeing resources
on last reference.

Signed-off-by: Marcelo Tosatti <>...

2c4b9d0e 02/07/2011 12:40 pm Alexander Graf

ahci: make number of ports runtime determined

Different AHCI controllers have a different number of ports, so the core
shouldn't care about the amount of ports available.

This patch makes the number of ports available to the AHCI core runtime
configurable, allowing us to have multiple different AHCI implementations...

760c3e44 02/07/2011 12:38 pm Alexander Graf

ahci: Implement HBA reset

The ahci code was missing its soft reset functionality. This wasn't really an
issue for Linux guests, but Windows gets confused when the controller doesn't
reset when it tells it so.

Using this patch I can now successfully boot Windows 7 from AHCI using AHCI...

87e62065 02/07/2011 12:38 pm Alexander Graf

ahci: send init d2h fis on fis enable

The drive sends a d2h init fis on initialization. Usually, the guest doesn't
receive fises yet at that point though, so the delivery is deferred.

Let's reflect that by sending the init fis on fis receive enablement....

7fb6577b 02/07/2011 12:37 pm Alexander Graf

ahci: split ICH and AHCI even more

Sebastian's patch already did a pretty good job at splitting up ICH-9
AHCI code and the AHCI core. We need some more though. Copyright was missing,
the lspci dump belongs to ICH-9, we don't need the AHCI core to have its...

f83a40dc 02/07/2011 12:35 pm Alexander Graf

ahci: add license header in ahci.h

Due to popular request, this patch adds a license header to ahci.h

Signed-off-by: Alexander Graf <>
Signed-off-by: Kevin Wolf <>

03c7a6a8 02/07/2011 12:14 pm Sebastian Herbszt

ahci: split ICH9 from core

There are multiple ahci devices out there. The currently implemented ich-9
is only one of the many. So let's split that one out into a separate file
to stress the difference.

Signed-off-by: Sebastian Herbszt <>
Signed-off-by: Alexander Graf <>...

7185f931 02/04/2011 02:33 pm Amit Shah

virtio-serial: Make sure virtqueue is ready before discarding data

This can happen if a port gets unplugged before guest has chance to
initialise vqs.

Reported-by: Juan Quintela <>
Signed-off-by: Amit Shah <>
Signed-off-by: Anthony Liguori <>

0280b571 02/04/2011 02:33 pm Jan Kiszka

ioapic: Implement EOI handling for level-triggered IRQs

Add the missing EOI broadcast from local APIC to the IOAPICs on
completion of level-triggered IRQs. This ensures that a still asserted
IRQ source properly re-triggers an APIC IRQ.

Signed-off-by: Jan Kiszka <>...

35a74c5c 02/04/2011 02:33 pm Jan Kiszka

ioapic: Save/restore irr

This is a guest modifiable state that must be saved/restored properly.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

5dce4999 02/04/2011 02:33 pm Jan Kiszka

ioapic: Add support for qemu-kvm's vmstate v2

qemu-kvm carries the IOAPIC base address in its v2 vmstate. We only
support the default base address so far, and saving even that in the
device state was rejected.

Add a padding field to be able to read qemu-kvm's old state, but...

1f5e71a8 02/04/2011 02:33 pm Jan Kiszka

ioapic: Style & magics cleanup

Fix a few style issues and convert magic numbers into prober symbolic
constants, also fixing the wrong but unused IOAPIC_DM_SIPI value.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

cf8ce30d 02/02/2011 12:50 am Gleb Natapov

Add bootindex handling into usb storage device.

Signed-off-by: Gleb Natapov <>
Signed-off-by: Gleb Natapov <>
Signed-off-by: Anthony Liguori <>

5430a28f 02/02/2011 12:50 am mst@redhat.com

vhost: force vhost off for non-MSI guests

When MSI is off, each interrupt needs to be bounced through the io
thread when it's set/cleared, so vhost-net causes more context switches and
higher CPU utilization than userspace virtio which handles networking in...

9363ee31 02/01/2011 11:22 pm Anthony Liguori

Merge remote branch 'spice/spice.v29.pull' into staging

Conflicts:
trace-events

cfb41c82 02/01/2011 11:21 pm Anthony Liguori

Merge remote branch 'spice/usb.5' into staging

e54b7f52 02/01/2011 11:20 pm Anthony Liguori

Merge remote branch 'amit/for-anthony' into staging

c84a88d8 02/01/2011 07:02 pm Peter Maydell

hw/slavio_intctl.c: fix gcc warning about array bounds overrun

The Ubuntu 10.10 gcc for ARM complains that we might be overrunning
the cpu_irqs[][] array: silence this by correcting the bounds on the
loop. (In fact we would not have overrun the array because bit...

60f356e8 02/01/2011 07:01 pm Fabien Chouteau

SPARC: Fix Leon3 cache control

The "leon3_cache_control_int" (op_helper.c) function is called within leon3.c
which leads to segfault error with the global "env".

Now cache control is a CPU feature and everything is handled in op_helper.c.

Signed-off-by: Fabien Chouteau <>...

2685d296 01/31/2011 08:07 pm Anthony Liguori

Merge remote branch 'mst/for_anthony' into staging

319ae529 01/31/2011 12:59 pm Markus Armbruster

blockdev: Fix drive_add for drives without media

Watch this:

(qemu) drive_add 0 if=none
(qemu) info block
none0: type=hd removable=0 [not inserted]
(qemu) drive_del none0
Segmentation fault (core dumped)

add_init_drive() is confused about drive_init()'s failure modes, and...

2292ddae 01/31/2011 11:59 am Markus Armbruster

blockdev: Make drive_add() take explicit type, index parameters

Before, type & index were hidden in printf-like fmt, ... parameters,
which get expanded into an option string. Rather inconvenient for
uses later in this series.

New IF_DEFAULT to ask for the machine's default interface. Before,...

27d6bf40 01/31/2011 11:42 am Markus Armbruster

blockdev: Fix regression in -drive if=scsi,index=N

Before commit 622b520f, index=12 meant bus=1,unit=5.

Since the commit, it means bus=0,unit=12. The drive is created, but
not the guest device. That's because the controllers we use with
if=scsi drives (lsi53c895a and esp) support only 7 units, and...

13839974 01/31/2011 11:24 am Markus Armbruster

blockdev: New drive_get_next(), replacing qdev_init_bdrv()

qdev_init_bdrv() doesn't belong into qdev.c; it's about drives, not
qdevs. Rename to drive_get_next, move to blockdev.c, drop the bogus
DeviceState argument, and return DriveInfo instead of
BlockDriverState....

fe6ceac8 01/31/2011 11:03 am Stefan Hajnoczi

ahci: Fix cpu_physical_memory_unmap() argument ordering

The len and is_write arguments to cpu_physical_memory_unmap() were
swapped. This patch changes calls to use the correct argument ordering.

Signed-off-by: Stefan Hajnoczi <>...

31e1ea3e 01/31/2011 11:03 am Markus Armbruster

scsi hotplug: Set DriveInfo member bus correctly

drive_init() picks the first free bus and unit number, unless the user
specifies them.

This isn't a good fit for the drive_add monitor command, because there
we specify the controller by PCI address instead of using bus number...