« Previous | Next » 

Revision 8caf907f

ID8caf907f07688972e5e7cd11526079b1665d6dba

Added by Cornelia Huck over 10 years ago

dataplane: Fix startup race.

Avoid trying to setup dataplane again if dataplane setup is already in
progress. This may happen if an eventfd is triggered during setup.

I saw this occasionally with an experimental s390 irqfd implementation:

virtio_blk_handle_output
> virtio_blk_data_plane_start
> virtio_ccw_set_host_notifier
...
> virtio_queue_set_host_notifier_fd_handler
> virtio_queue_host_notifier_read
> virtio_queue_notify_vq
> virtio_blk_handle_output
> virtio_blk_data_plane_start
> vring_setup
> hostmem_init
> memory_listener_register
-> BOOM

As virtio-ccw tries to follow what virtio-pci does, it might be triggerable
for other platforms as well.

Signed-off-by: Cornelia Huck <>
Signed-off-by: Stefan Hajnoczi <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences