ioapic: convert to qdev
Convert to qdev.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
ioapic: unexport ioapic_set_irq
There's no need to use ioapic_set_irq() outside of ioapic.c, somake it static.
Fix comparison which always returned false
Comparing an 8 bit value with ~0 does not work as expected.Replace ~0 by UINT8_MAX in comparison and also in assignment(and fix coding style, too).
Cc: Gleb Natapov <gleb@redhat.com>Cc: Anthony Liguori <aliguori@us.ibm.com>...
xen: Fix build error due to missing include
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block: Move error actions from DriveInfo to BlockDriverState
That's where they belong semantically (block device host part), eventhough the actions are actually executed by guest device code.
Signed-off-by: Markus Armbruster <armbru@redhat.com>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE
Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c
Per https://bugs.launchpad.net/qemu/+bug/424453 the correct valuesfor FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against...
virtio-blk: simplify multiwrite calling conventions
Pass the MultiReqBuffer structure down all the way to the I/O submissioninstead of takin it apart. Also mark num_writes unsigned as it can'tgo negative, and take the check for any pending I/O requests into the...
Clarify error message when a PCI slot is already in use (v2)
When mistakenly configuring two devices in the same PCI slot,QEMU gives a not entirely obvious message about a 'devfn' beingin use:
$ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3...
qdev: Revert the hack to let -net nic and pci_add set qdev ID
Setting the ID in pci_nic_init() is a blatant violation of theDeviceState abstraction. Which even carries a comment advisingagainst this:
/* This structure should not be accessed directly. We declare it here...
acpi_piix4: save gpe and pci hotplug slot status
PCI hotplug currently doesn't work after a migration becausewe don't migrate the enable bits of the GPE state. Pull hotplugstructs into vmstate.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>...
View revisions
Also available in: Atom