Statistics
| Branch: | Revision:

root / monitor.c @ a74cdab4

History | View | Annotate | Download (145.8 kB)

# Date Author Comment
90dc8812 05/09/2011 11:31 pm Scott Wood

monitor: add PPC BookE SPRs

Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
and display them in "info registers".

Also get CR and PID from the existing KVM_GET_REGS.

Signed-off-by: Scott Wood <>
Signed-off-by: Alexander Graf <>

b8b79323 04/12/2011 10:51 pm Stefan Weil

monitor: Remove some type casts which are no longer needed

All other type casts in calls of cpu_physical_memory_read are
used by hardware emulations and will be fixed by separate patches.

Cc: Blue Swirl <>
Signed-off-by: Stefan Weil <>...

54f7b4a3 04/12/2011 10:51 pm Stefan Weil

Replace cpu_physical_memory_rw were possible

Using cpu_physical_memory_read, cpu_physical_memory_write and ldub_phys
improves readability and allows removing some type casts.

lduw_phys and ldl_phys were not used because both require aligned
addresses. Therefore it is not possible to simply replace existing...

bb593904 04/01/2011 07:34 pm David Gibson

Parse SDR1 on mtspr instead of at translate time

On ppc machines with hash table MMUs, the special purpose register SDR1
contains both the base address of the encoded size (hashed) page tables.

At present, we interpret the SDR1 value within the address translation...

821601ea 03/22/2011 03:39 pm Jes Sorensen

Make VNC support optional

Per default VNC is enabled.

Signed-off-by: Jes Sorensen <>
Signed-off-by: Anthony Liguori <>

31b7c261 03/22/2011 12:42 am Anthony Liguori

Merge remote branch 'qemu-kvm/uq/master' into staging

74475455 03/21/2011 10:23 am Paolo Bonzini

change all other clock references to use nanosecond resolution accessors

This was done with:

sed -i 's/qemu_get_clock\>/qemu_get_clock_ns/' \
$(git grep -l 'qemu_get_clock\>' )
sed -i 's/qemu_new_timer\>/qemu_new_timer_ns/' \
$(git grep -l 'qemu_new_timer\>' )...
dc7a09cf 03/16/2011 10:11 pm Jan Kiszka

Expose thread_id in info cpus

Based on patch by Glauber Costa:

To allow management applications like libvirt to apply CPU affinities to
the VCPU threads, expose their ID via info cpus. This patch provides the
pre-existing and used interface from qemu-kvm....

2fa11da0 03/15/2011 06:19 am Jan Kiszka

x86: Small cleanups of MCE helpers

Fix some code style issues, use proper headers, and align to cpu_x86
naming scheme. No functional changes.

Signed-off-by: Jan Kiszka <>
CC: Huang Ying <>
CC: Hidetoshi Seto <>...

316378e4 03/15/2011 06:19 am Jan Kiszka

x86: Refine error reporting of MCE injection services

As this service is used by the human monitor, make sure that errors get
reported to the right channel, and also raise the verbosity.

This requires to move Monitor typedef in qemu-common.h to resolve the...

747461c7 03/15/2011 06:19 am Jan Kiszka

x86: Optionally avoid injecting AO MCEs while others are pending

Allow to tell cpu_x86_inject_mce that it should ignore Action Optional
MCE events when the target VCPU is still processing another one. This
will be used by KVM soon.

Signed-off-by: Jan Kiszka <>...

e07bbac5 02/14/2011 04:39 pm Jan Kiszka

Improve vm_stop reason declarations

Define and use dedicated constants for vm_stop reasons, they actually
have nothing to do with the EXCP_* defines used so far. At this chance,
specify more detailed reasons so that VM state change handlers can
evaluate them....

c48855e1 02/02/2011 12:50 am Paolo Bonzini

add qemu_chr_set_echo

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Anthony Liguori <>

b3a98367 02/01/2011 11:32 pm Anthony Liguori

Merge remote branch 'qemu-kvm/uq/master' into staging

aliguori: fix build with !defined(KVM_CAP_ASYNC_PF)

Signed-off-by: Anthony Liguori <>

9363ee31 02/01/2011 11:22 pm Anthony Liguori

Merge remote branch 'spice/spice.v29.pull' into staging

Conflicts:
trace-events

1cd20f8b 02/01/2011 11:16 pm Anthony Liguori

vnc: Fix password expiration through 'change vnc ""' (v2)

commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the
change vnc password command that changed the behavior of setting the VNC
password to an empty string from disabling login to disabling authentication....

d00b2618 01/25/2011 10:22 am Isaku Yamahata

monitor: use after free in do_wav_capture()

use after free in do_wav_capture() on the error path.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Aurelien Jarno <>

e866e239 01/24/2011 04:13 pm Gerd Hoffmann

spice/vnc: client migration.

Handle spice client migration, i.e. inform a spice client connected
about the new host and connection parameters, so it can move over the
connection automatically.

The monitor command has a not-yet used protocol argument simliar to...

8d86e2bf 01/24/2011 04:13 pm Marc-André Lureau

vnc/spice: fix "never" and "now" expire_time

70b4f4bb 01/24/2011 12:08 pm Jes Sorensen

Make strtosz() return int64_t instead of ssize_t

strtosz() needs to return a 64 bit type even on 32 bit
architectures. Otherwise qemu-img will fail to create disk
images >= 2GB

Signed-off-by: Jes Sorensen <>
Signed-off-by: Kevin Wolf <>

31ce5e0c 01/21/2011 06:05 pm Jin Dongming

Add "broadcast" option for mce command

When the following test case is injected with mce command, maybe user could not
get the expected result.
DATA
command cpu bank status mcg_status addr misc
(qemu) mce 1 1 0xbd00000000000000 0x05 0x1234 0x8c...

2d5b5074 01/15/2011 10:31 am Blue Swirl

monitor: fix a typo

Fix usage of wrong variable, spotted by clang:
/src/qemu/monitor.c:2278:36: warning: The left operand of '&' is a garbage value
prot = pde & (PG_USER_MASK | PG_RW_MASK |

Signed-off-by: Blue Swirl <>

818c2e1b 12/27/2010 11:59 pm Aurelien Jarno

Merge branch 'spice.v23.pull' of git://anongit.freedesktop.org/spice/qemu

  • 'spice.v23.pull' of git://anongit.freedesktop.org/spice/qemu:
    vnc/spice: add set_passwd monitor command.
    vnc: support password expire
    vnc: auth reject cleanup
    spice: add qmp 'query-spice' and hmp 'info spice' commands....
d41160a3 12/19/2010 03:42 pm Blue Swirl

Sparc: implement monitor command 'info tlb'

Use existing dump_mmu() to implement monitor command 'info tlb'.

Signed-off-by: Blue Swirl <>

fef39578 12/17/2010 04:23 pm Anthony Liguori

Merge remote branch 'qmp/for-anthony' into staging

1b3cba6e 12/11/2010 08:56 pm Blue Swirl

monitor: implement x86 info mem for PAE and long modes

'info mem' didn't show correct information for PAE mode and
x86_64 long mode.

Fix by implementing the output for missing modes.

Signed-off-by: Blue Swirl <>

d65aaf37 12/11/2010 08:56 pm Blue Swirl

monitor: implement x86 info tlb for PAE and long modes

'info tlb' didn't show correct information for PAE mode and
x86_64 long mode.

Implement the missing modes. Also print NX bit for PAE and long modes.
Fix off-by-one error in 32 bit mode mask.

Signed-off-by: Blue Swirl <>

7572150c 12/09/2010 03:23 pm Gerd Hoffmann

vnc/spice: add set_passwd monitor command.

This patch adds new set_password and expire_password monitor commands
which allows to change and expire the password for spice and vnc
connections. See the doc update patch chunk for details.

Signed-off-by: Gerd Hoffmann <>

6f8c63fb 12/09/2010 03:23 pm Gerd Hoffmann

spice: connection events.

This patch adds support for connection events to spice. The events are
quite simliar to the vnc events. Unlike vnc spice uses multiple tcp
channels though. qemu will report every single tcp connection (aka
spice channel). If you want track spice sessions only you can filter...

cb42a870 12/09/2010 03:23 pm Gerd Hoffmann

spice: add qmp 'query-spice' and hmp 'info spice' commands.

The patch adds a 'query-spice' monitor command which returns
informations about the spice server configuration and also a list of
channel connections.

Signed-off-by: Gerd Hoffmann <>

c01e6885 12/06/2010 01:51 pm Luiz Capitulino

QMP: Fix default response regression

Commit 030db6e89d dropped do_info() usage from QMP and introduced
qmp_call_query_cmd(). However, the new function doesn't emit QMP's
default OK response when the handler doesn't return data.

Fix that by also calling monitor_protocol_emitter() when...

6d441430 12/06/2010 01:51 pm Luiz Capitulino

QMP: Drop dead code

The first if/else clause in handler_audit() makes no sense for two
reasons:

1. this function is now called only by QMP code, so testing if
it's a QMP call makes no sense anymore
2. the else clause first asserts that there's no error in the...
83a27d4d 12/06/2010 01:51 pm Luiz Capitulino

QMP: Simplify monitor_json_emitter()

Use the ternary operator instead of an if (also fixes bad indentation).

Signed-off-by: Luiz Capitulino <>

0268d97c 11/17/2010 01:52 pm Luiz Capitulino

QMP: Introduce Human Monitor passthrough command

This command allows QMP clients to execute HMP commands.

Please, check the documentation added to the qmp-commands.hx file
for additional details about the interface and its limitations.

Signed-off-by: Luiz Capitulino <>

dbc0c67f 11/03/2010 07:48 pm Jes Sorensen

Add support for 'o' octet (bytes) format as monitor parameter.

Octet format relies on strtosz which supports K/k, M/m, G/g, T/t
suffixes and unit support for humans, like 1.3G

Signed-off-by: Jes Sorensen <>
Signed-off-by: Anthony Liguori <>

07de3e60 11/03/2010 07:48 pm Jes Sorensen

Remove obsolete 'f' double parameter type

'f' double is no longer used, and we should be using floating point
variables to store byte sizes. Remove it.

Signed-off-by: Jes Sorensen <>
Signed-off-by: Anthony Liguori <>

46c7fc18 10/22/2010 03:08 pm Kusanagi Kouichi

monitor: Ignore "." and ".." when completing file name.

Signed-off-by: Kusanagi Kouichi <>
Signed-off-by: Luiz Capitulino <>

f871d689 10/13/2010 10:14 pm Blue Swirl

trace: print a warning if user tries to enable an unknown trace event

There was no warning if a bad trace event name was given to
'trace-event' command, thus the user could think that the command
was successful even if this was not the case.

Print a warning if the user tries to enable a trace event which is not...

48f57044 10/05/2010 09:54 pm Anthony Liguori

Merge remote branch 'qmp/for-anthony' into staging

8b7968f7 10/03/2010 09:34 am Stefan Weil

Use GCC_FMT_ATTR (format checking)

Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>

4903de0c 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Rename monitor_handler_is_async()

Let's follow the convention introduced by the previous commit and
call it handler_is_async().

Signed-off-by: Luiz Capitulino <>

de79ba6f 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Directly call QObject handlers

This avoids handle_user_command() calling monitor_call_handler(),
which is currently shared with QMP.

Signed-off-by: Luiz Capitulino <>

fc29df75 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce qmp_call_cmd()

Calls a QObject handler and emits the QMP response, also drops
monitor_call_handler() which is now unused.

Signed-off-by: Luiz Capitulino <>

acd0a093 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Rename the qemu-monitor.hx file

Let's be consistent and call it hmp-commands.hx, so that we have
qmp-commands.hx for QMP and hmp-commands.hx for HMP.

Please, note that this commit doesn't touch qemu-monitor.texi. All
texi files have the qemu- prefix and I don't think it's worth...

945c5ac8 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Introduce search_dispatch_table()

It's a generic version of monitor_find_command() which searches
the dispatch table passed as an argument.

Future commits will introduce new dispatch tables, so we need
common code to search them.

Signed-off-by: Luiz Capitulino <>

0fb88582 10/01/2010 04:20 pm Luiz Capitulino

QMP: handle_qmp_command(): Move 'cmd' sanity check

Next commit will change how query commands are handled in a
way that the 'cmd' sanity check is also going to be needed
for query commands handling.

Let's move it out of the else body then.

Signed-off-by: Luiz Capitulino <>

030db6e8 10/01/2010 04:20 pm Luiz Capitulino

QMP: Don't use do_info()

Since its inception, QMP has been using HMP's do_info() function
to run query commands.

This was a bad choice, as it made do_info() more complex and
contributed to couple QMP and HMP.

This commit fixes that by doing the following changes:...

1dcbd6f6 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop QMP bits from do_info()

As of last commit, QMP doesn't use do_info() anymore. Simplify it.

Signed-off-by: Luiz Capitulino <>

d4551293 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop is_async_return()

If I understood it correcty, the is_async_return() logic was only
used to prevent QMP from issuing duplicated success responses
for asynchronous handlers.

However, QMP doesn't use do_info() anymore so this is dead logic
and (hopefully) can be safely dropped....

1162daa6 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Convert do_info() back to HMP

This is a HMP specific handler, it makes no sense to have it
under QMP.

Signed-off-by: Luiz Capitulino <>

bead3ce1 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce qmp_find_cmd()

Next commit needs this new function: it will introduce the
the QMP's command dispatch table and qmp_find_cmd() will be
used to search on it.

Signed-off-by: Luiz Capitulino <>

f36b4afb 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce command dispatch table

Also update QMP functions to use it. The table is generated
from the qmp-commands.hx file.

From now on, QMP and HMP have different command dispatch
tables.

Signed-off-by: Luiz Capitulino <>

3e12a751 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce query commands dispatch table

The new table is a copy of HMP's table, containing only QObject
handlers.

In the near future HMP will be making QMP calls and then we will
be able to drop QObject handlers from HMP's table.

From now on, QMP and HMP have different query command dispatch...

2e061a7c 10/01/2010 04:20 pm Luiz Capitulino

QMP: Simplify do_info_commands()

We now iterate over QMP's dispatch tables, no need to check for
QMP-only handlers anymore.

Signed-off-by: Luiz Capitulino <>

d1249eaa 10/01/2010 04:20 pm Luiz Capitulino

QMP: Small cleanup in handle_qmp_command()

QMP has its own dispatch tables, we can now drop the following
checks:

o 'info' command: this command doesn't exist in QMP's
dispatch table, the right thing will happen when it's
issued by a client (ie. command not found error)...
30f5041e 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop QMP info from the qemu-monitor.hx file

QMP has its own dispatch table and documentation file
(qmp-commands.hx), we can now drop the following QMP specific info
from qemu-monitor.hx:

o SQMP/EQMP sections
o The qmp_capabilities command...
0e19a627 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop monitor_cmd_user_only()

This function was only needed when QMP and HMP were sharing dispatch
tables, this is no longer true so just drop it.

Signed-off-by: Luiz Capitulino <>

9e80721e 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Rename monitor_handler_ported()

That name makes no sense anymore, as dispatch tables have been split,
a better name is handler_is_qobject(), which really communicates
the handler's type.

Signed-off-by: Luiz Capitulino <>

39eaab9a 10/01/2010 04:12 pm Daniel P. Berrange

Add option to turn on JSON pretty printing in monitor

Expaned '-mon' arg to allow a 'pretty=on' flag. This makes the
monitor pretty print its replies to easy human debugging / reading

Signed-off-by: Daniel P. Berrange <>
Signed-off-by: Luiz Capitulino <>

22890ab5 09/10/2010 12:22 am Prerna Saxena

trace: Support for dynamically enabling/disabling trace events

This patch adds support for dynamically enabling/disabling of trace events.
This is done by internally maintaining each trace event's state, and
permitting logging of data from a trace event only if it is in an...

c5ceb523 09/10/2010 12:22 am Stefan Hajnoczi

trace: Add trace-file command to open/close/flush trace file

This patch adds the trace-file command:

trace-file [on|off|flush]
Open, close, or flush the trace file.  If no argument is given,
the status of the trace file is displayed.

The trace file is turned on by default but is only written out when the...

0ec0291d 08/23/2010 01:11 am Miguel Di Ciurcio Filho

QMP/monitor: update do_info_version() to output broken down version string

This code was originally developed by Daniel P. Berrange <>

Signed-off-by: Miguel Di Ciurcio Filho <>
Signed-off-by: Luiz Capitulino <>...

f0aa7a8b 08/03/2010 04:57 pm Miguel Di Ciurcio Filho

loadvm: improve tests before bdrv_snapshot_goto()

This patch improves the resilience of the load_vmstate() function, doing
further and better ordered tests.

In load_vmstate(), if there is any error on bdrv_snapshot_goto(), except if the
error is on VM state device, load_vmstate() will return zero and the VM will be...

8e84865e 07/31/2010 12:14 am Amit Shah

migration: Accept 'cont' only after successful incoming migration

When a 'cont' is issued on a VM that's just waiting for an incoming
migration, the VM reboots and boots into the guest, possibly corrupting
its storage since it could be shared with another VM running elsewhere....

02d0ba14 07/06/2010 04:31 pm Anthony Liguori

Merge remote branch 'qmp/for-anthony' into staging

a88790a1 07/03/2010 09:48 am Paolo Bonzini

remove exec-all.h inclusion from cpu.h

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Blue Swirl <>

e4940c60 07/01/2010 08:27 pm Luiz Capitulino

QMP: handle_qmp_command(): Small cleanup

Drop a unneeded label and QDECREF call.

Signed-off-by: Luiz Capitulino <>

a6c4d364 07/01/2010 08:27 pm Jan Kiszka

monitor: Allow to exclude commands from QMP

Ported commands that are marked 'user_only' will not be considered for
QMP monitor sessions. This allows to implement new commands that do not
(yet) provide a sufficiently stable interface for QMP use.

Signed-off-by: Jan Kiszka <>...

5af7bbae 07/01/2010 08:27 pm Luiz Capitulino

QMP: Fix error reporting in the async API

The current asynchronous command API doesn't return a QMP response
when the async command fails.

This is easy to reproduce with the balloon command (the sole async
command we have so far): run qemu w/o the '-balloon virtio' option...

eb159d13 07/01/2010 08:27 pm Luiz Capitulino

Monitor: handle optional '-' arg as a bool

Historically, user monitor arguments beginning with '-' (eg. '-f')
were passed as integers down to handlers.

I've maintained this behavior in the new monitor because we didn't
have a boolean type at the very beginning of QMP. Today we have it...

2dbc8db0 07/01/2010 08:27 pm Luiz Capitulino

QMP: New argument checker (first part)

Current QMP's argument checker is more complex than it should be
and has (at least) one serious bug: it ignores unknown arguments.

To solve both problems we introduce a new argument checker. It's
added on top of the existing one, so that there are no regressions...

4af9193a 07/01/2010 08:27 pm Luiz Capitulino

QMP: New argument checker (second part)

This commit introduces the second (and last) part of QMP's new
argument checker.

The job is done by check_client_args_type(), it iterates over
the client's argument qdict and for for each argument it checks
if it exists and if its type is valid....

f6b4fc8b 07/01/2010 08:27 pm Luiz Capitulino

QMP: Drop old client argument checker

Previous two commits added qmp_check_client_args(), which
fully replaces this code and is way better.

It's important to note that the new checker doesn't support
the '/' arg type. As we don't have any of those handlers...

c917c8f3 07/01/2010 08:27 pm Luiz Capitulino

QMP: Introduce qmp_check_input_obj()

This is similar to qmp_check_client_args(), but it checks if
the input object follows the specification (QMP/qmp-spec.txt
section 2.3).

As we're limited to three keys, the work here is quite simple:
we iterate over the input object, checking each time if the...

0bbab46d 07/01/2010 08:27 pm Luiz Capitulino

QMP: Drop old input object checking

Previous commit added qmp_check_input_obj(), it does all the
checking we need.

Signed-off-by: Luiz Capitulino <>

03a63484 07/01/2010 07:58 pm Jan Kiszka

monitor: Fix leakage during completion processing

Given too many arguments or an invalid command, we were leaking the
duplicated argument strings.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Luiz Capitulino <>

3b6dbf27 07/01/2010 07:58 pm Jan Kiszka

monitor: Fix command completion vs. boolean switches

We now have to move forward to the next argument type via next_arg_type.
This patch fixes completion for 'eject' and maybe also other commands.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Luiz Capitulino <>

8ac470c1 07/01/2010 07:58 pm Jan Kiszka

monitor: Establish cmd flags and convert the async tag

As we want to add more flags to monitor commands, convert the only so
far existing one accordingly.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Luiz Capitulino <>

49b586a9 06/22/2010 11:15 pm Bernhard M. Wiedemann

Extra scan codes for missing keys

The code comes from
http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html

Without this patch it is not possible to send at least 10 special
characters (\|'"`~:;[]{}) via the monitor sendkey command.

Signed-off-by: Bernhard M. Wiedemann <>...

a4673e27 06/14/2010 06:33 pm Anthony Liguori

Merge remote branch 'kwolf/for-anthony' into staging

Conflicts:
hw/pc.c

ea4e78e5 06/13/2010 03:33 pm Jan Kiszka

monitor/QMP: Drop info hpet / query-hpet

This command was of minimal use before, now it is useless as the hpet
become a qdev device and is thus easily discoverable. We should
definitely not set query-hpet in QMP's stone, and there is also no good
reason to keep it for the interactive monitor....

666daa68 06/04/2010 04:20 pm Markus Armbruster

blockdev: Collect block device code in new blockdev.c

Anything that moves hundreds of lines out of vl.c can't be all bad.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

637503d1 06/01/2010 09:48 pm Luiz Capitulino

Monitor: Drop QMP documentation from code

Previous commit added QMP documentation to the qemu-monitor.hx
file, it's is a copy of this information.

While it's good to keep it near code, maintaining two copies of
the same information is too hard and has little benefit as we...

39b59d26 05/19/2010 06:45 pm Luiz Capitulino

Monitor: Return before exiting with 'quit'

This is a new version of the (now reverted) following commit:

0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d

The 'quit' Monitor command (implemented by do_quit()) calls
exit() directly, this is problematic under QMP because QEMU...

a8751701 05/19/2010 06:45 pm Luiz Capitulino

Revert "Monitor: Return before exiting with 'quit'"

This reverts commit 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d.

Next commits will do the same thing in a better way.

Signed-off-by: Luiz Capitulino <>

5a834bb4 05/09/2010 11:19 pm Blue Swirl

sparc: Fix lazy flag calculation on interrupts, refactor

Recalculate Sparc64 CPU flags on interrupts, otherwise some earlier
flags could be stored to pstate.

Refactor PSR/CCR/CWP handling: concentrate the actual
functions to op_helper.c.

Thanks to Igor Kovalenko for reporting....

cb4e5f8e 05/03/2010 08:39 pm Naphtali Sprei

block: read-only: open cdrom as read-only when using monitor's change command

Current code of monitor command: 'change', used to open file for read-write
uncoditionally. Change to open it as read-only for CDROM, and read-write for all others.

Signed-off-by: Naphtali Sprei <>...

6ed2c484 05/03/2010 08:39 pm Luiz Capitulino

QMP: Introduce RESUME event

It's emitted when the Virtual Machine resumes execution.

We currently have the STOP event but don't have the matching
RESUME one, this means that clients are notified when the VM
is stopped but don't get anything when it resumes....

e53f27b9 04/26/2010 10:36 pm Paolo Bonzini

stash away SCM_RIGHTS fd until a getfd command arrives

If there is already a fd in s->msgfd before recvmsg it is
closed by parts that this patch does not touch. So, only
one descriptor can be "leaked" by attaching it to a command
other than getfd.

Signed-off-by: Paolo Bonzini <>...

0e8d2b55 04/26/2010 10:36 pm Luiz Capitulino

Monitor: Return before exiting with 'quit'

The 'quit' Monitor command (implemented by do_quit()) calls
exit() directly, this is problematic under QMP because QEMU
exits before having a chance to send the ok response.

Clients don't know if QEMU exited because of a problem or...

04f8c053 04/26/2010 05:17 pm Luiz Capitulino

QMP: Check "arguments" member's type

Otherwise the following input crashes QEMU:

{ "execute": "migrate", "arguments": "tcp:0:4446" }

Signed-off-by: Luiz Capitulino <>

88f7db84 04/26/2010 05:17 pm Luiz Capitulino

QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER

The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only
for two problems: the input is not an object or the "execute"
key is missing.

Signed-off-by: Luiz Capitulino <>

d6e9098e 04/23/2010 05:08 pm Kevin Wolf

Replace calls of old bdrv_open

What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
callers of the old function are converted to the new one. In some places they
even know the right format, so they should have used bdrv_open2 from the...

ee9545da 04/19/2010 12:55 am Markus Armbruster

monitor: Rename argument type 'b' to 'f'

To make 'b' available for boolean argument.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Luiz Capitulino <>

942cd1f2 04/19/2010 12:55 am Markus Armbruster

monitor: New argument type 'b'

This is a boolean value. Human monitor accepts "on" or "off".
Consistent with option parsing (see parse_option_bool()).

Signed-off-by: Markus Armbruster <>
Signed-off-by: Luiz Capitulino <>

f1dc58e0 04/19/2010 12:55 am Luiz Capitulino

Monitor: Convert do_screen_dump() to QObject

Trivial, as it never fails, doesn't have output nor return
any data.

Note that it's also available under QMP, as kvm-autotest
needs this.

Signed-off-by: Luiz Capitulino <>

e17ba87c 04/19/2010 12:46 am Markus Armbruster

error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER

Signed-off-by: Markus Armbruster <>
Signed-off-by: Luiz Capitulino <>

07a5d95a 04/18/2010 11:31 pm Ryan Harper

Add qerror message if the 'change' target filename can't be opened

Currently when using the change command to switch the file in the cd drive
the command doesn't complain if the file doesn't exit or can't be opened
and the drive keeps the existing image. This patch adds a qerror_report...

28c28973 04/09/2010 07:55 pm Paolo Bonzini

move balloon handling to balloon.c

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Aurelien Jarno <>

9f59b566 03/27/2010 03:30 pm Markus Armbruster

error: Trim includes after "Move qemu_error & friends..."

Missed in commit 2f792016.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Aurelien Jarno <>