Statistics
| Branch: | Revision:

root / qga @ a8aec295

Name Size
Makefile.objs 317 Bytes
channel-posix.c 7.7 kB
channel-win32.c 9.5 kB
channel.h 912 Bytes
commands-posix.c 39.4 kB
commands-win32.c 8.8 kB
commands.c 2 kB
guest-agent-command-state.c 1.6 kB
guest-agent-core.h 1.3 kB
main.c 33.4 kB
qapi-schema.json 17.1 kB
service-win32.c 3.2 kB
service-win32.h 855 Bytes

Latest revisions

# Date Author Comment
c394ecb7 05/30/2013 07:37 pm Laszlo Ersek

qga: determine default state dir and pidfile dynamically

No effective change on POSIX, but on Win32 the defaults come from the
environment / session.

Since commit 39097daf ("qemu-ga: use key-value store to avoid recycling fd
handles after restart") we've relied on the state directory for the fd...
bf12c1fa 05/30/2013 07:37 pm Laszlo Ersek

qga: create state directory on win32

On Win32 the local state directory is application specific and users might
expect qemu-ga to create it automatically.

Signed-off-by: Laszlo Ersek <>
Signed-off-by: Michael Roth <>
a880845f 05/30/2013 07:37 pm Laszlo Ersek

qga: remove undefined behavior in ga_install_service()

We shouldn't snprintf() from a buffer to the same buffer.

Signed-off-by: Laszlo Ersek <>
Signed-off-by: Michael Roth <>
a839ee77 05/30/2013 07:37 pm Laszlo Ersek

qga: save state directory in ga_install_service()

If the user selects a non-default state directory at service installation
time, we should remember it in the registered service.

Signed-off-by: Laszlo Ersek <>
Signed-off-by: Michael Roth <>
ce4cc316 05/17/2013 06:00 pm Anthony Liguori

Merge remote-tracking branch 'mdroth/qga-pull-2013-05-13' into staging

  • mdroth/qga-pull-2013-05-13:
    qga: unlink just created guest-file if fchmod() or fdopen() fails on it
    qga: distinguish binary modes in "guest_file_open_modes" map

Signed-off-by: Anthony Liguori <>
8fe6bbca 05/13/2013 05:45 pm Laszlo Ersek

qga: distinguish binary modes in "guest_file_open_modes" map

In Windows guests this may make a difference.

Since the original patch (commit c689b4f1) sought to be pedantic and to
consider theoretical corner cases of portability, we should fix it up
where it failed to come through in that pursuit....
2b720018 05/13/2013 05:45 pm Laszlo Ersek

qga: unlink just created guest-file if fchmod() or fdopen() fails on it

We shouldn't allow guest filesystem pollution on error paths.

Suggested-by: Eric Blake <>
Signed-off-by: Laszlo Ersek <>
Reviewed-by: Eric Blake <>...
c7e775e4 05/12/2013 12:25 pm Dong Xu Wang

remove double semicolons

Signed-off-by: Dong Xu Wang <>
Signed-off-by: Michael Tokarev <>
c689b4f1 05/07/2013 02:46 pm Laszlo Ersek

qga: set umask 0077 when daemonizing (CVE-2013-2007)

The qemu guest agent creates a bunch of files with insecure permissions
when started in daemon mode. For example:

rw-rw-rw 1 root root /var/log/qemu-ga.log
  rw-rw-rw 1 root root /var/run/qga.state...
ce7f7cc2 04/02/2013 05:06 pm Luiz Capitulino

qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

Today we reset fd_counter if it wraps, but it's better to abort()
instead, as fd_counter should never reach INT64_MAX.

Signed-off-by: Luiz Capitulino <>
Reviewed-by: Eric Blake <>...

View revisions

Also available in: Atom