« Previous | Next » 

Revision b6348f29

IDb6348f29d033d5a8a26f633d2ee94362595f32a4

Added by Peter Crosthwaite over 11 years ago

target-arm/translate: Fix RRX operands

Instructions that both use the RRX second operand and update CS were
incorrect, as the Carry flag was updated too early. An example of such an
instruction would be:

ands r12,r13,RRX

Ands, because of the "s" flag will update the carry flag. But the RRX second
operand rotates through the C flag which should happen before the update.
Fixed the ordering of the two, the old carry is read by "r13,RRX" before being
updated.

Signed-off-by: Peter Crosthwaite <>
Reported-by: Vinesh Peringat <>
Reviewed-by: Peter Maydell <>
Signed-off-by: Aurelien Jarno <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences