« Previous | Next » 

Revision cd7b87ff

IDcd7b87ffe9b6b7b0089ec8c71555f3b942bc6daf

Added by Andreas Färber over 10 years ago

target-i386: Fix X86CPU error handling

Error **errp argument is not for emitting warnings, it means an error
has occurred and the caller should not make any assumptions about the
state of other return values (unless otherwise documented).

Therefore cpu_x86_create() must unref the new X86CPU itself, and
pc_new_cpu() must check for an Error rather than NULL return value.

While at it, clean up a superfluous NULL check.

Reported-by: Jan Kiszka <>
Cc:
Cc: Igor Mammedov <>
Signed-off-by: Andreas Färber <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences