net: Real fix for check_params users
OK, last try: 8e4416af45 broke -net socket, ffad4116b9 tried to fix itbut broke error reporting of invalid parameters. So this patch widelyreverts ffad4116b9 again and intead fixes those callers of check_paramsthat originally suffered from overwritten buffers by using separate...
net: fix error reporting for some net parameter checks
A small bit of confusion between buffers is causing errors like:
qemu: invalid parameter '10' in 'script=/etc/qemu-ifup,fd=10'
instead of:
qemu: invalid parameter 'script' in 'script=/etc/qemu-ifup,fd=10'...
net: Improve parameter error reporting
As host network devices can also be instantiated via the monitor, errorsshould then be reported to the related monitor instead of stderr. Thisrequires larger refactoring, so this patch starts small with introducing...
slirp: Reorder initialization
This patch reorders the initialization of slirp itself as well as itsassociated features smb and redirection. So far the first reference toslirp triggered the initialization, independent of the actual -net useroption which may carry additional parameters. Now we save any request to...
net: factor tap_read_packet() out of tap_send()
Move portability clutter out into its own function.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
net: move the tap buffer into TAPState
KVM uses a 64k buffer for reading from tapfd (for GSO support)and allocates the buffer with TAPState rather than on the stack.
Not allocating it on the stack probably makes sense for qemuanyway, so merge it in advance of GSO support....
net: vlan clients with no fd_can_read() can always receive
If a vlan client has no fd_can_read(), that means it canalways receive packets. The current code assumes it can neverreceive packets.
net: only read from tapfd when we can send
Reduce the number of packets dropped under heavy networktraffic by only reading a packet from the tapfd when aclient can actually handle it.
net: add fd_readv() handler to qemu_new_vlan_client() args
This, apparently, is the style we prefer - all VLANClientStateshould be an argument to qemu_new_vlan_client().
net: re-name vc->fd_read() to vc->receive()
VLANClientState's fd_read() handler doesn't read from filedescriptors, it adds a buffer to the client's receive queue.
Re-name the handlers to make things a little less confusing.
View all revisions | View revisions
Also available in: Atom