« Previous | Next » 

Revision eecbb9fe

IDeecbb9fe6f9a9cffd8d305f688b1be27d197a253

Added by Markus Armbruster over 11 years ago

Revert "qdev: Add help for property value"

This reverts commit 922910ce42d15bdb7c2347436b1b5798b5401de4.

The commit has four issues:

  • When it runs from the monitor, e.g. "device_add e1000,mac=?", it
    prints to stderr instead of the monitor.
  • Help looks to callers just like failed device creation. This makes
    main() exit unsuccessfully on "-device e1000,mac=?".
  • It has an undocumented side effect on -global: "-global e1000.mac=?"
    prints help, but only when we actually add an e1000 device.
  • It does not work for properties that accept the value "?".

We need to do this differently.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Anthony Liguori <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences