Statistics
| Branch: | Revision:

root / hw / usb @ f487b677

# Date Author Comment
f487b677 07/04/2013 06:42 pm Paolo Bonzini

dma: keep a device alive while it has SGLists

Reviewed-by: Anthony Liguori <>
Signed-off-by: Paolo Bonzini <>

71938a09 06/24/2013 09:41 am Gerd Hoffmann

usb: add serial bus property

This patch adds a serial property for all usb devices, which can be
used to set the serial number of a usb device (as listed by lsusb -v)
to a specific value. Applies to emulated devices only.

Signed-off-by: Gerd Hoffmann <>

628e5485 06/24/2013 09:40 am Gerd Hoffmann

usb-host-libusb: set USB_DEV_FLAG_IS_HOST

... like host-{linux,bsd}.c do.

Cc:
Signed-off-by: Gerd Hoffmann <>

cc8d6a84 06/24/2013 09:33 am Kuo-Jung Su

usb/hcd-ehci: Replace PORTSC macros with variables

Replace PORTSC macros with variables which could then be
configured in ehci_xxxx_class_init(...)

Signed-off-by: Kuo-Jung Su <>
Signed-off-by: Andreas Färber <>
Signed-off-by: Gerd Hoffmann <>

4e3d8b4b 06/24/2013 09:33 am Kuo-Jung Su

usb/hcd-ehci: Add Faraday FUSBH200 support

Add Faraday FUSBH200 support, which is slightly different from EHCI spec.
(Or maybe simply a bad/wrong implementation...)

Signed-off-by: Kuo-Jung Su <>
Signed-off-by: Andreas Färber <>...

bc45de8c 06/24/2013 09:33 am Hans de Goede

usb/host-libusb: Fix building with libusb git master code

The next libusb release will deprecate libusb_get_port_path, and since
we compile with -Werror, this breaks the build.

Signed-off-by: Hans de Goede <>
Signed-off-by: Gerd Hoffmann <>

08f4c90b 06/24/2013 09:23 am Andreas Färber

usb/hcd-ehci-sysbus: Convert to QOM realize

The SysBus qdev initfn merely calls SysBusDeviceClass::init, so we can
replace it with a realizefn already. This avoids getting into any initfn
ambiguity with the upcoming Faraday EHCI implementation.

Rename internal usb_ehci_initfn() to usb_ehci_realize() to allow to...

d4614cc3 06/24/2013 09:23 am Andreas Färber

usb/hcd-ehci: Split off instance_init from realize

This makes the mem MemoryRegion available to derived instance_inits.

Keep the bus in realize for now since naming breaks in instance_init.

Signed-off-by: Andreas Färber <>
Signed-off-by: Gerd Hoffmann <>

20c57043 06/24/2013 09:23 am Andreas Färber

usb/hcd-ehci: Add Tegra2 SysBus EHCI device

This prepares an EHCI device for the Nvidia Tegra2 SoC family.
Values based on patch by Vincent Palatin and verified against TRM v01p.

Cc: Vincent Palatin <>
Signed-off-by: Andreas Färber <>...

df32fd1c 06/20/2013 05:39 pm Paolo Bonzini

dma: eliminate DMAContext

The DMAContext is a simple pointer to an AddressSpace that is now always
already available. Make everyone hold the address space directly,
and clean up the DMA API to use the AddressSpace directly.

Reviewed-by: Peter Maydell <>...

37352df3 06/03/2013 12:38 pm Gerd Hoffmann

xhci: add live migration support

With all preparing pieces in place we can finally drop in
the vmstate structs and the postload function.

Signed-off-by: Gerd Hoffmann <>

4034e693 06/03/2013 12:37 pm Gerd Hoffmann

xhci: add XHCISlot->addressed

Preparing for live-migration support, post_load will need that.

Signed-off-by: Gerd Hoffmann <>

492b21f6 06/03/2013 12:37 pm Gerd Hoffmann

xhci: add xhci_alloc_epctx

Factor out endpoint context allocation to a separate function.
xhci live migration will need that too, in post_load.

Signed-off-by: Gerd Hoffmann <>

003e15a1 06/03/2013 12:37 pm Gerd Hoffmann

xhci: add xhci_init_epctx

Factor out endpoint context initialization to a separate function.
xhci live migration will need that too, in post_load.

Signed-off-by: Gerd Hoffmann <>

75633529 06/03/2013 08:17 am Michael Marineau

Fix usage of USB_DEV_FLAG_IS_HOST flag.

USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a
"Fitbit Base Station" USB dongle was triggering this assert.

Signed-off-by: Michael Marineau <>
Cc:
Signed-off-by: Gerd Hoffmann <>

45ec2671 06/03/2013 08:17 am Ed Maste

host-libusb: Correct test for USB packet state

USB_RET_ASYNC is -6, so inflight was always false.

Signed-off-by: Ed Maste <>
Cc:
Signed-off-by: Gerd Hoffmann <>

c7e775e4 05/12/2013 12:25 pm Dong Xu Wang

remove double semicolons

Signed-off-by: Dong Xu Wang <>
Signed-off-by: Michael Tokarev <>

9822261c 05/07/2013 12:34 pm Hans de Goede

uhci: Use an intermediate buffer for usb packet data

Due to various unfortunate reasons we cannot reliable detect a guest
cancelling a packet as soon as it happens, instead we detect cancels
with some delay.

When packets are handled async, and we directly pass the guest memory for...

4e906d56 05/07/2013 12:34 pm Gerd Hoffmann

xhci: handle USB_RET_BABBLE

Signed-off-by: Gerd Hoffmann <>

c3268cc1 05/07/2013 12:34 pm Gerd Hoffmann

usb-host: add usb_host_full_speed_compat

Alloes to pass through usb2 devices on usb1 host controllers if possible.
Brings the libusb implementation to feature-parity with the linux usbfs
code, so the usb-host implementation in 1.5 (libusb) doesn't regress...

95efb20c 05/07/2013 09:19 am Gerd Hoffmann

usb-host: live migration support for the libusb version

Signed-off-by: Gerd Hoffmann <>

11fc853c 05/03/2013 08:05 pm KONRAD Frederic

scsi: add bus_name parameter to scsi_bus_new.

This adds the possibility to create a scsi-bus with a specified name.

Signed-off-by: KONRAD Frederic <>
Acked-by: Paolo Bonzini <>
Tested-by: Cornelia Huck <>...

36cd6f6f 04/29/2013 08:16 pm Paolo Bonzini

audio: remove the need for audio card CONFIG_* symbols

Signed-off-by: Paolo Bonzini <>
Message-id:
Signed-off-by: Anthony Liguori <>

ae12e3a6 04/27/2013 02:38 am Cole Robinson

ccid: Fix crash when backend isn't specified

Reproducer:

./x86_64-softmmu/qemu-system-x86_64 -device usb-ccid,id=ccid0 -usb -device ccid-card-emulated -monitor stdio

Signed-off-by: Cole Robinson <>
Reviewed-by: Alon Levy <>

58aeda15 04/24/2013 11:48 am Alon Levy

dev-smartcard-reader: empty implementation for Mechanical (fail correctly)

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

2f8f916b 04/24/2013 11:48 am Alon Levy

dev-smartcard-reader: copy atr protocol to ccid parameters

Adds todos.

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

d7d218ef 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: change default protocol to T=0

We don't support T=1 so we shouldn't advertise it by default.

Two independent changes:
  • Default ATR
    sets T=0. This gets overwritten by the client provided ATR later.
  • Class descriptor
    changes dwAdvertise dwProtocols.PPPP to 0x1 and dwProtocols.RRRR=0 per spec....
4942d6c3 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: define structs for CCID_Parameter internals

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

b16352ac 04/24/2013 11:47 am Alon Levy

ccid-card-passthru, dev-smartcard-reader: add debug environment variables

Introduces a new utility function: parse_debug_env to avoid code
duplication.

This overrides whatever debug value is set on the corresponding devices
from the command line, and is meant to ease the usage with any...

0e61400c 04/24/2013 11:47 am Alon Levy

ccid-card-passthru: add atr check

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

693e4773 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: reuse usb.h definitions

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

c5cd7c87 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: support windows guest

By not advertising USB wakeup support (which we don't).

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

47bf53af 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: remove aborts (never triggered, but just in case)

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

7e1ac5ab 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: nicer debug messages

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

4543d43c 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: white space fixes

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

da000a48 04/24/2013 11:47 am Jim Meyering

ccid: declare DEFAULT_ATR table to be "static const"

Signed-off-by: Jim Meyering <>
Reviewed-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

d18c7117 04/24/2013 11:47 am Jim Meyering

ccid: make backend_enum_table "static const" and adjust users

Signed-off-by: Jim Meyering <>
Reviewed-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>

d0ebd788 04/24/2013 11:47 am Marc-André Lureau

ccid-card-emul: do not crash if backend is not provided

Program received signal SIGSEGV, Segmentation fault.
__strcmp_sse42 () at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164
164 movdqu (%rsi), %xmm2
(gdb) bt
at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:477...

7d04c2b7 04/23/2013 09:43 am Gerd Hoffmann

xhci: remove XHCIRing->base (unused)

Signed-off-by: Gerd Hoffmann <>

e449f26b 04/23/2013 09:43 am Hans de Goede

ehci_free_packet: Discard finished packets when the queue is halted

With pipelining it is possible to encounter a finished packet when cleaning
the queue due to a halt. This happens when a non stall error happens while
talking to a real device. In this case the queue on the usb-host side will...

3b7e759a 04/23/2013 09:43 am Gerd Hoffmann

usb: better speed mismatch error reporting

Report the supported speeds for device and port in the error message.
Also add the speeds to the tracepoint. And while being at it drop
the redundant error message in usb_desc_attach, usb_device_attach will
report the error anyway....

3f5cc97e 04/23/2013 09:43 am Gerd Hoffmann

usb-host: raise libusbx minimum version to 1.0.13

Allows to remove one FIXME. Makes LIBUSB_LOG_LEVEL_WARNING build errors
go away. And starting with that version libusb has a LIBUSBX_API_VERSION
define which allows to easily #ifdef version dependencies should that...

af203be3 04/16/2013 01:04 pm Gerd Hoffmann

xhci: use slotid as device address

Is good enougth for unique device addresses and avoids the need for any
state for device addressing. Makes live migration support easier. Also
makes device->slot lookups trivial.

Signed-off-by: Gerd Hoffmann <>

a6718874 04/16/2013 01:04 pm Gerd Hoffmann

xhci: fix address device

Zero-initialize the set-address dummy USBPacket,
also add buffer to avoid sanity checks triggering.

https://bugzilla.redhat.com/show_bug.cgi?id=929019

Signed-off-by: Gerd Hoffmann <>

2b2325ff 04/16/2013 01:04 pm Gerd Hoffmann

use libusb for usb-host

Reimplement usb-host on top of libusb.
Reasons to do this:

(1) Largely rewritten from scratch, nice opportunity to kill historical
cruft.
(2) Offload usbfs handling to libusb.
(3) Have a single portable code base instead of bsd + linux variants....
7598b41c 04/16/2013 12:59 pm Hans de Goede

usb-serial: Remove double call to qemu_chr_add_handlers( NULL )

usb-serial has a qdev chardev property, and hw/qdev-properties-system.c
already contains:

static void release_chr(Object *obj, const char *name, void *opaque) {
DeviceState *dev = DEVICE;...

94ae9eec 04/16/2013 12:59 pm Gerd Hoffmann

xhci: remove leftover debug printf

Signed-off-by: Gerd Hoffmann <>

6d3bc22e 04/16/2013 12:59 pm Gerd Hoffmann

xhci: add xhci_cap_write

Signed-off-by: Gerd Hoffmann <>

bdfce20d 04/16/2013 12:59 pm Gerd Hoffmann

xhci: fix portsc writes

Check for port reset first and skip everything else then.
Add sanity checks for PLS updates.
Add PLC notification when entering PLS_U0 state.

This gets host-initiated port resume going on win8.

Signed-off-by: Gerd Hoffmann <>

0bc3cd62 04/15/2013 07:19 pm Paolo Bonzini

include: avoid useless includes of exec/ headers

Headers in include/exec/ are for the deepest innards of QEMU,
they should almost never be included directly.

Signed-off-by: Paolo Bonzini <>

dccfcd0e 04/15/2013 07:19 pm Paolo Bonzini

sysemu: avoid proliferation of include/ subdirectories

Signed-off-by: Paolo Bonzini <>

47b5264e 04/08/2013 09:12 pm Anthony Liguori

Merge remote-tracking branch 'bonzini/hw-dirs' into staging

  1. By Paolo Bonzini
  2. Via Paolo Bonzini
    • bonzini/hw-dirs: (35 commits)
      hw: move private headers to hw/ subdirectories.
      MAINTAINERS: update for source code movement
      hw: move last file to hw/arm/...
47b43a1f 04/08/2013 07:13 pm Paolo Bonzini

hw: move private headers to hw/ subdirectories.

Many headers are used only in a single directory. These can be
kept in hw/.

Signed-off-by: Paolo Bonzini <>

49ab747f 04/08/2013 07:13 pm Paolo Bonzini

hw: move target-independent files to subdirectories

This patch tackles all files that are compiled once, moving
them to subdirectories of hw/.

Signed-off-by: Paolo Bonzini <>

aaa4d1df 04/08/2013 07:13 pm Paolo Bonzini

hw: make all of hw/usb/ configurable via default-configs/

Signed-off-by: Paolo Bonzini <>

0d09e41a 04/08/2013 07:13 pm Paolo Bonzini

hw: move headers to include/

Many of these should be cleaned up with proper qdev-/QOM-ification.
Right now there are many catch-all headers in include/hw/ARCH depending
on cpu.h, and this makes it necessary to compile these files per-target.
However, fixing this does not belong in these patches....

2a7a239f 04/08/2013 06:36 pm Anthony Liguori

Merge remote-tracking branch 'kraxel/usb.79' into staging

  1. By Gerd Hoffmann (7) and Hans de Goede (3)
  2. Via Gerd Hoffmann
    • kraxel/usb.79:
      usb-tablet: Don't claim wakeup capability for USB-2 version
      usb: update docs for bus name change
      usb-hub: report status changes only once...
76534da7 04/05/2013 07:58 pm Kevin Wolf

usb-storage: Forward serial number to scsi-disk

usb-storage takes care to fetch the USB serial number from -drive
options, but it neglected to pass its own 'serial' property to the
scsi-disk it creates. With this patch, the 'serial' qdev property and
the 'serial' option in -drive behave the same and correctly apply the...

c24e4aac 04/03/2013 12:39 pm Gerd Hoffmann

usb-hub: limit chain length

USB supports up to 5 hubs chained.
Catch attempts to chain more.

Signed-off-by: Gerd Hoffmann <>

a309ee6e 04/03/2013 12:39 pm Gerd Hoffmann

usb-hub: report status changes only once

Signed-off-by: Gerd Hoffmann <>

aa1c9e97 04/03/2013 12:39 pm Hans de Goede

usb-tablet: Don't claim wakeup capability for USB-2 version

Our ehci code does not implement wakeup support, so claiming support for
it with usb-tablet in USB-2 mode causes all tablet events to get lost.

http://bugzilla.redhat.com/show_bug.cgi?id=929068...

4b7b2afa 04/03/2013 12:39 pm Gerd Hoffmann

xhci: zap unused name field

Signed-off-by: Gerd Hoffmann <>

c94a7c69 04/03/2013 10:55 am Gerd Hoffmann

xhci: fix numintrs sanity checks

Make sure numintrs is a power of two, msi requires this.

https://bugzilla.redhat.com/show_bug.cgi?id=918035

Signed-off-by: Gerd Hoffmann <>

61803996 04/03/2013 10:55 am Gerd Hoffmann

xhci: remove leftover debug printf

Signed-off-by: Gerd Hoffmann <>

0ab966cf 04/03/2013 10:55 am Gerd Hoffmann

xhci: remove unimplemented printfs

Replace them with a tracepoint, so they don't spam stderr by default.

Signed-off-by: Gerd Hoffmann <>

3713e148 04/03/2013 10:55 am Hans de Goede

usb-redir: Fix crash on migration with no client connected

If no client is connected on the src side, then we won't receive a
parser during migrate, in this case usbredir_post_load() should be a nop,
rather then to try to derefefence the NULL dev->parser pointer....

c874ea97 04/03/2013 10:55 am Hans de Goede

usb-redir: Add flow control support

Signed-off-by: Hans de Goede <>
Signed-off-by: Gerd Hoffmann <>

19083228 03/27/2013 05:26 pm Hans de Goede

qemu-char: Automatically do fe_open / fe_close on qemu_chr_add_handlers

Most frontends can't really determine if the guest actually has the frontend
side open. So lets automatically generate fe_open / fe_close as soon as a
frontend becomes ready (as signalled by calling qemu_chr_add_handlers) /...

16665b94 03/27/2013 05:26 pm Hans de Goede

qemu-char: Rename opened to be_open

Rename the opened variable to be_open to reflect that it contains the
opened state of the backend.

Signed-off-by: Hans de Goede <>
Message-id:
Signed-off-by: Anthony Liguori <>

6214e73c 03/26/2013 09:02 pm Alex Williamson

pcie: Add endpoint capability initialization wrapper

Fix the awkward API of mangling the caller specified PCIe type and
just provide an interface to initialize an endpoint device. This
will pick either a regular endpoint or integrated endpoint based on
the bus and return pcie_cap_init to doing exactly what is asked....

b4a42f81 03/01/2013 02:54 pm Paolo Bonzini

hw: move qdev-monitor.o to toplevel directory

qdev-monitor.c is the only "core qdev" file that is not used in
user-mode emulation, and it does not define anything that is used
by hardware models. Remove it from the hw/ directory and
remove hw/qdev-monitor.h from hw/qdev.h too; this requires...

685cbd2f 02/23/2013 11:39 am Hervé Poussineau

xhci: fix bad print specifier

This fixes the following compilation error:
hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
‘long long unsigned int’, but argument 4 has type ‘unsigned int’

Signed-off-by: Hervé Poussineau <>...

82fb0c89 02/22/2013 05:53 pm Gerd Hoffmann

unbreak hw/usb/redirect.c build

Commit 8550a02d1239415342959f6a32d178bc05c557cc added a streams
parameter to usb_wakeup and didn't update redirect.c. Fix it.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

89a453d4 02/19/2013 02:18 pm Gerd Hoffmann

uas-uas: usb3 streams

Add usb3 streams support to the uas (usb attached scsi) emulation.

Signed-off-by: Gerd Hoffmann <>

024426ac 02/19/2013 02:17 pm Gerd Hoffmann

usb-xhci: usb3 streams

Add streams support to the xhci emulation. No secondary streams yet,
only linear stream arays are supported for now.

Signed-off-by: Gerd Hoffmann <>

4075975d 02/19/2013 01:30 pm Gerd Hoffmann

usb-host: move legacy cmd line bits

The code handling the "-usbdevice host:..." legacy command line
syntax is moved to the new hw/usb/host-legacy.c file.

Signed-off-by: Gerd Hoffmann <>

1a3973b3 02/19/2013 01:30 pm Gerd Hoffmann

usb-host: remove usb_host_device_close

Nobody implements that anyway.

Signed-off-by: Gerd Hoffmann <>

e382d966 02/19/2013 01:30 pm Gerd Hoffmann

usb: add usb_ep_set_halted

Signed-off-by: Gerd Hoffmann <>

6a98d1c0 02/19/2013 01:30 pm Gerd Hoffmann

usb: make usb_packet_copy operate on combined packets

Likewise usb_packet_skip.
Also usb_packet_size.

Signed-off-by: Gerd Hoffmann <>

6ef3ccd1 02/19/2013 01:30 pm Gerd Hoffmann

usb-redir: simplify packet copy

usb_packet_copy can handle combined packets now,
so it isn't needed to special-case them any more.

Also use the new usb_packet_size() function.

Signed-off-by: Gerd Hoffmann <>

2e5df36d 02/19/2013 01:30 pm Gerd Hoffmann

usb: fix endpoint descriptor ordering

Fix the ordering of the endpoint descriptors for superspeed endpoints:
The superspeed companion must come first, possible additional
descriptors for the endpoint after that.

Signed-off-by: Gerd Hoffmann <>

8550a02d 02/19/2013 01:30 pm Gerd Hoffmann

usb-core: usb3 streams

This patch adds support for usb3 streams to the usb subsystem core.
This is just adding a streams field / parameter in a number of places.

Signed-off-by: Gerd Hoffmann <>

07d17e77 02/19/2013 01:30 pm Gerd Hoffmann

allow disabling usb smartcard support

Signed-off-by: Gerd Hoffmann <>

9db7c414 02/19/2013 01:30 pm Gerd Hoffmann

usb-storage: use scsi_req_enqueue return value

Signed-off-by: Gerd Hoffmann <>

6c83f815 02/19/2013 01:28 pm Gerd Hoffmann

make usb devices configurable

Leave the core usb devices (usb hub, tablet, mouse, keyboard)
enabled unconditionally. Make the other ones configurable.

Exceptions:
- bluetooth: not qdevified yet, has a vl.c dependency because
of that, thus disabling isn't as easy as not linking the...

62162fff 02/19/2013 10:51 am Gerd Hoffmann

usb: Makefile cleanup

Group files, sprinkle in some comments.

Signed-off-by: Gerd Hoffmann <>

948ecf21 02/01/2013 07:03 pm Jason Wang

net: intorduce qemu_del_nic()

To support multiqueue nic, this patch separate the nic destructor from
qemu_del_net_client() to a new helper qemu_del_nic() since the mapping bettween
NiCState and NetClientState were not 1:1 in multiqueue. The following patches...

cc1f0f45 02/01/2013 07:03 pm Jason Wang

net: introduce qemu_get_nic()

To support multiqueue, this patch introduces a helper qemu_get_nic() to get
NICState from a NetClientState. The following patches would refactor this helper
to support multiqueue.

Signed-off-by: Jason Wang <>...

b356f76d 02/01/2013 07:02 pm Jason Wang

net: introduce qemu_get_queue()

To support multiqueue, the patch introduce a helper qemu_get_queue()
which is used to get the NetClientState of a device. The following patches would
refactor this helper to support multiqueue.

Signed-off-by: Jason Wang <>...

7fa96d73 01/22/2013 12:09 pm Gerd Hoffmann

ohci: add missing break

Signed-off-by: Gerd Hoffmann <>

34707333 01/22/2013 12:09 pm Gerd Hoffmann

usb: add usb-bot device (scsi bulk-only transport).

Basically the same as usb-storage, but without automatic scsi
device setup. Also features support for up to 16 LUNs.

Signed-off-by: Gerd Hoffmann <>

f4c0e501 01/22/2013 12:01 pm Gerd Hoffmann

Revert "usb-storage: Drop useless null test in usb_msd_handle_data()"

This reverts commit a1cbfd554e11bb8af38c2f3e1f1574bf4c563cd2.

Test isn't useless. scsi_req_enqueue() may finish the request (will
actually happen for requests which don't trigger any I/O such as...

c1db2919 01/19/2013 12:30 pm Stefan Weil

usb: Fix compilation for MinGW (regression)

84f2d0ea added an argument to function usb_host_info.
The stub function must match the declaration in usb.h.

Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>

84f2d0ea 01/17/2013 02:24 pm Wenchao Xia

HMP: add QDict to info callback handler

This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter. Now it is set to NULL at default case.

Signed-off-by: Wenchao Xia <>...

a1cbfd55 01/16/2013 08:03 pm Markus Armbruster

usb-storage: Drop useless null test in usb_msd_handle_data()

scsi_req_new() never returns null, and scsi_req_enqueue() dereferences
the pointer, so checking for null is useless.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Anthony Liguori <>

b55160c3 01/14/2013 06:27 pm Anthony Liguori

Merge remote-tracking branch 'kraxel/usb.76' into staging

  • kraxel/usb.76:
    usb-host: Initialize dev->port the obviously safe way
    usb-host: Drop superfluous null test from usb_host_auto_scan()
    ehci: Assert state machine is sane w.r.t. EHCIQueue
    xhci: nuke transfe5rs on detach...
cc8d2b65 01/14/2013 01:47 pm Markus Armbruster

ehci: Assert state machine is sane w.r.t. EHCIQueue

Coverity worries the EHCIQueue pointer could be null when we pass it
to functions that reference it. The state machine ensures it can't be
null then. Assert that, to hush the checker.

Signed-off-by: Markus Armbruster <>...

46635308 01/14/2013 01:47 pm Markus Armbruster

usb-host: Drop superfluous null test from usb_host_auto_scan()

Coverity points out that port is later passed to usb_host_open(),
which dereferences it. It actually can't be null: it always points to
usb_host_scan()'s auto port[]. Drop the superfluous port == NULL...

03607847 01/14/2013 01:47 pm Markus Armbruster

usb-host: Initialize dev->port the obviously safe way

Coverity worries the strcpy() could overrun the destination. It
can't, because the source always points to usb_host_scan()'s auto
port[], which has the same size. Use pstrcpy() anyway, to hush the
checker....

0cb41e2c 01/14/2013 09:59 am Gerd Hoffmann

xhci: nuke transfe5rs on detach

Signed-off-by: Gerd Hoffmann <>