Statistics
| Branch: | Revision:

root @ fc22118d

# Date Author Comment
ab03b63d 10/20/2010 08:10 pm Sripathi Kodi

[virtio-9p] open should not return EBADF

When 9P server fails to create a file due to permission problems it should
return EPERM. However the current 9P2000.L code returns EBADF. EBADF is NOT
a valid return value from open() call.

The problem is because we do not preserve the errno variable properly. If the...
82cc3ee8 10/20/2010 08:10 pm M. Mohan Kumar

[virto-9p] Implement TLOCK

Synopsis

size[4] TLock tag[2] fid[4] flock[n]
    size[4] RLock tag[2] status[1]

Description

Tlock is used to acquire/release byte range posix locks on a file
identified by given fid. The reply contains status of the lock request...
8f354003 10/20/2010 08:10 pm M. Mohan Kumar

qemu-virtio9p: Implement TGETLOCK

Synopsis

size[4] TGetlock tag[2] fid[4] getlock[n]
    size[4] RGetlock tag[2] getlock[n]

Description

TGetlock is used to test for the existence of byte range posix locks on
a file identified by given fid. The reply contains getlock structure. If...
b41e95d3 10/20/2010 08:10 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Introduce server side TFSYNC/RFSYNC for dotl

SYNOPSIS
size4 Tfsync tag2 fid4

size[4] Rfsync tag[2]

DESCRIPTION

The Tfsync transaction transfers ("flushes") all modified in-core data of
file identified by fid to the disk device (or other permanent storage...
df0973a4 10/20/2010 08:10 pm M. Mohan Kumar

qemu-virtio-9p: Implement TREADLINK operation for 9p2000.L

Synopsis

size[4] TReadlink tag[2] fid[4]
        size[4] RReadlink tag[2] target[s]

Description
Readlink is used to return the contents of the symoblic link
referred by fid. Contents of symboic link is returned as a...
0f8151cb 10/20/2010 08:10 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Ignore O_DIRECT hint from client.

The O_DIRECT flag imposes alignment restrictions on the length and address
of userspace buffers and the file offset of I/Os.

While VirtFS/9P has plans to implement O_DIRECT behavior on the server,
for now we will stick to a behavior like NFS by bypassing the page cache...
fc22118d 10/20/2010 08:10 pm Aneesh Kumar K.V

virtio-9p: Use layered xattr approach

We would need this to make sure we handle the mapped
security model correctly for different xattr names.

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>
a12c668f 10/20/2010 07:41 pm Blue Swirl

trace: improve info trace output

Use PRI*64 to print full 64 bit data even on ILP32 hosts.

Print also sixth tracepoint parameter.

Acked-by: Stefan Hajnoczi <>
Cc: Stefan Hajnoczi <>
Signed-off-by: Blue Swirl <>
cf85cf8e 10/20/2010 07:41 pm Stefan Hajnoczi

trace: Format strings must begin/end with double quotes

Document the restriction that format strings must begin and end with
double quotes. This is for easy parsing since we don't run cpp over
trace-events.

Signed-off-by: Stefan Hajnoczi <>...
d8023f31 10/20/2010 07:41 pm Blue Swirl

apic: convert debug printf statements to tracepoints

Replace debug printf statements with tracepoints.

Signed-off-by: Stefan Hajnoczi <>
Signed-off-by: Blue Swirl <>
6df40080 10/20/2010 07:27 pm Stefan Hajnoczi

trace: Relax trace-events parsing regex in simpletrace.py

The regular expression to parse trace event definitions assumed the
format string would be a simple double-quoted string. However, we now
use PRI?64 for portability which splits string literals. The regular...
38cc9b60 10/17/2010 11:39 pm Jindrich Makovicka

issue snd_pcm_start() when capturing audio

snd_pcm_start() starts the capture process and ensures that the events
are delivered to the poll handler. Without the call, capture can be started
only when there is simultaneous playback running.

Signed-off-by: Jindrich Makovicka <>...
22d948a2 10/17/2010 11:39 pm Jindrich Makovicka

fix 100% CPU load when idle with ALSA

Playback control function did not disable polling when playback stops.
Caused busy spinning of the main loop due to unprocessed events.

Signed-off-by: Jindrich Makovicka <>
Signed-off-by: malc <>
f871d689 10/13/2010 10:14 pm Blue Swirl

trace: print a warning if user tries to enable an unknown trace event

There was no warning if a bad trace event name was given to
'trace-event' command, thus the user could think that the command
was successful even if this was not the case.

Print a warning if the user tries to enable a trace event which is not...
2abf314d 10/13/2010 09:43 pm Blue Swirl

mips: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
/src/qemu/target-mips/translate.c: In function 'gen_ld':
/src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set but not used [-Werror=unused-but-set-variable]...
577f25a5 10/13/2010 09:43 pm Blue Swirl

ppc: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
/src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but not used [-Werror=unused-but-set-variable]...
4581cbcd 10/13/2010 09:43 pm Blue Swirl

i386: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-i386/op_helper.c: In function 'switch_tss':
/src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' set but not used [-Werror=unused-but-set-variable]...
2ded6ad7 10/13/2010 09:43 pm Blue Swirl

vnc: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/ui/vnc.c: In function 'vnc_client_cache_auth':
/src/qemu/ui/vnc.c:217:12: error: variable 'qdict' set but not used [-Werror=unused-but-set-variable]
/src/qemu/ui/vnc.c: In function 'vnc_display_open':...
03e654c0 10/13/2010 09:42 pm Blue Swirl

cris: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced a warning:
In file included from /src/qemu/target-cris/translate.c:3154:0:
/src/qemu/target-cris/translate_v10.c: In function 'dec10_prep_move_m':
/src/qemu/target-cris/translate_v10.c:111:22: error: variable 'rd' set but not used [-Werror=unused-but-set-variable]...
49a2942d 10/13/2010 09:41 pm Blue Swirl

Delete write only variables

Compiling with GCC 4.6.0 20100925 produced warnings like:
/src/qemu/net/tap-win32.c: In function 'tap_win32_open':
/src/qemu/net/tap-win32.c:582:12: error: variable 'hThread' set but not used [-Werror=unused-but-set-variable]
...
83e3f76c 10/13/2010 09:38 pm Blue Swirl

block: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/block/qcow2-refcount.c: In function 'update_refcount':
/src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable]...
8c78881f 10/13/2010 09:38 pm Blue Swirl

cirrus: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
In file included from /src/qemu/hw/cirrus_vga_rop.h:174:0,
from /src/qemu/hw/cirrus_vga.c:284:
/src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_patternfill_0_8':...
ef476062 10/13/2010 09:38 pm Blue Swirl

eepro100: initialize a variable in all cases

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/hw/eepro100.c: In function 'eepro100_read4':
/src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]...
f3f5b867 10/13/2010 09:38 pm Blue Swirl

lsi53c895a: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable]...
ae0bfb79 10/13/2010 09:38 pm Blue Swirl

ppc: remove video.x

Only Mac-on-Linux stuff used video.x, OpenBIOS does not need it.

Remove video.x MoL hacks.

Signed-off-by: Alexander Graf <>
Signed-off-by: Blue Swirl <>
a2d3f695 10/11/2010 11:37 pm Anthony Liguori

Merge remote branch 'mst/for_anthony' into staging
d7489b72 10/09/2010 11:24 am Blue Swirl

trace: remove timestamp files when cleaning up

'make clean' did not remove trace.[ch]-timestamp files,
only trace.[ch]. But 'make' did not know how to make trace.[ch]
files if the timestamp files were present.

Fix by removing the timestamp files along with trace.[ch]....
ba807829 10/09/2010 11:23 am Stefan Weil

configure: Send error message from spice check to /dev/null

pkg-config is not always available (e.g. on win32 hosts),
but we don't want to see the 'command not found' error message.

Redirect stdout and stderr to /dev/null.

v2:

  • Removed changes which should not have been here....
6650b710 10/09/2010 11:20 am Stefan Weil

win32: Set unbuffered stdout

Win32 does not support line-buffering, but it allows
unbuffered output.

Unbuffered output is a good approximation. For typical output
statements which usually end with '\n', it's even identical.

Buffered output is unusable for program traces because of...
ea95f156 10/09/2010 11:19 am Stefan Hajnoczi

.gitignore: Ignore *-timestamp

Timestamp files were recently added to reduce make churn on source files
that use tracing. The timestamp files should never be committed and
should not be visible in git status.

Signed-off-by: Stefan Hajnoczi <>...
b755a428 10/09/2010 11:19 am Vincent Minet

acpi: Fix an infinite loop in acpi_table_add

Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an
infinite loop in acpi_table_add.

Signed-off-by: Vincent Minet <>
Acked-by: Jes Sorensen <>...
10d554c6 10/09/2010 11:18 am Stefan Weil

configure: Remove unneeded defines from checks

_GNU_SOURCE is already defined in QEMU_CFLAGS which
is passed to gcc in shell function compile_prog.

Removing the definition from several checks avoids compiler warnings
(which are now written to config.log)....
832ce9c2 10/09/2010 11:17 am Scott Wood

configure: include stddef.h for NULL

This fixes an observed failure to detect madvise() on Linux.

To avoid similar issues, all other tests that use NULL but don't already
have stddef.h (or another header that is defined to provide NULL,
such as stdio.h, unistd.h, or time.h) are also fixed....
bbf0a440 10/09/2010 11:17 am Stefan Hajnoczi

trace: Trace bdrv_aio_{readv,writev}

Observing block layer aio readv/writev operations is useful for
debugging image formats or understanding guest disk I/O patterns.

Signed-off-by: Stefan Hajnoczi <>
Signed-off-by: Blue Swirl <>
ea9c1698 10/09/2010 11:16 am Stefan Hajnoczi

trace: Use TP_PROTO() and TP_ARGS() for LTTng UST

The LTTng UserSpace Tracer formerly used TPPROTO and TPARGS instead
of TP_PROTO() and TP_ARGS() like the kernel uses. This has been changed
so QEMU needs to follow.

I am not aware of a graceful way of making the transition but since no...
5eb5527b 10/09/2010 11:16 am Stefan Hajnoczi

trace: Don't strip lines containing '#' arbitrarily

Although comment lines must be skipped, the '#' character can occur in
valid format strings. Be more careful when checking for comments.
Leave comments at the end of the line where they will not interfere with...
9a85d394 10/09/2010 11:16 am Stefan Hajnoczi

trace: Use portable format strings

It is not portable to use "%ld" for int64_t because int64_t may have
type long on 64-bit platforms and long long on 32-bit platforms. Use
the standard library PRId64 macros to keep format strings portable.

Signed-off-by: Stefan Hajnoczi <>...
3e18c6bf 10/07/2010 10:20 pm Edgar E. Iglesias

cris: Consider the TLB valid bit on writes to the TLB

When updating the guest TLB we only need to flush previous
mappings from the entry written if the entry was valid.

Also fixes a compiler warning reported by Blue Swirl.

Signed-off-by: Edgar E. Iglesias <>
e0c472d8 10/07/2010 01:19 pm Michael S. Tsirkin

virtio: invoke set_status callback on reset

As status is set to 0 on reset, invoke the relevant callback. This makes
for a cleaner code in devices as they don't need to duplicate the code
in their reset routine, as well as excercises this path a little more....
afbaa7b4 10/07/2010 01:19 pm Michael S. Tsirkin

virtio-net: unify vhost-net start/stop

Move all of vhost-net start/stop logic to a single routine,
and call it from everywhere.

Additionally, start/stop vhost-net on link up/down:
we should not transmit anything if user asked us to
put the link down.

Signed-off-by: Michael S. Tsirkin <>...
010ec629 10/07/2010 01:19 pm Stefan Weil

eepro100: Add support for multiple individual addresses (multiple IA)

I reviewed the latest sources of Linux, FreeBSD and NetBSD.
They all reset the multiple IA bit (multi_ia in BSD) to zero,
but I did not find code which sets this bit to one
(like it is done by some routers)....
54dd9321 10/07/2010 01:19 pm Michael S. Tsirkin

virtio: change set guest notifier to per-device

When using irqfd with vhost-net to inject interrupts,
a single evenfd might inject multiple interrupts.
Implementing this is much easier with a single
per-device callback to set guest notifiers.

Signed-off-by: Michael S. Tsirkin <>
c8852121 10/07/2010 01:19 pm Michael S. Tsirkin

vhost: error code

fix up errors returned to include errno, not just -1

Signed-off-by: Michael S. Tsirkin <>
a083a89d 10/06/2010 07:24 pm Michael S. Tsirkin

net: delay freeing peer host device

With -netdev, virtio devices present offload
features to guest, depending on the backend used.
Thus, removing host netdev peer while guest is
active leads to guest-visible inconsistency and/or crashes.

As a solution, while guest (NIC) peer device exists,...
4447d609 10/05/2010 10:14 pm Anthony Liguori

Merge remote branch 'spice/submit.6' into staging

Conflicts:
configure

Signed-off-by: Anthony Liguori <>
48f57044 10/05/2010 09:54 pm Anthony Liguori

Merge remote branch 'qmp/for-anthony' into staging
b0cd712c 10/05/2010 09:53 pm Stefan Weil

Fix spelling in comments

multifuction -> multifunction
successfull -> successful.

Signed-off-by: Stefan Weil <>
e0c8a796 10/05/2010 09:53 pm Stefan Weil

linux-user: Fix typo m86k -> m68k

Replace m86k_sim_stat by m68k_sim_stat.

Cc: Riku Voipio <>
Signed-off-by: Stefan Weil <>
f66724c9 10/05/2010 09:53 pm Stefan Weil

Add new user mode option -ignore-environment

An empty environment is sometimes useful in user mode.
The new option provides it for linux-user and bsd-user
(darwin-user still has no environment related options).

The patch also adds the documentation for other...
dda5336e 10/05/2010 09:53 pm Stefan Weil

docs: Improve documentation

Fix some inconsistencies (tabs and punctuation)
and try to improve grammar and spelling.

Cc: Juan Quintela <>
Signed-off-by: Stefan Weil <>
999fa40e 10/05/2010 07:38 pm John Clark

ppc: Minor 40x MMU fixes

  • Fix swapped reading of tlblo/hi.
  • Fix tlb exec permissions

Signed-off-by: John Clark <>
Signed-off-by: Alexander Graf <>
Signed-off-by: Edgar E. Iglesias <>
358664cc 10/03/2010 09:43 am Stefan Hajnoczi

console: Avoid dereferencing NULL active_console

The console_select() function does not check that active_console is
non-NULL before dereferencing it. When invoked with qemu -nodefaults it
is possible to hit this case.

This patch checks that active_console is non-NULL before stashing away...
7fd3f494 10/03/2010 09:41 am Stefan Weil

exec: Fix compilation error for debug code

is_softmmu was removed with commit
d4c430a80f000d722bb70287af4d4c184a8d7006,
so remove it now from debug code, too.

Fix also the format specifier for paddr
in the same line of code.

Cc: Blue Swirl <>...
b832134d 10/03/2010 09:41 am Stefan Weil

rc4030: Fix compilation error in debug code

min was unknown here, so avoid it.

Cc: Blue Swirl <>
Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>
a4a77677 10/03/2010 09:40 am Stefan Weil

mipsnet: Fix compiler warning in debug code

size_t needs a different format specifier, so fix this.

Cc: Blue Swirl <>
Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>
d523d5d6 10/03/2010 09:40 am Stefan Weil

block/vvfat: Fix compiler warning in debug code

Fix this compiler warning:
./block/vvfat.c:2285: error: comparison of unsigned expression >= 0 is always true

Cc: Blue Swirl <>
Cc: Kevin Wolf <>
Signed-off-by: Stefan Weil <>...
c9ba47dc 10/03/2010 09:39 am Stefan Weil

virtio-9p: Use GCC_FMT_ATTR and fix a format warning

With the new gcc format warnings, gcc detected this:

/qemu/hw/virtio-9p.c:1040: error: format ‘%u’ expects type ‘unsigned int’, but argument 4 has type ‘__nlink_t’

Cc: Blue Swirl <>...
6ea421fe 10/03/2010 09:37 am Stefan Weil

blockdev: Use GCC_FMT_ATTR (format checking)

Additional changes:

  • Removed 'extern' from drive_add (avoids too long line).
  • Removed 'extern' from other functions (makes declarations
    consistent with others in same header file).

Cc: Blue Swirl <>...
8b7968f7 10/03/2010 09:34 am Stefan Weil

Use GCC_FMT_ATTR (format checking)

Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>
e5924d89 10/03/2010 09:34 am Stefan Weil

Replace most gcc format attributes by macro GCC_FMT_ATTR (format checking)

Since version 4.4.x, gcc supports additional format attributes.
attribute ((format (gnu_printf, 1, 2)))
should be used instead of
attribute ((format (printf, 1, 2))...
4a2b39d3 10/03/2010 09:31 am Andreas Färber

slirp: Silence warning on Haiku

Haiku has O_BINARY in fcntl.h.

Signed-off-by: Andreas Färber <>
Cc: Jan Kiszka <>
Signed-off-by: Blue Swirl <>
3ee66dfa 10/03/2010 09:31 am Andreas Färber

tap: Add stub for Haiku

Adapted from AIX code.

Signed-off-by: Andreas Färber <>
Signed-off-by: Blue Swirl <>
5dc2eec9 10/03/2010 09:31 am Andreas Färber

nbd: Haiku has _IO() in its BSD compatibility layer

Signed-off-by: Andreas Färber <>
Signed-off-by: Blue Swirl <>
aff447c9 10/03/2010 09:31 am Andreas Färber

Haiku doesn't have libm

Math functions are integrated into Haiku's libroot.

Signed-off-by: Andreas Färber <>
Signed-off-by: Blue Swirl <>
bd00d539 10/03/2010 09:31 am Andreas Färber

configure: Don't rely on special pthreads library

Haiku has pthreads integrated into its libroot.so library. No linker arguments
are needed for it, so don't fail if -lpthread and similar don't link.

Signed-off-by: Andreas Färber <>...
179cf400 10/03/2010 09:31 am Andreas Färber

configure: Add basic support for Haiku

For compatibility with BeOS, Haiku's error codes are negative whereas recent
POSIX versions require them to be positive. As spotted by François, some
parts of QEMU code rely on this, so use a mapper library to convert them...
a82cdd58 10/02/2010 05:28 pm Blue Swirl

trace: avoid unnecessary recompilation if nothing changed

Add logic to detect changes in generated files. If the old
and new files are identical, don't touch the generated file.
This avoids a lot of churn since many files depend on trace.h.

Based on suggestion by Paolo Bonzini....
904fe1fb 10/02/2010 05:28 pm Blue Swirl

Makefile: fix config-devices.mak generation

The logic of detecting changes in default-configs/*.mak is
flawed as can be demonstrated by 'touch default-configs/*.mak'
followed by make. This results in a message claiming that user
made changes to the */config-devices.mak files....
3f7132d1 10/02/2010 05:27 pm Blue Swirl

sysbus: fix address truncation

Fix address truncation in sysbus by using a wider type.

Reported-by: Artyom Tarasenko <>
Tested-by: Andreas Färber <>
Signed-off-by: Blue Swirl <>
e6aa0f11 10/02/2010 02:12 pm Stefan Weil

target-microblaze: Use %td for ptrdiff_t arguments in debug message

According to ISO/IEC 9899:1999 7.19.6.1,
the correct length modifier for ptrdiff_t is 't', not 'z'.

Cc: Blue Swirl <>
Cc: Markus Armbruster <>
Signed-off-by: Stefan Weil <>...
211ecdc0 10/02/2010 02:12 pm Stefan Weil

target-cris: Use %td for ptrdiff_t arguments in debug message

According to ISO/IEC 9899:1999 7.19.6.1,
the correct length modifier for ptrdiff_t is 't', not 'z'.

Cc: Blue Swirl <>
Cc: Markus Armbruster <>
Signed-off-by: Stefan Weil <>...
3b2e3dc9 10/02/2010 02:04 pm Edgar E. Iglesias

virtex: Add braces

Signed-off-by: Edgar E. Iglesias <>
4903de0c 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Rename monitor_handler_is_async()

Let's follow the convention introduced by the previous commit and
call it handler_is_async().

Signed-off-by: Luiz Capitulino <>
de79ba6f 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Directly call QObject handlers

This avoids handle_user_command() calling monitor_call_handler(),
which is currently shared with QMP.

Signed-off-by: Luiz Capitulino <>
fc29df75 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce qmp_call_cmd()

Calls a QObject handler and emits the QMP response, also drops
monitor_call_handler() which is now unused.

Signed-off-by: Luiz Capitulino <>
acd0a093 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Rename the qemu-monitor.hx file

Let's be consistent and call it hmp-commands.hx, so that we have
qmp-commands.hx for QMP and hmp-commands.hx for HMP.

Please, note that this commit doesn't touch qemu-monitor.texi. All
texi files have the qemu- prefix and I don't think it's worth...
a18b2ce2 10/01/2010 04:20 pm Luiz Capitulino

QMP/README: Update QMP homepage address

Signed-off-by: Luiz Capitulino <>
07b0403d 10/01/2010 04:20 pm Eduardo Habkost

disable guest-provided stats on "info balloon" command

The addition of memory stats reporting to the virtio balloon causes
the 'info balloon' command to become asynchronous. This is a regression
because in some cases it can hang the user monitor.

This is an alternative to Adam Litke's patch. Adam's patch disabled the...
945c5ac8 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Introduce search_dispatch_table()

It's a generic version of monitor_find_command() which searches
the dispatch table passed as an argument.

Future commits will introduce new dispatch tables, so we need
common code to search them.

Signed-off-by: Luiz Capitulino <>
0fb88582 10/01/2010 04:20 pm Luiz Capitulino

QMP: handle_qmp_command(): Move 'cmd' sanity check

Next commit will change how query commands are handled in a
way that the 'cmd' sanity check is also going to be needed
for query commands handling.

Let's move it out of the else body then.

Signed-off-by: Luiz Capitulino <>
030db6e8 10/01/2010 04:20 pm Luiz Capitulino

QMP: Don't use do_info()

Since its inception, QMP has been using HMP's do_info() function
to run query commands.

This was a bad choice, as it made do_info() more complex and
contributed to couple QMP and HMP.

This commit fixes that by doing the following changes:...
1dcbd6f6 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop QMP bits from do_info()

As of last commit, QMP doesn't use do_info() anymore. Simplify it.

Signed-off-by: Luiz Capitulino <>
d4551293 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop is_async_return()

If I understood it correcty, the is_async_return() logic was only
used to prevent QMP from issuing duplicated success responses
for asynchronous handlers.

However, QMP doesn't use do_info() anymore so this is dead logic
and (hopefully) can be safely dropped....
1162daa6 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Convert do_info() back to HMP

This is a HMP specific handler, it makes no sense to have it
under QMP.

Signed-off-by: Luiz Capitulino <>
82a56f0d 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Introduce the qmp-commands.hx file

This file contains a copy of the following information from the
qemu-monitor.hx file:

o QObject handlers entries
    o QMP documentation (all SQMP/EQMP sections)

Right now it's only used to generate the QMP docs in QMP/, but...
bead3ce1 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce qmp_find_cmd()

Next commit needs this new function: it will introduce the
the QMP's command dispatch table and qmp_find_cmd() will be
used to search on it.

Signed-off-by: Luiz Capitulino <>
f36b4afb 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce command dispatch table

Also update QMP functions to use it. The table is generated
from the qmp-commands.hx file.

From now on, QMP and HMP have different command dispatch
tables.

Signed-off-by: Luiz Capitulino <>
3e12a751 10/01/2010 04:20 pm Luiz Capitulino

QMP: Introduce query commands dispatch table

The new table is a copy of HMP's table, containing only QObject
handlers.

In the near future HMP will be making QMP calls and then we will
be able to drop QObject handlers from HMP's table.

From now on, QMP and HMP have different query command dispatch...
2e061a7c 10/01/2010 04:20 pm Luiz Capitulino

QMP: Simplify do_info_commands()

We now iterate over QMP's dispatch tables, no need to check for
QMP-only handlers anymore.

Signed-off-by: Luiz Capitulino <>
d1249eaa 10/01/2010 04:20 pm Luiz Capitulino

QMP: Small cleanup in handle_qmp_command()

QMP has its own dispatch tables, we can now drop the following
checks:

o 'info' command: this command doesn't exist in QMP's
       dispatch table, the right thing will happen when it's
       issued by a client (ie. command not found error)...
30f5041e 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop QMP info from the qemu-monitor.hx file

QMP has its own dispatch table and documentation file
(qmp-commands.hx), we can now drop the following QMP specific info
from qemu-monitor.hx:

o SQMP/EQMP sections
    o The qmp_capabilities command...
0e19a627 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Drop monitor_cmd_user_only()

This function was only needed when QMP and HMP were sharing dispatch
tables, this is no longer true so just drop it.

Signed-off-by: Luiz Capitulino <>
9e80721e 10/01/2010 04:20 pm Luiz Capitulino

Monitor: Rename monitor_handler_ported()

That name makes no sense anymore, as dispatch tables have been split,
a better name is handler_is_qobject(), which really communicates
the handler's type.

Signed-off-by: Luiz Capitulino <>
212b6008 10/01/2010 04:12 pm Daniel P. Berrange

Add support for JSON pretty printing

The monitor does not pretty-print JSON output, so that everything
will be on a single line reply. When JSON docs get large this is
quite unpleasant to read. For the future command line capabilities
query ability, huge JSON docs will be available. This needs the...
39eaab9a 10/01/2010 04:12 pm Daniel P. Berrange

Add option to turn on JSON pretty printing in monitor

Expaned '-mon' arg to allow a 'pretty=on' flag. This makes the
monitor pretty print its replies to easy human debugging / reading

Signed-off-by: Daniel P. Berrange <>
Signed-off-by: Luiz Capitulino <>
2c50e26e 09/30/2010 07:53 pm Edgar E. Iglesias

powerpc: Add a virtex5 ml507 refdesign board

Signed-off-by: Edgar E. Iglesias <>
Signed-off-by: Alexander Graf <>
95070372 09/30/2010 07:53 pm Edgar E. Iglesias

powerpc: Add a ppc-440x5 Xilinx model

Add a powerpc 440x5 with the model ID on the Xilinx virtex5.
Connect the 440x5 to the 40x interrupt logic.

Signed-off-by: Edgar E. Iglesias <>
Signed-off-by: Alexander Graf <>
5251d6ad 09/29/2010 07:15 pm Andreas Färber

tap: Remove double include of util.h

If neither of FreeBSD, FreeBSD_kernel and DragonFly is defined,
util.h is included from tap-bsd.c.
Don't include it again if OpenBSD is defined.

Cc: Blue Swirl <>
Signed-off-by: Andreas Färber <>...
fd5723b3 09/29/2010 07:24 am Wu Fengguang

pulse-audio: fix bug on updating rpos

Fix a rpos coordination bug between qpa_run_out() and qpa_thread_out(),
which shows up as playback noises.

qpa_run_out()
            qpa_thread_out loop N critical section 1
    qpa_run_out()   qpa_thread_out loop N doing pa_simple_write()...
575c153f 09/28/2010 07:56 am malc

audio: Fix memory size for resampling buffer in DAC case

Signed-off-by: malc <>