Statistics
| Branch: | Revision:

root / migration-rdma.c @ feature-archipelago

History | View | Annotate | Download (104.9 kB)

# Date Author Comment
41310c68 02/25/2014 03:30 pm Michael R. Hines

rdma: rename 'x-rdma' => 'rdma'

As far as we can tell, all known bugs have been fixed:

1. Parallel migrations are working
2. IPv6 migration is working
3. virt-test is working

I'm not comfortable sending the revised libvirt patch
until this is accepted or review suggestions are addressed,...

5a91337c 09/24/2013 02:22 pm Isaku Yamahata

rdma: clean up of qemu_rdma_cleanup()

- It can't be determined by RDMAContext::cm_id != NULL if the connection
is established or not.
- RDMAContext::cm_id is leaked and not destroyed because it is set to NULL
too early.
- RDMAContext::qp is created by rdma_create_qp() so that it should be destroyed...

dd286ed7 09/24/2013 02:22 pm Isaku Yamahata

rdma: constify ram_chunk_{index, start, end}

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Juan Quintela <>

c89aa2f1 09/01/2013 06:03 pm Michael R. Hines

rdma: silly ipv6 bugfix

My bad - but it's very important for us to warn the user that
IPv6 is broken on RoCE in linux right now, until linux releases
a fixed version.

Signed-off-by: Michael R. Hines <>
Signed-off-by: Michael Tokarev <>

4c293dc6 09/01/2013 05:59 pm Stefan Weil

misc: Fix some typos in names and comments

Most typos were found using a modified version of codespell:

accross -> across
issueing -> issuing
TICNT_THRESHHOLD -> TICNT_THRESHOLD
bandwith -> bandwidth
VCARD_7816_PROPIETARY -> VCARD_7816_PROPRIETARY
occured -> occurred...

6470215b 08/12/2013 05:31 pm Michael R. Hines

rdma: proper getaddrinfo() handling

getaddrinfo() already knows what it's doing,
but it can potentially return multiple addresses.
We need to handle that...

Reviewed-by: Orit Wasserman <>
Signed-off-by: Michael R. Hines <>...

7fc5b13f 08/12/2013 05:31 pm Michael R. Hines

rdma: IPv6 over Ethernet (RoCE) is broken in linux - workaround

We've gotten reports from multiple testers (including Frank Yangjie
and myself) that RDMA IPv6 support over RocE (Ethernet) is broken
in linux.

A patch to Linux is still in review:

http://comments.gmane.org/gmane.linux.drivers.rdma/16448...

885e8f98 08/12/2013 05:31 pm Isaku Yamahata

rdma: use resp.len after validation in qemu_rdma_registration_stop

resp.len is given from remote host. So should be validated before use.
Otherwise memcpy can access beyond the buffer.

Cc: Michael R. Hines <>
Reviewed-by: Orit Wasserman <>...

6f1484ed 08/12/2013 05:31 pm Isaku Yamahata

rdma: validate RDMAControlHeader::len

RMDAControlHeader::len is provided from remote, so validate it.

Reviewed-by: Orit Wasserman <>
Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>...

88571882 08/12/2013 05:31 pm Isaku Yamahata

rdma: check if RDMAControlHeader::len match transferred byte

RDMAControlHeader::len is provided from remote, so check if the value
match the actual transferred byte_len.

Reviewed-by: Orit Wasserman <>
Reviewed-by: Michael R. Hines <>...

66988941 08/05/2013 07:47 pm Michael R. Hines

rdma: correct newlines in error statements

Don't print newlines on the error_setg() function,
but still allow newlines on fprintf().

Signed-off-by: Michael R. Hines <>
Message-id: ...

44b59494 08/05/2013 07:47 pm Isaku Yamahata

rdma: don't use negative index to array

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>
Message-id: ...

1f22364b 08/05/2013 07:47 pm Isaku Yamahata

rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX

RDMA_WRID_CONTROL should be used. And remove related work around.

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>...

87772639 08/05/2013 07:47 pm Isaku Yamahata

rdma: use RDMA_WRID_READY

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>
Message-id: ...

e1d0fb37 08/05/2013 07:47 pm Isaku Yamahata

rdma: memory leak RDMAContext::host

It is allocated by g_strdup(), so needs to be freed.

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>...

b58c8552 08/05/2013 07:47 pm Michael R. Hines

rdma: bugfix: make IPv6 support work

RDMA does not use sockets, so we cannot use many of the socket
helper functions, but we do use inet_parse() which gives
RDMA all the necessary details of the connection parameters.

However, when testing with libvirt, a simple IPv6 migration test failed...

8cd31adc 08/05/2013 07:47 pm Michael R. Hines

rdma: forgot to turn off the debugging flag

Ooops. We forgot to turn off the flag.

Signed-off-by: Michael R. Hines <>
Message-id:
Signed-off-by: Anthony Liguori <>

52f35022 07/27/2013 10:22 am Stefan Weil

misc: Fix new typos in comments and strings

All these typos were found by codespell.

sould -> should
emperical -> empirical
intialization -> initialization
successfuly -> successfully
gaurantee -> guarantee

Fix also another error (before before) in the same context....

2da776db 07/23/2013 12:12 pm Michael R. Hines

rdma: core logic

Code that does need to be visible is kept
well contained inside this file and this is the only
new additional file to the entire patch.

This file includes the entire protocol and interfaces
required to perform RDMA migration.

Also, the configure and Makefile modifications to link...