Statistics
| Branch: | Revision:

root @ ff753bb9

# Date Author Comment
dc786bc9 10/30/2010 11:02 am Jes Sorensen

Move qemu_gettimeofday() to OS specific files

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>
ff753bb9 10/30/2010 11:02 am Jes Sorensen

Do not redefine reserved key-words TRUE/FALSE

TRUE/FALSE are generally reserved keywords and shouldn't be defined in
a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE
respectively.

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>
70e72ce4 10/30/2010 11:02 am Jes Sorensen

qemu_pipe() is used only by POSIX code, so move to oslib-posix.c

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>
949d31e6 10/30/2010 11:02 am Jes Sorensen

We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>
c1b0b93b 10/30/2010 11:02 am Jes Sorensen

Move QEMU OS dependant library functions to OS specific files

This moves library functions used by both QEMU and the QEMU tools,
such as qemu-img, qemu-nbd etc. from osdep.c to oslib-{posix,win32}.c

In addition it introduces oslib-obj.y to the Makefile set to be...
9549e764 10/30/2010 11:02 am Jes Sorensen

Move osdep socket code to oslib-{posix,win32}.c

Signed-off-by: Jes Sorensen <>
Signed-off-by: Blue Swirl <>
055403b2 10/30/2010 11:01 am Stefan Weil

exec: Use fprintf_function for dump_exec_info (format checking)

fprintf_function uses format checking with GCC_FMT_ATTR.

It is declared in qemu-common.h and used in cpu-all.h
(which is included from cpu.h), so qemu-common.h must
be included earlier. Some redundant include statements...
9a78eead 10/30/2010 11:01 am Stefan Weil

target-xxx: Use fprintf_function (format checking)

fprintf_function uses format checking with GCC_FMT_ATTR.

Format errors were fixed in
  • target-i386/helper.c
  • target-mips/translate.c
  • target-ppc/translate.c

Cc: Blue Swirl <>
Signed-off-by: Stefan Weil <>...
405cf9ff 10/30/2010 11:01 am Stefan Weil

tcg: Use fprintf_function (format checking)

fprintf_function uses format checking with GCC_FMT_ATTR.

Cc: Blue Swirl <>
Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>
f868445a 10/30/2010 11:01 am Stefan Weil

Add fprintf_function for function pointers to fprintf-like functions

This kind of function pointers is used very often in qemu.

The new data type uses format checking with GCC_FMT_ATTR
and will be used in later patches.

Cc: Blue Swirl <>...
338b922e 10/30/2010 12:41 am malc

Mov muldiv64 to qemu-common.h (Thus unbreaking gus)

Signed-off-by: malc <>
174b2877 10/26/2010 05:51 pm Anthony Liguori

Merge remote branch 'qmp/for-anthony' into staging
21bcc590 10/26/2010 05:50 pm Anthony Liguori

Merge remote branch 'kwolf/for-anthony' into staging
758c309f 10/26/2010 12:43 am Anthony Liguori

seabios: Update to 0.6.1

- 0ff9051 Update version to 0.6.1
 - 9c000e6 Support Samsung SE-S084 USB DVD drive (and probably many others)
 - eebe949 pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().
 - 06644f4 Minor - indentation change to jpeg.c....
c57c846a 10/23/2010 06:24 pm Blue Swirl

qemu-timer: move commonly used timer code to qemu-timer-common

Move timer init functions to a new file, qemu-timer-common.c. Make other
critical timer functions inlined to preserve performance in
qemu-timer.c, also move muldiv64() (used by the inline functions)...
2b2e59e6 10/23/2010 05:47 pm Paolo Bonzini

rewrite i386 tests Makefile

1) compute path to i386 compiler from configure. If it is found, run
the i386 tests. I use macros so that this approach could be applied
for other arches as well.

2) provide an easily extensible way to add tests

Most tests fail, but at least "make test" does something meaningful....
48118b02 10/23/2010 05:47 pm Paolo Bonzini

fix test_path

path.c grew quite a few new dependencies (mostly via cutils.c),
include them.

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Blue Swirl <>
e311248b 10/23/2010 05:47 pm Paolo Bonzini

make runcom compile on recent distributions

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Blue Swirl <>
f34f1fed 10/23/2010 05:46 pm Paolo Bonzini

disable test_enter on i386, it is broken

Many other tests fail, but this has an infinite loop with both
qemu-i386 and native execution (albeit on x86_64), so there is
something more going on. I'm not going to debug it now, so just
disable the test.

Signed-off-by: Paolo Bonzini <>...
9517a9e6 10/23/2010 05:46 pm Paolo Bonzini

unbreak "make" from vpath-built tests directory

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Blue Swirl <>
e6c3b0f7 10/23/2010 05:46 pm Paolo Bonzini

unbreak "make" from tests directory

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Blue Swirl <>
5340c8a0 10/22/2010 09:26 pm Blue Swirl

mips_fulong2e: fix ram allocation

RAM registration used incorrect offset.

Fix by using the offset obtained previously for this purpose.

Spotted by GCC 4.6.0 20100925 warning, which is also avoided.

Signed-off-by: Blue Swirl <>
2c80e423 10/22/2010 08:11 pm Stefan Weil

Replace remaining gcc format attributes by macro GCC_FMT_ATTR (format checking)

Replace the remaining format attribute printf by macro
GCC_FMT_ATTR which uses gnu_printf (if supported).

v2
  • Removal of dyngen specific code is now done in a separate patch....
47b01cf3 10/22/2010 08:11 pm Stefan Weil

Remove special handling of system include files (no longer needed)

The formerly used dyngen code did not work with
system include files like stdio.h.

Tests with Linux, OSX and Win32 show that this
restriction is no longer needed.

So we hopefully can remove that special piece of code....
dbb14135 10/22/2010 04:02 pm Anthony Liguori

Merge remote branch 'qemu-kvm/uq/master' into staging
72893756 10/22/2010 03:49 pm Stefan Hajnoczi

qcow2: Support exact L1 table growth

The L1 table grow operation includes a size calculation that bumps up
the new L1 table size in order to anticipate the size needs of vmstate
data. This helps reduce the number of times that the L1 table has to be
grown when vmstate data is appended....
a9420734 10/22/2010 03:49 pm Kevin Wolf

qcow2: Simplify image creation

Instead of doing lots of magic for setting up initial refcount blocks and stuff
create a minimal (inconsistent) image, open it and initialize the rest with
regular qcow2 functions.

This is a complete rewrite of the image creation function. The old...
9b036055 10/22/2010 03:49 pm Kevin Wolf

qcow2: Remove old image creation function

They have been #ifdef'd out by the previous patch.

Signed-off-by: Kevin Wolf <>
a58b8d54 10/22/2010 03:49 pm Christoph Hellwig

ide: set WCACHE supported in IDENTIFY data

ATA does not only have the WCACHE enabled bit in identify word 85, but also
a WCACHE supported bit in word 82. While the Linux kernel is fine with the
latter at least hdparm also needs the former before correctly displaying...
51ef6727 10/22/2010 03:49 pm edison

Copy snapshots out of QCOW2 disk

In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage.
The following patch adds a new option in "qemu-img": qemu-img convert -f qcow2 -O qcow2 -s snapshot_name src_img bck_img....
191c2890 10/22/2010 03:49 pm Kevin Wolf

qemu-io: New command map

The new map command in qemu-io lists all allocated/unallocated areas in an
image file.

Signed-off-by: Kevin Wolf <>
a77cffe7 10/22/2010 03:49 pm Stefan Weil

block: Use GCC_FMT_ATTR and fix a format error

Adding the gcc format attribute detects a format bug
which is fixed here.

v2:
Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long,
so %lld should be the correct format specifier.

Cc: Blue Swirl <>...
a18953fb 10/22/2010 03:49 pm Kevin Wolf

qemu-img: Fix qemu-img convert -obacking_file

The old -B option caused a backing file to be used for the converted image and
to avoid copying clusters from the old backing file. When replaced with
-obacking_file, qemu-img convert does assign the backing file to the new image,...
6bcb1a79 10/22/2010 03:49 pm Kevin Wolf

ide: Factor ide_flush_cache out

The next patch reuses this code, so put it in its own function.

Signed-off-by: Kevin Wolf <>
e2bcadad 10/22/2010 03:49 pm Kevin Wolf

ide: Handle flush failure

Instead of always assuming success for bdrv_aio_flush, actually do something
with the error. This respects the werror option and accordingly ignores the
error, reports it to the guest or stops the VM and retries after cont.

Ignoring the error is trivial, obviously. For stopping the VM and retrying...
8c269b54 10/22/2010 03:49 pm Kevin Wolf

virtio-blk: Respect werror option for flushes

The werror option now affects not only write requests, but also flush requests.
Previously, it was not possible to stop a VM on a failed flush.

Signed-off-by: Kevin Wolf <>
46c7fc18 10/22/2010 03:08 pm Kusanagi Kouichi

monitor: Ignore "." and ".." when completing file name.

Signed-off-by: Kusanagi Kouichi <>
Signed-off-by: Luiz Capitulino <>
7af72c24 10/22/2010 03:08 pm Hidetoshi Seto

Trivial fix for QMP/qmp-events.txt

Fix example of STOP event that was just copy-and-pasted.

Signed-off-by: Hidetoshi Seto <>
Signed-off-by: Luiz Capitulino <>
e7a06af8 10/22/2010 03:08 pm Jan Kiszka

Silence compiler warning in json test case

This avoids

error: zero-length gnu_printf format string

Signed-off-by: Jan Kiszka <>
Signed-off-by: Luiz Capitulino <>
945d3e63 10/22/2010 03:08 pm Jan Kiszka

Fix test suite build with tracing enabled

qemu_malloc instrumentations require linking against the trace objects.

Signed-off-by: Jan Kiszka <>
Acked-by: Stefan Hajnoczi <>
Signed-off-by: Luiz Capitulino <>
d03703c8 10/21/2010 07:31 pm Samuel Thibault

curses: Fix control-{@[\]^_} and ESC

control-{@[\]^_} shouldn't get the 'a' - 'A' offset for correct
translation. ESC is better simulated as escape key.

Signed-off-by: Samuel Thibault <>
Signed-off-by: Andrew Zaborowski <>
25d2e361 10/21/2010 06:37 pm Marcelo Tosatti

kvm: save/restore x86-64 MSRs on x86-64 kernels

Signed-off-by: Marcelo Tosatti <>
384331a6 10/21/2010 06:37 pm Marcelo Tosatti

kvm: writeback SMP TSCs on migration only

commit 6389c45441269baa2873e6feafebd17105ddeaf6
Author: Jan Kiszka <>
Date: Mon Mar 1 18:17:26 2010 +0100

qemu-kvm: Cleanup/fix TSC and PV clock writeback

Signed-off-by: Marcelo Tosatti <>
75b10c43 10/21/2010 06:37 pm Marcelo Tosatti

kvm: factor out kvm_has_msr_star

And add kvm_has_msr_hsave_pa(), to avoid warnings on older
kernels without support.

Signed-off-by: Marcelo Tosatti <>
aa851e36 10/21/2010 06:37 pm Marcelo Tosatti

kvm: add save/restore of MSR_VM_HSAVE_PA

commit 2bba4446746add456ceeb0e8359a43032a2ea333
Author: Alexander Graf <>
Date: Thu Dec 18 15:38:32 2008 +0100

Enable nested SVM support in userspace

Signed-off-by: Marcelo Tosatti <>
d8da8574 10/21/2010 06:12 pm Hidetoshi Seto

Fix build on !KVM_CAP_MCE

This patch removes following warnings:

target-i386/kvm.c: In function 'kvm_put_msrs':
target-i386/kvm.c:782: error: unused variable 'i'
target-i386/kvm.c: In function 'kvm_get_msrs':
target-i386/kvm.c:1083: error: label at end of compound statement...
f71ac88f 10/21/2010 06:11 pm Hidetoshi Seto

x86, mce: broadcast mce depending on the cpu version

There is no reason why SRAO event received by the main thread
is the only one that being broadcasted.

According to the x86 ASDM vol.3A 15.10.4.1,
MCE signal is broadcast on processor version 06H_EH or later....
f8502cfb 10/21/2010 06:09 pm Hidetoshi Seto

x86, mce: ignore SRAO only when MCG_SER_P is available

And restruct this block to call kvm_mce_in_exception() only when it is
required.

Signed-off-by: Hidetoshi Seto <>
Signed-off-by: Marcelo Tosatti <>
4441a287 10/21/2010 01:23 am Gleb Natapov

Use defines instead of numbers for pci hotplug sts bit

Signed-off-by: Gleb Natapov <>
Signed-off-by: Anthony Liguori <>
633aa0ac 10/21/2010 01:23 am Gleb Natapov

Fix pci hotplug to generate level triggered interrupt.

SCI is level triggered. pci hotplug should behave appropriately.

Signed-off-by: Gleb Natapov <>
Signed-off-by: Anthony Liguori <>
db0ad1ba 10/21/2010 12:15 am Joerg Roedel

Set cpuid definition to 0 before initializing it

This patch cleans the (stack-allocated) cpuid definition to
0 before actually initializing it.

Signed-off-by: Joerg Roedel <>
Signed-off-by: Avi Kivity <>
296acb64 10/21/2010 12:15 am Joerg Roedel

Add svm cpuid features

This patch adds the svm cpuid feature flags to the qemu
intialization path. It also adds the svm features available
on phenom to its cpu-definition and extends the host cpu
type to support all svm features KVM can provide.

Signed-off-by: Joerg Roedel <>...
dcc38d1c 10/21/2010 12:15 am Marcelo Tosatti

signalfd compatibility

Port qemu-kvm's signalfd compat code.

commit 5a7fdd0abd7cd24dac205317a4195446ab8748b5
Author: Anthony Liguori <>
Date: Wed May 7 11:55:47 2008 -0500

Use signalfd() in io-thread
This patch reworks the IO thread to use signalfd() instead of sigtimedwait()...
a8486bc9 10/21/2010 12:15 am Marcelo Tosatti

iothread: use signalfd

Block SIGALRM, SIGIO and consume them via signalfd.

Signed-off-by: Marcelo Tosatti <>
Signed-off-by: Avi Kivity <>
e7701825 10/21/2010 12:15 am Marcelo Tosatti

kvm: x86: add mce support

Port qemu-kvm's MCE support

commit c68b2374c9048812f488e00ffb95db66c0bc07a7
Author: Huang Ying <>
Date: Mon Jul 20 10:00:53 2009 +0800

Add MCE simulation support to qemu/kvm
KVM ioctls are used to initialize MCE simulation and inject MCE. The...
e890261f 10/21/2010 12:15 am Marcelo Tosatti

Export qemu_ram_addr_from_host

To be used by next patches.

Signed-off-by: Marcelo Tosatti <>
Signed-off-by: Avi Kivity <>
983dfc3b 10/21/2010 12:15 am Huang Ying

Add RAM -> physical addr mapping in MCE simulation

In QEMU-KVM, physical address != RAM address. While MCE simulation
needs physical address instead of RAM address. So
kvm_physical_memory_addr_from_ram() is implemented to do the
conversion, and it is invoked before being filled in the IA32_MCi_ADDR...
c0532a76 10/21/2010 12:15 am Marcelo Tosatti

MCE: Relay UCR MCE to guest

Port qemu-kvm's

commit 4b62fff1101a7ad77553147717a8bd3bf79df7ef
Author: Huang Ying <>
Date: Mon Sep 21 10:43:25 2009 +0800

MCE: Relay UCR MCE to guest
UCR (uncorrected recovery) MCE is supported in recent Intel CPUs,...
57780495 10/21/2010 12:15 am Marcelo Tosatti

Add savevm/loadvm support for MCE

Port qemu-kvm's

commit 1bab5d11545d8de5facf46c28630085a2f9651ae
Author: Huang Ying <>
Date: Wed Mar 3 16:52:46 2010 +0800

Add savevm/loadvm support for MCE
MCE registers are saved/load into/from CPUState in...
0f53994f 10/21/2010 12:15 am Marcelo Tosatti

Fix memory leak in register save load due to xsave support

From: Avi Kivity <>
Signed-off-by: Marcelo Tosatti <>
1e027be7 10/20/2010 11:52 pm Markus Armbruster

configure: Support disabling warnings in $gcc_flags

-Wall enables a bunch of warnings at once. configure puts it after
$gcc_flags. This makes it impossible to disable warnings enabled by
-Wall there. Fix by putting configured flags last.

Signed-off-by: Markus Armbruster <>...
c3b08d0e 10/20/2010 11:52 pm Stefan Weil

tcg: Fix compiler error (comparison of unsigned expression)

When qemu is configured with --enable-debug-tcg,
gcc throws this warning (or error with -Werror):

tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true

Fix it by removing the >= 0 part....
56d15a53 10/20/2010 08:10 pm Sanchit Garg

[virtio-9p] Use preadv/pwritev instead of readv/writev

readv & writev, read & write respectively from the current offset
of the file & hence their use has to be preceeded by a call to lseek.
preadv/writev can be used instead, as they take the offset as an argument....
45b23ff8 10/20/2010 08:10 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Add support to v9fs_string_alloc_printf() for handling %lu.

Signed-off-by: Venkateswararao Jujjuri <>
cd496926 10/20/2010 08:10 pm Gerd Hoffmann

vmmouse: adapt to mouse handler changes.

This patch updates the vmmouse handler registration and activation.

Old behavior:
vmmouse_read_id, vmmouse_request_relative and vmmouse_request_absolute
unregister the handler and re-register it.

New behavior:...
b2d4d832 10/20/2010 08:10 pm Gerd Hoffmann

wacom tablet: activate event handlers.

Add qemu_activate_mouse_event_handler() calls to the usb wavom tablet so
it actually receives events. Also make sure we only remove the handler
if we registered it before.

Signed-off-by: Gerd Hoffmann <>...
ab03b63d 10/20/2010 08:10 pm Sripathi Kodi

[virtio-9p] open should not return EBADF

When 9P server fails to create a file due to permission problems it should
return EPERM. However the current 9P2000.L code returns EBADF. EBADF is NOT
a valid return value from open() call.

The problem is because we do not preserve the errno variable properly. If the...
82cc3ee8 10/20/2010 08:10 pm M. Mohan Kumar

[virto-9p] Implement TLOCK

Synopsis

size[4] TLock tag[2] fid[4] flock[n]
    size[4] RLock tag[2] status[1]

Description

Tlock is used to acquire/release byte range posix locks on a file
identified by given fid. The reply contains status of the lock request...
8f354003 10/20/2010 08:10 pm M. Mohan Kumar

qemu-virtio9p: Implement TGETLOCK

Synopsis

size[4] TGetlock tag[2] fid[4] getlock[n]
    size[4] RGetlock tag[2] getlock[n]

Description

TGetlock is used to test for the existence of byte range posix locks on
a file identified by given fid. The reply contains getlock structure. If...
b41e95d3 10/20/2010 08:10 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Introduce server side TFSYNC/RFSYNC for dotl

SYNOPSIS
size4 Tfsync tag2 fid4

size[4] Rfsync tag[2]

DESCRIPTION

The Tfsync transaction transfers ("flushes") all modified in-core data of
file identified by fid to the disk device (or other permanent storage...
df0973a4 10/20/2010 08:10 pm M. Mohan Kumar

qemu-virtio-9p: Implement TREADLINK operation for 9p2000.L

Synopsis

size[4] TReadlink tag[2] fid[4]
        size[4] RReadlink tag[2] target[s]

Description
Readlink is used to return the contents of the symoblic link
referred by fid. Contents of symboic link is returned as a...
0f8151cb 10/20/2010 08:10 pm Venkateswararao Jujjuri (JV)

[virtio-9p] Ignore O_DIRECT hint from client.

The O_DIRECT flag imposes alignment restrictions on the length and address
of userspace buffers and the file offset of I/Os.

While VirtFS/9P has plans to implement O_DIRECT behavior on the server,
for now we will stick to a behavior like NFS by bypassing the page cache...
fc22118d 10/20/2010 08:10 pm Aneesh Kumar K.V

virtio-9p: Use layered xattr approach

We would need this to make sure we handle the mapped
security model correctly for different xattr names.

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>
70fc55eb 10/20/2010 08:10 pm Aneesh Kumar K.V

virtio-9p: Support mapped posix acl

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>
9f506893 10/20/2010 08:10 pm Harsh Prateek Bora

[virtio-9p] Qemu 9p commandline options validity checks

Signed-off-by: Harsh Prateek Bora <>
Signed-off-by: Venkateswararao Jujjuri <>
a12c668f 10/20/2010 07:41 pm Blue Swirl

trace: improve info trace output

Use PRI*64 to print full 64 bit data even on ILP32 hosts.

Print also sixth tracepoint parameter.

Acked-by: Stefan Hajnoczi <>
Cc: Stefan Hajnoczi <>
Signed-off-by: Blue Swirl <>
cf85cf8e 10/20/2010 07:41 pm Stefan Hajnoczi

trace: Format strings must begin/end with double quotes

Document the restriction that format strings must begin and end with
double quotes. This is for easy parsing since we don't run cpp over
trace-events.

Signed-off-by: Stefan Hajnoczi <>...
d8023f31 10/20/2010 07:41 pm Blue Swirl

apic: convert debug printf statements to tracepoints

Replace debug printf statements with tracepoints.

Signed-off-by: Stefan Hajnoczi <>
Signed-off-by: Blue Swirl <>
6df40080 10/20/2010 07:27 pm Stefan Hajnoczi

trace: Relax trace-events parsing regex in simpletrace.py

The regular expression to parse trace event definitions assumed the
format string would be a simple double-quoted string. However, we now
use PRI?64 for portability which splits string literals. The regular...
38cc9b60 10/17/2010 11:39 pm Jindrich Makovicka

issue snd_pcm_start() when capturing audio

snd_pcm_start() starts the capture process and ensures that the events
are delivered to the poll handler. Without the call, capture can be started
only when there is simultaneous playback running.

Signed-off-by: Jindrich Makovicka <>...
22d948a2 10/17/2010 11:39 pm Jindrich Makovicka

fix 100% CPU load when idle with ALSA

Playback control function did not disable polling when playback stops.
Caused busy spinning of the main loop due to unprocessed events.

Signed-off-by: Jindrich Makovicka <>
Signed-off-by: malc <>
f871d689 10/13/2010 10:14 pm Blue Swirl

trace: print a warning if user tries to enable an unknown trace event

There was no warning if a bad trace event name was given to
'trace-event' command, thus the user could think that the command
was successful even if this was not the case.

Print a warning if the user tries to enable a trace event which is not...
2abf314d 10/13/2010 09:43 pm Blue Swirl

mips: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
/src/qemu/target-mips/translate.c: In function 'gen_ld':
/src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set but not used [-Werror=unused-but-set-variable]...
577f25a5 10/13/2010 09:43 pm Blue Swirl

ppc: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
/src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but not used [-Werror=unused-but-set-variable]...
4581cbcd 10/13/2010 09:43 pm Blue Swirl

i386: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-i386/op_helper.c: In function 'switch_tss':
/src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' set but not used [-Werror=unused-but-set-variable]...
2ded6ad7 10/13/2010 09:43 pm Blue Swirl

vnc: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/ui/vnc.c: In function 'vnc_client_cache_auth':
/src/qemu/ui/vnc.c:217:12: error: variable 'qdict' set but not used [-Werror=unused-but-set-variable]
/src/qemu/ui/vnc.c: In function 'vnc_display_open':...
03e654c0 10/13/2010 09:42 pm Blue Swirl

cris: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced a warning:
In file included from /src/qemu/target-cris/translate.c:3154:0:
/src/qemu/target-cris/translate_v10.c: In function 'dec10_prep_move_m':
/src/qemu/target-cris/translate_v10.c:111:22: error: variable 'rd' set but not used [-Werror=unused-but-set-variable]...
49a2942d 10/13/2010 09:41 pm Blue Swirl

Delete write only variables

Compiling with GCC 4.6.0 20100925 produced warnings like:
/src/qemu/net/tap-win32.c: In function 'tap_win32_open':
/src/qemu/net/tap-win32.c:582:12: error: variable 'hThread' set but not used [-Werror=unused-but-set-variable]
...
83e3f76c 10/13/2010 09:38 pm Blue Swirl

block: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/block/qcow2-refcount.c: In function 'update_refcount':
/src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable]...
8c78881f 10/13/2010 09:38 pm Blue Swirl

cirrus: avoid write only variables

Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
In file included from /src/qemu/hw/cirrus_vga_rop.h:174:0,
from /src/qemu/hw/cirrus_vga.c:284:
/src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_patternfill_0_8':...
ef476062 10/13/2010 09:38 pm Blue Swirl

eepro100: initialize a variable in all cases

Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/hw/eepro100.c: In function 'eepro100_read4':
/src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]...
f3f5b867 10/13/2010 09:38 pm Blue Swirl

lsi53c895a: avoid a write only variable

Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable]...
ae0bfb79 10/13/2010 09:38 pm Blue Swirl

ppc: remove video.x

Only Mac-on-Linux stuff used video.x, OpenBIOS does not need it.

Remove video.x MoL hacks.

Signed-off-by: Alexander Graf <>
Signed-off-by: Blue Swirl <>
a2d3f695 10/11/2010 11:37 pm Anthony Liguori

Merge remote branch 'mst/for_anthony' into staging
d7489b72 10/09/2010 11:24 am Blue Swirl

trace: remove timestamp files when cleaning up

'make clean' did not remove trace.[ch]-timestamp files,
only trace.[ch]. But 'make' did not know how to make trace.[ch]
files if the timestamp files were present.

Fix by removing the timestamp files along with trace.[ch]....
ba807829 10/09/2010 11:23 am Stefan Weil

configure: Send error message from spice check to /dev/null

pkg-config is not always available (e.g. on win32 hosts),
but we don't want to see the 'command not found' error message.

Redirect stdout and stderr to /dev/null.

v2:

  • Removed changes which should not have been here....
6650b710 10/09/2010 11:20 am Stefan Weil

win32: Set unbuffered stdout

Win32 does not support line-buffering, but it allows
unbuffered output.

Unbuffered output is a good approximation. For typical output
statements which usually end with '\n', it's even identical.

Buffered output is unusable for program traces because of...
ea95f156 10/09/2010 11:19 am Stefan Hajnoczi

.gitignore: Ignore *-timestamp

Timestamp files were recently added to reduce make churn on source files
that use tracing. The timestamp files should never be committed and
should not be visible in git status.

Signed-off-by: Stefan Hajnoczi <>...
b755a428 10/09/2010 11:19 am Vincent Minet

acpi: Fix an infinite loop in acpi_table_add

Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an
infinite loop in acpi_table_add.

Signed-off-by: Vincent Minet <>
Acked-by: Jes Sorensen <>...
10d554c6 10/09/2010 11:18 am Stefan Weil

configure: Remove unneeded defines from checks

_GNU_SOURCE is already defined in QEMU_CFLAGS which
is passed to gcc in shell function compile_prog.

Removing the definition from several checks avoids compiler warnings
(which are now written to config.log)....