Statistics
| Branch: | Revision:

root / hw / etraxfs_eth.c @ ff753bb9

History | View | Annotate | Download (13.5 kB)

# Date Author Comment
9e84a470 08/26/2010 09:04 pm Blue Swirl

etraxfs_eth: correct use of ! and &

Combining bitwise AND and logical NOT is suspicious.

Fixed by this Coccinelle script:
// From http://article.gmane.org/gmane.linux.kernel/646367
@ expression E1,E2; @
(
!E1 & !E2 |
- !E1 & E2
+ !(E1 & E2)
)

Acked-by: Edgar E. Iglesias <>...

cdcf9153 07/25/2010 10:03 pm Edgar E. Iglesias

etrax: Update ethernet mgm-ctrl reg on writes

Some SW drivers dont keep track of what they've written and
depend on the HW latching write contents for later
read+modify+write sequences.

Signed-off-by: Edgar E. Iglesias <>

0d84be5b 04/25/2010 10:46 pm Blue Swirl

cris: remove dead assignments, spotted by clang analyzer

Value stored is never read.

Signed-off-by: Blue Swirl <>

163bf3a5 12/03/2009 05:41 pm Mark McLoughlin

net: convert etrax to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

e13b10be 12/03/2009 05:41 pm Mark McLoughlin

net: remove NICInfo::vc

Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

70783b9c 10/27/2009 07:29 pm Mark McLoughlin

net: add receive_raw parameter to qemu_new_vlan_client()

Trivial patch to allow supplying a receive_raw function.

A future cleanup should combine this function pointer parameters into a
table.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

bb6e6364 10/27/2009 07:29 pm Mark McLoughlin

net: add a client type code

This is so as to allow APIs which operate on specific client types
without having to add a function table entry which is only implemented
by a single client type.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

283c7c63 10/15/2009 05:32 pm Mark McLoughlin

net: allow NICs to be connected to netdevs

Introduce a 'peer' member to VLANClientState as an alternative
to a vlan. The idea being that packets are transfered directly
from peer clients rather than going through a vlan.

Patchworks-ID: 35516
Signed-off-by: Mark McLoughlin <>...

c227f099 10/02/2009 12:12 am Anthony Liguori

Revert "Get rid of _t suffix"

In the very least, a change like this requires discussion on the list.

The naming convention is goofy and it causes a massive merge problem. Something
like this must be presented on the list first so people can provide input...

99a0949b 10/01/2009 09:45 pm malc

Get rid of _t suffix

Some not so obvious bits, slirp and Xen were left alone for the time
being.

Signed-off-by: malc <>

d60efc6b 08/25/2009 09:29 pm Blue Swirl

Make CPURead/WriteFunc structure 'const'

Signed-off-by: Blue Swirl <>

ae50b274 07/10/2009 12:58 am Mark McLoughlin

Don't leak VLANClientState on PCI hot remove

destroy_nic() requires that NICInfo::private by a PCIDevice pointer,
but then goes on to require that the same pointer matches
VLANClientState::opaque.

That is no longer the case for virtio-net since qdev and wasn't...

1eed09cb 06/16/2009 11:18 pm Avi Kivity

Remove io_index argument from cpu_register_io_memory()

The parameter is always zero except when registering the three internal
io regions (ROM, unassigned, notdirty). Remove the parameter to reduce
the API's power, thus facilitating future change.

Signed-off-by: Avi Kivity <>...

ba494313 06/15/2009 10:00 pm Edgar E. Iglesias

etrax: Don't pass CPUState to peripherals.

Signed-off-by: Edgar E. Iglesias <>

463af534 06/09/2009 01:38 pm Mark McLoughlin

net: add fd_readv() handler to qemu_new_vlan_client() args

This, apparently, is the style we prefer - all VLANClientState
should be an argument to qemu_new_vlan_client().

Signed-off-by: Mark McLoughlin <>

cda9046b 06/09/2009 01:38 pm Mark McLoughlin

net: re-name vc->fd_read() to vc->receive()

VLANClientState's fd_read() handler doesn't read from file
descriptors, it adds a buffer to the client's receive queue.

Re-name the handlers to make things a little less confusing.

Signed-off-by: Mark McLoughlin <>

e3f5ec2b 06/09/2009 01:38 pm Mark McLoughlin

net: pass VLANClientState* as first arg to receive handlers

Give static type checking a chance to catch errors.

Signed-off-by: Mark McLoughlin <>

4f1c942b 06/09/2009 01:38 pm Mark McLoughlin

net: add return value to packet receive handler

This allows us to handle queue full conditions rather than dropping
the packet on the floor.

Signed-off-by: Mark McLoughlin <>

678fdca8 05/18/2009 10:34 pm Edgar E. Iglesias

etrax: Remove unused eth irq line.

The ethernet blocks irq line to report errors is unimplemented in QEMU.
Remove it for now.

Signed-off-by: Edgar E. Iglesias <>

4af6e404 05/13/2009 11:17 am Edgar E. Iglesias

ETRAX: Correct setting of ethernet station address.

Signed-off-by: Edgar E. Iglesias <>

b946a153 04/17/2009 08:11 pm aliguori

Introduce VLANClientState::cleanup() (Mark McLoughlin)

We're currently leaking memory and file descriptors on device
hot-unplug.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7150 c046a42c-6fe2-441c-8c8c-71466251a162

cc53adbc 02/22/2009 01:59 pm edgar_igl

CRIS: Fix remaining build warnings.

Signed-off-by: Jan Kiszka <>
Acked-by: Edgar E. Iglesias <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6638 c046a42c-6fe2-441c-8c8c-71466251a162

487414f1 02/06/2009 12:06 am aliguori

hw: remove error handling from qemu_malloc() callers (Avi Kivity)

Signed-off-by: Avi Kivity <>
Signed-off-by: Anthony Liguori <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6529 c046a42c-6fe2-441c-8c8c-71466251a162

0ae18cee 01/13/2009 09:39 pm aliguori

Check NIC model in some NIC init functions (Mark McLoughlin)

Some NIC init functions are only called when that model is
the only valid model. In that case, it makes sense to use
qemu_check_nic_model() from the NIC init function itself.

Signed-off-by: Mark McLoughlin <>...

94410b78 01/09/2009 02:04 am edgar_igl

ETRAX: Let the ethernet PHY report the current link-state.

  • PHY reports correct link-state.
  • Allow the board description to assign separate addresses to each PHY.

Signed-off-by: Edgar E. Iglesias <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6255 c046a42c-6fe2-441c-8c8c-71466251a162

7a9f6e4a 01/07/2009 07:48 pm aliguori

Add a -net name=foo parameter (Mark McLoughlin)

Allow the user to supply a vlan client name on the command line.

This is probably only useful for management tools so that they can
use their own names rather than parsing the output of 'info network'.

Signed-off-by: Mark McLoughlin <>...

bf38c1a0 01/07/2009 07:42 pm aliguori

Add a model string to VLANClientState (Mark McLoughlin)

Don't lose track of what type/model a vlan client is so that we can
e.g. assign a global per-model id to clients.

The entire patch is basically a tedious excercise in making sure the
type/model string gets propagated down to qemu_new_vlan_client()....

35ef81d6 01/07/2009 04:00 pm edgar_igl

ETRAX: Correct size of control-register area.

Signed-off-by: Edgar E. Iglesias <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6209 c046a42c-6fe2-441c-8c8c-71466251a162

8da3ff18 12/01/2008 08:59 pm pbrook

Change MMIO callbacks to use offsets, not absolute addresses.

Signed-off-by: Paul Brook <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5849 c046a42c-6fe2-441c-8c8c-71466251a162

aa25cf46 10/24/2008 12:18 pm edgar_igl

ETRAX-FS: Drop DMA polling for ethernet.

  • Drop DMA poll mode. Instead immediately push rx frames straight into the DMA
    without waiting for DMA_run to poll them of the fifo.

Signed-off-by: Edgar E. Iglesias <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5520 c046a42c-6fe2-441c-8c8c-71466251a162

c6488268 09/22/2008 11:34 pm edgar_igl

ETRAX-FS: Correct ethernet PHY diagnostics register reads.

  • Correct ethernet PHY diagnostics register reads.
  • Add friendly names for the speed/duplex fields.
  • Report duplex mismatches between MAC and PHY.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5300 c046a42c-6fe2-441c-8c8c-71466251a162

d27b2e50 06/30/2008 02:51 pm edgar_igl

Avoid refering to CRIS specific cpu-state to be able to use these blocks with other cores.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4806 c046a42c-6fe2-441c-8c8c-71466251a162

d297f464 06/30/2008 11:59 am edgar_igl

Avoid CRIS related warnings by Jan Kiszka.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4804 c046a42c-6fe2-441c-8c8c-71466251a162

9bcd77d6 05/28/2008 12:05 am edgar_igl

ETRAX: Avoid compiler warning.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4593 c046a42c-6fe2-441c-8c8c-71466251a162

f6953f13 05/18/2008 11:50 am edgar_igl ETRAX: Add support for the ethernet receivers dest addr filters.
  • Support the station address filters MA0 and MA1.
  • Model the group address bloom filter.
  • Indentation.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4487 c046a42c-6fe2-441c-8c8c-71466251a162

2e56350e 05/14/2008 02:51 am edgar_igl ETRAX: Add some kind of support for simulating 802.3 auto-negotiation.
  • Add support for link partner ability and diagnostics reg.
  • Correct the endianess for MDIO responses.
  • Dont trash PHY registers after reads.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4456 c046a42c-6fe2-441c-8c8c-71466251a162

a3ea5df5 05/11/2008 06:04 pm edgar_igl

Add limited support for the etrax ethernet controller.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4429 c046a42c-6fe2-441c-8c8c-71466251a162