Activity

From 12/22/2009 to 01/20/2010

01/20/2010

03:47 pm ganeti-local Revision 2ebf1568: Add unittests for cli.GenerateTable
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:47 pm Revision 2ebf1568: Add unittests for cli.GenerateTable
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:47 pm ganeti-local Revision ec39d63c: cli: Fix bug when not using headers
Commit 9fe72672 added code to not write spaces at the end of each line.
Unfortunately it didn't work properly when no...
Michael Hanselmann
03:47 pm Revision ec39d63c: cli: Fix bug when not using headers
Commit 9fe72672 added code to not write spaces at the end of each line.
Unfortunately it didn't work properly when no...
Michael Hanselmann

01/19/2010

06:18 pm ganeti-local Revision 03956d39: daemon-util: Fix quoting issue
This patch fixes a quoting issue in daemon-util:
$ EXTRA_MASTERD_ARGS=--no-voting /etc/init.d/ganeti restart
[…]
* g...
Michael Hanselmann
06:18 pm Revision 03956d39: daemon-util: Fix quoting issue
This patch fixes a quoting issue in daemon-util:
$ EXTRA_MASTERD_ARGS=--no-voting /etc/init.d/ganeti restart
[…]
* g...
Michael Hanselmann

01/15/2010

02:17 pm ganeti-local Revision 0175fd8c: Bump version to 2.1.0~rc3
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: ...
Michael Hanselmann
02:17 pm Revision 0175fd8c: Bump version to 2.1.0~rc3
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: ...
Michael Hanselmann
01:23 pm Revision f9d0783b: Merge branch 'stable-2.1' into devel-2.1
* stable-2.1: (22 commits)
Fix long-standing race condition bug in locking unittest
confd client: copy the peers ...
Iustin Pop
01:23 pm ganeti-local Revision f9d0783b: Merge branch 'stable-2.1' into devel-2.1
* stable-2.1: (22 commits)
Fix long-standing race condition bug in locking unittest
confd client: copy the peers ...
Iustin Pop
01:22 pm Revision 1b3a7656: Switch the SplitKeyVal function to accept escapes
This tiny patch switches the SplitKeyVal function (and thus the command
line options like -H, -B, etc.) to UnescapeAn...
Iustin Pop
01:22 pm ganeti-local Revision 1b3a7656: Switch the SplitKeyVal function to accept escapes
This tiny patch switches the SplitKeyVal function (and thus the command
line options like -H, -B, etc.) to UnescapeAn...
Iustin Pop
12:16 pm ganeti-local Revision 51e3bb92: Fix long-standing race condition bug in locking unittest
Every once in a while we saw failures in the locking unittest, but
weren't able to determine the cause. This patch fi...
Michael Hanselmann
12:16 pm Revision 51e3bb92: Fix long-standing race condition bug in locking unittest
Every once in a while we saw failures in the locking unittest, but
weren't able to determine the cause. This patch fi...
Michael Hanselmann

01/14/2010

07:07 pm ganeti-local Revision db169865: confd client: copy the peers in UpdatePeerList
Since the peer list is shuffled by the client, we don't keep a reference
to the list which was passed in, but copy it...
Guido Trotter
07:07 pm Revision db169865: confd client: copy the peers in UpdatePeerList
Since the peer list is shuffled by the client, we don't keep a reference
to the list which was passed in, but copy it...
Guido Trotter
06:38 pm ganeti-local Revision a804261a: Move instance relocation test upper in the chain
Currently we test each instance for relocation in checkMove; however, it
is a little more clear if we pass only the r...
Iustin Pop
06:38 pm Revision a804261a: Move instance relocation test upper in the chain
Currently we test each instance for relocation in checkMove; however, it
is a little more clear if we pass only the r...
Iustin Pop
06:05 pm Revision 5ad86777: Split the balancing function in two parts
Currently in the balancing function we do two thing:
- take the decision where to do a new balancing round or not
- ...
Iustin Pop
06:05 pm ganeti-local Revision 5ad86777: Split the balancing function in two parts
Currently in the balancing function we do two thing:
- take the decision where to do a new balancing round or not
- ...
Iustin Pop
04:15 pm Revision 210ed839: Small update to the Makefile
Iustin Pop
04:15 pm ganeti-local Revision 210ed839: Small update to the Makefile
Iustin Pop
04:09 pm ganeti-local Revision 0d478754: Makefile: Switch from subshell to $(MAKE) -C
It seems that set -e does not affect subshell (only simple commands),
and thus we don't actually get failures from ma...
Iustin Pop
04:09 pm Revision 0d478754: Makefile: Switch from subshell to $(MAKE) -C
It seems that set -e does not affect subshell (only simple commands),
and thus we don't actually get failures from ma...
Iustin Pop
02:17 pm Revision 43983a88: testutils: Print name of test program before running it
While the name can be looked up in Makefile.am, this
is useful when an automated test just hangs and needs
to be kill...
Michael Hanselmann
02:17 pm ganeti-local Revision 43983a88: testutils: Print name of test program before running it
While the name can be looked up in Makefile.am, this
is useful when an automated test just hangs and needs
to be kill...
Michael Hanselmann
02:17 pm ganeti-local Revision 6d7cc5ff: Don't use hardcoded name for pylint
Look it up at configure time instead.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop ...
Michael Hanselmann
02:17 pm Revision 6d7cc5ff: Don't use hardcoded name for pylint
Look it up at configure time instead.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop ...
Michael Hanselmann
02:16 pm Revision f60d352e: Partially revert "Makefile.am: Run pylint on all Python code"
This partially reverts commit e4e7c7df3a2356103c2442a91d628ca0470fb267,
which made newer pylint versions fail.
Signe...
Michael Hanselmann
02:16 pm ganeti-local Revision f60d352e: Partially revert "Makefile.am: Run pylint on all Python code"
This partially reverts commit e4e7c7df3a2356103c2442a91d628ca0470fb267,
which made newer pylint versions fail.
Signe...
Michael Hanselmann
02:16 pm Revision b4086ce8: build-bash-completion: Take care of pylint warnings
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
02:16 pm ganeti-local Revision b4086ce8: build-bash-completion: Take care of pylint warnings
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
11:26 am ganeti-local Revision 5b69bc7c: Add an UnescapeAndSplit function
In many cases, where we accept (usually from the command line) a list of
parameters, we remove the use of the separat...
Iustin Pop
11:26 am Revision 5b69bc7c: Add an UnescapeAndSplit function
In many cases, where we accept (usually from the command line) a list of
parameters, we remove the use of the separat...
Iustin Pop

01/13/2010

07:09 pm ganeti-local Revision 5548de18: Small improvements for release script
- Print usage if no tree-ish (tag, branch or commit) was
specified.
- Use “gntrelease.XXXXXXXXXX” as temporary dire...
Michael Hanselmann
07:09 pm ganeti-local Revision e4e7c7df: Makefile.am: Run pylint on all Python code
That is, all Python code except unittests. In particular,
autotool/build-bash-completion was missing from the
previou...
Michael Hanselmann
07:09 pm Revision 5548de18: Small improvements for release script
- Print usage if no tree-ish (tag, branch or commit) was
specified.
- Use “gntrelease.XXXXXXXXXX” as temporary dire...
Michael Hanselmann
07:09 pm Revision e4e7c7df: Makefile.am: Run pylint on all Python code
That is, all Python code except unittests. In particular,
autotool/build-bash-completion was missing from the
previou...
Michael Hanselmann
07:08 pm ganeti-local Revision f59418db: build-bash-completion: Fix a few pylint warnings
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
07:08 pm ganeti-local Revision bdba4757: check-python-code: Use “set -e” to abort on errors
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
07:08 pm Revision f59418db: build-bash-completion: Fix a few pylint warnings
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
07:08 pm Revision bdba4757: check-python-code: Use “set -e” to abort on errors
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
06:45 pm ganeti-local Revision e2e92ea0: Generate hmac file with a newline at the end
This makes it slightly easier to cut&paste its content.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed...
Guido Trotter
06:45 pm Revision e2e92ea0: Generate hmac file with a newline at the end
This makes it slightly easier to cut&paste its content.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed...
Guido Trotter
05:47 pm ganeti-local Revision d2c8afb1: jqueue: Don't return negative number for unchecked jobs when archiving
When the queue was empty, the calculation for unchecked jobs while
archiving would return -1. ``last_touched`` is set...
Michael Hanselmann
05:47 pm Revision d2c8afb1: jqueue: Don't return negative number for unchecked jobs when archiving
When the queue was empty, the calculation for unchecked jobs while
archiving would return -1. ``last_touched`` is set...
Michael Hanselmann
03:03 pm ganeti-local Revision 9fe72672: cli.GenerateTable: Don't write EOL spaces
With this change, there won't be unnecessary space characters
at the end of lines.
Signed-off-by: Michael Hanselmann...
Michael Hanselmann
03:03 pm Revision 9fe72672: cli.GenerateTable: Don't write EOL spaces
With this change, there won't be unnecessary space characters
at the end of lines.
Signed-off-by: Michael Hanselmann...
Michael Hanselmann
03:03 pm ganeti-local Revision 9fa2e150: Improve logging for workerpool tasks by providing __repr__
Before it would log something like “starting task
(<ganeti.http.client._HttpClientPendingRequest object at 0x2aaaad17...
Michael Hanselmann
03:03 pm Revision 9fa2e150: Improve logging for workerpool tasks by providing __repr__
Before it would log something like “starting task
(<ganeti.http.client._HttpClientPendingRequest object at 0x2aaaad17...
Michael Hanselmann
03:03 pm ganeti-local Revision 02fc74da: workerpool: Simplify log messages
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:03 pm Revision 02fc74da: workerpool: Simplify log messages
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:03 pm ganeti-local Revision d16e6fd9: workerpool: Use worker name as thread name
This way it shows up in debug logs.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <i...
Michael Hanselmann
03:03 pm Revision d16e6fd9: workerpool: Use worker name as thread name
This way it shows up in debug logs.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <i...
Michael Hanselmann
03:02 pm ganeti-local Revision 89e2b4d2: workerpool: Make worker ID alphanumeric
Having a proper name instead of just a number makes debugging
easier.
Signed-off-by: Michael Hanselmann <hansmi@goog...
Michael Hanselmann
03:02 pm Revision 89e2b4d2: workerpool: Make worker ID alphanumeric
Having a proper name instead of just a number makes debugging
easier.
Signed-off-by: Michael Hanselmann <hansmi@goog...
Michael Hanselmann
03:02 pm ganeti-local Revision 71e1863e: locking: Fix race condition in LockSet
This patch fixes a race condition when acquiring all locks in
a LockSet instance. The list of lock names needs to be ...
Michael Hanselmann
03:02 pm Revision 71e1863e: locking: Fix race condition in LockSet
This patch fixes a race condition when acquiring all locks in
a LockSet instance. The list of lock names needs to be ...
Michael Hanselmann
03:02 pm ganeti-local Revision 4776e022: mcpu: Log lock status with sorted names
Reading and comparing sorted lists is easier when debugging locking problems.
Signed-off-by: Michael Hanselmann <han...
Michael Hanselmann
03:02 pm Revision 4776e022: mcpu: Log lock status with sorted names
Reading and comparing sorted lists is easier when debugging locking problems.
Signed-off-by: Michael Hanselmann <han...
Michael Hanselmann
03:02 pm ganeti-local Revision 9b154270: locking: Append to list outside error handling block
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Michael Hanselmann
03:02 pm Revision 9b154270: locking: Append to list outside error handling block
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Michael Hanselmann
03:02 pm ganeti-local Revision 56452af7: locking: Don't fail in error handling if lock isn't owned
In case an exception was thrown while acquiring the lock, not necessarily all
owned locks are also really acquired. B...
Michael Hanselmann
03:02 pm Revision 56452af7: locking: Don't fail in error handling if lock isn't owned
In case an exception was thrown while acquiring the lock, not necessarily all
owned locks are also really acquired. B...
Michael Hanselmann

01/12/2010

12:45 pm ganeti-local Revision 752a8ca8: Provide example default files and install one for development
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
12:45 pm Revision 752a8ca8: Provide example default files and install one for development
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
12:24 pm ganeti-local Revision b13dfb92: Merge branch 'devel-2.1' into stable-2.1
Iustin Pop
12:24 pm Revision b13dfb92: Merge branch 'devel-2.1' into stable-2.1
Iustin Pop
12:18 pm Revision 71e635f3: Fixing a typo in option description
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Ius...
René Nussbaumer
12:18 pm ganeti-local Revision 71e635f3: Fixing a typo in option description
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Ius...
René Nussbaumer

01/11/2010

02:25 pm ganeti-local Revision 82187135: Normalize MAC addresses to all lower.
This change will normalize the MAC to all lower after validation.
Signed-off-by: René Nussbaumer <rn@google.com>
Sig...
René Nussbaumer
02:25 pm Revision 82187135: Normalize MAC addresses to all lower.
This change will normalize the MAC to all lower after validation.
Signed-off-by: René Nussbaumer <rn@google.com>
Sig...
René Nussbaumer

01/07/2010

02:58 pm Revision 9f4b0931: live-test fixes for the text backend changes
Iustin Pop
02:58 pm ganeti-local Revision 9f4b0931: live-test fixes for the text backend changes
Iustin Pop
01:57 pm ganeti-local Revision 66ea8434: Update hscan to generate new-format text files
This also updates its manpage, some information were really old. Iustin Pop
01:57 pm Revision 66ea8434: Update hscan to generate new-format text files
This also updates its manpage, some information were really old. Iustin Pop
01:57 pm ganeti-local Revision 16c2369c: Switch the text file format to single-file
This patch changes from the two separate files to a single file, with
sections separated by a blank line. Currently o...
Iustin Pop
01:57 pm Revision 16c2369c: Switch the text file format to single-file
This patch changes from the two separate files to a single file, with
sections separated by a blank line. Currently o...
Iustin Pop
12:44 pm Revision f5197d89: Change the signatures of the text loader slightly
This is in preparation for the text format changes. Iustin Pop
12:44 pm ganeti-local Revision f5197d89: Change the signatures of the text loader slightly
This is in preparation for the text format changes. Iustin Pop

01/05/2010

02:56 pm ganeti-local Revision 7699c3af: Introduce a Luxi call for GetTags
This changes from submitting jobs to get the tags (in cli scripts) to
queries, which (since the tags query is a cheap...
Iustin Pop
02:56 pm Revision 7699c3af: Introduce a Luxi call for GetTags
This changes from submitting jobs to get the tags (in cli scripts) to
queries, which (since the tags query is a cheap...
Iustin Pop
02:39 pm ganeti-local Revision 47a72f18: LURenameCluster: run post hook on all nodes
Since the cluster name might be used for various purposes on nodes, we
should let all nodes "know" about a cluster re...
Iustin Pop
02:39 pm Revision 47a72f18: LURenameCluster: run post hook on all nodes
Since the cluster name might be used for various purposes on nodes, we
should let all nodes "know" about a cluster re...
Iustin Pop
09:23 am ganeti-local Revision 1cd5bc89: Allow passing options to pylint in the lint rule
This allows automated builders to override the format, for example.
Signed-off-by: Iustin Pop <iustin@google.com>
Re...
Iustin Pop
09:23 am Revision 1cd5bc89: Allow passing options to pylint in the lint rule
This allows automated builders to override the format, for example.
Signed-off-by: Iustin Pop <iustin@google.com>
Re...
Iustin Pop

01/04/2010

12:55 pm ganeti-local Revision 24cd3744: Merge remote branch 'devel-2.1'
* devel-2.1: (40 commits)
Fix unused imports or add silences where needed
bdev: Add a TODO and a pylint silence
...
Iustin Pop
12:55 pm Revision 24cd3744: Merge remote branch 'devel-2.1'
* devel-2.1: (40 commits)
Fix unused imports or add silences where needed
bdev: Add a TODO and a pylint silence
...
Iustin Pop
11:20 am ganeti-local Revision 30e4e741: Fix unused imports or add silences where needed
In some cases pylint doesn't parse the import correctly, so we add
silences; but there are also many cases of unused ...
Iustin Pop
11:20 am Revision 30e4e741: Fix unused imports or add silences where needed
In some cases pylint doesn't parse the import correctly, so we add
silences; but there are also many cases of unused ...
Iustin Pop
11:17 am ganeti-local Revision 527a15ac: bdev: Add a TODO and a pylint silence
A piece of old code in bdev.py uses a for loop over a single variable
because we can 'break' out of the loop or exit ...
Iustin Pop
11:17 am Revision 527a15ac: bdev: Add a TODO and a pylint silence
A piece of old code in bdev.py uses a for loop over a single variable
because we can 'break' out of the loop or exit ...
Iustin Pop
11:17 am ganeti-local Revision c9ca81c9: confd: add a TODO and a pylint disable
Two variables are used in a strange way in ExecConfd. Until that is
clarified, add a TODO and a silence for the unuse...
Iustin Pop
11:17 am Revision c9ca81c9: confd: add a TODO and a pylint disable
Two variables are used in a strange way in ExecConfd. Until that is
clarified, add a TODO and a silence for the unuse...
Iustin Pop
11:17 am ganeti-local Revision 460bb584: pylint: Temporarily disable W0201
There seems to be a bug in pylint relating to W0201 (“Attribute '%r'
defined outside __init__”) being re-enabled by s...
Iustin Pop
11:17 am Revision 460bb584: pylint: Temporarily disable W0201
There seems to be a bug in pylint relating to W0201 (“Attribute '%r'
defined outside __init__”) being re-enabled by s...
Iustin Pop
11:17 am ganeti-local Revision 16bef045: Disable R0922 in pylint
R0922, “Abstract class is only referenced 1 times”, cannot be disabled
in the source code, and thus
lib/http/auth.py:...
Iustin Pop
11:17 am Revision 16bef045: Disable R0922 in pylint
R0922, “Abstract class is only referenced 1 times”, cannot be disabled
in the source code, and thus
lib/http/auth.py:...
Iustin Pop
11:17 am ganeti-local Revision 2d54e29c: Further pylint disables, mostly for Unused args
Many of our functions have to follow a given API, and thus we have to
keep a given signature, but pylint doesn't unde...
Iustin Pop
11:17 am Revision 2d54e29c: Further pylint disables, mostly for Unused args
Many of our functions have to follow a given API, and thus we have to
keep a given signature, but pylint doesn't unde...
Iustin Pop
11:17 am ganeti-local Revision 0dda8696: pylint: disable the similarities checker
This is a very slow checker, estimated to be O(n²) by its author; so
using it all the time is not good. It can be re-...
Iustin Pop
11:17 am Revision 0dda8696: pylint: disable the similarities checker
This is a very slow checker, estimated to be O(n²) by its author; so
using it all the time is not good. It can be re-...
Iustin Pop
11:16 am ganeti-local Revision 857121ad: LUDiagnoseOS._DiagnoseByOS: remove unused arg
The node_list argument to _DiagnoseByOS is not used, and is obsoleted by
the fact that the rlist argument already has...
Iustin Pop
11:16 am Revision 857121ad: LUDiagnoseOS._DiagnoseByOS: remove unused arg
The node_list argument to _DiagnoseByOS is not used, and is obsoleted by
the fact that the rlist argument already has...
Iustin Pop
11:16 am ganeti-local Revision f93427cd: daemons: handle arguments correctly and uniformly
Of all daemons, only rapi did abort when given argument. None of our
daemons use any arguments, but they accepted the...
Iustin Pop
11:16 am Revision f93427cd: daemons: handle arguments correctly and uniformly
Of all daemons, only rapi did abort when given argument. None of our
daemons use any arguments, but they accepted the...
Iustin Pop
11:16 am ganeti-local Revision 7ed85ffe: hv_xen/_GetConfigFileDiskData: remove unused arg
The disk template is not needed, all that's used is the disk data. As
such, remove this parameter from the function.
...
Iustin Pop
11:16 am Revision 7ed85ffe: hv_xen/_GetConfigFileDiskData: remove unused arg
The disk template is not needed, all that's used is the disk data. As
such, remove this parameter from the function.
...
Iustin Pop
11:16 am ganeti-local Revision 45e0d704: jqueue/_CheckRpcResult: log the whole operation
Currently only the rpc call, but not its description (which also shows
the argument) is logged. We change this to log...
Iustin Pop
11:16 am Revision 45e0d704: jqueue/_CheckRpcResult: log the whole operation
Currently only the rpc call, but not its description (which also shows
the argument) is logged. We change this to log...
Iustin Pop
11:16 am ganeti-local Revision 8929d28c: Optparse extenders have to obey a given API
So we just silence the warning.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@goo...
Iustin Pop
11:16 am Revision 8929d28c: Optparse extenders have to obey a given API
So we just silence the warning.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@goo...
Iustin Pop
11:16 am ganeti-local Revision c19f9810: backend._OSOndiskAPIVersion: remove obsolete arg
The 'name' argument is not used anymore, probably since before 2.0.
Since this is an internal function, we can just r...
Iustin Pop
11:16 am Revision c19f9810: backend._OSOndiskAPIVersion: remove obsolete arg
The 'name' argument is not used anymore, probably since before 2.0.
Since this is an internal function, we can just r...
Iustin Pop
11:16 am ganeti-local Revision e11ddf13: pylint cleanups: dangerous initializers
Plus a silence for a wrong "uninitialized var".
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier T...
Iustin Pop
11:16 am Revision e11ddf13: pylint cleanups: dangerous initializers
Plus a silence for a wrong "uninitialized var".
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier T...
Iustin Pop
11:16 am ganeti-local Revision 7e950d31: Convert to static methods (where appropriate)
Many methods are simple pure functions, and not depending on the object
state. We convert these to staticmethods.
Si...
Iustin Pop
11:16 am Revision 7e950d31: Convert to static methods (where appropriate)
Many methods are simple pure functions, and not depending on the object
state. We convert these to staticmethods.
Si...
Iustin Pop
11:15 am ganeti-local Revision f4ad2ef0: Remove more unused variables
This removes unused variables in the rest of the code (outside lib/).
Signed-off-by: Iustin Pop <iustin@google.com>
...
Iustin Pop
11:15 am Revision f4ad2ef0: Remove more unused variables
This removes unused variables in the rest of the code (outside lib/).
Signed-off-by: Iustin Pop <iustin@google.com>
...
Iustin Pop
11:15 am ganeti-local Revision 7260cfbe: Add targeted pylint disables
This patch should have only:
- pylint disables
- docstring changes
- whitespace changes
Signed-off-by: Iustin Pop <...
Iustin Pop
11:15 am Revision 7260cfbe: Add targeted pylint disables
This patch should have only:
- pylint disables
- docstring changes
- whitespace changes
Signed-off-by: Iustin Pop <...
Iustin Pop
11:15 am ganeti-local Revision e7beaa02: burnin: move decorators out of classes
Similar to commit c881c5, we move the decorators out of classes, such
that they become simple functions instead of me...
Iustin Pop
11:15 am Revision e7beaa02: burnin: move decorators out of classes
Similar to commit c881c5, we move the decorators out of classes, such
that they become simple functions instead of me...
Iustin Pop
11:15 am ganeti-local Revision e2e10467: Rename an ConfdInotifyEventHandler init argument
'file' is a builtin keyword/type. Like many others, it should not be
used as a variable/argument name.
No code is ac...
Iustin Pop
11:15 am Revision e2e10467: Rename an ConfdInotifyEventHandler init argument
'file' is a builtin keyword/type. Like many others, it should not be
used as a variable/argument name.
No code is ac...
Iustin Pop
11:15 am ganeti-local Revision e0098923: Introduce a makefile lint rule
This runs pylint over all the python files. Yes, it takes a long while,
but it's the only way to properly analyze the...
Iustin Pop
11:15 am Revision e0098923: Introduce a makefile lint rule
This runs pylint over all the python files. Yes, it takes a long while,
but it's the only way to properly analyze the...
Iustin Pop
11:15 am ganeti-local Revision 94fed7da: Implement all hv functions in hv_chroot/hv_fake
The chroot and fake hypervisors were missing:
- the powercycle node functionality
- proper handling of migration req...
Iustin Pop
11:15 am Revision 94fed7da: Implement all hv functions in hv_chroot/hv_fake
The chroot and fake hypervisors were missing:
- the powercycle node functionality
- proper handling of migration req...
Iustin Pop
11:12 am ganeti-local Revision 0a4e7f24: Update the _autoconf.py make rule for pylint
This adds targeted pylint disables, but since _autoconf.py is
autogenerated we need to do this in Makefile.am (hence ...
Iustin Pop
11:12 am Revision 0a4e7f24: Update the _autoconf.py make rule for pylint
This adds targeted pylint disables, but since _autoconf.py is
autogenerated we need to do this in Makefile.am (hence ...
Iustin Pop
11:12 am ganeti-local Revision dfe879ce: Disable TODO warnings in pylint
We don't get any useful out of this - a git grep is as effective, and
these only pollute the pylint output.
Signed-o...
Iustin Pop
11:12 am Revision dfe879ce: Disable TODO warnings in pylint
We don't get any useful out of this - a git grep is as effective, and
these only pollute the pylint output.
Signed-o...
Iustin Pop
11:12 am ganeti-local Revision bbe4cc16: Add some stubs to bdev.FileStorage
This patch adds explicit errors (instead of notimplemented) in
FileStorage (and the associated TODOs).
Signed-off-by...
Iustin Pop
11:12 am Revision bbe4cc16: Add some stubs to bdev.FileStorage
This patch adds explicit errors (instead of notimplemented) in
FileStorage (and the associated TODOs).
Signed-off-by...
Iustin Pop
11:11 am ganeti-local Revision 6af8a903: Fix indentation issues
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>
Iustin Pop
11:11 am Revision 6af8a903: Fix indentation issues
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>
Iustin Pop
11:11 am ganeti-local Revision be0fc05d: Fix two bugs in ConfigWriter._EnsureUUID
Wrong argument name and wrong number of arguments in string formatting.
Signed-off-by: Iustin Pop <iustin@google.com...
Iustin Pop
11:11 am Revision be0fc05d: Fix two bugs in ConfigWriter._EnsureUUID
Wrong argument name and wrong number of arguments in string formatting.
Signed-off-by: Iustin Pop <iustin@google.com...
Iustin Pop
11:11 am ganeti-local Revision 5905901c: KVM: Abstract/rework instance up checks
This patch abstract the check "is instance stopped" into a separate
function, and thus simplifies a couple of higher-...
Iustin Pop
11:11 am Revision 5905901c: KVM: Abstract/rework instance up checks
This patch abstract the check "is instance stopped" into a separate
function, and thus simplifies a couple of higher-...
Iustin Pop
11:10 am ganeti-local Revision 98ec75d6: KVM: Split out the pidfile computation
In some cases we only need the pidfile, but not the pid or the alive
status.
Signed-off-by: Iustin Pop <iustin@googl...
Iustin Pop
11:10 am Revision 98ec75d6: KVM: Split out the pidfile computation
In some cases we only need the pidfile, but not the pid or the alive
status.
Signed-off-by: Iustin Pop <iustin@googl...
Iustin Pop
11:10 am ganeti-local Revision d1b83918: Fix an error message
Detected by an 'Unused variable' warning.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan ...
Iustin Pop
11:10 am Revision d1b83918: Fix an error message
Detected by an 'Unused variable' warning.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan ...
Iustin Pop
11:10 am ganeti-local Revision 1122eb25: Remove many 'Unused variable' warnings
Note there are some cases left which need extra cleanup.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ...
Iustin Pop
11:10 am Revision 1122eb25: Remove many 'Unused variable' warnings
Note there are some cases left which need extra cleanup.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ...
Iustin Pop
10:42 am ganeti-local Revision 07b8a2b5: Fix use of the logging functions
The logging functions expand the arguments themselves, thus it's safer
to let them do it rather than manual string fo...
Iustin Pop
10:42 am Revision 07b8a2b5: Fix use of the logging functions
The logging functions expand the arguments themselves, thus it's safer
to let them do it rather than manual string fo...
Iustin Pop

12/29/2009

09:33 pm Revision f6044dc4: Update NEWS file for the 0.2.2 release
Iustin Pop
09:33 pm ganeti-local Revision f6044dc4: Update NEWS file for the 0.2.2 release
Iustin Pop
09:33 pm Revision 53c24840: Update hbal man page to note that we use stddev
We actually use stddev and not the coefficient of variance (as wrongly
noted before), so we update the documentation ...
Iustin Pop
09:33 pm ganeti-local Revision 53c24840: Update hbal man page to note that we use stddev
We actually use stddev and not the coefficient of variance (as wrongly
noted before), so we update the documentation ...
Iustin Pop
08:50 pm Revision 57df9cb3: Update comments in live-test about clusters
The live test needs a populated cluster, so let's write this down. Iustin Pop
08:50 pm ganeti-local Revision 57df9cb3: Update comments in live-test about clusters
The live test needs a populated cluster, so let's write this down. Iustin Pop

12/28/2009

02:05 pm ganeti-local Revision d984846d: Merge branch 'devel-2.0' into devel-2.1
* devel-2.0:
Fix indentation in hv_kvm
Implement BuildHooksEnv for NoHooksLU
Clarifiy some more wide pylint dis...
Iustin Pop
02:05 pm Revision d984846d: Merge branch 'devel-2.0' into devel-2.1
* devel-2.0:
Fix indentation in hv_kvm
Implement BuildHooksEnv for NoHooksLU
Clarifiy some more wide pylint dis...
Iustin Pop
01:01 pm Revision 0d0503b2: Improve the dist build rule
This changes the 'dist' rule to also do a check that the archive can
build all the programs and passes the check test...
Iustin Pop
01:01 pm ganeti-local Revision 0d0503b2: Improve the dist build rule
This changes the 'dist' rule to also do a check that the archive can
build all the programs and passes the check test...
Iustin Pop
12:43 pm ganeti-local Revision c70d2d9b: Clarifiy some more wide pylint disables
This removes/updates some module-wide pylint disables.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Ol...
Iustin Pop
12:43 pm ganeti-local Revision 80f3f415: Update pylintrc
Since the current pylintrc is in now way good for our style, we update
it:
- remove docstring checks, since we have ...
Iustin Pop
12:43 pm ganeti-local Revision 4c4b5058: Fix two bugs in seldom-used codepaths
New version of pylint, new bugs found!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <ol...
Iustin Pop
12:43 pm ganeti-local Revision fe267188: Add targetted pylint disables
This patch adds targeted pylint disables, where it makes sense (either
due to limitations in pylint or due to histori...
Iustin Pop
12:43 pm ganeti-local Revision fc8a6b8f: Implement BuildHooksEnv for NoHooksLU
This just adds a stub function that raises an assertion error; this
accomplishes two things:
- silences many pylint ...
Iustin Pop
12:43 pm ganeti-local Revision 146afafb: Fix indentation in hv_kvm
Per pylint warnings.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>
Iustin Pop
12:43 pm Revision fe267188: Add targetted pylint disables
This patch adds targeted pylint disables, where it makes sense (either
due to limitations in pylint or due to histori...
Iustin Pop
12:43 pm Revision 146afafb: Fix indentation in hv_kvm
Per pylint warnings.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>
Iustin Pop
12:43 pm Revision 4c4b5058: Fix two bugs in seldom-used codepaths
New version of pylint, new bugs found!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <ol...
Iustin Pop
12:43 pm Revision c70d2d9b: Clarifiy some more wide pylint disables
This removes/updates some module-wide pylint disables.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Ol...
Iustin Pop
12:43 pm Revision fc8a6b8f: Implement BuildHooksEnv for NoHooksLU
This just adds a stub function that raises an assertion error; this
accomplishes two things:
- silences many pylint ...
Iustin Pop
12:43 pm Revision 80f3f415: Update pylintrc
Since the current pylintrc is in now way good for our style, we update
it:
- remove docstring checks, since we have ...
Iustin Pop
12:43 pm ganeti-local Revision caeffaa0: Partial cherry-pick of 6c881c5 from the 2.1 branch
This cherry-picks the utils.FieldSet.Matches changes and the significant
jqueue.py change. These are stable in the 2....
Iustin Pop
12:43 pm Revision caeffaa0: Partial cherry-pick of 6c881c5 from the 2.1 branch
This cherry-picks the utils.FieldSet.Matches changes and the significant
jqueue.py change. These are stable in the 2....
Iustin Pop
12:13 pm Revision 1901266d: Remove Version.hs during clean too
Ganeti/HTools/Version.hs is generated at build time from version (which
is the only one shipped), so it must be remov...
Iustin Pop
12:13 pm ganeti-local Revision 1901266d: Remove Version.hs during clean too
Ganeti/HTools/Version.hs is generated at build time from version (which
is the only one shipped), so it must be remov...
Iustin Pop
12:09 pm Revision 0ccaab44: Fix small typo
This was found, of all things, via lintian during the Debian packaging… Iustin Pop
12:09 pm ganeti-local Revision 0ccaab44: Fix small typo
This was found, of all things, via lintian during the Debian packaging… Iustin Pop
« Previous
Next »
 

Also available in: Atom