Synnefo » snf-ganeti

#!/usr/bin/python

#

# Copyright (C) 2013 Google Inc.

#

# This program is free software; you can redistribute it and/or modify

# it under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 2 of the License, or

# (at your option) any later version.

#

# This program is distributed in the hope that it will be useful, but

# WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

# General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with this program; if not, write to the Free Software

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA

# 02110-1301, USA.

"""Tests for LUNode*

"""

from collections import defaultdict

from ganeti import compat

from ganeti import constants

from ganeti import objects

from ganeti import opcodes

from ganeti import errors

from testsupport import *

import testutils

# pylint: disable=W0613

def _TcpPingFailSecondary(cfg, mock_fct, target, port, timeout=None,

                          live_port_needed=None, source=None):

  # This will return True if target is in 192.0.2.0/24 (primary range)

  # and False if not.

  return "192.0.2." in target

class TestLUNodeAdd(CmdlibTestCase):

  def setUp(self):

    super(TestLUNodeAdd, self).setUp()

    # One node for testing readding:

    self.node_readd = self.cfg.AddNewNode()

    self.op_readd = opcodes.OpNodeAdd(node_name=self.node_readd.name,

                                      readd=True,

                                      primary_ip=self.node_readd.primary_ip,

                                      secondary_ip=self.node_readd.secondary_ip)

    # One node for testing adding:

    # don't add to configuration now!

    self.node_add = objects.Node(name="node_add",

                                 primary_ip="192.0.2.200",

                                 secondary_ip="203.0.113.200")

    self.op_add = opcodes.OpNodeAdd(node_name=self.node_add.name,

                                    primary_ip=self.node_add.primary_ip,

                                    secondary_ip=self.node_add.secondary_ip)

    self.netutils_mod.TcpPing.return_value = True

    self.mocked_dns_rpc = self.rpc_mod.DnsOnlyRunner.return_value

    self.mocked_dns_rpc.call_version.return_value = \

      self.RpcResultsBuilder(use_node_names=True) \

        .AddSuccessfulNode(self.node_add, constants.CONFIG_VERSION) \

        .AddSuccessfulNode(self.node_readd, constants.CONFIG_VERSION) \

        .Build()

    node_verify_result = \

      self.RpcResultsBuilder() \

        .CreateSuccessfulNodeResult(self.node_add, {constants.NV_NODELIST: []})

    # we can't know the node's UUID in advance, so use defaultdict here

    self.rpc.call_node_verify.return_value = \

      defaultdict(lambda: node_verify_result, {})

  def testOvsNoLink(self):

    ndparams = {

      constants.ND_OVS: True,

      constants.ND_OVS_NAME: "testswitch",

      constants.ND_OVS_LINK: None,

    }

    op = self.CopyOpCode(self.op_add,

                         ndparams=ndparams)

    self.ExecOpCode(op)

    self.assertLogContainsRegex(

      "No physical interface for OpenvSwitch was given."

      " OpenvSwitch will not have an outside connection."

      " This might not be what you want")

    created_node = self.cfg.GetNodeInfoByName(op.node_name)

    self.assertEqual(ndparams[constants.ND_OVS],

                     created_node.ndparams.get(constants.ND_OVS, None))

    self.assertEqual(ndparams[constants.ND_OVS_NAME],

                     created_node.ndparams.get(constants.ND_OVS_NAME, None))

    self.assertEqual(ndparams[constants.ND_OVS_LINK],

                     created_node.ndparams.get(constants.ND_OVS_LINK, None))

  def testWithoutOVS(self):

    self.ExecOpCode(self.op_add)

    created_node = self.cfg.GetNodeInfoByName(self.op_add.node_name)

    self.assertEqual(None,

                     created_node.ndparams.get(constants.ND_OVS, None))

  def testWithOVS(self):

    ndparams = {

      constants.ND_OVS: True,

      constants.ND_OVS_LINK: "eth2",

    }

    op = self.CopyOpCode(self.op_add,

                         ndparams=ndparams)

    self.ExecOpCode(op)

    created_node = self.cfg.GetNodeInfoByName(op.node_name)

    self.assertEqual(ndparams[constants.ND_OVS],

                     created_node.ndparams.get(constants.ND_OVS, None))

    self.assertEqual(ndparams[constants.ND_OVS_LINK],

                     created_node.ndparams.get(constants.ND_OVS_LINK, None))

  def testReaddingMaster(self):

    op = opcodes.OpNodeAdd(node_name=self.cfg.GetMasterNodeName(),

                           readd=True)

    self.ExecOpCodeExpectOpPrereqError(op, "Cannot readd the master node")

  def testReaddNotVmCapableNode(self):

    self.cfg.AddNewInstance(primary_node=self.node_readd)

    self.netutils_mod.GetHostname.return_value = \

      HostnameMock(self.node_readd.name, self.node_readd.primary_ip)

    op = self.CopyOpCode(self.op_readd, vm_capable=False)

    self.ExecOpCodeExpectOpPrereqError(op, "Node .* being re-added with"

                                       " vm_capable flag set to false, but it"

                                       " already holds instances")

  def testReaddAndPassNodeGroup(self):

    op = self.CopyOpCode(self.op_readd,group="groupname")

    self.ExecOpCodeExpectOpPrereqError(op, "Cannot pass a node group when a"

                                       " node is being readded")

  def testPrimaryIPv6(self):

    self.master.secondary_ip = self.master.primary_ip

    op = self.CopyOpCode(self.op_add, primary_ip="2001:DB8::1",

                         secondary_ip=self.REMOVE)

    self.ExecOpCode(op)

  def testInvalidSecondaryIP(self):

    op = self.CopyOpCode(self.op_add, secondary_ip="333.444.555.777")

    self.ExecOpCodeExpectOpPrereqError(op, "Secondary IP .* needs to be a valid"

                                       " IPv4 address")

  def testNodeAlreadyInCluster(self):

    op = self.CopyOpCode(self.op_readd, readd=False)

    self.ExecOpCodeExpectOpPrereqError(op, "Node %s is already in the"

                                       " configuration" % self.node_readd.name)

  def testReaddNodeNotInConfiguration(self):

    op = self.CopyOpCode(self.op_add, readd=True)

    self.ExecOpCodeExpectOpPrereqError(op, "Node %s is not in the"

                                       " configuration" % self.node_add.name)

  def testPrimaryIpConflict(self):

    # In LUNodeAdd, DNS will resolve the node name to an IP address, that is

    # used to overwrite any given primary_ip value!

    # Thus we need to mock this DNS resolver here!

    self.netutils_mod.GetHostname.return_value = \

      HostnameMock(self.node_add.name, self.node_readd.primary_ip)

    op = self.CopyOpCode(self.op_add)

    self.ExecOpCodeExpectOpPrereqError(op, "New node ip address.* conflict with"

                                       " existing node")

  def testSecondaryIpConflict(self):

    op = self.CopyOpCode(self.op_add, secondary_ip=self.node_readd.secondary_ip)

    self.ExecOpCodeExpectOpPrereqError(op, "New node ip address.* conflict with"

                                       " existing node")

  def testReaddWithDifferentIP(self):

    op = self.CopyOpCode(self.op_readd, primary_ip="192.0.2.100",

                         secondary_ip="230.0.113.100")

    self.ExecOpCodeExpectOpPrereqError(op, "Readded node doesn't have the same"

                                       " IP address configuration as before")

  def testNodeHasSecondaryIpButNotMaster(self):

    self.master.secondary_ip = self.master.primary_ip

    self.ExecOpCodeExpectOpPrereqError(self.op_add, "The master has no"

                                       " secondary ip but the new node has one")

  def testMasterHasSecondaryIpButNotNode(self):

    op = self.CopyOpCode(self.op_add, secondary_ip=None)

    self.ExecOpCodeExpectOpPrereqError(op, "The master has a secondary ip but"

                                       " the new node doesn't have one")

  def testNodeNotReachableByPing(self):

    self.netutils_mod.TcpPing.return_value = False

    op = self.CopyOpCode(self.op_add)

    self.ExecOpCodeExpectOpPrereqError(op, "Node not reachable by ping")

  def testNodeNotReachableByPingOnSecondary(self):

    self.netutils_mod.GetHostname.return_value = \

      HostnameMock(self.node_add.name, self.node_add.primary_ip)

    self.netutils_mod.TcpPing.side_effect = \

      compat.partial(_TcpPingFailSecondary, self.cfg, self.netutils_mod.TcpPing)

    op = self.CopyOpCode(self.op_add)

    self.ExecOpCodeExpectOpPrereqError(op, "Node secondary ip not reachable by"

                                       " TCP based ping to node daemon port")

  def testCantGetVersion(self):

    self.mocked_dns_rpc.call_version.return_value = \

      self.RpcResultsBuilder(use_node_names=True) \

        .AddErrorNode(self.node_add) \

        .Build()

    op = self.CopyOpCode(self.op_add)

    self.ExecOpCodeExpectOpExecError(op, "Can't get version information from"

                                     " node %s" % self.node_add.name)

if __name__ == "__main__":

  testutils.GanetiTestProgram()