Statistics
| Branch: | Tag: | Revision:

root / test / ganeti.asyncnotifier_unittest.py @ 0f85ebd9

History | View | Annotate | Download (6.7 kB)

# Date Author Comment
0f85ebd9 02/21/2012 04:34 pm Iustin Pop

Fix asyncnotifier unit tests

On my workstation, if I run the following two tests in this exact
order:

- TestSingleFileEventHandler.testError
- TestSingleFileEventHandler.testReplace

the second test will fail, because there is no "unregister" of
previous tests (and the poll() done by asyncore will fire on the...
db859c7d 11/14/2011 08:23 am Michael Hanselmann

check-python-code: Detect old-style pylint disable-msg lines

Commit b459a848d was supposed to replace all, but one was missed. Add a
check to autotools/check-python-code.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Andrea Spadaccini <>
84ce674e 11/26/2010 06:36 pm Iustin Pop

asyncnotifier tests: simplify the setup code

First change is to replace "range(len(self.NOTIFIERS)))" with
self.NOTIFIERS, as range(len(range(N))) ≡ range(N).

Sencond change is switch from an explicit indexing to use of zip.
Unittests still pass :)

Signed-off-by: Iustin Pop <>...
e543a42f 10/13/2010 03:18 pm Michael Hanselmann

Extract base class from SingleFileEventHandler

The base class can contain code useful to other inotify users.
As it is “SingleFileEventHandler” can not be used in ganeti-rapi,
therefore it'll use its own small inotify handler class based
on this base class....
158206e0 06/30/2010 02:17 pm Manuel Franceschini

User assertFalse instead of assert_(not ...)

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Guido Trotter <>
e3cc4c69 06/01/2010 11:34 am Guido Trotter

reraise exceptions in async tests' error handlers

This makes sure that any unforeseen error raises an exception rather
then just increasing a counter. It makes unittest debugging a lot
easier.

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>
7678409f 05/25/2010 01:16 pm Guido Trotter

Test for errors during inotify callback

- Create a new _MyErrorLoggingAsyncNotifier class which registers
error counts, rather than logging them
- Add an additional ERR notifier to test with
- Check that no error was returned, for tests that weren't supposed to...
e9c8deab 05/25/2010 01:16 pm Guido Trotter

ErrorLoggingAsyncNotifier

This mixes AsyncNotifier with GanetiBaseAsyncoreDispatcher to provide an
AsyncNotifier which will log errors, rather than bail out.

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>
49f986e7 05/24/2010 01:00 pm Guido Trotter

TestSingleFileEventHandler: abstract notifier type

Rather than hardcode that we have two notifiers, and notifier 0 is the
terminating one, we abstract this with class level constants. This makes
it easier to add more, with different features.

The only real change is that now the callback class takes as input the...
17496050 05/21/2010 01:45 pm Guido Trotter

Add asyncnotifier unittests

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>