Statistics
| Branch: | Tag: | Revision:

root @ 355d1f32

# Date Author Comment
355d1f32 09/13/2013 02:55 pm Sebastian Gebhard

Fix lint errors in fix keyerrors patch

This patch fixes one lint error introduced by my recent patch to
fix keyerrors in lib/cmdlib/node.py.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>
11414807 09/13/2013 02:20 pm Klaus Aehlig

Fix example IPs and hostnames in tests

Our tests are a form of documentation, and hence should use
IPs from the TEST-NET ranges according to RFC 5737. They definitely
should not use real public IP addresses.

Similarly, example host names should be from one of the reserved...
0d8ce33e 09/13/2013 01:50 pm Sebastian Gebhard

Fix keyerrors in cmdlib node

This patch fixes potential key errors in the OpenvSwitch implementation
in cmdlib/node.py. The checks in that file expected to have a ndparams dict
with certain keys to be present. This should not be the case as it will
result in KeyErrors when those keys are not present....
b8e39189 09/13/2013 11:59 am Klaus Aehlig

design update: symlink structure

Update the upgrade design document according to the outcome
of the design discussion at GanetiCon 2013. There are two
changes in the design.

  • As revision upgrades are binary compatible at all levels,
    one can accept a rough upgrade, just replacing the binaries....
798582cf 09/13/2013 11:46 am Spyros Trigazis

Make CPUload Data Collector aware of clock ticks

Modify CPUload data collector to get the number of clock ticks
per second from Posix.Unistd. Since CPUload collector converts
clock ticks (jiffies) to seconds and the clock ticks to seconds
ratio varies between linux distributions, it must be read from...
f8d4db63 09/12/2013 06:26 pm Klaus Aehlig

Add shelltest for the --ignore-dynu option of hbal

In the example, we have two nodes and 6 instances, all using external
storage. There are four small instances on one node, and two big
instances, requiring twice the amount of resources of a small instance,...
14b4e045 09/12/2013 06:26 pm Klaus Aehlig

Make hbal support the option --ignore-dynu

This will allow to do balancing based only on static information.
In particular, the effect of balancing towards same number of
instances per node that the dynamic usage consideration has
if no usage file is provided, can be turned off, if this is...
81b6fa23 09/12/2013 06:25 pm Klaus Aehlig

Make ExtLoader honor the --ignore-dynu option

Make the external data loader correctly honor the --ignore-dynu option
by clearing the dynamic utilisation data from all instances if the option
is given.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>
a06a4dac 09/12/2013 06:25 pm Klaus Aehlig

Provide utility function to clear utilisation data

Using this utility function, the dynamic utilisation of all instances
can be set to 0. This will have the effect of all utilisation being ignored.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>
61f96e6f 09/12/2013 06:25 pm Klaus Aehlig

Define a new option --ignore-dynu

This option, if set, will tell htools to ignore any dynamic
use data.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>
2f3230f6 09/12/2013 03:56 pm Thomas Thrainer

Add unit test for LUInstanceQuery and -QueryData

This patch provides rudimentary unit test coverage for LUInstanceQuery
and LUInstanceQueryData.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
d1b2ffe8 09/12/2013 03:56 pm Thomas Thrainer

Add unit tests for LUInstanceMigrate and -Failover

This patch adds rudimentary unit test coverage for LUInstanceMigrate and
LUInstanceFailover.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
b02063fe 09/12/2013 03:56 pm Thomas Thrainer

Add unit tests for LUInstanceChangeGroup

This patch provides unit test coverage for LUInstanceChangeGroup.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
aefc2f89 09/12/2013 03:56 pm Thomas Thrainer

Use RpcResult.Warn where appropriate

Those two occurrences of warnings can be replaced the RpcResult.Warn
method, which is done in this patch.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
34956ece 09/12/2013 03:56 pm Thomas Thrainer

Remove unneeded except block

The validation of the opcodes already checks the size parameter for the
right type, so this except block is not required.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
f667baab 09/12/2013 03:56 pm Thomas Thrainer

Rename variable to reflect its content

Rename the "node" variable to "node_uuid" as that's the content it
actually receives.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
27619aac 09/12/2013 03:56 pm Thomas Thrainer

Add unit tests for LUInstanceSetParams

This patch adds unit tests for LUInstanceSetParams. It does not provide
100% coverage, but covers a significant portion.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
f41b569f 09/12/2013 03:56 pm Thomas Thrainer

Fix testMasterNetmask in TestLUClusterSetParams

The netmask was previously wrongly given as a bitmask, now it's given as
the net prefix length.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>
6b604e1d 09/12/2013 03:32 pm Jose A. Lopes

Fix missing dependency in 'src/hs2py-constants'

Fix target 'src/hs2py-constants' because it must depend on
'src/AutoConf.hs'. Fixes issue 573.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
0c5f1b13 09/12/2013 03:23 pm Thomas Thrainer

Merge branch 'stable-2.9' into master

  • stable-2.9
    Fix bridging in net-common
    Sync build_chroot with buildbot slack role
    Auto-upgrade of disks' config wrt LD-renaming
    Fix tests regarding DISK_LD_DEFAULTS
    Fixing renaming of DISK_LD_DEFAULTS
    Replace LD_* constants with DT_* constants...
191e5c19 09/12/2013 02:01 pm Jose A. Lopes

Update reference to Python constants

Update reference to 'DAEMONS_PORTS' and related constants that are
used on the Haskell side to construct the 'daemonsPorts' constant.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
6dc0cb59 09/12/2013 02:01 pm Jose A. Lopes

Add 'daemonsPorts' and related constants

  • add 'daemonsPorts' and related constants used in the construction of
    the 'Map' that maps each daemon to its corresponding protocol and
    port. This breaks constant 'daemonsPortsGanetiNoded' which is
    automatically generated from the Python dictionary 'DAEMONS_PORTS'...
cd0359bc 09/12/2013 02:01 pm Jose A. Lopes

Add 'Protocol' datatype

Add 'Protocol' datatype which is necessary for the 'daemonsPorts'
constant.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
92b28956 09/12/2013 02:01 pm Jose A. Lopes

Fix instances of 'PyValue'

Fix instances of 'PyValue', namely, for tuples and maps.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
f2cf4da2 09/12/2013 02:01 pm Jose A. Lopes

Update references to Python constants

Update references to the Python constants introduced by the previous
patch.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
f361a6ee 09/12/2013 01:51 pm Jose A. Lopes

Haskell to Python constants: more constants

  • move several groups of constants, from Python to Haskell, which are
    currently being used in Haskell, including SSH and daemon related
    constants, policy allocation, blockdev driver manual (this is a
    single constant), auto repair related constants, and data collector...
b2e7599d 09/12/2013 12:24 pm Thomas Thrainer

Merge branch 'stable-2.8' into stable-2.9

  • stable-2.8
    Make tools/users-setup explain its actions first
    Generate tools/users-setup from descriptions
    Provide ganeti user and group data in easy-to-parse form
    Remove dsahostkeypub during config downgrade...
9317e5dc 09/11/2013 07:11 pm Klaus Aehlig

Make tools/users-setup explain its actions first

Before doing any changes, make tools/users-setup explain its
actions first, and ask the user for confirmation. If the first
argument is --yes-do-it, this step will be skipped.

Signed-off-by: Klaus Aehlig <>...
7822dd66 09/11/2013 07:11 pm Klaus Aehlig

Generate tools/users-setup from descriptions

Now that we have a machine readable description of the users
to be added to the system, use it to generate the tools/users-setup
script, so that we again have only one authoritative source of
the user and group requirements. This also has the advantage of...
d2f465dc 09/11/2013 07:11 pm Klaus Aehlig

Provide ganeti user and group data in easy-to-parse form

Upon build time, also generate, in the directory doc/users, files
containing the groups, the users with their primary group, and the
additional groupmemberships to be added. In this way, packages can use...
6970c28b 09/11/2013 11:16 am Jose A. Lopes

Inconsistent auto repair related constant

In 'lib/constants.py', fix inconsistency in the value of
'AUTO_REPAIR_TAG_SUSPENDED'. Fixes issue 569.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
d5b17094 09/11/2013 11:02 am Jose A. Lopes

Update constant references

Update Python user separation constants to reference the generated
module 'lib/_constants.py' instead of 'lib/_autoconf.py'.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
26eca119 09/11/2013 11:01 am Jose A. Lopes

Add user separation constants

Add user separation constants, such as, 'daemonsGroup', 'rapiGroup',
and 'rapiUser', to the Haskell to Python constant generation
infrastructure.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
ca2d5dcc 09/11/2013 11:01 am Jose A. Lopes

Add target 'AutoConf.hs'

Add Makefile target to generate 'AutoConf.hs' and add this file to
'.gitignore'.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
fa70fff2 09/11/2013 11:00 am Jose A. Lopes

Add AutoConf.hs.in

Add 'AutoConf.hs.in' which is the template for generating the file
'AutoConf.hs'. This file mimics the Python equivalent
'lib/_autoconf.py' and it is necessary for Haskell constants to be
able to retrieve their values from 'configure'....
3e5b34c3 09/10/2013 02:33 pm Klaus Aehlig

Also clean up top-level *.tix files

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>
2b1c5a63 09/10/2013 11:58 am Jose A. Lopes

Haskell to Python constants: Update 'ADMINST_ALL' reference

Update constant 'ADMINST_ALL' to take its value from the generated
'lib/_constants.py' module.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
9413ef24 09/10/2013 11:58 am Jose A. Lopes

Haskell to Python constants: add 'adminstAll'

Add constant 'adminstAll' to Haskell to Python constant generation.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
f2b6e7d4 09/10/2013 11:58 am Jose A. Lopes

Add 'FrozenSet'

Add type 'FrozenSet' that wrap a Haskell 'Set', and a guarded
constructor for this type and a 'PyValue' instance.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
4c9fdf69 09/10/2013 11:58 am Jose A. Lopes

Fix module documentation

Fix 'Ganeti.Hs2Py.ListContants.hs.in' template module documentation to
warn about automatic module generation.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
88284d52 09/10/2013 11:58 am Jose A. Lopes

Fix module documentation

Fix 'lib/_constants.py.in' documentation to be consistent with other
modules.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
c93041a5 09/10/2013 11:58 am Jose A. Lopes

Fix module documentation

Fix 'HsConstants' module documentation to warn about proper module
usage.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Klaus Aehlig <>
4651c69f 09/10/2013 11:58 am Jose A. Lopes

Wrap 'Set' in 'ListSet' for the opcodes

In what Haskell to Python opcodes are concerned, a Haskell 'Set' is
translated into a Python 'list'. In other words, currently, opcodes
that handle sets of parameters are actually handling lists because
this is how sets are currently encoded. This patch introduces a new...
3a933ed8 09/10/2013 11:58 am Jose A. Lopes

Fix 'List' instance of 'PyValue'

Fix 'List' instance of 'PyValue' to properly convert Haskell lists to
Python lists.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Guido Trotter <>
b2fbea47 09/09/2013 07:47 pm Jose A. Lopes

Replace literals with constants

In "lib/cmdlib/node.py", in lines 1315-1316, 1354, and 1359-1370,
replace string literals with constants. Fixes issue 558.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Michele Tartara <>
e46de62a 09/09/2013 12:28 pm Sebastian Gebhard

Fix bridging in net-common

Bridging does not work correctly in net-common. The parameters passed
by Ganeti are put in /var/run/ganeti/xen-hypervisor/nic/$domname/$devid
and read again from there before running the setup functions according
to the $MODE which is read from the file....
78237f71 09/09/2013 12:22 pm Apollon Oikonomopoulos

Remove dsahostkeypub during config downgrade

Remove the newly-added DSA host public key field from the configuration file
when downgrading to 2.7, if present. Otherwise masterd will refuse to start.

Signed-off-by: Apollon Oikonomopoulos <>...
3022ea9f 09/09/2013 12:22 pm Apollon Oikonomopoulos

Mark the DSA host pubkey as optional

Commit a9542a4 introduced support for DSA SSH keys. However, the dsahostkeypub
field added to the config is not marked as optional in the Haskell components.
As a result, luxid thinks the config file is corrupt and refuses to start. We...
e2bbdded 08/30/2013 04:41 pm Michele Tartara

Sync build_chroot with buildbot slack role

Keep the build_chroot script as similar as possible to the buildbot's slack role
for squeeze.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>
02eb0fe5 08/30/2013 03:15 pm Klaus Aehlig

Don't install dangling symlink for hail

hail is installed to the iallocators directory, not to the binary
directory. Hence, if --enable-symlinks is given (the default), do
not install a symbolic links there either.

Signed-off-by: Klaus Aehlig <>...
73d6b4a7 08/29/2013 04:13 pm Helga Velroyen

Auto-upgrade of disks' config wrt LD-renaming

This patch adds auto-upgrade functionality to the disk
objects with respected to the switch from LD constants
to DT constants. Unit tests are provided.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Guido Trotter <>
ce1b0c05 08/29/2013 04:05 pm Jose A. Lopes

Haskell to Python opcodes: fix Unit

Fix how Haskell to Python opcode generation handles unit. It seems
that, in 'template-haskell-2.7.0', unit is represented by Template
Haskell as a constructor of the form '(ConT name)', where 'name' is
the constructor name for 'Unit'. However, in 'template-haskell-2.8.0'...
73b63a40 08/29/2013 01:17 pm Jose A. Lopes

Import original constants instead of generated

Haskell to Python constant generation introduced duplicated constants
in Haskell. This patch eliminates the duplication and fixes Haskell
to import the correct constants, instead of the generated ones.

Signed-off-by: Jose A. Lopes <>...
acf9af53 08/29/2013 01:17 pm Jose A. Lopes

Update Python constants references to '_constants.py'

Update Python constants 'ADMINST_{DOWN,UP,OFFLINE}' to take their
values from the Haskell generated module 'lib/_constants.py'.

Signed-off-by: Jose A. Lopes <>
Reviewed-by: Guido Trotter <>
1b2adaa6 08/29/2013 01:17 pm Jose A. Lopes

Setup constant generation infrastructure

Setup a transitional Haskell to Python constant generation
infrastructure. This infrastructure is transitional and Python
constants will not be migrated to Haskell all at once. Instead, some
constants will be incrementally pulled from Python and moved to...
fec1fac1 08/29/2013 01:17 pm Jose A. Lopes

Rename 'Constants.hs' to 'PyConstants.hs'

Rename the generated 'Constants.hs' module, which contains the Haskell
constants generated from Python, to 'PyConstants.hs' in order to
eliminate duplicated constants in Haskell, a problem introduced by the
Haskell to Python constant generation, and to circumvent a problem...
d34c79b6 08/29/2013 01:17 pm Jose A. Lopes

Add Template Haskell code for constant generation

Add Template Haskell functions that generate a list in Haskell
containing all the constants to be generated in Python. This list is
an association list mapping the constant name to its Python value,
which is stored as a string....
c4d68e39 08/29/2013 01:17 pm Jose A. Lopes

Move some 'PyValue' instances to a separate file

Move some 'PyValue' instances to a separate file so they can be
available to other modules which need these instances but do not want
to depend on the constants module, which led to compilation
constraints....
880ab678 08/29/2013 12:02 pm Helga Velroyen

Fix tests regarding DISK_LD_DEFAULTS

This fixes two remaining issues regarding the renaming
of DISK_LD_DEFAULTS:

- The keys of the map DISK_LD_DEFAULTS cannot be compared
to DISK_TEMPLATES right away, because there are no
defaults for the diskless template. This patch adjusts...
6da90c0a 08/28/2013 10:13 pm Helga Velroyen

Fixing renaming of DISK_LD_DEFAULTS

This fixes the somewhat over-eager renaming of
DISK_LD_DEFAULTS to DISK_DT_DEFAULTS, which clashes
with another occurence of DISK_DT_DEFAULTS. This
patch just undoes the renaming and additionally fixes
a test regarding shared file storage....
3abb0a5c 08/28/2013 06:31 pm Leon Handreke

Fix documentation for gnt-node evacuate -p option

Update the documentation to remove the claim that the --primary-only
option results in data copies while in fact it only fails over/migrates
the all primary instances.

Signed-off-by: Leon Handreke <>...
cd3b4ff4 08/28/2013 06:19 pm Helga Velroyen

Replace LD_* constants with DT_* constants

LD_* constants are basically like DT_* constants, except
for that both file and shared file were mapped to file.
In order to not having to maintain three slightly different
sets of disk-related constants (DT, LD and ST), we merge...
2de59e2c 08/28/2013 06:19 pm Helga Velroyen

QA: fix file storage QA wrt ipolicy

Ipolicy-allowed disk templates are now dependend on the
cluster-wide enabled disk-templates. The QA for file
storage did not consider this updated logic so far.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Guido Trotter <>
2408d766 08/28/2013 05:52 pm Klaus Aehlig

Bump versions to release 2.9~beta1

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Guido Trotter <>
036744e2 08/28/2013 05:52 pm Klaus Aehlig

Add design-2.9 to docinput

While design-2.9.rst was already created earlier, it
wasn't registered in the Makefile. Fix this.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Guido Trotter <>
eb0413c6 08/27/2013 05:16 pm Klaus Aehlig

Provide symlinks for all myexeclib_SCRIPTS

As we also install the nodist_myexeclib_SCRIPTS, we also need to
provide symbolic links for them if symlink installation is desired.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Guido Trotter <>
2c88200b 08/27/2013 04:50 pm Helga Velroyen

CLI: actually remove the --no-drbd-storage option

This removes the '--no-drbd-storage' option completely
from the command line interface. The hugepages design
doc still had a left-over reference to --no-lvm-storage,
which is removed in this patch as well....
38969795 08/27/2013 04:50 pm Helga Velroyen

cluster init/modify: set helper without DRBD being enabled

The logic around the DRBD usermode helper so far was that
setting it was only possible when DRDB was not explicitely
disabled. This patches changes it in a way that it is
consistent to how Ganeti handles the volume group name....
a25f44a4 08/27/2013 04:50 pm Helga Velroyen

QA: adapt changes wrt DRBD usermode helper

This adjusts and extends the QA for 'gnt-cluster modify'
with respect to the changes regarding the DRBD
usermode helper.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Thomas Thrainer <>
25e5e785 08/27/2013 04:50 pm Helga Velroyen

objects.py: upgrade config

Upgrading the config with respect to the DRBD usermode
helper was so far based on a guess whether or not DRBD
is enabled by checking if there are any DRBD instances
running. This check can now be replaced to look at the
list of enabled disk templates in the cluster's...
31ccfc0e 08/27/2013 04:50 pm Helga Velroyen

cluster modify: deprecate --no-drbd-storage

As in the previous patch, the option '--no-drbd-storage'
is deprectated, because it is subsumed by the non-inclusion
of 'drbd' in the list of enabled disk templates.

Signed-off-by: Helga Velroyen <>...
7796e1f8 08/27/2013 04:50 pm Helga Velroyen

cluster init: deprecate --no-drbd-storage

Whether or not a particular type of storage is enabled
or not is determined by the list of enabled disk templates
in the cluster's configuration. This makes the option
'--no-drbd-storage' obsolete, because it is subsumed by...
9af7ece3 08/27/2013 04:50 pm Helga Velroyen

cluster verify: check drbd helper only when drbd enabled

This change makes sure that 'gnt-cluster verify' only
checks for the DRBD usermode helper, if DRBD is actually
enabled.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Thomas Thrainer <>
7c577910 08/27/2013 04:50 pm Helga Velroyen

cmdlib/cluster.py: unit tests for usermode helper

This patch factors out the functions that deal with setting
and modifying the DRBD usermode helper in cluster.py in
order to make them more unittestable. The unit tests are
provided as well. No functional changes otherwise....
c121d42f 08/27/2013 04:50 pm Helga Velroyen

gnt_cluster.py: unit test for usermode helper

This patch factors out the functions in gnt_cluster
(related to cluster init and cluster modify) which
deal with setting / determining the drbd usermode helper
to make them more testable. Unit tests for the extracted...
af95196c 08/27/2013 04:50 pm Helga Velroyen

bootstrap.py: unit tests for setting the usermode helper

This patch factors out the function that checks the DRBD
usermode helper in bootstrap (cluster init) in order to make
it more testable. It also contains the unit tests. Otherwise,
no functional changes....
46204919 08/27/2013 03:08 pm Klaus Aehlig

In the manpages, use unversioned paths

Ganeti now installs all its files into a version-specific directory
and only adds symbolic links at the canonical installation places.
Nevertheless, make documentation, in particular man pages, still contain
the old places, i.e., the places where the symbolic links are added....
f148fe23 08/27/2013 03:04 pm Klaus Aehlig

Merge branch 'stable-2.8' into stable-2.9

  • stable-2.8
    Add function to unwrap Results logging failures
    Make the DRBD collector more failure-resilient
    Prepare GetLinuxNodeInfo for testing
    Add unit test for GetLinuxNodeInfo
    NEWS update and version bump for 2.8 rc2...
c3ae7998 08/27/2013 11:46 am Klaus Aehlig

Change versiondir to adhere the changed design

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Guido Trotter <>
4c4153b5 08/27/2013 11:46 am Klaus Aehlig

Change design to install to ${PREFIX}/lib/ganeti-${VERSION}

Even though the ${PREFIX}/opt/ only came into the design in the review
process, it is not the best choice, as /opt is reserverd for manually
installed software, but Ganeti intends to be packaged. Use ${libdir}...
0865101d 08/27/2013 11:28 am Michele Tartara

NEWS update and version bump for 2.8 rc2

Latest modifications and fixes added to the NEWS file.

Signed-off-by: Michele Tartara <>
Reviewed-by: Guido Trotter <>
6afb9fb4 08/27/2013 09:32 am Jose A. Lopes

Simplify '_CheckOutputFields'

Function '_CheckOutputFields' was receiving three field sets, two of
which were simply being merged together. This was complicated and
unnecessary. This patch simplifies '_CheckOutputFields' to take
simply two field sets.
...
dc3dcdaf 08/27/2013 09:32 am Jose A. Lopes

Add 'SF_NODE' to 'VALID_STORAGE_FIELDS'

Constant 'SF_NODE' is a storage field and, therefore, should be in
'VALID_STORAGE_FIELDS'. This patch fixes this and also reference to
these constants, namely, in 'cmdlib' and 'qa'.

Signed-off-by: Jose A. Lopes <>...
c2266ec8 08/27/2013 09:31 am Jose A. Lopes

Remove storage field duplication in 'qa'

QA was adding 'SF_TYPE' to a list containing all storage fields (i.e.,
'VALID_STORAGE_FIELDS'). However, 'SF_TYPE' is already part of
'VALID_STORAGE_FIELDS', which means this element was occurring twice
in the list....
0ac2ff3b 08/23/2013 03:16 pm Spyros Trigazis

Update iallocator design to include MonD data

Add "MonD data" sub-section.

Signed-off-by: Spyros Trigazis <>
Signed-off-by: Michele Tartara <>
Reviewed-by: Michele Tartara <>
78f99abb 08/23/2013 03:12 pm Michele Tartara

Lint improvements to regexps

Fix some regular expressions so that they pass lint checks with newer versions
of pylint.

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>
f51e9849 08/23/2013 10:27 am Klaus Aehlig

Add name for the Parameter ND_OVS

That was forgotten when the parameter was added.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>
03b0b21b 08/23/2013 09:56 am Klaus Aehlig

Add new node parameters to Object.hs

In commit 807d8853, new node parameters were introduced in the python world.
Add them to the haskell world as well to restore consistency.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>
902eb29f 08/22/2013 06:18 pm Michele Tartara

Add unit test for GetLinuxNodeInfo

The function was not unit tested previously.

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>
23cb5697 08/22/2013 06:17 pm Michele Tartara

Prepare GetLinuxNodeInfo for testing

The names of the input files are not hardcoded anymore, but they are now default
parameters.

No changes for the callers, but it's now possible to test the function more
easily.

Signed-off-by: Michele Tartara <>...
9cf292af 08/22/2013 06:02 pm Klaus Aehlig

Add configure option on whether to install symlinks

As of Ganeti 2.10, all files are installed into a single, version
specific, directory. In this way, several Ganeti versions can be
installed in parallel. Appropriate symbolic links in the search path
will be added by the Ganeti upgrade procedure. For the initial...
667e9959 08/22/2013 06:01 pm Klaus Aehlig

Move installation to a single Ganeti specific directory

As first step of implementing the new upgrade procedure (see design
document), make Ganeti install all files into a single directory,
$(prefix)/opt/Ganeti-$(VERSION). Symbolic links outside to this directory...
7bb0c47f 08/22/2013 03:03 pm Thomas Thrainer

Check right disk template in inst set params

While checking the parameters of the opcode for LUInstanceSetParams, the
already set disk_template was checked instead of the new one in the
opcode. This patch fixes this bug.

Signed-off-by: Thomas Thrainer <>...
7699ab7b 08/21/2013 06:26 pm Sebastian Gebhard

Minor documentations fixed to gnt-node man page

Fix two grammatical errors in gnt-node man page

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>
2e5fc2ed 08/21/2013 06:26 pm Sebastian Gebhard

Documentation of new node parameters

This will add the new node parameters to the ganeti man page.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>
c760c1aa 08/21/2013 06:26 pm Sebastian Gebhard

Add parameters for OpenvSwitch to gnt-node

Extend gnt-node by parameters for OpenvSwitch. --ovs Flag to enable
OpenvSwitch, --ovs-name for the name of the OpenvSwitch and --ovs-link
for the interface to connect to.

Signed-off-by: Sebastian Gebhard <>...
90d8d4d1 08/21/2013 06:26 pm Sebastian Gebhard

Add RPC functionality for creating OpenvSwitches

This patches adds the needed RPC functions in order to create the
OpenvSwitches on the nodes.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>
8baa9ca7 08/21/2013 06:26 pm Sebastian Gebhard

Add OpenvSwitch functionality to LUNodeAdd

This patch adds functionality to LUNodeAdd to
- check the arguments given. It will warn if no physical link is given
and fail if OpenvSwitch is not enabled, but parameters are given
- call the RPC to configure OpenvSwitch on the node...
4daa5eb9 08/21/2013 06:26 pm Sebastian Gebhard

Backend: Create openvswitches on the nodes

This is the functionality to create the OpenvSwitches on the nodes.
Parameters are given via opcode and checked as well as extended with
the defaults.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>...
807d8853 08/21/2013 06:21 pm Sebastian Gebhard

Add params for OpenvSwitch to ndparams

This patch introduces the needed fields for OpenvSwitch parameters
into ndparams and also provides the default values.

The parameters are:
ND_OVS: boolean, to show whether OpenvSwitch is enabled or not
ND_OVS_NAME: the name of the OpenvSwitch to create...