| Branch: | Tag: | Revision:

root @ 37696594

Name Size
.ghci 21 Bytes
.gitignore 2.1 kB
INSTALL 9.9 kB 56.6 kB
NEWS 96.2 kB
README 189 Bytes
UPGRADE 7.4 kB 283 Bytes 23.6 kB 444 Bytes
pylintrc 2.8 kB

Latest revisions

# Date Author Comment
37696594 03/18/2013 04:45 am Dimitris Aragiorgis

Update py_compat_networks test

Use renamed methods of network module and fix genValidNetwork.

In network module during _Validate we check whether gateway/network
pairs (both v4 and v6) are valid. Having a gateway without a network
is considered invalid....

a979fe4e 03/18/2013 04:45 am Dimitris Aragiorgis

Rename private methods in network module

Most methods are used internally by the class it self; make those
methods start with a '_'. This will make things easier when we
support abstract networks and we have to know which method
are externally used and should be implemented....

85c4ae9b 03/18/2013 04:45 am Dimitris Aragiorgis

Refactor network module

Merge InitializePool inside init. Introduce new helper
funtion _InitializeReservations which creates the corresponding
nobj entries if they do not exist and reserves gateway, network,
and broadcast addresses.

Signed-off-by: Dimitris Aragiorgis <>

ddfa03fd 03/18/2013 04:45 am Dimitris Aragiorgis

Add Check method in network module

This checks if the given address/network pair is valid.
If not it raises OpPrereqError. This is used in LUNetworkSetParams
to check if a modification is valid. This is done in CheckPrereq
and not in Exec via pool.Validate because in case of invalid pool...

ac0f4fe5 03/18/2013 04:45 am Dimitris Aragiorgis

Delegate IsReserved() check in ReserveIp()

..and raise OpPrereqError. Thus remove any if pool.IsReserved()..
and try-except-raise in LUNetworkSetParams().

Signed-off-by: Dimitris Aragiorgis <>

3d736ac9 03/18/2013 04:45 am Dimitris Aragiorgis

Make ReserveIp/GenerateIp raise OpPrereqError

Both catch AddressPool errors and raise OpPrereqError with
the corresponding message. Remove any unnecessary try-except
when invoking these two config methods.

Signed-off-by: Dimitris Aragiorgis <>

e5e39af4 03/18/2013 04:45 am Dimitris Aragiorgis

Add _AllIPs() config method

This returns a list of tuples (ip, network). Use it in ReserveIp,
where a network without AddressPool can be passed, in order to
ensure IP uniqueness inside the network. Please note that no
configuration error is raised if a two NICs have the same IP but do...

83695d19 03/18/2013 04:45 am Dimitris Aragiorgis

Make GetStats() an AddressPool method

..and remove it from cmdlib

Signed-off-by: Dimitris Aragiorgis <>

e79955a6 03/18/2013 04:45 am Dimitris Aragiorgis

Use HooksDict() everywhere

To do so network object should be available just after CheckPrereq().
Thus move object creation away from Exec() in LUNetworkAdd.

Signed-off-by: Dimitris Aragiorgis <>

7ee959dc 03/18/2013 04:45 am Dimitris Aragiorgis

Support reserve/release external IPs

Modify ReserveIp/ReleaseIp/GenerateIp/UnlockedCommitIp to take
an additional argument; the external flag.
Update invocations of the corresponding methods in cmdlib.
Use new methods in LUNetworkSetParams with external flag set....

View all revisions | View revisions

Also available in: Atom