« Previous | Next » 

Revision 3fffa0c6

Parent e7d34815
Child d2234191

Added by Santi Raffa about 7 years ago

ComputeLDParams: do not spell out disk templates

A large part of the complexity in this function is due to the need
to translate from "template-specific" parameter names to
"template-agnostic" parameter names. This logic is complex and having
complex code for complex logic is okay.

However, for all other cases, the additional complexity is not needed.
Additionally this function would do the wrong thing silently for new,
unhandled disk templates by just not changing the resulting paramters.

This commit replaces the ad-hoc logic with a more generally useful
logic while leaving the DRBD code carefully alone.

Signed-off-by: Santi Raffa <>
Signed-off-by: Thomas Thrainer <>
Reviewed-by: Thomas Thrainer <>


  • added
  • modified
  • copied
  • renamed
  • deleted

View differences