Revision 7260cfbe daemons/ganeti-masterd

b/daemons/ganeti-masterd
26 26

  
27 27
"""
28 28

  
29
# pylint: disable-msg=C0103
30
# C0103: Invalid name ganeti-masterd
29 31

  
30 32
import os
31 33
import sys
......
61 63

  
62 64

  
63 65
class ClientRequestWorker(workerpool.BaseWorker):
66
   # pylint: disable-msg=W0221
64 67
  def RunTask(self, server, request, client_address):
65 68
    """Process the request.
66 69

  
......
70 73
    try:
71 74
      server.finish_request(request, client_address)
72 75
      server.close_request(request)
73
    except:
76
    except: # pylint: disable-msg=W0702
74 77
      server.handle_error(request, client_address)
75 78
      server.close_request(request)
76 79

  
......
108 111
    self.request_workers.AddTask(self, request, client_address)
109 112

  
110 113
  @utils.SignalHandled([signal.SIGINT, signal.SIGTERM])
111
  def serve_forever(self, signal_handlers=None):
114
  def serve_forever(self, signal_handlers=None): # pylint: disable-msg=W0221
112 115
    """Handle one request at a time until told to quit."""
113 116
    assert isinstance(signal_handlers, dict) and \
114 117
           len(signal_handlers) > 0, \
......
141 144
  READ_SIZE = 4096
142 145

  
143 146
  def setup(self):
147
    # pylint: disable-msg=W0201
148
    # setup() is the api for initialising for this class
144 149
    self._buffer = ""
145 150
    self._msgs = collections.deque()
146 151
    self._ops = ClientOps(self.server)
......
204 209
  def __init__(self, server):
205 210
    self.server = server
206 211

  
207
  def handle_request(self, method, args):
212
  def handle_request(self, method, args): # pylint: disable-msg=R0911
208 213
    queue = self.server.context.jobqueue
209 214

  
210 215
    # TODO: Parameter validation
211 216

  
217
    # TODO: Rewrite to not exit in each 'if/elif' branch
218

  
212 219
    if method == luxi.REQ_SUBMIT_JOB:
213 220
      logging.info("Received new job")
214 221
      ops = [opcodes.OpCode.LoadOpCode(state) for state in args]
......
333 340
  This class creates and holds common objects shared by all threads.
334 341

  
335 342
  """
343
  # pylint: disable-msg=W0212
344
  # we do want to ensure a singleton here
336 345
  _instance = None
337 346

  
338 347
  def __init__(self):
......
498 507
      # Call function
499 508
      result = int(bool(fn()))
500 509
      assert result in (0, 1)
501
    except:
510
    except: # pylint: disable-msg=W0702
502 511
      logging.exception("Error while calling function in separate process")
503 512
      # 0 and 1 are reserved for the return value
504 513
      result = 33
505 514

  
506
    os._exit(result)
515
    os._exit(result) # pylint: disable-msg=W0212
507 516

  
508 517
  # Parent process
509 518

  
......
544 553

  
545 554
    confirmation = sys.stdin.readline().strip()
546 555
    if confirmation != "YES":
547
      print >>sys.stderr, "Aborting."
556
      print >> sys.stderr, "Aborting."
548 557
      sys.exit(constants.EXIT_FAILURE)
549 558

  
550 559
    return

Also available in: Unified diff