Statistics
| Branch: | Tag: | Revision:

root / lib @ 91c622a8

# Date Author Comment
91c622a8 07/28/2010 11:19 pm Iustin Pop

Improve handling of lost jobs

Currently, if the cli.JobExecutor class is being used, and one of the
jobs is being archived before it can check its result, it will raise a
stracktrace as _ChooseJob is not prepared to handle this case.

This case makes JobExecutor work better with lost jobs (it still reports...

5a1c22fe 07/28/2010 08:16 pm Iustin Pop

luxi: convert permission errors into exception

This patch adds handling of permission errors so that we don't show
tracebacks when a non-root user runs a gnt-* command. Since in the
future we'll have different permissions, we need to handle this in RAPI
too....

6a016df9 07/28/2010 07:10 pm Michael Hanselmann

cmdlib: Return new name from rename operations

The new name is then displayed by the clients.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Manuel Franceschini <>

3fe11ba3 07/28/2010 06:40 pm Manuel Franceschini

gnt-instance rename: Fix bug and rename params

This patch fixes a bug when gnt-instance rename was invoked with
--no-name-check. It renames the internal variables to be consistent with
the ones in equivalent instance add code. Furthermore it checks whether...

f38ea602 07/26/2010 05:55 pm Iustin Pop

Add modification of the reserved logical volumes

This doesn't allow addition/removal of individual volumes, only
wholesale replace of the entire list. It can be improved later, if we
ever get generic container parameters.

The man page changes replaces some tabs with spaces (hence the...

5a3ab484 07/26/2010 05:54 pm Iustin Pop

Add printing of reserved_lvs in cluster info

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

999b183c 07/26/2010 05:54 pm Iustin Pop

Introuce a new cluster parameter - reserved_lvs

This parameter, which is a list of regular expression patterns, will
make cluster verify ignore any such LVs. It will not prevent creation or
removal of such volumes by the backend code.

Signed-off-by: Iustin Pop <>...

91492e57 07/26/2010 05:50 pm Iustin Pop

Change the meaning of call_node_start_master

Currently, backend.StartMaster (the function behind this RPC call) will
activate the master IP and then, if the start_daemons parameter is true,
it will also activate the master role.

While this works, it has two issues:...

e0e916fe 07/26/2010 05:45 pm Iustin Pop

Move the UsesRPC decorator from cli to rpc

This is needed because not just the cli scripts need this decorator, but
the master daemon too (and it already duplicated the code once).

In cli.py we just leave a stub, so that we don't have to modify all the
scripts to import rpc.py....

52194140 07/23/2010 08:26 pm Iustin Pop

Update the RAPI node migrate for the 'live' change

This patch adds handling of the new 'mode' parameter to the RAPI server,
while keeping compatibility with the old mode. Note that in the old mode
(when 'live' is being passed), the auto-mode doesn't work....

1f334d96 07/23/2010 08:26 pm Iustin Pop

Update the RAPI client for the migration mode

See the discussion on the previous patch about this. Basically unless we
want to a add a new 'feature' marking for the live migration parameter,
there is no simple way to handle this nicely in the client.

Given that the client was/is marked as experimental, this patch simply...

8c35561f 07/23/2010 08:26 pm Iustin Pop

Rename the OpMigrate* parameter 'live' to 'mode'

This is needed as now the parameter is no longer boolean, but tri-state.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

783a6c0b 07/23/2010 08:26 pm Iustin Pop

Rename migration type to migration mode

This is in preparation for the rename of the opcode 'live' parameter to
'mode'.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

2ea65c7d 07/23/2010 03:19 pm Manuel Franceschini

utils: Fix incorrect docstring

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Iustin Pop <>

089e5e50 07/22/2010 08:33 pm Iustin Pop

Merge branch 'devel-2.1' into master

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

6e04dc39 07/22/2010 08:21 pm Iustin Pop

Fix issue when changing the disk template to drbd

If we pass the current primary node, the conversion will fail horribly
with LVM creation errors. Instead, we catch and check for this
condition in CheckPrereq.

Signed-off-by: Iustin Pop <>...

600535f0 07/21/2010 12:34 pm Manuel Franceschini

Always set commonName in X509 certificates

Due to the current switch of the RPC client to PycURL, a bug with newer
versions of libcurl surfaced. When the 'Subject' or 'Issuer' of
'server.pem' were empty, SSL handshake failed.

This patch changes the certificate generation functions such that they...

2089573e 07/20/2010 12:34 pm René Nussbaumer

Adding constants for setup-ssh

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

3727671e 07/20/2010 12:34 pm René Nussbaumer

Change AddAuthorizedKey to also allow filehandles

This is required to use this function over paramiko
sftp file handles.

Signed-off-by: René Nussbaumer <>
Reviewed-by: Michael Hanselmann <>

8306e0e4 07/19/2010 04:49 pm Michael Hanselmann

RAPI client: Encode empty body to JSON

If the body consists of an empty dict, it should also be encoded.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

84a12e40 07/19/2010 04:24 pm Iustin Pop

Introduce git reference/tag tracking for debugging

This patch adds a new vcs-version file that is generated via git (and
can be adapted if VCS is changed) and then embebbded as VCS_VERSION in
the constants module.

This means two things:
- local modifications without committing to git (or when using a tar.gz...

0ad22aab 07/16/2010 06:59 pm Luca Bigliardi

Fix epydoc warning "Lists must be indented."

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Michael Hanselmann <>

33231500 07/16/2010 06:18 pm Michael Hanselmann

Convert RPC client to PycURL

Instead of using our custom HTTP client, using PycURL's multi
interface allows us to get rid of the HTTP client threadpool.
The majority of the code is still in the ganeti.http.client
module.

A simple per-thread HTTP client pool gives cURL a chance to...

7f93570a 07/16/2010 04:56 pm Iustin Pop

Implement lock names for debugging purposes

This patch adds lock names to SharedLocks and LockSets, that can be used
later for displaying the actual locks being held/used in places where we
only have the lock, and not the entire context of the locking operation....

067d927b 07/16/2010 03:05 pm Michael Hanselmann

Fix pylint complaints introduced in commit e58f87a958c

Due to a small mistake I missed three non-critical pylint complaints for
commit e58f87a958c. They're fixed with this patch.

Signed-off-by: Michael Hanselmann <>
Signed-off-by: Iustin Pop <>...

e3ed5316 07/16/2010 12:48 pm Balazs Lecz

LXC: Add cpu_mask hypervisor parameter

Also implement syntax checking.

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

31155d60 07/16/2010 12:47 pm Balazs Lecz

Add ParseCpuMask() utility function

Also adds a generic ParseError exception.

Signed-off-by: Balazs Lecz <>
Reviewed-by: Michael Hanselmann <>

e71b9ef4 07/16/2010 10:46 am Iustin Pop

Add a migration type global hypervisor parameter

Since migration live/non-live is more stable (e.g.) for Xen-PVM versus
Xen-HVM, we introduce a new parameter for what mode we should use by
default (if not overridden by the user, in the opcode).

The meaning of the opcode 'live' field changes from boolean to either...

e58f87a9 07/15/2010 07:27 pm Michael Hanselmann

Add test for some aspects of job queue

This new opcode and gnt-debug sub-command test some aspects of the
job queue, including the status of a job. The bug fixed in commit
2034c70d507 was identified using this test. A future patch will
run this test automatically from the QA scripts....

9dd6889b 07/15/2010 07:18 pm Luca Bigliardi

LUVerifyCluster: update _ValidateNode description

Change _ValidateNode description to reflect what the function actually does.

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

748e4b5a 07/15/2010 05:38 pm Michael Hanselmann

KVM hypervisor: Use utils.ShellWriter for network script

This patch converts hv_kvm to use utils.ShellWriter for writing
the network script. It also adds a few unittests (the first
for any hypervisor modules).

Signed-off-by: Michael Hanselmann <>...

858905fb 07/15/2010 05:38 pm Michael Hanselmann

Move ShellWriter class to utils

Also add unittest.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

989a8bee 07/15/2010 05:37 pm Michael Hanselmann

jqueue: Factorize code waiting for job changes

By splitting the _WaitForJobChangesHelper class into multiple smaller
classes, we gain in several places:

- Simpler code, less interaction between functions and variables
- Easy to unittest (close to 100% coverage)...

54dc4fdb 07/13/2010 11:39 pm Michael Hanselmann

Merge remote branch 'origin/devel-2.1'

  • origin/devel-2.1:
    RAPI client: Implement old instance creation request format
    rlib2: Use constants for disk and NIC parameters

Conflicts:
test/ganeti.rapi.client_unittest.py: Trivial
test/ganeti.rapi.rlib2_unittest.py: Trivial...

48436b97 07/13/2010 09:55 pm Michael Hanselmann

RAPI client: Implement old instance creation request format

Commit 8a47b4478 implemented instance creation in the RAPI client,
but it left out support for the old instance creation request format.
This patch now implements the old format as good as possible. This...

7be048f0 07/13/2010 05:26 pm Michael Hanselmann

rlib2: Use constants for disk and NIC parameters

These constants were added in commit bd061c35, but the parsing code
was not updated. This also fixes a bug where a NIC's MAC address
wasn't used.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

926feaf1 07/12/2010 06:59 pm Manuel Franceschini

Use reserved documentation IPs and domains

Use RFC 5737 IP addresses and RFC 2606 domain names in all
unittests, docs, qa and docstrings.

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Iustin Pop <>

7b4c1cb9 07/12/2010 05:32 pm Michael Hanselmann

Provide feedback function for all LU methods

By exposing mcpu's _Feedback function (now renamed to “Log”) to LU's,
methods like ExpandNames can also write to the job execution log.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

2034c70d 07/12/2010 05:27 pm Michael Hanselmann

jqueue: Setup inotify before checking for any job changes

Since the code waiting for job changes was modified to use inotify,
a race condition between checking for changes the first time and
setting up inotify occurs. If the job is modified after the check...

583163a6 07/12/2010 05:27 pm Michael Hanselmann

cli.SubmitOpCode: Support custom job reporter

This is necessary to reuse SubmitOpCode while adding processing for
custom message types.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

8a7f1c61 07/12/2010 05:27 pm Michael Hanselmann

Add function to format all job log messages

Just calling utils.SafeEncode on the log message failed when it
wasn't of the type ELOG_MESSAGE and not a string. Now non-message
log entries are formatted using repr().

Signed-off-by: Michael Hanselmann <>...

e51ca051 07/12/2010 05:27 pm Michael Hanselmann

baserlib: Fix feedback function

The feedback function is called with only one parameter, a tuple
with the message details.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

d8bcfe21 07/12/2010 03:58 pm Manuel Franceschini

Confd IPv6 support

This patch series basically adds a new parameter 'family' to the constructors
of daemon.AsyncUDPSocket and confd.client.ConfdUDPClient. This enables the
users of these two classes to support IPv6.

In ganeti-confd.ConfdAsyncUDPClient a method to check the address families of...

13c564e7 07/09/2010 06:17 pm Balazs Lecz

LXC: Create per-instance log files

This replaces the single global log file with per-instance logs.
The instance log file is not truncated when the instance is started.

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

c83864fe 07/09/2010 06:17 pm Balazs Lecz

LXC: Fix wording of error messages

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

b8aa46ed 07/09/2010 06:17 pm Balazs Lecz

LXC: Fix GetInstanceInfo()

Don't try to get cgroups info if instance is not running.

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

a744b676 07/09/2010 04:37 pm Manuel Franceschini

Introduce lib/netutils.py

This patch moves network utility functions to a dedicated module.

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Iustin Pop <>

63cef6c3 07/08/2010 06:57 pm Balazs Lecz

LXC: Fix GetAllInstancesInfo()

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

4ea3de4e 07/08/2010 06:57 pm Balazs Lecz

Add oper_vcpus instance status field

This introduces a new instance status field, named "oper_vcpus".
It contains the actual number of VCPUs an instance is using as
seen by the hypervisor.

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

1c1b3cab 07/08/2010 04:45 pm Apollon Oikonomopoulos

LUCreateInstance: use cluster-wide iallocator

LUCreateInstance uses the cluster-wide default iallocator if no iallocator or
primary node is specified manually.

Signed-off-by: Apollon Oikonomopoulos <>
Signed-off-by: Iustin Pop <>...

63ac47cc 07/08/2010 04:45 pm Apollon Oikonomopoulos

LUNodeEvacuationStrategy: Use default iallocator

Signed-off-by: Apollon Oikonomopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

bf4af505 07/08/2010 04:45 pm Apollon Oikonomopoulos

Add default_iallocator cluster parameter

Add a cluster parameter to hold the iallocator that will be used by default
when required and no alternative (manually-specified iallocator or
manually-specified node(s)) is given.

Signed-off-by: Apollon Oikonomopoulos <>...

b6dd40f5 07/08/2010 04:45 pm Apollon Oikonomopoulos

Add _CheckIAllocatorOrNode for common iallocator/node checks

_CheckIAllocatorOrNode will be called by LUs wishing to use an instance
allocator or a target node. It performs sanity checks and will modify the LU's
opcode's iallocator slot to use the cluster-wide allocator if...

c4d3e57f 07/07/2010 09:07 pm Balazs Lecz

LXC: Report actual number of CPUs

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

7e5913a7 07/07/2010 05:50 pm Luca Bigliardi

Merge branch 'devel-2.1'

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

4c32a8bd 07/07/2010 05:45 pm Luca Bigliardi

Mlockall: decrease warnings if ctypes module is not present

Node daemon prints a lot of warnings if --no-mlock option is not specified and
ctypes module is not present.

With the following patch the warning is printed only at noded startup.

Signed-off-by: Luca Bigliardi <>...

0d422065 07/07/2010 04:45 pm Iustin Pop

Add a delay in master failover

I have seen some very seldom errors where (it seems) the address is
still live for a short while after removing it from the old master, thus
the new master will fail in startup/adding its own IP address.

To prevent against this, we add a delay/retry before we proceed, if the...

637c8ab8 07/07/2010 04:36 pm Balazs Lecz

LXC: add lxc.console to the generated lxc.conf file

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

d01baf53 07/07/2010 04:36 pm Balazs Lecz

LXC: Use lxc-info to get instance info

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

271daef8 07/06/2010 07:05 pm Iustin Pop

Fix opcode transition from WAITLOCK to RUNNING

With the recent changes in the job queue, an old bug surfaced: we never
serialized the status change when in NotifyStart, thus a crash of the
master would have left the job queue oblivious to the fact that the job...

53a8a54d 07/06/2010 07:05 pm Iustin Pop

cli.JobExecutor.WaitOrShow: always return status

Currently, for the 'wait' case, we return a list of tuples (status,
result), in the order of submitted jobs, but we don't return anything
for the no-wait case.

This patch changes the no-wait case to return a list of tuples (status,...

44247302 07/06/2010 07:05 pm Iustin Pop

Rework the export failure handling

Currently, the way to signal export failures is by the return value.
This means that if a client doesn't check the values (e.g. burnin), any
failure is being ignore. And this is what we've been doing forever in
burning (not actually testing that the export is successful)....

1b045f5d 07/06/2010 05:10 pm Balazs Lecz

Add utils.GetMounts()

Signed-off-by: Balazs Lecz <>
Reviewed-by: Michael Hanselmann <>

a188f1ef 07/06/2010 05:10 pm Balazs Lecz

LXC: use utils.GetMounts()

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

e8cd390d 07/06/2010 05:10 pm Balazs Lecz

hv_chroot: use utils.GetMounts()

Signed-off-by: Balazs Lecz <>
Reviewed-by: Iustin Pop <>

425f0f54 07/06/2010 03:28 pm Iustin Pop

Add a delay in master failover

I have seen some very seldom errors where (it seems) the address is
still live for a short while after removing it from the old master, thus
the new master will fail in startup/adding its own IP address.

To prevent against this, we add a delay/retry before we proceed, if the...

26591bfd 07/06/2010 12:25 pm Luca Bigliardi

Add drbd helper and storage options

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

d1871275 07/06/2010 12:25 pm Luca Bigliardi

Report drbd helper in query info LU

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

7b2cd2b4 07/06/2010 12:25 pm Luca Bigliardi

Check and set drbd helper in set params LU

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

a721e23a 07/06/2010 12:24 pm Luca Bigliardi

Check and set drbd helper during bootstrap

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

c46b9782 07/06/2010 12:24 pm Luca Bigliardi

Add drbd_helper rpc call

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

15cf9cbb 07/06/2010 12:24 pm Luca Bigliardi

Check drbd usermode helper in cluster verify

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

ee2f0ed4 07/06/2010 12:24 pm Luca Bigliardi

Set drbd usermode helper on config upgrade

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

51cb1581 07/06/2010 12:24 pm Luca Bigliardi

Generalize a recursive check on logical disks

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

9e33896b 07/06/2010 12:24 pm Luca Bigliardi

Add drbd_usermode_helper to configuration

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

7ef40fbe 07/06/2010 12:24 pm Luca Bigliardi

VerifyNode: add usermode helper reply

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

549071a0 07/06/2010 12:23 pm Luca Bigliardi

BaseDRBD: provide a way to query usermode_helper parameter

Signed-off-by: Luca Bigliardi <>
Reviewed-by: Iustin Pop <>

d3ce528b 07/05/2010 02:59 pm Iustin Pop

OpCreateInstance: do not require hv/be/os params

It is perfectly legal to create an instance using only defaults
(although beparams will be most times passed in), so let's relax the
requirement for these three parameters.

Signed-off-by: Iustin Pop <>...

3d16a983 07/02/2010 06:01 pm Iustin Pop

A few more type definitions

This is to simplify the type declarations in the actual LUs.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

e7736336 07/02/2010 06:01 pm Iustin Pop

Make _CheckDiskTemplate a valid type checker

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

b8812691 07/02/2010 06:01 pm Iustin Pop

Rework the "type" system

This patch merges the _OP_REQP and _OP_DEFS class attributes into a
_OP_PARAMS list, which holds both. The associated unittest checks that
all opcode attributes are declared and checked, and that no LU uses the
old fields (could be removed later)....

7486d752 07/02/2010 06:01 pm Iustin Pop

Remove _CheckBooleanOpField

This is no longer used, and we can remove it.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

801b6a33 07/01/2010 05:31 pm Guido Trotter

Merge branch 'stable-2.1'

  • stable-2.1:
    Bump up version for 2.1.5 release
    RapiClient: fix multi-authentication in Python 2.6
    Remove rapi-user and rapi-pass from qa-sample.json
    qa: fix gnt-instance modify -t drbd
    qa: shutdown instance before trying disk convert...
14ff387e 07/01/2010 04:49 pm Guido Trotter

RapiClient: fix multi-authentication in Python 2.6

In Python 2.6 the urllib2.HTTPBasicAuthHandler has a "retried" count for
failed authentications. The handler fails after 5 of them. To solve this
we reset the handler's "retried" member variable to 0 after every...

ac492887 07/01/2010 03:14 pm Michael Hanselmann

utils.OwnIpAddress: Change try/except for Python 2.4

Python 2.4 doesn't support “except” and “finally” in the same block.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

2a7c3583 07/01/2010 03:13 pm Michael Hanselmann

RAPI client: Switch to pycURL

Currently the RAPI client uses the urllib2 and httplib modules from
Python's standard library. They're used with pyOpenSSL in a very fragile
way, and there are known issues when receiving large responses from a RAPI
server.
...

b939de46 07/01/2010 03:12 pm Michael Hanselmann

baserlib: Use boolean type for boolean variables

This does not yet fix all issues in the RAPI interface which were
introduced with the type system. More testing is needed.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

1a1296c8 07/01/2010 01:20 pm Guido Trotter

Fix check in gnt-instance modify -t

Currently when changing the instance disks the instance status (which
must be down) is only checked if the target status is among the mirrored
ones. This is incorrect: the instance must be down either way, even if
the desired final status is non-mirrored....

9c5885e2 07/01/2010 12:28 pm René Nussbaumer

Adding check_name option to the opcode and luxi call for instance rename

This will allow instance rename without dns check as it does for instance
add.

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

56e4c4a0 06/30/2010 04:58 pm Manuel Franceschini

Enable utils.OwnIpAddress to work with IPv6 addresses

Currently a TcpPing using the target address as source is used to
determine wheter or not an IP address belongs to a node. This does not
work for IPv6 anymore (I'm not sure why) as binding to IPv6 localhost as...

4b5e40a5 06/30/2010 04:46 pm Iustin Pop

Barebones LXC hypervisor

This needs lots of work, but it can successfully launch an LXC-based
instance. See the docstring for the limitations/work to be done.

Signed-off-by: Iustin Pop <>
Reviewed-by: Balazs Lecz <>

5a672c30 06/30/2010 02:55 pm Manuel Franceschini

DRBD IPv6 support

Support IPv6 configuration for 'drbdsetup show' parser and add unittests
concerning that case. Renames some data files to use consistent names
clarifying their usage.

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Michael Hanselmann <>

cf0e6df7 06/30/2010 02:43 pm Manuel Franceschini

IPv6 support for utils.TcpPing()

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Michael Hanselmann <>

2632795d 06/30/2010 02:32 pm Manuel Franceschini

Add function to retrieve family of an ip address

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Guido Trotter <>

c0c3fa27 06/30/2010 02:32 pm Manuel Franceschini

Introduce utils.IsValidIP{4,6}()

This patch introduces functions to check for valid IPv4 and IPv6
addresses and converts IsValidIP() to return True if it is either a IPv4
or a IPv6 address.

For now we do not change the functional behavior and replace IsValidIP...

0fbd4b02 06/30/2010 01:55 pm Manuel Franceschini

Fix osparams bug when gnt-cluster modify'ing

Commit 625ac1135834c27a2e78fd61bf2df2ce29ad2966 introduced 'osparams'
slot in OPSetClusterParams which was not passed when invoked via
gnt-cluster modify.

Signed-off-by: Manuel Franceschini <>...

0d2cd893 06/30/2010 01:42 pm Manuel Franceschini

Introduce IPv6 constants

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Guido Trotter <>

14f5f1b6 06/30/2010 01:42 pm Manuel Franceschini

Replace '0.0.0.0' with constant

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Guido Trotter <>

9769bb78 06/30/2010 01:41 pm Manuel Franceschini

Rename some constants to facilitate IPv6 support

Signed-off-by: Manuel Franceschini <>
Reviewed-by: Guido Trotter <>

1ee8e01a 06/29/2010 07:53 pm Guido Trotter

Pass force variant option at instance creation

This was supposed to be done in
"06073e857e3b518c7195d57306ae01793240c0c2" but by mistake the field was
added to batch create rather than the normal instance create.

Signed-off-by: Guido Trotter <>...