Statistics
| Branch: | Tag: | Revision:

root @ 9b3939ea

# Date Author Comment
9b3939ea 11/22/2007 04:11 pm Michael Hanselmann

Call more hooks during QA tests.

Reviewed-by: schreiberal

f3299a07 11/22/2007 04:10 pm Michael Hanselmann

Sort list returned by ListVisibleFiles.

If we didn't sort this list, files would be in arbitrary order.

Reviewed-by: iustinp

4de0fa98 11/22/2007 03:51 pm Iustin Pop

Add man page for the ganeti-master script

This patch adds a simple man page for the master startup script and
modifies the footer.sgml fragment to include it.

Reviewed-by: imsnah

b81ef751 11/22/2007 03:51 pm Iustin Pop

Create /var/run/ganeti before noded startup

The /var/run directory can be a tmpfs mount, so even if we make it at
install time (or include it in the package) it can go away. Therefore,
test for its existence and create it in the startup script.

Reviewed-by: imsnah

d5a446f2 11/22/2007 03:51 pm Iustin Pop

Remove extra docdir variable from Makefile.am

The docdir variable is defined by autoconf, so we don't need to define
it ourselves. This way, the target documentation directory can
be changed via ./configure instead of patching Makefile.am.

In truth, we should install the pdf and html files using the pdf and...

f9fe750a 11/22/2007 02:17 pm Michael Hanselmann

List loading hooks in QA.

Reviewed-by: schreiberal

8bb7c6cb 11/22/2007 01:25 pm Michael Hanselmann

Add hook for logging.

This may help to debug problems in QA tests.

Reviewed-by: schreiberal

2ff95e62 11/21/2007 06:58 pm Michael Hanselmann

Abort if tests for disk templates remote_raid1 and drbd are enabled.

Reviewed-by: iustinp

84cc52ab 11/21/2007 06:57 pm Michael Hanselmann

Flush stdout after printing a message during burnin.

Reviewed-by: iustinp

23103544 11/21/2007 06:56 pm Michael Hanselmann

Implement disk templates for burnin from QA.

Reviewed-by: iustinp

12c3449a 11/21/2007 06:55 pm Michael Hanselmann

Replace disk template drbd8 with drbd where missing.

Reviewed-by: iustinp

01b69ec5 11/21/2007 05:29 pm Michael Hanselmann

Code style fixes for burnin.

Reviewed-by: iustinp

25d659a5 11/21/2007 05:29 pm Michael Hanselmann

Add two comments to qa-sample.yaml.

Reviewed-by: iustinp

a8459f1c 11/21/2007 01:34 pm Iustin Pop

Fix logging in drbd _ShutdownNet method

We didn't test for failure, just always logged the output.

Reviewed-by: imsnah

520de3bb 11/21/2007 11:36 am Iustin Pop

Correct the -s parameter in gnt-node output

This fixed the previous commit (-s => -s ip).

Reviewed-by: ultrotter

6174860c 11/21/2007 11:15 am Iustin Pop

Add the -s option in the output of 'gnt-node'

Since on dual-homed clusters one always needs to add '-s' to the
gnt-node add command, make this appear in the output of 'gnt-node' (when
run without arguments).

Reviewed-by: imsnah

3bd5f059 11/20/2007 04:49 pm Michael Hanselmann

Add description of “gnt-instance startup --force” to manpage.

This was reported by Henning Sprang in issue #14. Also add a missing word
in the description of “gnt-instance reboot”.

Reviewed-by: iustinp

7fbb1f65 11/20/2007 11:18 am Michael Hanselmann

Make sure aliases written to /etc/hosts are unique.

Reviewed-by: iustinp

f7414041 11/20/2007 11:17 am Michael Hanselmann

Add function to return list with unique elements.

Reviewed-by: ultrotter

7d7609a3 11/19/2007 08:38 pm Michael Hanselmann

Add basic QA tests for DRBD 8.

Reviewed-by: schreiberal

6852c52f 11/16/2007 08:36 pm Guido Trotter

Fix a typo in a warning message

Reviewed-by: schreiberal

6510a58a 11/16/2007 04:28 pm Michael Hanselmann

Don't remove master's hostname from /etc/hosts on cluster destroy.

This fixes issue #13.

Reviewed-by: schreiberal

dfea906f 11/16/2007 04:28 pm Michael Hanselmann

Use spaces to indent and fix typo in tag.

Reviewed-by: schreiberal

f89f17a8 11/16/2007 02:43 pm Michael Hanselmann

Fix typo in function name.

Reviewed-by: schreiberal

1df40cb5 11/15/2007 08:08 am Guido Trotter

Suggest disabling of automatic xen domain save

By default xen tries to save running virtual machines at system shutdown and
restore them at reboot. Make sure we suggest to disable this feature in the
installation manual.

Reviewed-by: iustinp

7ec54942 11/15/2007 08:04 am Guido Trotter

Complete the apt-get list in the install manual

The install manual was missing python-pyparsing and python-simplejson from the
apt-get install list. Adding them.

Thanks to Henning Sprang for spotting this issue.

Reviewed-by: iustinp

20a0c9ef 11/14/2007 11:52 pm Guido Trotter

When an assembly error occurs log it too

Right now an assembly error produces an exception but not a log message. This
is bad because the exception suggests looking at the log, but the log itself
has a lot of errors which are not really a problem and only some which really...

ebe8ef17 11/14/2007 05:56 pm Michael Hanselmann

Use setUp/tearDown for tests using temporary files.

Reviewed-by: schreiberal

667479d5 11/14/2007 05:55 pm Michael Hanselmann

Wrap line longer than 80 characters.

Reviewed-by: ultrotter

f0990e0c 11/14/2007 05:55 pm Michael Hanselmann

Compare file contents directly in unittests.

Reviewed-by: schreiberal, ultrotter

fcb1f331 11/14/2007 04:05 pm Michael Hanselmann

Give more details on errors when trying to run “lvdisplay”.

Reviewed-by: schreiberal

2fa9f1dd 11/14/2007 04:05 pm Michael Hanselmann

Create /var/run/ganeti directory on “make install”.

Reviewed-by: schreiberal

34bf35c0 11/14/2007 01:03 am Michael Hanselmann

Bump version numbers.

Reviewed-by: iustinp

28a6fbc8 11/13/2007 09:31 pm Michael Hanselmann

Run ganeti-watcher script from QA code instead of cron.

This makes the tests much more reliably because it avoids race conditions.
It also helps to speed them up a lot.

Reviewed-by: iustinp

7b195d9b 11/13/2007 09:31 pm Michael Hanselmann

Small changes and fixes in ganeti-watcher.

- Use constants for keys.
- Fix bug through which automatic instance restarts wouldn't be limited

Reviewed-by: iustinp

6623a5c1 11/13/2007 09:30 pm Michael Hanselmann

Fix call to TestInstanceConsecutiveFailures.

Reviewed-by: iustinp

9cd372ad 11/13/2007 05:39 pm Michael Hanselmann

Fix unittests broken by revision 360.

Reviewed-by: schreiberal

1e020d1b 11/13/2007 05:04 pm Michael Hanselmann

Fix --node option for “gnt-backup list”.

Reviewed-by: iustinp

7803d4d3 11/13/2007 01:11 am Iustin Pop

Fix a wrong comparison in _RecursiveAssembleBD

We want to prevent sending too many 'None' children to a device.
However, the test as it is today is wrong, as we want to test the
situation after adding a new child, and not before. This patch fixes
this by testing greater-or-equal instead of just greater....

7e3dbb94 11/13/2007 01:11 am Iustin Pop

Fix another breakage in SetEtcHostsEntry

The code assumes all lines have at least two elements which are
whitespace separated - i.e. it does not deal with empty lines or comment
lines with no spaces. This patch fixes this.

Also, the patch replaces the blank between IP and the canonical name...

2e3e75b7 11/12/2007 07:10 pm Michael Hanselmann

Call fsync() after modifying /etc/hosts.

This is a critical file. Breaking it would be very bad. Thus, if the system
crashes before the data is synched to the disk, it should have the complete
file afterwards.

Reviewed-by: iustinp

9440aeab 11/12/2007 07:09 pm Michael Hanselmann

Fix functions for /etc/hosts.

- Combine hostname and aliases on one line
- Fix bug with wrongfully removed newline characters
- Use wrapper for SetEtcHostsEntry in cmdlib

Reviewed-by: iustin

424908c1 11/12/2007 07:03 pm Michael Hanselmann

Rollback commit 356.

2d6cfa31 11/12/2007 06:44 pm Michael Hanselmann

Add functions for known_hosts files.

Reviewed-by: TODO

3e1cdf9f 11/12/2007 12:57 pm Michael Hanselmann

Add missing descriptions to {Add,Remove}EtcHostsEntry.

Reviewed-by: schreiberal

7df43a76 11/12/2007 05:56 am Iustin Pop

Relax replace_disks_all meaning for drbd8

In order to make the replace secondary action to be done via the same
opcode parameters for both remote_raid1 and drbd, we must allow the
LUReplaceDisks to change replace_disks_all for drbd with non-empty
remote_node into replace_disks_sec....

59885275 11/12/2007 05:36 am Guido Trotter

Change --nodes to --node

The --nodes option in gnt-backup really accepts only one node at a time.
Change it to --node, for added clarity and consistency with a similar
option in gnt-cluster. This patch also updates the relevant man page.

Reviewed-By: iustinp

6c4811dc 11/12/2007 03:19 am Iustin Pop

Update documentation for drbd8 and beta2 release

This patch does:
- add drbd8 information to the docs (the new disk template, examples,
etc.)
- fixes a section header to make it more clear
- update the NEWS file by changing format (format taken by looking at...

0b0dea6a 11/10/2007 08:05 pm Iustin Pop

Fix gnt-instance man page for replace-disks

This patch documents the new syntax for disk changes with the drbd disk
template.

Reviewed-by: ultrotter

f69dab6d 11/10/2007 07:54 pm Iustin Pop

Improve the man pages

This patch does some small fixes to the man pages and adds descriptions
for a few missing options.

Reviewed-by: ultrotter

2395c322 11/09/2007 10:13 pm Iustin Pop

Soften the requirements for hooks execution

Currently, an unreachable node (or one that return undetermined failure)
in the hooks pre-phase will abort the curren operation. This is not
good, as a down node could prevent many operation on the cluster.

This patch changes a RPC-level failure (and not a hook execution...

c8a0948f 11/09/2007 04:54 pm Michael Hanselmann

Use new functions to modify /etc/hosts.

Reviewed-by: schreiberal

899d2a81 11/09/2007 04:53 pm Michael Hanselmann

Add functions to modify /etc/hosts.

Reviewed-by: schreiberal

59f82e3f 11/09/2007 04:52 pm Michael Hanselmann

Cleanup temporary file in RemoveAuthorizedKey.

Reviewed-by: schreiberal

084bf7b2 11/09/2007 03:03 pm Michael Hanselmann

Fix usage of wrong variable in doc/examples/Makefile.am.

This makes “make distcheck” work again.

Reviewed-by: schreiberal

21546b1c 11/08/2007 09:04 pm Iustin Pop

Simplify burnin output

Currently, the burnin output is very verbose (we log the entire output
from LU feedback) and duplicate in some cases (as we enable debugging).

This patch disables debugging and only logs the burnin output when an
error occurs.

Reviewed-by: imsnah

5bfac263 11/08/2007 09:04 pm Iustin Pop

Changes related to logging

This patch modifes:
- mcpu.Processor.LogWarning to have its 'hint' parameter as optional
and only log it if not None
- cmdlib._WaitForSync to not log directly to stdout/stderr but via the
proc.Log(Info|Warning) methods...

175f44c2 11/08/2007 09:02 pm Iustin Pop

Refactor burnin to improve disk replacement

This patch changes the burnin:
- split the code into functions
- add replace2 (replace the secondary) for remote_raid1
- add replace1/2 for drbd8

Reviewed-by: imsnah

e42b5307 11/08/2007 01:51 pm Michael Hanselmann

Insert hook calls.

Reviewed-by: schreiberal

663ed0ce 11/08/2007 01:51 pm Michael Hanselmann

Implement sample hook.

Reviewed-by: schreiberal

1672a0d1 11/08/2007 01:50 pm Michael Hanselmann

Implement hooks infrastructure.

Reviewed-by: schreiberal

0834c866 11/07/2007 05:53 pm Iustin Pop

Enhance secondary node replace for drbd8

This (big) patch does two things:
- add "local disk status" to the block device checks
(BlockDevice.GetSyncStatus and the rpc calls that call this
function, and therefore cmdlib._CheckDiskConsistency)
- improve the drbd8 secondary replace operation using the above...

e3c826ec 11/07/2007 04:33 pm Michael Hanselmann

Indentation fixes for docs.

Reviewed-by: schreiberal

4677a909 11/07/2007 02:39 pm Michael Hanselmann

Update docs for the removed --secondary-node option.

Reviewed-by: ultrotter

7dd30006 11/07/2007 01:48 pm Michael Hanselmann

Check whether init.d script is executable.

Reviewed-by: schreiberal

113b8d89 11/06/2007 07:04 pm Michael Hanselmann

Adapt QA tests for removed --secondary-node option.

60d49723 11/06/2007 07:04 pm Michael Hanselmann

Remove --secondary-node option.

Replace --secondary-node option with an optional parameter for --node.

cff90b79 11/06/2007 07:01 pm Iustin Pop

Enhance DBRD8 disk replacement (same nodes)

This patch adds enhanced reporting and much more checks to the disk
replacement (when not switching the secondary).

Reviewed-by: imsnah

9db6dbce 11/06/2007 07:01 pm Iustin Pop

Implement degraded status for logical volumes

Logical volumes can be 'degraded' in a similar way to mirrored devices,
when their underlying storage has gone away (i.e. after a physical disk
failure and 'vgreduce --removemissing'). If we can detect this, we can...

0fbbf897 11/06/2007 07:01 pm Iustin Pop

Add better error logging functions for LUs

Currently, some LUs use logger.Error, others just feedback_fn, etc. This
patch adds three functions to mcpu.Processor than can be used to log
messages to both the log and to the user.

These function will be used to enhance the output of replace-disks for...

03ece5f3 11/06/2007 07:01 pm Iustin Pop

Enhance mirror operations for DRBD8

Currently, the mirror operations (add and remove children) test against
the instance's attributes. This patch changes the check tests to work
against the actual status of the device (i.e. live data) which is more
realistic....

fc1dc9d7 11/06/2007 07:00 pm Iustin Pop

Allow DRBD8 operation without backing storage

This patch adds the following functionality:
- DRBD8 devices can assemble without local storage (done by allowing
None in the list of children, and making DRBD8 to ignore all
children if any is None)...

583e3f6f 11/06/2007 07:00 pm Iustin Pop

Make DRBD8 disks show 'degraded' status if diskless

This patch enables the bdev.DRBD8 class report a degraded status if the
local disk is missing. This allows `gnt-instance info` to report the
actual situation in this case.

Note that DRBD7 should also behave like this, however the diskless case...

e739bd57 11/06/2007 07:00 pm Iustin Pop

Change the way remove children is called in bdev

For some cases, we don't have to have access to the children of a device
in order to remove them (e.g. md over lvs, or drbd over lvs). In order
to ease the removal process, skip over finding the child if it provides...

222f2dd5 11/06/2007 06:55 pm Iustin Pop

Add a support function to objects.Disk

This patch adds a function returning the device path if it is computable
from the disk object (and we don't need to instantiate a bdev object on
the target node in order to compute this). Only LVs support this.

Reviewed-by: imsnah

e2e521d0 11/05/2007 11:22 pm Iustin Pop

Small cleanup for error formatting

Reviewed-by: ultrotter

c7b46d59 11/05/2007 07:59 pm Iustin Pop

Handle missing init script at cluster init

This patch adds a check in the prereq of LUInitCluster for the existence
of the init script. This allows a clean abort instead of a stack dump.

Based on a report by

Reviewed-by: ultrotter

cf5a8306 11/05/2007 05:08 pm Iustin Pop

Fix a unhandled error case in device creation

The block device creation process is the following:
- device create
- device assembly (on primary or depending on dev_type, on secondary
too)
- set sync speed
- return

The problem is that device assembly after creation was not checked for...

65fe4693 11/05/2007 05:06 pm Iustin Pop

Miscellaneous style fixes

This patch fixes some minor pylint warnings (unused variables, wrong
indentation, etc.) and a real bug in the recovery for drbd8 rename
procedure.

Reviewed-by: imsnah

d74c2ca1 11/05/2007 02:19 pm Michael Hanselmann

Test tag functionality.

Reviewed-by: schreiberal

62843684 11/05/2007 02:18 pm Michael Hanselmann

Merge three small cluster tests into one.

Reviewed-by: schreiberal

24818e8f 11/05/2007 02:14 pm Michael Hanselmann

Rename utils.GetUUID to utils.NewUUID.

Reviewed-by: schreiberal

8ee53a06 11/05/2007 02:44 am Guido Trotter

Bump protocol version up

The OS cleanup patches change the wire protocol. Increment the protocol number
by one.

Reviewed-By: iustinp

dfa96ded 11/05/2007 02:43 am Guido Trotter

Convert os_get to use OS rather than InvalidOS

In order to do this for simplicity we leave the OSFromDisk function as-is and
we convert the eventual exception to an OS object in ganeti-noded. The
unmangling gets simplified and so does the code for checking whether the OS is...

4e679f11 11/05/2007 02:43 am Guido Trotter

Simplify diagnose mangling/unmangling functions

The functions in ganeti-noded and rpc.py still deal with the fact that an
InvalidOS error could be returned by DiagnoseOS. As this is not the case
anymore simplify their code for the current behavior.

Reviewed-By: iustinp

8fa42c7c 11/05/2007 02:43 am Guido Trotter

Make DiagnoseOS use the modified OS objects

Modify backend.py so that DiagnoseOS only returns OS objects rather than
InvalidOS errors, and make sure gnt-os understands the new objects. Also delete
the deprecated helper functions from gnt-os.

Reviewed-By: iustinp

d2c807e4 11/05/2007 02:42 am Guido Trotter

Create OS from an InvalidOS error

Add a new FromInvalidOS static function to objects.OS that makes it easy to
create an object representing a broken OS starting from the relevant exception.

Reviewed-By: iustinp

37482e7b 11/05/2007 02:42 am Guido Trotter

Make the OS object able to represent broken OSes

Till now the OS object just represents a correct OS instance. Change it so it
can represent a broken one too, by adding a "status" field: if this field is
different from the OS_VALID_STATUS constant the object is considered to be an...

519bfbae 11/05/2007 01:26 am Iustin Pop

Add option to burnin only a given set of nodes

This patch adds a '-n' option to burnin that takes a comma-separated
list of nodes to perform the burnin on.

Reviewed-by: ultrotter

00fe9e38 11/04/2007 06:10 am Guido Trotter

Make call_os_get a single node function

call_os_get is never called with a real list of nodes, so there's no point in
it being multi-node. Making it single-node till a usage for multi-node call is
found.

Reviewed-By: iustinp

74b4217d 11/04/2007 05:37 am Guido Trotter

Fix two typos in a doc string

Remove a wrong "i" and add a missing ")" to the DiagnoseOS function doc string.

Reviewed-By: iustinp

73415719 11/03/2007 08:55 am Iustin Pop

Implement tag searching

This patch adds a search command for locating tags on all objects of the
cluster using a regex pattern.

Reviewed-by: aat

830da270 11/02/2007 05:51 pm Michael Hanselmann

Test “gnt-cluster command”.

Also check whether file contents are correct for both “gnt-cluster command” and
“gnt-cluster copyfile”.

Reviewed-by: iustinp

3f78eef2 11/02/2007 03:44 pm Iustin Pop

Implement device to instance mapping cache

Currently, troubleshooting DRBD problems involves a manual process of going
backwards from the DRBD device to the instance that owns it.

This patch adds a weak (i.e. not guaranteed to be correct or up-to-date)
cache of device to instance. The cache should be, in normal operation,...

79f87a76 11/02/2007 03:43 pm Iustin Pop

Improve burnin with regard to drbd8

Allow burnin to use the new drbd8 template (for which case one needs to
disable replacement of disks, burnin does yet support that with drbd8).

The patch also changes do-replace12 to no-replace12 as that is what
they actually do....

be345db0 11/02/2007 03:43 pm Iustin Pop

Update the dev_path on LVs on rename

When renaming a logical volume, we should change the dev_path (and other
internal variables) in order to be consistent.

Reviewed-by: imsnah

25a915d0 11/02/2007 03:10 am Iustin Pop

Revision 302 is broken, this fixes it

I forgot a pair of parentheses in that revision which break the common
case. This patch adds them.

Reviewed-by: ultrotter

073ca59e 11/01/2007 11:40 pm Iustin Pop

Fix printing of unconfigured DRBD devices

If the device is unconfigured (not yet did SetDiskID for it ever), it
might have a physical_id of None. This patch fixes that case.

Reviewed-by: ultrotter

d06565e0 11/01/2007 07:51 pm Guido Trotter

Remove two trailing whitespaces

Ok, I've been battling with those for a while but it seems
in the end I forgot to get rid of them! :( Doing it explicitely now.

Reviewed-By: iustinp

2527691a 11/01/2007 07:48 pm Guido Trotter

Move blank lines inside function messages

This patch changes whitespace only. It fixes all the functions in script/gnt-os
by putting a white line at the end of all the function descriptions and
removing it from just before the code.

Reviewed-By: iustinp