Statistics
| Branch: | Tag: | Revision:

root @ 9f7d5fe4

# Date Author Comment
9f7d5fe4 07/18/2013 01:52 pm Sebastian Gebhard

Support VLAN parameter during instance creation

If VLAN parameter is present, check its format:
either .<id>[:id], :id[:id...], or just id.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>

f1f11cef 07/18/2013 01:52 pm Sebastian Gebhard

Add VLAN-capabilities for Xen Hypervisor

This implementation depends on vif-openvswitch provided by Xen 4.3
and provides Xen with switch name and vlan as "link".

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>...

7ad422ec 07/18/2013 01:52 pm Sebastian Gebhard

Extending nicparams to support vlan parameter

This parameter is used to store the vlans each nic is connected to.
It is only used if the network is in openvswitch mode.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>...

347db542 07/18/2013 01:52 pm Sebastian Gebhard

Improvement of design-openvswitch.rst

Some improvements / fixes that came up during implementation.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>

6d67e8bf 07/17/2013 11:14 am Izhar

Design Doc for HugePages Support

Add design document for the "HugePages support" GSoC project.

Signed-off-by: Izhar ul Hassan <>
Reviewed-by: Guido Trotter <>
Reviewed-by: Thomas Thrainer <>

1fe10404 07/16/2013 12:47 pm Klaus Aehlig

Reset cfgupgrade --downgrade to be a no-op

In version 2.10 cfgupgrade --downgrade is supposed to downgrade
the configuration to version 2.9 which, at the moment, is still
the same as 2.10.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>

5ee24e45 07/16/2013 12:17 pm Helga Velroyen

Improve debugging output of DRBD8 status

Signed-off-by: Brian Candler <>
Reviewed-by: Helga Velroyen <>

71f35985 07/16/2013 11:45 am Klaus Aehlig

Bump version number after forking off 2.9

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Helga Velroyen <>

32449822 07/16/2013 10:55 am Dimitris Aragiorgis

Fix conflicts check in LUNetworkDisconnect

The function _NetworkConflictCheck expects a list of instances as
last argument, not a list of pairs of instance names and instances.

Signed-off-by: Dimitris Aragiorgis <>
Signed-off-by: Klaus Aehlig <>...

c832f7e9 07/16/2013 10:29 am Klaus Aehlig

Merge branch 'stable-2.8' into master

  • stable-2.8
    Change method dispatch in ClientOps to enforce luxi.REQ_ALL
    Allow modify_etc_hosts to be changed
    Add --modify-etc-hosts option for CLI tools
    Add luxiReqQueryNetworks to LuxiOp
    Log received message at debug level...
4eb06290 07/15/2013 05:24 pm Klaus Aehlig

Merge branch 'stable-2.7' into stable-2.8

  • stable-2.7
    Fix RAPI to include missing network fields
    Add support for querying network timestamps
    In the crontab example, look for the correct binary
    Fix wrong numbering in UPGRADE documentation

Conflicts:...

64d7e30f 07/15/2013 03:59 pm Klaus Aehlig

Change method dispatch in ClientOps to enforce luxi.REQ_ALL

ClientOps' handle_request dispatches on the luxi request received. Change
this to first verify if the request is luxi.REQ_ALL. In this way, we catch
programming errors introducing "secret" luxi requests earlier. This is relevant,...

f3bde990 07/15/2013 12:34 pm Helga Velroyen

Update documentation and NEWS wrt to file storage dir

This patch updates the 'gnt-cluster' man page and the NEWS
file regarding the changes related to the file storage
en/disabling and the configuration of the file storage
directory.

Signed-off-by: Helga Velroyen <>...

9c1c3c19 07/15/2013 12:34 pm Helga Velroyen

Verify file storage path

This patch adds two verification steps to 'gnt-cluster
verify':
- The configured file storage directory is checked against
the allowed file storage directories file.
- We check whether the configured file storage directory
is existing and writable on each node....

13a6c760 07/15/2013 12:34 pm Helga Velroyen

Prepare verification code for new file path verification

This patch prepares the verification code for adding
a new verification step for the file storage paths:
- It moves a couple of file storage helper functions from
bdev to filestorage (since they make more sense there...

2dcb5a26 07/15/2013 12:34 pm Helga Velroyen

Remove file storage path from autoconf

This patch removes the option to configure the file
storage path at configure time, because it is now
replaced by a runtime option for gnt-cluster init.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

5949c31c 07/15/2013 12:34 pm Helga Velroyen

QA: Adjust QA for file storage

This improves the QA code wrt to file storage in the
following ways:
- It fixes a FIXME to make the file storage directory
customizable in the QA config. Fallback is the default
value.
- It makes QA derive the enabled storage types from...

d721894a 07/15/2013 12:34 pm Helga Velroyen

storage utils: read file storage dir from cluster config

This patch make the storage utils read the file storage
directory from the cluster config instead of the constants.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

49a924bc 07/15/2013 12:34 pm Helga Velroyen

Remove ENABLE_FILE_STORAGE completely

This patch removes the ENABLE_FILE_STORAGE completely
from the remaining files, such as Makefile, configure,
constants, pathutils and objects.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

6a34eb01 07/15/2013 12:34 pm Helga Velroyen

cluster-merge: remove usage of 'ENABLE_FILE_STORAGE'

This patch adjusts the cluster-merge tool so that it does
no longer check the constant 'ENABLE_FILE_STORAGE' but
the clusters' configurations.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

b780c231 07/15/2013 12:34 pm Helga Velroyen

QA: Adjust test whether file storage is enabled

This patch fixes the node storage QA, which checked whether
file storage is enabled by looking at the constant
'ENABLE_FILE_STORAGE'. QA should rather retrieve this
information from the QA config.

Signed-off-by: Helga Velroyen <>...

9d276e93 07/15/2013 12:34 pm Helga Velroyen

Opcodes: move storage type checks to cmdlib

So far, there was a static check whether or not a given
storage type of an opcode was enabled. This check is
no longer possibe at this layer, because the information
whether or not file/shared file storage is enabled must...

850c53f1 07/15/2013 12:34 pm Helga Velroyen

cmdlib: remove usage of ENABLE_FILE_STORAGE

This patch removes all usages of the constant
'ENABLE_FILE_STORAGE' from the cmdlib code and
replaces them by checking the cluster's configuration.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

1f7c8208 07/15/2013 12:34 pm Helga Velroyen

backend: remove ENABLE_FILE_STORAGE

This patch removes the usage of the ENABLE_FILE_STORAGE
constant in the backend code. To avoid having to pass
it through various RPC calls, we instead move the check
to cmdlib.

Signed-off-by: Helga Velroyen <>...

5030cff3 07/15/2013 12:34 pm Helga Velroyen

cluster init: check for enabled disk templates

The purpose of this patch is to remove the usage of the
'ENABLE_FILE_STORAGE' constant. To get there, we do some
refactoring, add unit tests and add a FIXME for a forgotten
test regarding the file storage location....

43c54ced 07/15/2013 12:34 pm Helga Velroyen

cluster verify: adjust path verification

This patch adjusts the verification of file storage paths
by checking the list of enabled disk templates instead
of the 'ENABLE_FILE_STORAGE' constant.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

ebe93784 07/15/2013 12:34 pm Helga Velroyen

Utility functions to check if a disk template is enabed

This patch adds some helper functions to the config and
storage utils which check whether a disk template is
enabled or not. The functions themselves are quite small
but they will be used quite often and therefore should...

2b48dbca 07/15/2013 12:34 pm Helga Velroyen

Add default file storage path to path utils

This patch adds the default storage path to the pathutils
for now. At the end of this patch series, it will no longer
be determined at configure time and therefore be removed
from the configure.ac file.

Signed-off-by: Helga Velroyen <>...

75f2ff7d 07/15/2013 12:10 pm Michele Tartara

Allow modify_etc_hosts to be changed

The modify_etc_hosts options, enabling the cluster to modify the /etc/hosts
files of nodes, and to keep them in sync, could only be set at cluster init
time.

With this commit it can now be changed through modify_etc_hosts as well....

c89db623 07/15/2013 12:10 pm Michele Tartara

Add --modify-etc-hosts option for CLI tools

The option will be used by gnt-cluster modify in the following commit.

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>

795d035d 07/12/2013 04:42 pm Klaus Aehlig

Add luxiReqQueryNetworks to LuxiOp

When the QueryNetwork was introduced as a method, apparently
it was forgotten in the Haskell world. Add it here as well.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Helga Velroyen <>

385d4574 07/12/2013 04:42 pm Klaus Aehlig

Log received message at debug level

At debug level, we can well afford to have a detailed entry
for each message received by a server.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Helga Velroyen <>

91525dee 07/11/2013 06:08 pm Michele Tartara

Set the correct group for confd

Starting confd as a member of the daemons group allows the RAPI daemon to access
the LUXI socket.

Fixes Issue 477.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

c393abbf 07/11/2013 02:42 pm Michele Tartara

Log RPC errors from inside executeRpcCall

executeRpcCall is the function to be used for executing RPCs, so it makes sense
to use it as the single point for logging all thte RPC call errors.

Fixes Issue 293.

Signed-off-by: Michele Tartara <>...

a246ce76 07/11/2013 02:41 pm Michele Tartara

Factor out the logRpcErrors function

This function can be useful to multiple RPC calls, therefore it is moved
to the file containing the common RPC functions.

Also, it is made more generic by changing its signature.

Signed-off-by: Michele Tartara <>...

3312709d 07/10/2013 05:21 pm Leon Handreke

Expose bulk parameter for GetJobs in RAPI client

This patch exposes the bulk argument of the jobs resource on
the RAPI python wrapper, making it possible to retrieve status
information about all jobs with a single call.

Signed-off-by: Leon Handreke <>...

c4101ab5 07/10/2013 05:14 pm Michele Tartara

Add git send-email to the chroot

"git send-email" is used as part of the official workflow but it was not
installed in the chroot.

This patch adds it.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

335c14dc 07/10/2013 04:44 pm Michele Tartara

Add tests for CanRead

Verify that the CanRead function is actually able to check whether a file has
the proper permissions.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

95c83fe6 07/10/2013 03:45 pm Christos Stavrakakis

Fix RAPI to include missing network fields

Fix RAPI interface to include missing network fields. Specifically, fix
instance queries to include the network name for instance NICs. Also fix
network queries to include missing common fields, like uuid and serial....

22ff02a7 07/10/2013 03:45 pm Christos Stavrakakis

Add support for querying network timestamps

Add creation and modified timestamps when creating a new network, and
extend the available query fields for networks with these fields,
namely 'ctime' and 'mtime'.

Signed-off-by: Christos Stavrakakis <>...

d90f0cb4 07/10/2013 03:36 pm Helga Velroyen

Unittesting for instance_storage._CheckNodesFreeDiskOnVG

This patch refactors the '_CheckNodesFreeDiskOnVG' of
cmdlib.instance_storage to make it at least a little
more testible and provides the unit tests for it.

Signed-off-by: Helga Velroyen <>...

3f73b3ae 07/10/2013 03:36 pm Helga Velroyen

Unit tests for _GetVgInfo

This patch provides unit tests for the backend's
_GetVgInfo function. In order to mock the underlying
backend function, it was necessary to make it an
optional parameter of the function.

Signed-off-by: Helga Velroyen <>...

86e16e3f 07/10/2013 03:36 pm Helga Velroyen

Fix module functions overridden by mocks

This patch fixes remaining occurrences of module functions
that were overridden by mock functions. They need to be
set back to their original functions after the test case
ends.

Signed-off-by: Helga Velroyen <>...

a18ab868 07/10/2013 03:36 pm Helga Velroyen

Unit tests for _GetVgSpindlesInfo

This patch provides unit tests for _GetVgSpindlesInfo.
In order to mock the used function for the 'bdev' module
I made the low-level storage function an optional parameter
of _GetVgSpindlesInfo. I also found out that mocked...

3c8a599a 07/10/2013 03:36 pm Helga Velroyen

More sanity checks for spindle space reporting

This patch adds a wrapper around the space reporting
for spindles which includes more sanity checks for
the input. Unit tests provided.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

3ae259d3 07/10/2013 03:36 pm Helga Velroyen

Tighten sanity checks for '_GetLvmVgSpaceInfo'

This patch tightens the sanity checks for the input of
'_GetLvmVgSpaceInfo' and provides unit tests for it.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

b01b7a50 07/10/2013 03:36 pm Helga Velroyen

Factor out check for storage params

This patch factors out the sanity checks for storage
parameters in its own function. Unit tests included.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

99b67c35 07/10/2013 02:37 pm Spyros Trigazis

Add design for mond's CPU load collector

This commit extends monitoring agent's design document, with the
design of a new data collector that will provide CPU load statistics.
It also extends the monitoring agent's design to include:

  • a new thread which triggers the collection of data...
5f7d4181 07/10/2013 02:04 pm Jose A. Lopes

Fix single-execution of Haskell tests and shelltests

Add Makefile.am target hs-test-% for single-execution of Haskell
tests.

Add Makefile.am target hs-shell-% for single-execution of Haskell
shelltests.

Update documentation on running individual tests....

f9649b3d 07/10/2013 12:41 pm Klaus Aehlig

Only generate node lists with nodes having different names

genNodeList is used in testing to generate list of nodes
that could come up in cluster configurations. Since names
are used to assign indices to nodes, they have to be unique;
this is also the case in all real clusters....

4c18846f 07/10/2013 12:12 pm Michele Tartara

Add missing newline to the NEWS file

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>

69d1fde2 07/10/2013 11:31 am Michele Tartara

ConfD-related NEWS file update

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>

a9a30ecd 07/10/2013 11:31 am Michele Tartara

Add monitoring daemon updates to the NEWS file

The "inst-status-xen", "diskstats" and "lv" data collectors have been added.

The daemon is now running as root.

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>

69ac3b74 07/09/2013 07:41 pm Michele Tartara

Cluster verify checks server.pem permissions

Currently, ConfD must be able to access server.pem (though this is likely to
change in the future). If this is not true, all sorts of weird things happen,
such as "gnt-node list" printing lots of question marks instead of actual...

fc84ef94 07/09/2013 07:41 pm Michele Tartara

Add function for checking file access permissions

The CanRead function checks whether a user of the local machine (specified
by name) can access a given file.

IsUserInGroup is a helper function for CanRead, but might also be used
independently, so its name does not begin with an underscore....

20029b6e 07/09/2013 06:15 pm Sebastian Gebhard

More details on vlan support in openvswitch

This design doc give a more detailed design about the implementation
of openvswitch in regareds of VLANs.

Signed-off-by: Sebastian Gebhard <>
Signed-off-by: Klaus Aehlig <>
Reviewed-by: Klaus Aehlig <>

b23226d5 07/09/2013 05:22 pm Michele Tartara

Prevent silent failure in case of connection problems

While running "gnt-node list", if a query to ConfD fails (especially
because of permission problems) it used to just fail silently, with gnt-node
showing question marks instead of data.

With this patch, ConfD records the error in its log file, together with a...

3fe41221 07/09/2013 04:05 pm Klaus Aehlig

Fix type error in the call of _NetworkConflictCheck

The function _NetworkConflictCheck expects a list of instances as
last argument, not a list of pairs of instance names and instances.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Guido Trotter <>

927840bc 07/09/2013 12:22 pm Klaus Aehlig

In the crontab example, look for the correct binary

When ganeti-master-cleaner was merged back into ganeti-cleaner in 46118ed2,
the binary to test for should have also been updated. Do this now.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Helga Velroyen <>

2bc994ce 07/08/2013 12:45 pm Michele Tartara

Fix apt-get invocation in chroot_builder

Use the macro containing all the required parameters, instead of just using
"apt-get install".

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

c7ec6a25 07/08/2013 12:37 pm Michele Tartara

Fix wrong numbering in UPGRADE documentation

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

76825515 07/05/2013 03:12 pm Klaus Aehlig

Merge branch 'stable-2.8' into master

  • stable-2.8:
    Also remove prop_IterateAlloc_sane from test list
    Fix documentation for prop_Alloc_sane
    Remove IterateAllocSane test
    Clean up work around for host name filtering
    Do not handle host queries special...
5ab57a1e 07/05/2013 01:03 pm Klaus Aehlig

Merge branch 'stable-2.7' into stable-2.8

  • stable-2.7:
    Release version 2.7.0
    Fix "instance replace" typo in admin.rst
    Fix typo in the install guide
    Disable pylint E1101 on hypothetical import

Conflicts:
NEWS: trivial
configure.ac: trivial

Signed-off-by: Klaus Aehlig <>...

5b6ef0e7 07/04/2013 08:04 pm Michele Tartara

Add documentation for the LV collector

Documentation added in the mon-collector man page.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

820ca72d 07/04/2013 08:04 pm Michele Tartara

Include "instance" information in LV data collector

This commit enables the logical volume data collector to get information about
the instances and to link it to the information about logical volumes.

The list of parameters accepted by the collector is expanded to allow proper...

76968973 07/04/2013 08:04 pm Michele Tartara

Add "includeLogicalId" function for Disks

This function checks whether a disk contains a given Lvm logical ID,
directly or through its children.

Unit tests are added as well.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

53753d20 07/04/2013 08:03 pm Michele Tartara

Add option for loading serialized instances

Monitoring CLI tools might have to load serialized lists of instances
(mainly for testing reasons). This patch adds an option to allow that.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

f22b987a 07/04/2013 08:03 pm Michele Tartara

Factor out lv info gathering function

The buildJsonReport function will soon have to perform the coupling of
instance data with LVInfo data. In preparation for that, in order to make
it more readable, the instructions for obtaining LVInfos are factored out...

58458012 07/04/2013 08:03 pm Michele Tartara

Add "instance" field to LVInfo

Extend the LVInfo data structure with the field for storing the name of
the instance it is paired with.

Update the tests accordingly.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

fbfa1d19 07/04/2013 08:02 pm Michele Tartara

Better specify LVInfo "instance" field

Specify that it is serialized as "null" if empty.

Signed-off-by: Michele Tartara <>
Reviewed-by: Klaus Aehlig <>

9611c32e 07/04/2013 08:02 pm Michele Tartara

Factor out the getInstances function

The getInstances function can be useful in general, but is defined inside
the InstStatus data collector. This commit takes it out and adds it to
a proper (newly created) library.

Signed-off-by: Michele Tartara <>...

51b12695 07/04/2013 08:01 pm Klaus Aehlig

Also remove prop_IterateAlloc_sane from test list

In f4d1bb7 that test was removed, but forgotten to remove it
from the list of tests to be executed. Fix that.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Michele Tartara <>

b2525349 07/04/2013 06:47 pm Thomas Thrainer

Disable failing QA test

See issue 516 for an explanation of the problem, and why it was required
to disable this test.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>

09d8b0fc 07/04/2013 06:46 pm Klaus Aehlig

Fix documentation for prop_Alloc_sane

As discussed in the last commit, placing a new instance on the cluster
can lead to a cluster that can be improved by moving previously added
instances. For an empty cluster, however, there are no previous
instances. So add this to the test description to make obvious why...

f4d1bb75 07/04/2013 06:46 pm Klaus Aehlig

Remove IterateAllocSane test

The test is testing for a property that just isn't true. Iterated
allocation greedily place one instance at a time taking the locally
most balanced solution. Then it is tested whether the resulting global
allocation can be improved....

788529f2 07/04/2013 03:01 pm Guido Trotter

Release version 2.7.0

We don't have notice of anything blocking for 2.7, and it's been in
release candidate state long enough. Any future problems can be
addressed as bugfixes.

Signed-off-by: Guido Trotter <>
Reviewed-by: Klaus Aehlig <>

2b5b6da1 07/03/2013 07:57 pm Helga Velroyen

Disable enabled-template-test for exclusive storage

This patch disables the tests regarding enabled disk
templates for exclusive storage, because the semantics
there are different and not covered in the test.

Signed-off-by: Helga Velroyen <>...

52a8a6ae 07/03/2013 07:57 pm Helga Velroyen

Fix propagation of storage parameters to/from backend

This patch fixes two problems with the storage reporting
that showed up in the QA for exclusive storage:

- The processing of storage space information for instance
operations wrongly assumed that the volume group's...

109a21b1 07/03/2013 07:57 pm Helga Velroyen

Fix typo in iallocator

Signed-off-by: Helga Velroyen <>
Reviewed-by: Klaus Aehlig <>

49bea583 07/03/2013 07:35 pm Dimitris Aragiorgis

Fix gnt-network info

QueryNetworks() returns the uuids of the instances that are
inside a network. Since QueryInstances() uses names and not uuids
for search, we create a uuid2name dict to get each instance name
and then retrieve its nics and networks.

Signed-off-by: Dimitris Aragiorgis <>...

e78a8c0b 07/03/2013 02:05 pm Helga Velroyen

Extraction of storage info by type

There was a bug in the node queries. It was assumed that
the returned storage space information was in a particular
order. With the changes in the storage reporting, this
order is not that reliable anymore, in particular, the...

20faaa74 07/03/2013 12:41 pm Helga Velroyen

Improve handling of storage info

This patch improves the processing of storage information
as result of the 'node_info' call in the following way:
- It removes the override for LVM storage. This was needed
in MakeLegacyNode info to be compatible to the...

e4f377ae 07/03/2013 12:40 pm Helga Velroyen

Mention default disk template in NEWS file

Signed-off-by: Helga Velroyen <>
Reviewed-by: Michele Tartara <>

2206e4c9 07/03/2013 12:40 pm Helga Velroyen

Add default disk template selection to man pages

This documents the newly implemented behavior of picking
the disk template from the list of enabled disk templates
on instance creation.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Michele Tartara <>

513c5e25 07/03/2013 12:40 pm Helga Velroyen

Mention alternative template selection in design doc

This is a small adjustment of the design doc
'design-storagetypes.rst' with respect to the selection
of the default disk template.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Michele Tartara <>

72080db1 07/03/2013 12:40 pm Helga Velroyen

Let instance creation fall back to default disk template

So far, the '-t' option of 'gnt-instance add' is mandatory.
This patch makes it optional. In case, no disk template is
specified, the first of the list of enabled_disk_templates
is used.

Signed-off-by: Helga Velroyen <>...

dab6ea3d 07/03/2013 12:40 pm Helga Velroyen

LUInstanceCreate: factor out disk checks

The 'CheckArguments' method of 'LUInstanceCreate' is way
too long and should be broken up in smaller pieces. This
patch starts with that and factors out the disk checks.
No functional changes whatsoever.

Signed-off-by: Helga Velroyen <>...

fe0d94d8 07/03/2013 10:20 am Guido Trotter

Fix "instance replace" typo in admin.rst

gnt-instance `replace` should read `replace-disks`

Signed-off-by: Guido Trotter <>
Reviewed-by: Klaus Aehlig <>

56bbc5b0 07/03/2013 10:16 am Klaus Aehlig

Clean up work around for host name filtering

These functions simply served as a work around to express
host name matching by regular expressions, instead of using
correct equality filter on host names that provides
the correct matching already.

Signed-off-by: Klaus Aehlig <>...

c4e0d065 07/03/2013 10:16 am Klaus Aehlig

Do not handle host queries special

As, since 91c1a265, the equality used for host names already
is based on matching, there is no need to use a special function
for this any more.

Signed-off-by: Klaus Aehlig <>
Reviewed-by: Guido Trotter <>

76e11023 07/03/2013 09:52 am Thomas Thrainer

Document the 'protocol' disk parameter

Document the new disk parameter 'protocol' which is used to set the DRBD
replication protocol.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>

65fc2388 07/03/2013 09:52 am Thomas Thrainer

Make DRBD replication protocol configurable

Add a new disk parameter which allows to choose the DRBD replication
protocol. The protocol is fixed to "C" during dual primary mode though.

Signed-off-by: Thomas Thrainer <>
Reviewed-by: Klaus Aehlig <>

d352b796 07/02/2013 05:54 pm Helga Velroyen

Revert "QA: Make Query tests test for '?' values"

This reverts commit
bfbef99b9f056638411aa894e300aa095132e931. The problem is that
in some cases it makes sense for '?' to be displayed. This
is the case for storage reporting on clusters that have only
the 'diskless' disk template enabled. It would be nicer,...

7af293d7 07/02/2013 04:54 pm Thomas Thrainer

Add QA test for verify-disks with broken DRBD

gnt-cluster verify-disks supports automatic activation of broken DRBD
disks. This new QA test verifies that it actually finds instances with
broken DRBD disks and activates the disks of those instances.

Signed-off-by: Thomas Thrainer <>...

235a6b29 07/02/2013 04:54 pm Thomas Thrainer

Check DRBD status on verify-disks

Enhance `gnt-cluster verify-disks` such that it checks the DRBD status
of all disks. If the status of at least one disk of an instance is
either StandAlone or Diskless, the instance disks are activated
automatically.

Signed-off-by: Thomas Thrainer <>...

843094ad 07/02/2013 04:54 pm Thomas Thrainer

Make names more descriptive

LUGroupVerifyDisks had some not very descriptive names which made it
hard to read and understand the code. This patch renames some methods
and variables to make it more readable.

Also, the return type of MapInstanceLvsToNodes was changed to contain...

e58c4f2c 07/02/2013 02:43 pm Michele Tartara

Fix typo in the install guide

Signed-off-by: Michele Tartara <>
Reviewed-by: Helga Velroyen <>

bfbef99b 07/02/2013 01:54 pm Helga Velroyen

QA: Make Query tests test for '?' values

When something goes wrong in the Haskell implementation of
queries, the 'gnt-* list' command does not actually fail,
but it just displays '?' as a sign of failure. We so far
do not test for that, which makes errors in the haskell...

212b66c3 07/02/2013 01:53 pm Helga Velroyen

Turn 'exclusive_storage' into storage parameter (hs)

This is the haskell implementation of my patch "Extend RPC call
'node_info' by storage parameters". It turns the 'exclusive
storage' flag into a storage parameter of the LVM storage types.
Besides that, this patch moves some types into the Types.hs....

a59c31ca 07/02/2013 12:47 pm Helga Velroyen

noded.py: remove fallback of 'node_info'

In order to change backend and frontend code of the RPC
call 'node_info' in separate patches, we included a
fallback to the old implementation. Since all RPC callers
are adjusted, this can be removed now.

Signed-off-by: Helga Velroyen <>...