Synnefo » snf-ganeti

_MISSING = object()

def _ConvertNicDiskModifications(mods):

  """Converts NIC/disk modifications from CLI to opcode.

  When L{opcodes.OpInstanceSetParams} was changed to support adding/removing

  disks at arbitrary indices, its parameter format changed. This function

  converts legacy requests (e.g. "--net add" or "--disk add:size=4G") to the

  newer format and adds support for new-style requests (e.g. "--new 4:add").

  @type mods: list of tuples

  @param mods: Modifications as given by command line parser

  @rtype: list of tuples

  @return: Modifications as understood by L{opcodes.OpInstanceSetParams}

  """

  result = []

  for (idx, params) in mods:

    if idx == constants.DDM_ADD:

      # Add item as last item (legacy interface)

      action = constants.DDM_ADD

      idxno = -1

    elif idx == constants.DDM_REMOVE:

      # Remove last item (legacy interface)

      action = constants.DDM_REMOVE

      idxno = -1

    else:

      # Modifications and adding/removing at arbitrary indices

      try:

        idxno = int(idx)

      except (TypeError, ValueError):

        raise errors.OpPrereqError("Non-numeric index '%s'" % idx,

                                   errors.ECODE_INVAL)

      add = params.pop(constants.DDM_ADD, _MISSING)

      remove = params.pop(constants.DDM_REMOVE, _MISSING)

      if not (add is _MISSING or remove is _MISSING):

        raise errors.OpPrereqError("Cannot add and remove at the same time",

                                   errors.ECODE_INVAL)

      elif add is not _MISSING:

        action = constants.DDM_ADD

      elif remove is not _MISSING:

        action = constants.DDM_REMOVE

      else:

        action = constants.DDM_MODIFY

      assert not (constants.DDMS_VALUES_WITH_MODIFY & set(params.keys()))

    if action == constants.DDM_REMOVE and params:

      raise errors.OpPrereqError("Not accepting parameters on removal",

                                 errors.ECODE_INVAL)

    result.append((action, idxno, params))

  return result

def _ParseDiskSizes(mods):

  """Parses disk sizes in parameters.

  """

  for (action, _, params) in mods:

    if params and constants.IDISK_SIZE in params:

      params[constants.IDISK_SIZE] = \

        utils.ParseUnit(params[constants.IDISK_SIZE])

    elif action == constants.DDM_ADD:

      raise errors.OpPrereqError("Missing required parameter 'size'",

                                 errors.ECODE_INVAL)

  return mods

  nics = _ConvertNicDiskModifications(opts.nics)

  disks = _ParseDiskSizes(_ConvertNicDiskModifications(opts.disks))

                                   nics=nics,

                                   disks=disks,

optional ``vg=``*VG* option specifies an LVM volume group other than

the default volume group to create the disk on. For DRBD disks, the

``metavg=``*VG* option specifies the volume group for the metadata

device. ``--disk`` *N*``:add,size=``**SIZE** can be used to add a

disk at a specific index. The ``--disk remove`` option will remove the

last disk of the instance. Use ``--disk ``*N*``:remove`` to remove a

disk by its index. The ``--disk`` *N*``:mode=``*MODE* option will change

the mode of the Nth disk of the instance between read-only (``ro``) and

The ``--net add:``*options* and ``--net`` *N*``:add,``*options* option

will add a new network interface to the instance. The available options

are the same as in the **add** command (``mac``, ``ip``, ``link``,

``mode``). The ``--net remove`` will remove the last network interface

of the instance (``--net`` *N*``:remove`` for a specific index), while

the ``--net`` *N*``:``*options* option will change the parameters of the Nth

instance network interface.

class TestConvertNicDiskModifications(unittest.TestCase):

  def test(self):

    fn = gnt_instance._ConvertNicDiskModifications

    self.assertEqual(fn([]), [])

    # Error cases

    self.assertRaises(errors.OpPrereqError, fn, [

      (constants.DDM_REMOVE, { "param": "value", }),

      ])

    self.assertRaises(errors.OpPrereqError, fn, [

      (0, { constants.DDM_REMOVE: True, "param": "value", }),

      ])

    self.assertRaises(errors.OpPrereqError, fn, [

      ("Hello", {}),

      ])

    self.assertRaises(errors.OpPrereqError, fn, [

      (0, {

        constants.DDM_REMOVE: True,

        constants.DDM_ADD: True,

        }),

      ])

    # Legacy calls

    for action in constants.DDMS_VALUES:

      self.assertEqual(fn([

        (action, {}),

        ]), [

        (action, -1, {}),

        ])

    self.assertEqual(fn([

      (constants.DDM_ADD, {

        constants.IDISK_SIZE: 1024,

        }),

      ]), [

      (constants.DDM_ADD, -1, {

        constants.IDISK_SIZE: 1024,

        }),

      ])

    # New-style calls

    self.assertEqual(fn([

      (2, {

        constants.IDISK_MODE: constants.DISK_RDWR,

        }),

      ]), [

      (constants.DDM_MODIFY, 2, {

        constants.IDISK_MODE: constants.DISK_RDWR,

        }),

      ])

    self.assertEqual(fn([

      (0, {

        constants.DDM_ADD: True,

        constants.IDISK_SIZE: 4096,

        }),

      ]), [

      (constants.DDM_ADD, 0, {

        constants.IDISK_SIZE: 4096,

        }),

      ])

    self.assertEqual(fn([

      (-1, {

        constants.DDM_REMOVE: True,

        }),

      ]), [

      (constants.DDM_REMOVE, -1, {}),

      ])

class TestParseDiskSizes(unittest.TestCase):

  def test(self):

    fn = gnt_instance._ParseDiskSizes

    self.assertEqual(fn([]), [])

    # Missing size parameter

    self.assertRaises(errors.OpPrereqError, fn, [

      (constants.DDM_ADD, 0, {}),

      ])

    # Converting disk size

    self.assertEqual(fn([

      (constants.DDM_ADD, 11, {

        constants.IDISK_SIZE: "9G",

        }),

      ]), [

        (constants.DDM_ADD, 11, {

          constants.IDISK_SIZE: 9216,

          }),

        ])

    # No size parameter

    self.assertEqual(fn([

      (constants.DDM_REMOVE, 11, {

        "other": "24M",

        }),

      ]), [

        (constants.DDM_REMOVE, 11, {

          "other": "24M",

          }),

        ])