Statistics
| Branch: | Tag: | Revision:

root / autotools @ b43dcc5a

# Date Author Comment
858905fb 07/15/2010 05:38 pm Michael Hanselmann

Move ShellWriter class to utils

Also add unittest.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

546d7c4f 06/02/2010 06:09 pm Iustin Pop

Second attempt at fixing check-man

I was wrong, actually LANG-vs-LC_ALL only fixed one case, by mistake. To
get proper UTF-8 encoding, we need to enforce any UTF-8 locale. We
choose the 'default' of en_US.UTF-8.

Signed-off-by: Iustin Pop <>...

e68cb187 06/02/2010 05:14 pm Iustin Pop

Fix check-man for newer man-db

Again, check-man :)

Commit 5fa1642226 removed LC_ALL=C, since that breaks the check.
However, with no LANG/LC_* variables, man-db is still broken.

We import the new lintian behaviour, i.e. LANG=C (which seems to differ
from LC_ALL=C, even with empty environment). I'm not sure of the...

e7b61bb0 03/23/2010 10:35 am Iustin Pop

Introduce a bool CLI option type

This option type enforces its value to either True or False, relieving
the scripts from manually parsing the values in each function.

We also update the bash completion code to use the option type if
possible.

Signed-off-by: Iustin Pop <>...

5fa16422 03/15/2010 04:55 pm Iustin Pop

Fix two issues related to check-man

First, we don't need to check man pages at sed time, because this means
everyone building the package will do - we only need to check at docbook
time, which is mostly at developer time.

Second, don't force LC_ALL to C, as this breaks newer man-db. I've...

571b34f8 03/12/2010 05:44 pm Michael Hanselmann

Add unittest for daemon-util

This test doesn't cover everything, but it's better than nothing.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

e8c8cf1a 03/12/2010 05:44 pm Michael Hanselmann

Add support for non-Python unittests

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

f9faf9c3 03/09/2010 02:27 pm René Nussbaumer

cli: Add ArgOs for later use in gnt-os

Signed-off-by: René Nussbaumer <>
Signed-off-by: Michael Hanselmann <>
Reviewed-by: Michael Hanselmann <>

27e336af 02/23/2010 07:11 pm Michael Hanselmann

Add make target to generate unittest coverage report

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

650fd0c8 02/11/2010 06:42 pm Iustin Pop

Skip line-length warnings in man

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

a4f12da4 02/10/2010 12:49 pm Michael Hanselmann

Check built manpages for errors

One fix is necessary in gnt-cluster.sgml. Also adding “DELETE_ON_ERROR”
target to remove output file if an error occurred while building it (in
this case the manpage).

This was reported by Iustin Pop in issue 87 and proposed check method...

b4086ce8 01/14/2010 02:16 pm Michael Hanselmann

build-bash-completion: Take care of pylint warnings

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

f59418db 01/13/2010 07:08 pm Michael Hanselmann

build-bash-completion: Fix a few pylint warnings

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

bdba4757 01/13/2010 07:08 pm Michael Hanselmann

check-python-code: Use “set -e” to abort on errors

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

8adfb141 11/25/2009 02:08 pm Michael Hanselmann

build-bash-completion: Check for None before comparing

Comparing a number with None is not a good idea:

>>> (0 < None, 0 > None)
(False, True)

This patch also adds build-bash-completion to the list
of checked Python scripts and wraps one line of more...

3d547d87 11/11/2009 03:30 pm Michael Hanselmann

Revert "Backport AC_PATH_PROGS_FEATURE_CHECK"

This reverts commit 52b699ecaa688a2aaac00fa64558e249d0bc9a26.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

52b699ec 11/05/2009 03:21 pm Guido Trotter

Backport AC_PATH_PROGS_FEATURE_CHECK

In order to allow working with older versions of autoconf we backport
this macro, but only if it's not defined already (by autoconf itself).

This commit can be reverted after we decide support for autoconf 2.61
and below should be deprecated....

a10caf87 10/27/2009 01:53 pm Michael Hanselmann

bash_completion: Move common code into function

This reduces the size of the script by about 9 kB.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

11c684bf 10/02/2009 06:53 pm Michael Hanselmann

Disallow "xrange" function

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

9648f1b4 10/02/2009 03:03 pm Michael Hanselmann

check-python-code: Show line number for problems

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Olivier Tharan <>

064c21f8 09/18/2009 01:53 pm Iustin Pop

Remove explicit DEBUG_OPT and add it by default

Since >90% of the commands take the “--debug” option, and all should
actually take it (the gnt-job command is currently missing it), it makes
sense to simply remove this and add it by default in cli.py.

Signed-off-by: Iustin Pop <>...

1f4e391b 09/16/2009 07:13 pm Michael Hanselmann

Show "--help" in bash completion

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

b757f830 09/11/2009 05:34 pm Michael Hanselmann

check-python-code: Report EOL whitespace

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Luca Bigliardi <>

eed5c5df 09/11/2009 05:33 pm Michael Hanselmann

Check for tabs and long lines in Python code

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

e948770c 09/10/2009 07:01 pm Michael Hanselmann

Move LoadModule function to ganeti.build

It should only be used at build-time.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

2d3ed64b 09/04/2009 06:58 pm Michael Hanselmann

Add bash completion for --node node1[:node2]

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Luca Bigliardi <>

5b0ca9d4 09/04/2009 06:58 pm Michael Hanselmann

Add more debugging to bash completion

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Luca Bigliardi <>

d6f5892b 09/03/2009 06:44 pm Michael Hanselmann

Move LoadModule function to utils

It can be used by unittests for daemons/* or scripts/*.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Luca Bigliardi <>

63d44c55 08/28/2009 06:24 pm Michael Hanselmann

Bash completion: Implement dynamic option value completion

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Olivier Tharan <>

30d44392 08/28/2009 06:24 pm Michael Hanselmann

Bash completion: Add function to get all iallocators

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Olivier Tharan <>

d4b94fe8 08/28/2009 06:24 pm Michael Hanselmann

Bash completion: Simplify option completion

This makes the output file quite a bit smaller and is needed
in preparation for non-static option completion (e.g. list of
nodes).

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Olivier Tharan <>

632d5090 08/28/2009 06:24 pm Michael Hanselmann

Bash completion: Support for --foo=bar option format

That is with the equal sign.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

580ef58d 08/28/2009 06:24 pm Michael Hanselmann

Bash completion: Small optimizations

$2 doesn't contain the correct value when completing something like
"--disk-template=…". Getting it via COMP_WORDS is better.

Short options (e.g. -I) can't have an equal sign.

Also add useful debugging commands for development....

5431eff1 08/26/2009 07:08 pm Michael Hanselmann

bash completion: Allow arguments with min < max arguments

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

b959138f 08/25/2009 06:38 pm Michael Hanselmann

Add script to run build commands in temporary directory

Python always compiles imported modules. By running these targets
in a temporary directory we don't pollute the source tree.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

434c34a5 08/25/2009 06:38 pm Michael Hanselmann

Simplify manpage building

This eliminates one temporary directory in the process.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

5a78e2e7 08/25/2009 06:38 pm Michael Hanselmann

Handle more errors in bash completion

Don't print error messages if cluster hasn't been initialized yet.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

83ec7961 08/24/2009 06:01 pm Michael Hanselmann

Add ArgHost class

It expands to the hostnames known by bash.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

4f3d5b76 08/24/2009 04:53 pm Michael Hanselmann

Use script to generate bash completion

Completion for tools/burnin is not yet implemented. It needs to be
converted to definition-based options handling first.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

65dfd777 10/02/2008 01:22 pm Michael Hanselmann

Use docbook2* paths found during configure for actual build

docbook-wrapper had the names for the docbook2* programs hardcoded. This
patch changes Makefile.am and the wrapper script to pass them via
another argument.

Another issue where rapi.in was built before rapi-resources.sgml is...

8ab8e969 07/01/2008 03:13 pm Michael Hanselmann

Set locale when using docbook programs

At least docbook2man inserts a date formatted using the current
locale into its output.

Reviewed-by: iustinp

e8230860 06/19/2008 03:56 pm Michael Hanselmann

Use a single Makefile.am instead of many

This change allows us to use cleaner dependencies between
directories. The build system is basically rewritten in large parts
and may contain bugs.

Reviewed-by: iustinp

6e06b36c 11/26/2007 05:48 pm Iustin Pop

Add checking of python modules at ./configure time

This patch adds checking for our external python modules at the
./configure stage, as it's better to check than rely on documentation.

The patch adds one autoconf macro from the autoconf macro archive
(http://autoconf-archive.cryp.to)...