Statistics
| Branch: | Tag: | Revision:

root @ c664f05e

# Date Author Comment
c664f05e 06/14/2012 07:15 pm Guido Trotter

Add query2 numeric comparison operators

These were recently added to the python version.

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

ac13f473 06/12/2012 04:55 pm Guido Trotter

Haskell data types for query2

This contains the types to express query2 queries, filters and results.

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

3a44fd5f 06/12/2012 02:44 pm Iustin Pop

Merge branch 'stable-2.6'

  • stable-2.6: (26 commits)
    Bump version for beta 2 release
    Fix epydoc raises L{...} usage
    Fix race condition in test for *FileID functions
    Move KVM keymap from GenerateRuntime to ExecuteRuntime
    Add the keymap directory to the list of runtime KVM dirs...
1ad80d57 06/12/2012 01:30 pm Iustin Pop

Bump version for beta 2 release

I've added the changes under beta1, not beta2, since it's easier to
keep it separate.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

5c3d5dfd 06/12/2012 01:02 pm Iustin Pop

Fix epydoc raises L{...} usage

For epydoc raise statement, it already expects an exception which will
be hyperlinked; if passing an L{…} construct, it will instead break
the formatting (the @raise will not be recognised, but merged into the
previous paragraph)....

be0b29bd 06/11/2012 05:52 pm Iustin Pop

Merge branch 'stable-2.5' into stable-2.6

  • stable-2.5:
    Fix race condition in test for *FileID functions
    Move KVM keymap from GenerateRuntime to ExecuteRuntime
    Add the keymap directory to the list of runtime KVM dirs

Signed-off-by: Iustin Pop <>...

deb717a0 06/11/2012 04:55 pm Michael Hanselmann

Fix race condition in test for *FileID functions

In this test the “file ID” of a temporary file is compared against the
file ID gathered via an open file descriptor to the same file. For
reasons unknown to me utime(2) is called in-between to update the
inode's a- and mtime. Depending on the file system's timestamp...

839642c2 06/11/2012 04:29 pm Iustin Pop

Move KVM keymap from GenerateRuntime to ExecuteRuntime

Per issue 243, "side-effects" are GenerateRuntime are bad as they
execute only on the initial node of the instance. By moving the
write-out of the keymap file to ExecuteRuntime, it will be done both
at start and at migrate time....

2911f46c 06/11/2012 04:29 pm Iustin Pop

Add the keymap directory to the list of runtime KVM dirs

Commit 4f580fef added the keymap support, but missed that this
directory needs to be ensured/created at hypervisor init time.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

316dc1ff 06/11/2012 02:19 pm Iustin Pop

Fix make -n use

Due to the way $(MAKE) behaves (it forces execution of the commands
that contain it), use of $(MAKE) in a command line together with
side-effects commands will break stuff. It's better to keep it either
on a separate line, or if not possible, move said commands to a...

6e4c8f68 06/11/2012 01:35 pm Iustin Pop

Enable hlint in lint and reorganise this target

Currently, the lint target does a sequential: pep8, pylint, pylint on
the QA sources. hlint is run only when explicitly requested.

This patch reorganises the lint target by:

- splitting the current lint target into separate pylint (slow),...

b59092f7 06/08/2012 05:33 pm Iustin Pop

Improve error message for auto-promote/node modify

This has been reported internally 3-4 times already, and the current
version (from 8b437a6e) is still not good enough, it seems.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

1c573fb4 06/08/2012 04:58 pm Iustin Pop

Fix QA import of existing instances

Commit f346a7d9 broke the TestInstanceImport test in QA, since it
dropped the "always generate" parameter for backup import. We add an
override mac parameter so that, no matter what is defined in the
config file, imported instances (can) have a different MAC....

656db618 06/08/2012 02:02 pm Iustin Pop

Remove one obsolete hlint override

During the preparations for 2.6, we cleaned up the codebase to use
newer exceptions (e.g. commits 30d25dd8, 79ac58fa), so we can now drop
this override.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

c5b4a186 06/08/2012 02:02 pm Iustin Pop

Fix prefix bug in Haskell ssconf implementation

This patch fixes a (brown-bag) bug in the ssconf implementation where
the looked-for filenames were not prefixed with the ssconf file
prefix.

Additionally, a test for this is added (which fails without the fix)....

c09254c2 06/08/2012 02:02 pm Iustin Pop

Move the ssconf file prefix constant to constants.py

This way, it can be reused in the Haskell code too.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

f346a7d9 06/07/2012 04:51 pm Michael Hanselmann

QA: Add configuration options for static MAC address

In some QA environments static MAC addresses must be used.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

c1513c7f 06/07/2012 04:51 pm Michael Hanselmann

QA: Ignore tags using regular expression

In some QA environments external scripts may add tags. With this patch a
regular expression can be used to ignore them during QA runs.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: René Nussbaumer <>

d7772efa 06/06/2012 02:08 pm Iustin Pop

Merge branch 'stable-2.5' into stable-2.6

  • stable-2.5:
    Fix parallel build failures
    QA: Add default setting for tests

Conflicts:
Makefile.am (expected, from the parallel build fixes)
qa/qa_config.py (due to cherry-pick, ignored, simply checkout out with --ours)...

a13d6911 06/06/2012 01:40 pm Iustin Pop

Fix parallel build failures

This is the 2.5 version of the "fix build failures":

- man/%.gen could be left over even in case of failure, due to
automake bug
- make man/%.gen runs RUN_IN_TEMPDIR, so let's depend on it, since
that target has the proper dependencies (create needed dirs)...

69a15dd7 06/05/2012 08:02 pm Michael Hanselmann

QA: Add default setting for tests

Commit 1010ec70b1 enabled all tests by default. In some scenarios where
the configuration is static one may not want newly added tests to be
run.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>...

b498540e 06/05/2012 06:58 pm Iustin Pop

QA: add toggle for fewer common instance tests

Currently, the "common" instance tests (shutdown, rapi stopped
console, stopped modify, startup, rapi shutdown, rapi startup, list,
info, modify, rapi modify , console, rapi console, reinstall, rename,
rapi rename, rename and back, rapi rename and back, grow disk, reboot,...

710bc88c 06/05/2012 06:58 pm Iustin Pop

QA: stop logging SSH arguments for each invocation

Currently, this is how the QA log looks like:

Command: ssh -oEscapeChar=none -oBatchMode=yes -l root -t -oStrictHostKeyChecking=yes -oClearAllForwardings=yes -oForwardAgent=yes -oControlPath=/tmp/ganeti-qa-multiplexer.DMzkuH -oControlMaster=no node14 exit...

f14a8b15 06/05/2012 04:42 pm Iustin Pop

Switch QA to tty-less mode

This makes ssh generate much less noise when QA is run itself without
a tty, as otherwise we get thousands of lines of:

Pseudo-terminal will not be allocated because stdin is not a terminal.

in the QA logs (which are already big enough)....

e375fb61 06/01/2012 06:12 pm Iustin Pop

Fix a type issue and bad logic in cluster verification

Commit 2e04d454 introduced the new offline state for the instance
state, but being a big monolithic patch it sneaked in something that
doesn't make sense.

The checks for extra instances (either wrongly up or just unknown) are...

4b5a9365 06/01/2012 12:52 pm René Nussbaumer

Make the xen-cmd test more readable and portable

Signed-off-by: René Nussbaumer <>
Reviewed-by: Michael Hanselmann <>

db620e95 05/31/2012 06:05 pm Michael Hanselmann

doc/hooks: Clarify hook directory structure

I was not able to find where the “.d” suffix is documented, so this
clarification should make it more obvious.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

0625d08f 05/31/2012 12:09 pm René Nussbaumer

Support xl as a xen interface command

xm and xl are mostly compatible, there is just a change in migrate,
which for now we simple bridge by comparing the command string.

Also XEN_CMD is now set during configure time. This will then be fixed
in Ganeti 2.7 when we make it an hvparams....

1eb37421 05/31/2012 12:08 pm René Nussbaumer

Add XEN_CMD to _autoconf.py

This is needed so we can specify the xen command upon configure time

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

592eb0df 05/30/2012 02:08 pm René Nussbaumer

Fix GenericCurlConfig when pycurl is linked against nss

Redhat links its pycurl against NSS/ so this check fails and therefore
makes ganeti-watcher unusable.

Even though this seems to fix the problem and works, further testing on
this might be needed.

Signed-off-by: René Nussbaumer <>...

fcad6377 05/30/2012 12:41 pm Iustin Pop

Fix a tiny typo in a design doc

Reported by user ewoud, thanks!

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

4a78c361 05/30/2012 11:31 am Iustin Pop

Merge branch 'stable-2.6'

  • stable-2.6:
    Document that the disk/hypervisor state is not used
    Correct the watcher state files in the man page
    Re-wrap some lines in watcher code
    Add support for SIGHUP handling in Haskell daemons
    Rework logging setup for Haskell daemons...
a1cef552 05/29/2012 03:48 pm Iustin Pop

Document that the disk/hypervisor state is not used

This didn't get completed in time for 2.6, so we document that it's
not working as is. Well, it's not broken, just not used by anything.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

4e3c9f2d 05/29/2012 12:13 pm Iustin Pop

Correct the watcher state files in the man page

The move to per-group state files forgot to update the man page of
ganeti-watcher; let's fix this and add some more details on what
removal means and when it's needed.

Signed-off-by: Iustin Pop <>...

40b068e5 05/29/2012 12:12 pm Iustin Pop

Re-wrap some lines in watcher code

These were using exactly 80 chars, and I like them smaller.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

36691f08 05/29/2012 12:09 pm Iustin Pop

Add support for SIGHUP handling in Haskell daemons

This patch adds support for handling SIGHUP and reopening the
stdout/stderr logfile in daemon mode (but not in foreground mode).

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

0c28bee1 05/29/2012 12:09 pm Iustin Pop

Rework logging setup for Haskell daemons

This fixes a missing functionality: closing of stdout/stderr when
forking daemons. Without this, starting the daemons from the command
line seems to work, but doing it from utils.RunCmd breaks, since
without closing the standard descriptors, RunCmd never finishes....

47834a4f 05/24/2012 05:27 pm René Nussbaumer

Adapt example init.d script to work on Fedora

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

aa9f166a 05/24/2012 05:27 pm René Nussbaumer

Update the INSTALL doc for Fedora users

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

2803b47d 05/24/2012 05:08 pm Michael Hanselmann

Merge branch 'stable-2.5' into stable-2.6

  • stable-2.5:
    kvm-ifup: Use /bin/bash

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

1817dca9 05/24/2012 11:44 am Michael Hanselmann

kvm-ifup: Use /bin/bash

As reported by Ben Beuchler, kvm-ifup uses bash-specific constructs and
doesn't work with Ubuntu's default shell. We use bash all over the place
anyway, so changing the shebang line is the easiest solution.

Signed-off-by: Michael Hanselmann <>...

43c16a8a 05/23/2012 03:24 pm Iustin Pop

Merge branch 'stable-2.6'

  • stable-2.6:
    Version bump for 2.6.0~beta1
    Adjust cfgupgrade for new minor version
    Add support to daemon-util for distributions without start-stop-daemon
    Improve the check-news script
    Fix NEWS file
    _MaybeParseUnit: The elements are dicts not arrays...
106ee697 05/23/2012 03:03 pm Iustin Pop

Merge branch 'devel-2.6' into stable-2.6

It seems Michael submitted the daemon-util patch on devel-2.6, and I
didn't realise it. It's way too early in the release cycle of 2.6 to
have diverging branches, so I'm merging devel-2.6 into stable-2.6 and
then will ff the devel branch to the merge point....

aff49a15 05/23/2012 01:20 pm Iustin Pop

Version bump for 2.6.0~beta1

Finally!

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

93fd9bb1 05/23/2012 01:20 pm Iustin Pop

Adjust cfgupgrade for new minor version

Also does some abstracting of the versions.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

07c7c94a 05/23/2012 11:49 am Jun Futagawa

Add support to daemon-util for distributions without start-stop-daemon

This adds support to daemon-util for Red Hat based distributions that
do not have a start-stop-daemon. If /sbin/start-stop-daemon is not
available, daemon-util will source /etc/rc.d/init.d/functions....

f0fa05ac 05/22/2012 05:02 pm Iustin Pop

Improve the check-news script

Allow all errors to be displayed, instead of aborting at the first
one, and don't show stacktraces anymore.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

3f84531d 05/22/2012 05:02 pm Iustin Pop

Fix NEWS file

Too many empty lines…

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

ef40c537 05/22/2012 02:01 pm René Nussbaumer

_MaybeParseUnit: The elements are dicts not arrays

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

cd415612 05/22/2012 11:25 am René Nussbaumer

Make it possible to reset vcpu/spindle ratio to default

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

ff39194f 05/22/2012 11:17 am Iustin Pop

Add man page documentation for cpu_mask hv parameter

This is adapted from the design doc.

Also fixes a typo in cmdlib.py.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

387863a5 05/22/2012 11:17 am Iustin Pop

Add checks from wrong hard-coded paths in manpages

This is trivial, but should prevent such things in the future.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

a6c79f3a 05/22/2012 11:17 am Iustin Pop

Fix hardcoded paths in gnt-cluster.rst man page

Also reworks a bit the sentence and fixes a typo.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

f67cca80 05/22/2012 11:17 am Iustin Pop

First round of NEWS file updates for 2.6

More will come, this is just what I took from the existing NEWS
entries.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

eb70f6cf 05/22/2012 10:56 am René Nussbaumer

gnt-group: Adding vcpu/spindle ratio to ipolicy flags

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

31d827d1 05/22/2012 10:56 am René Nussbaumer

gnt-cluster modify: Add ipolicy for spindle ratio opt

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

ad5cc6bd 05/22/2012 10:56 am René Nussbaumer

cli: Add ipolicy_spindle_ratio to CreateIPolicyFromOpts

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

4b42c3d6 05/21/2012 01:43 pm Jun Futagawa

Add support to daemon-util for distributions without start-stop-daemon

This adds support to daemon-util for Red Hat based distributions that
do not have a start-stop-daemon. If /sbin/start-stop-daemon is not
available, daemon-util will source /etc/rc.d/init.d/functions....

83d4ba5e 05/21/2012 12:21 pm René Nussbaumer

gnt-instance info: Rework beparams listings

This patch reworks the beparams listing to the new style. However, due
to this process the naming of the fields with mixed casing changed to
lowercase and is therefore not 100% compatible with the previous versions....

15b5f9a4 05/16/2012 02:52 pm Iustin Pop

Fix a tiny typo

Was showing in the man page as --diskN, without a space.

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

38ef0c2c 05/15/2012 06:48 pm Michael Hanselmann

constants: Add FIXME regarding CPU pinning bitfield

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

d67e0a94 05/15/2012 02:38 pm Iustin Pop

Allow units in ipolicy disk/mem CLI changes

This makes "gnt-cluster modify --specs-mem-size max=16g" work. The
downside (due to how we iterate) is that error messages are not very
clear:

$ gnt-cluster modify --specs-mem-size max=16a
Failure: prerequisites not met for this operation:...
703fa9ab 05/15/2012 02:38 pm Iustin Pop

Move some ipolicy functions from objects to cli

These are only used in CLI programs to parse command line options and
such they do not belong in object.py (I will change them more and I
don't want to add more code in objects.py).

Signed-off-by: Iustin Pop <>...

ea0f78c8 05/15/2012 02:38 pm Iustin Pop

Beautify a couple of error messages

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

0fd5547a 05/15/2012 02:38 pm Iustin Pop

Fix _ComputeNewInstanceViolations logic

This function did the opposite: was computing which old instance
violated the specs but no longer do it now. new - old is the expected
behaviour.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

0c2e59ac 05/15/2012 02:38 pm Iustin Pop

Beautify disk ipolicy violations in cluster-verify

Currently, we only get:

instance3: ['disk-size value 512 is not in range [1024, 1048576]'

which doesn't explain which disk we are talking about. This patch
extends the verification functions to take an additional parameter...

889bed16 05/15/2012 02:19 pm Michael Hanselmann

qa_utils: Factorize code for getting entity name

This reduces code duplication and provides better error messages if
something is incorrect while getting a node or instance name.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

1a4e4b17 05/15/2012 02:19 pm Michael Hanselmann

NEWS: Style fixes

- Quote where appropriate
- Small wording changes

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

2ac35588 05/14/2012 08:32 pm Michael Hanselmann

qa_utils: Accept string as instance for check

Some tests don't have access to an instance dictionary.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

51131cad 05/14/2012 06:38 pm Michael Hanselmann

QA: Cleanup after commit 5fa0375e4a

Some tests had wrong assumptions on the instance status and some
needed explicit start or stop commands.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

e78a6817 05/14/2012 06:34 pm Michael Hanselmann

LUInstanceCreate: Run rename script on instance import

If an instance is imported with a different name, network settings may have to
be changed. Since import scripts may not already to the right thing, we decided
to run the rename script. The same technique is already used for inter-cluster...

d3b51156 05/14/2012 04:49 pm René Nussbaumer

ganeti.query_unittest: Adding testcase for diskparams

Signed-off-by: René Nussbaumer <>
Reviewed-by: Michael Hanselmann <>

7228ca91 05/14/2012 02:51 pm René Nussbaumer

gnt-group add: Fix diskparam fill

This was a pretty non-obvious bug. A cluster looks sane after
gnt-cluster init, however on a daemon restart the diskparameters had the
default filled in. The same applies to gnt-group add. This is due to the
nature that UpgradeConfig() from NodeGroups did just populate them with...

b3230b32 05/14/2012 02:51 pm René Nussbaumer

gnt-group modify: Fix an update issue with diskparams

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

302424e7 05/14/2012 12:37 pm Iustin Pop

Make x509 unittest testClockSkew a bit less flaky

Since the tested function actually uses time.time(), it cannot be make
fully stable, but 1 second is very dangerous; let's just test SKEW * 2
and higher since that should be good (if the delta between _GenCert...

216d23c0 05/11/2012 05:20 pm René Nussbaumer

gnt-group: Add info command

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

64da5a53 05/11/2012 05:20 pm René Nussbaumer

cli: Make FormatParameterDict recursive

This is useful if you have nested parameter dicts like in diskparams.

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

2c758845 05/11/2012 05:20 pm René Nussbaumer

query: Expose diskparamters through query

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

f9bbf32b 05/11/2012 05:20 pm René Nussbaumer

gnt-cluster info: Print and format disk parameters

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

615b7a0f 05/11/2012 05:01 pm Iustin Pop

Merge branch 'devel-2.5'

  • devel-2.5:
    Update NEWS and bump version for 2.5.1 release
    Fix gnt-group --help display
    Fix hardcoded Xen kernel path
    Fix grow-disk handling of invalid units
    Accept both PUT and POST in noded
    Preserve bridge MTU in KVM ifup script...
5fa90892 05/11/2012 04:40 pm Iustin Pop

Merge commit 'v2.5.1' into devel-2.5

  • commit 'v2.5.1':
    Update NEWS and bump version for 2.5.1 release
    Fix gnt-group --help display
    Fix hardcoded Xen kernel path
    Fix grow-disk handling of invalid units
    Accept both PUT and POST in noded
    Preserve bridge MTU in KVM ifup script...
1a63f285 05/11/2012 03:38 pm Iustin Pop

Remove some duplicate code in the Xen config writing

Should be straightforward; the only difference from before is that we
will remove the 'auto' file even during migration finalise.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

ef2d1c57 05/11/2012 01:01 pm Iustin Pop

Update NEWS and bump version for 2.5.1 release

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

3ad56046 05/11/2012 12:03 pm Iustin Pop

Fix gnt-group --help display

Copy-paste mismatch :)

Signed-off-by: Iustin Pop <>
Reviewed-by: Bernardo Dal Seno <>
(cherry picked from commit 36c70d4ddc508dd1ffdcc806d617d5100f4cb265)

Signed-off-by: Iustin Pop <>...

3ac3de7a 05/11/2012 12:03 pm Iustin Pop

Fix hardcoded Xen kernel path

We already have a ./configure-time variable for this, but it seems to
be actually unused.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>
(cherry picked from commit 3c4afa2e93d9499ce39c1aed575dacb549d35083)...

b53874cb 05/11/2012 12:03 pm Iustin Pop

Fix grow-disk handling of invalid units

The reason why grow-disk was doing:

$ gnt-instance grow-disk instance3 0 -64
Unhandled Ganeti error: Invalid format

Is because it does it's own ParseUnit call, and doesn't transform that
into a nicer message.

Signed-off-by: Iustin Pop <>...

37c4d509 05/11/2012 12:03 pm Iustin Pop

Accept both PUT and POST in noded

This is a partial cherry-pick from
7530364ddbe949bc34fc26f25ba3f5d921beb021 on master:

Currently, noded requires PUT, even though the semantics of the RPC
calls do not match a PUT. We change the code accept both PUT and POST,...

3bdca55d 05/11/2012 12:02 pm Andrea Spadaccini

Preserve bridge MTU in KVM ifup script

Closes: #201 - KVM_IFUP does not set bridge-MTU on tap devices
Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>
(cherry picked from commit a1ec8695a6b453acdc2fa746a27be73c614b2e87)...

0fc1764f 05/11/2012 12:02 pm Michael Hanselmann

Update synopsis for “gnt-cluster repair-disk-sizes”

Mention that instances can be passed on the CLI when “--help” is used.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Andrea Spadaccini <>
(cherry picked from commit eb5ac108d146644200df98b9f90dae003dcea426)...

b3222537 05/11/2012 12:02 pm Iustin Pop

Reconcile Makefile.am and test data files

Sorry, forgot this in previous commit.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>
(cherry picked from commit 1a1e7ab3f7cfe156152fb69961115a2c85b2a82d)

Signed-off-by: Iustin Pop <>...

4c5dd3ff 05/11/2012 12:02 pm Iustin Pop

Workaround changed LVM behaviour

The vgreduce command has changed behaviour from when we initially
wrote the code (2.02.02 versus 2.02.66, 4 years delta):

- if there are LVs which will be impacted, it requires --force
- otherwise refuses to proceed, but it still returns exit code 0...

078cd57d 05/11/2012 12:02 pm Alexander Schreiber

Enable lvmstrap to run under Linux 3.x

Extend the kernel version check to also accept Linux 3.x as valid.

Signed-off-by: Alexander Schreiber <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>
(cherry picked from commit 1bf72492d381aacb5c488f1a87ac7665b9ddc6c7)...

af9fb4cc 05/10/2012 02:56 pm René Nussbaumer

apidoc: Fix some typos and errors introduced by my previous patches

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

5ff82cc9 05/10/2012 02:30 pm René Nussbaumer

bdev: Add a guard to verify disk parameters are set

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

b3f0d718 05/10/2012 02:30 pm René Nussbaumer

LUGroup*: Fix inheritance of disk parameters

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

c7c6606d 05/10/2012 02:30 pm René Nussbaumer

bdev: Take the params directly from disk without refill

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

769b0bde 05/10/2012 02:30 pm René Nussbaumer

Special case blockdev_find

Similiar to blockdev_create we sometimes do find on children. This fixes
those cases. However, this is not very nice.

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

fc5bb0fe 05/10/2012 02:30 pm René Nussbaumer

Special case blockdev_create

This is due to the nature of bdev. We spread some logic into cmdlib and
deal for example with it's children recursively. This makes it hard to
annotate the disk parameters in a generic way as we don't always deal
with the top most disk. But the disk parameters are depending on the top...

887b52e8 05/10/2012 02:30 pm René Nussbaumer

cmdlib: Adding annotation helper for special cases

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

99ccf8b9 05/10/2012 02:30 pm René Nussbaumer

cmdlib: Remove all diskparams calculations not required anymore

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>