Synnefo » snf-ganeti

#!/usr/bin/python

#

# Copyright (C) 2010, 2011 Google Inc.

#

# This program is free software; you can redistribute it and/or modify

# it under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 2 of the License, or

# (at your option) any later version.

#

# This program is distributed in the hope that it will be useful, but

# WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

# General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with this program; if not, write to the Free Software

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA

# 02110-1301, USA.

"""Script for unittesting the RAPI client module"""

import unittest

import warnings

import pycurl

from ganeti import opcodes

from ganeti import constants

from ganeti import http

from ganeti import serializer

from ganeti import utils

from ganeti import query

from ganeti import objects

from ganeti import rapi

from ganeti import errors

import ganeti.rapi.testutils

from ganeti.rapi import connector

from ganeti.rapi import rlib2

from ganeti.rapi import client

import testutils

# List of resource handlers which aren't used by the RAPI client

_KNOWN_UNUSED = set([

  rlib2.R_root,

  rlib2.R_2,

  ])

# Global variable for collecting used handlers

_used_handlers = None

class RapiMock(object):

  def __init__(self):

    self._mapper = connector.Mapper()

    self._responses = []

    self._last_handler = None

    self._last_req_data = None

  def ResetResponses(self):

    del self._responses[:]

  def AddResponse(self, response, code=200):

    self._responses.insert(0, (code, response))

  def CountPending(self):

    return len(self._responses)

  def GetLastHandler(self):

    return self._last_handler

  def GetLastRequestData(self):

    return self._last_req_data

  def FetchResponse(self, path, method, headers, request_body):

    self._last_req_data = request_body

    try:

      (handler_cls, items, args) = self._mapper.getController(path)

      # Record handler as used

      _used_handlers.add(handler_cls)

      self._last_handler = handler_cls(items, args, None)

      if not hasattr(self._last_handler, method.upper()):

        raise http.HttpNotImplemented(message="Method not implemented")

    except http.HttpException, ex:

      code = ex.code

      response = ex.message

    else:

      if not self._responses:

        raise Exception("No responses")

      (code, response) = self._responses.pop()

    return (code, NotImplemented, response)

class TestConstants(unittest.TestCase):

  def test(self):

    self.assertEqual(client.GANETI_RAPI_PORT, constants.DEFAULT_RAPI_PORT)

    self.assertEqual(client.GANETI_RAPI_VERSION, constants.RAPI_VERSION)

    self.assertEqual(client.HTTP_APP_JSON, http.HTTP_APP_JSON)

    self.assertEqual(client._REQ_DATA_VERSION_FIELD, rlib2._REQ_DATA_VERSION)

    self.assertEqual(client.JOB_STATUS_QUEUED, constants.JOB_STATUS_QUEUED)

    self.assertEqual(client.JOB_STATUS_WAITING, constants.JOB_STATUS_WAITING)

    self.assertEqual(client.JOB_STATUS_CANCELING,

                     constants.JOB_STATUS_CANCELING)

    self.assertEqual(client.JOB_STATUS_RUNNING, constants.JOB_STATUS_RUNNING)

    self.assertEqual(client.JOB_STATUS_CANCELED, constants.JOB_STATUS_CANCELED)

    self.assertEqual(client.JOB_STATUS_SUCCESS, constants.JOB_STATUS_SUCCESS)

    self.assertEqual(client.JOB_STATUS_ERROR, constants.JOB_STATUS_ERROR)

    self.assertEqual(client.JOB_STATUS_PENDING, constants.JOBS_PENDING)

    self.assertEqual(client.JOB_STATUS_FINALIZED, constants.JOBS_FINALIZED)

    self.assertEqual(client.JOB_STATUS_ALL, constants.JOB_STATUS_ALL)

    # Node evacuation

    self.assertEqual(client.NODE_EVAC_PRI, constants.NODE_EVAC_PRI)

    self.assertEqual(client.NODE_EVAC_SEC, constants.NODE_EVAC_SEC)

    self.assertEqual(client.NODE_EVAC_ALL, constants.NODE_EVAC_ALL)

    # Legacy name

    self.assertEqual(client.JOB_STATUS_WAITLOCK, constants.JOB_STATUS_WAITING)

    # RAPI feature strings

    self.assertEqual(client._INST_CREATE_REQV1, rlib2._INST_CREATE_REQV1)

    self.assertEqual(client.INST_CREATE_REQV1, rlib2._INST_CREATE_REQV1)

    self.assertEqual(client._INST_REINSTALL_REQV1, rlib2._INST_REINSTALL_REQV1)

    self.assertEqual(client.INST_REINSTALL_REQV1, rlib2._INST_REINSTALL_REQV1)

    self.assertEqual(client._NODE_MIGRATE_REQV1, rlib2._NODE_MIGRATE_REQV1)

    self.assertEqual(client.NODE_MIGRATE_REQV1, rlib2._NODE_MIGRATE_REQV1)

    self.assertEqual(client._NODE_EVAC_RES1, rlib2._NODE_EVAC_RES1)

    self.assertEqual(client.NODE_EVAC_RES1, rlib2._NODE_EVAC_RES1)

  def testErrors(self):

    self.assertEqual(client.ECODE_ALL, errors.ECODE_ALL)

    # Make sure all error codes are in both RAPI client and errors module

    for name in filter(lambda s: (s.startswith("ECODE_") and s != "ECODE_ALL"),

                       dir(client)):

      value = getattr(client, name)

      self.assertEqual(value, getattr(errors, name))

      self.assertTrue(value in client.ECODE_ALL)

      self.assertTrue(value in errors.ECODE_ALL)

class RapiMockTest(unittest.TestCase):

  def test404(self):

    (code, _, body) = RapiMock().FetchResponse("/foo", "GET", None, None)

    self.assertEqual(code, 404)

    self.assertTrue(body is None)

  def test501(self):

    (code, _, body) = RapiMock().FetchResponse("/version", "POST", None, None)

    self.assertEqual(code, 501)

    self.assertEqual(body, "Method not implemented")

  def test200(self):

    rapi = RapiMock()

    rapi.AddResponse("2")

    (code, _, response) = rapi.FetchResponse("/version", "GET", None, None)

    self.assertEqual(200, code)

    self.assertEqual("2", response)

    self.failUnless(isinstance(rapi.GetLastHandler(), rlib2.R_version))

def _FakeNoSslPycurlVersion():

  # Note: incomplete version tuple

  return (3, "7.16.0", 462848, "mysystem", 1581, None, 0)

def _FakeFancySslPycurlVersion():

  # Note: incomplete version tuple

  return (3, "7.16.0", 462848, "mysystem", 1581, "FancySSL/1.2.3", 0)

def _FakeOpenSslPycurlVersion():

  # Note: incomplete version tuple

  return (2, "7.15.5", 462597, "othersystem", 668, "OpenSSL/0.9.8c", 0)

def _FakeGnuTlsPycurlVersion():

  # Note: incomplete version tuple

  return (3, "7.18.0", 463360, "somesystem", 1581, "GnuTLS/2.0.4", 0)

class TestExtendedConfig(unittest.TestCase):

  def testAuth(self):

    cl = client.GanetiRapiClient("master.example.com",

      username="user", password="pw",

      curl_factory=lambda: rapi.testutils.FakeCurl(RapiMock()))

    curl = cl._CreateCurl()

    self.assertEqual(curl.getopt(pycurl.HTTPAUTH), pycurl.HTTPAUTH_BASIC)

    self.assertEqual(curl.getopt(pycurl.USERPWD), "user:pw")

  def testInvalidAuth(self):

    # No username

    self.assertRaises(client.Error, client.GanetiRapiClient,

                      "master-a.example.com", password="pw")

    # No password

    self.assertRaises(client.Error, client.GanetiRapiClient,

                      "master-b.example.com", username="user")

  def testCertVerifyInvalidCombinations(self):

    self.assertRaises(client.Error, client.GenericCurlConfig,

                      use_curl_cabundle=True, cafile="cert1.pem")

    self.assertRaises(client.Error, client.GenericCurlConfig,

                      use_curl_cabundle=True, capath="certs/")

    self.assertRaises(client.Error, client.GenericCurlConfig,

                      use_curl_cabundle=True,

                      cafile="cert1.pem", capath="certs/")

  def testProxySignalVerifyHostname(self):

    for use_gnutls in [False, True]:

      if use_gnutls:

        pcverfn = _FakeGnuTlsPycurlVersion

      else:

        pcverfn = _FakeOpenSslPycurlVersion

      for proxy in ["", "http://127.0.0.1:1234"]:

        for use_signal in [False, True]:

          for verify_hostname in [False, True]:

            cfgfn = client.GenericCurlConfig(proxy=proxy, use_signal=use_signal,

                                             verify_hostname=verify_hostname,

                                             _pycurl_version_fn=pcverfn)

            curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

            cl = client.GanetiRapiClient("master.example.com",

                                         curl_config_fn=cfgfn,

                                         curl_factory=curl_factory)

            curl = cl._CreateCurl()

            self.assertEqual(curl.getopt(pycurl.PROXY), proxy)

            self.assertEqual(curl.getopt(pycurl.NOSIGNAL), not use_signal)

            if verify_hostname:

              self.assertEqual(curl.getopt(pycurl.SSL_VERIFYHOST), 2)

            else:

              self.assertEqual(curl.getopt(pycurl.SSL_VERIFYHOST), 0)

  def testNoCertVerify(self):

    cfgfn = client.GenericCurlConfig()

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    curl = cl._CreateCurl()

    self.assertFalse(curl.getopt(pycurl.SSL_VERIFYPEER))

    self.assertFalse(curl.getopt(pycurl.CAINFO))

    self.assertFalse(curl.getopt(pycurl.CAPATH))

  def testCertVerifyCurlBundle(self):

    cfgfn = client.GenericCurlConfig(use_curl_cabundle=True)

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    curl = cl._CreateCurl()

    self.assert_(curl.getopt(pycurl.SSL_VERIFYPEER))

    self.assertFalse(curl.getopt(pycurl.CAINFO))

    self.assertFalse(curl.getopt(pycurl.CAPATH))

  def testCertVerifyCafile(self):

    mycert = "/tmp/some/UNUSED/cert/file.pem"

    cfgfn = client.GenericCurlConfig(cafile=mycert)

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    curl = cl._CreateCurl()

    self.assert_(curl.getopt(pycurl.SSL_VERIFYPEER))

    self.assertEqual(curl.getopt(pycurl.CAINFO), mycert)

    self.assertFalse(curl.getopt(pycurl.CAPATH))

  def testCertVerifyCapath(self):

    certdir = "/tmp/some/UNUSED/cert/directory"

    pcverfn = _FakeOpenSslPycurlVersion

    cfgfn = client.GenericCurlConfig(capath=certdir,

                                     _pycurl_version_fn=pcverfn)

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    curl = cl._CreateCurl()

    self.assert_(curl.getopt(pycurl.SSL_VERIFYPEER))

    self.assertEqual(curl.getopt(pycurl.CAPATH), certdir)

    self.assertFalse(curl.getopt(pycurl.CAINFO))

  def testCertVerifyCapathGnuTls(self):

    certdir = "/tmp/some/UNUSED/cert/directory"

    pcverfn = _FakeGnuTlsPycurlVersion

    cfgfn = client.GenericCurlConfig(capath=certdir,

                                     _pycurl_version_fn=pcverfn)

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    self.assertRaises(client.Error, cl._CreateCurl)

  def testCertVerifyNoSsl(self):

    certdir = "/tmp/some/UNUSED/cert/directory"

    pcverfn = _FakeNoSslPycurlVersion

    cfgfn = client.GenericCurlConfig(capath=certdir,

                                     _pycurl_version_fn=pcverfn)

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    self.assertRaises(client.Error, cl._CreateCurl)

  def testCertVerifyFancySsl(self):

    certdir = "/tmp/some/UNUSED/cert/directory"

    pcverfn = _FakeFancySslPycurlVersion

    cfgfn = client.GenericCurlConfig(capath=certdir,

                                     _pycurl_version_fn=pcverfn)

    curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

    cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                 curl_factory=curl_factory)

    self.assertRaises(NotImplementedError, cl._CreateCurl)

  def testCertVerifyCapath(self):

    for connect_timeout in [None, 1, 5, 10, 30, 60, 300]:

      for timeout in [None, 1, 30, 60, 3600, 24 * 3600]:

        cfgfn = client.GenericCurlConfig(connect_timeout=connect_timeout,

                                         timeout=timeout)

        curl_factory = lambda: rapi.testutils.FakeCurl(RapiMock())

        cl = client.GanetiRapiClient("master.example.com", curl_config_fn=cfgfn,

                                     curl_factory=curl_factory)

        curl = cl._CreateCurl()

        self.assertEqual(curl.getopt(pycurl.CONNECTTIMEOUT), connect_timeout)

        self.assertEqual(curl.getopt(pycurl.TIMEOUT), timeout)

class GanetiRapiClientTests(testutils.GanetiTestCase):

  def setUp(self):

    testutils.GanetiTestCase.setUp(self)

    self.rapi = RapiMock()

    self.curl = rapi.testutils.FakeCurl(self.rapi)

    self.client = client.GanetiRapiClient("master.example.com",

                                          curl_factory=lambda: self.curl)

  def assertHandler(self, handler_cls):

    self.failUnless(isinstance(self.rapi.GetLastHandler(), handler_cls))

  def assertQuery(self, key, value):

    self.assertEqual(value, self.rapi.GetLastHandler().queryargs.get(key, None))

  def assertItems(self, items):

    self.assertEqual(items, self.rapi.GetLastHandler().items)

  def assertBulk(self):

    self.assertTrue(self.rapi.GetLastHandler().useBulk())

  def assertDryRun(self):

    self.assertTrue(self.rapi.GetLastHandler().dryRun())

  def assertUseForce(self):

    self.assertTrue(self.rapi.GetLastHandler().useForce())

  def testEncodeQuery(self):

    query = [

      ("a", None),

      ("b", 1),

      ("c", 2),

      ("d", "Foo"),

      ("e", True),

      ]

    expected = [

      ("a", ""),

      ("b", 1),

      ("c", 2),

      ("d", "Foo"),

      ("e", 1),

      ]

    self.assertEqualValues(self.client._EncodeQuery(query),

                           expected)

    # invalid types

    for i in [[1, 2, 3], {"moo": "boo"}, (1, 2, 3)]:

      self.assertRaises(ValueError, self.client._EncodeQuery, [("x", i)])

  def testCurlSettings(self):

    self.rapi.AddResponse("2")

    self.assertEqual(2, self.client.GetVersion())

    self.assertHandler(rlib2.R_version)

    # Signals should be disabled by default

    self.assert_(self.curl.getopt(pycurl.NOSIGNAL))

    # No auth and no proxy

    self.assertFalse(self.curl.getopt(pycurl.USERPWD))

    self.assert_(self.curl.getopt(pycurl.PROXY) is None)

    # Content-type is required for requests

    headers = self.curl.getopt(pycurl.HTTPHEADER)

    self.assert_("Content-type: application/json" in headers)

  def testHttpError(self):

    self.rapi.AddResponse(None, code=404)

    try:

      self.client.GetJobStatus(15140)

    except client.GanetiApiError, err:

      self.assertEqual(err.code, 404)

    else:

      self.fail("Didn't raise exception")

  def testGetVersion(self):

    self.rapi.AddResponse("2")

    self.assertEqual(2, self.client.GetVersion())

    self.assertHandler(rlib2.R_version)

  def testGetFeatures(self):

    for features in [[], ["foo", "bar", "baz"]]:

      self.rapi.AddResponse(serializer.DumpJson(features))

      self.assertEqual(features, self.client.GetFeatures())

      self.assertHandler(rlib2.R_2_features)

  def testGetFeaturesNotFound(self):

    self.rapi.AddResponse(None, code=404)

    self.assertEqual([], self.client.GetFeatures())

  def testGetOperatingSystems(self):

    self.rapi.AddResponse("[\"beos\"]")

    self.assertEqual(["beos"], self.client.GetOperatingSystems())

    self.assertHandler(rlib2.R_2_os)

  def testGetClusterTags(self):

    self.rapi.AddResponse("[\"tag\"]")

    self.assertEqual(["tag"], self.client.GetClusterTags())

    self.assertHandler(rlib2.R_2_tags)

  def testAddClusterTags(self):

    self.rapi.AddResponse("1234")

    self.assertEqual(1234,

        self.client.AddClusterTags(["awesome"], dry_run=True))

    self.assertHandler(rlib2.R_2_tags)

    self.assertDryRun()

    self.assertQuery("tag", ["awesome"])

  def testDeleteClusterTags(self):

    self.rapi.AddResponse("5107")

    self.assertEqual(5107, self.client.DeleteClusterTags(["awesome"],

                                                         dry_run=True))

    self.assertHandler(rlib2.R_2_tags)

    self.assertDryRun()

    self.assertQuery("tag", ["awesome"])

  def testGetInfo(self):

    self.rapi.AddResponse("{}")

    self.assertEqual({}, self.client.GetInfo())

    self.assertHandler(rlib2.R_2_info)

  def testGetInstances(self):

    self.rapi.AddResponse("[]")

    self.assertEqual([], self.client.GetInstances(bulk=True))

    self.assertHandler(rlib2.R_2_instances)

    self.assertBulk()

  def testGetInstance(self):

    self.rapi.AddResponse("[]")

    self.assertEqual([], self.client.GetInstance("instance"))

    self.assertHandler(rlib2.R_2_instances_name)

    self.assertItems(["instance"])

  def testGetInstanceInfo(self):

    self.rapi.AddResponse("21291")

    self.assertEqual(21291, self.client.GetInstanceInfo("inst3"))

    self.assertHandler(rlib2.R_2_instances_name_info)

    self.assertItems(["inst3"])

    self.assertQuery("static", None)

    self.rapi.AddResponse("3428")

    self.assertEqual(3428, self.client.GetInstanceInfo("inst31", static=False))

    self.assertHandler(rlib2.R_2_instances_name_info)

    self.assertItems(["inst31"])

    self.assertQuery("static", ["0"])

    self.rapi.AddResponse("15665")

    self.assertEqual(15665, self.client.GetInstanceInfo("inst32", static=True))

    self.assertHandler(rlib2.R_2_instances_name_info)

    self.assertItems(["inst32"])

    self.assertQuery("static", ["1"])

  def testInstancesMultiAlloc(self):

    response = {

      constants.JOB_IDS_KEY: ["23423"],

      opcodes.OpInstanceMultiAlloc.ALLOCATABLE_KEY: ["foobar"],

      opcodes.OpInstanceMultiAlloc.FAILED_KEY: ["foobar2"],

      }

    self.rapi.AddResponse(serializer.DumpJson(response))

    insts = [self.client.InstanceAllocation("create", "foobar",

                                            "plain", [], []),

             self.client.InstanceAllocation("create", "foobar2",

                                            "drbd8", [{"size": 100}], [])]

    resp = self.client.InstancesMultiAlloc(insts)

    self.assertEqual(resp, response)

    self.assertHandler(rlib2.R_2_instances_multi_alloc)

  def testCreateInstanceOldVersion(self):

    # The old request format, version 0, is no longer supported

    self.rapi.AddResponse(None, code=404)

    self.assertRaises(client.GanetiApiError, self.client.CreateInstance,

                      "create", "inst1.example.com", "plain", [], [])

    self.assertEqual(self.rapi.CountPending(), 0)

  def testCreateInstance(self):

    self.rapi.AddResponse(serializer.DumpJson([rlib2._INST_CREATE_REQV1]))

    self.rapi.AddResponse("23030")

    job_id = self.client.CreateInstance("create", "inst1.example.com",

                                        "plain", [], [], dry_run=True)

    self.assertEqual(job_id, 23030)

    self.assertHandler(rlib2.R_2_instances)

    self.assertDryRun()

    data = serializer.LoadJson(self.rapi.GetLastRequestData())

    for field in ["dry_run", "beparams", "hvparams", "start"]:

      self.assertFalse(field in data)

    self.assertEqual(data["name"], "inst1.example.com")

    self.assertEqual(data["disk_template"], "plain")

  def testCreateInstance2(self):

    self.rapi.AddResponse(serializer.DumpJson([rlib2._INST_CREATE_REQV1]))

    self.rapi.AddResponse("24740")

    job_id = self.client.CreateInstance("import", "inst2.example.com",

                                        "drbd8", [{"size": 100,}],

                                        [{}, {"bridge": "br1", }],

                                        dry_run=False, start=True,

                                        pnode="node1", snode="node9",

                                        ip_check=False)

    self.assertEqual(job_id, 24740)

    self.assertHandler(rlib2.R_2_instances)

    data = serializer.LoadJson(self.rapi.GetLastRequestData())

    self.assertEqual(data[rlib2._REQ_DATA_VERSION], 1)

    self.assertEqual(data["name"], "inst2.example.com")

    self.assertEqual(data["disk_template"], "drbd8")

    self.assertEqual(data["start"], True)

    self.assertEqual(data["ip_check"], False)

    self.assertEqualValues(data["disks"], [{"size": 100,}])

    self.assertEqualValues(data["nics"], [{}, {"bridge": "br1", }])

  def testDeleteInstance(self):

    self.rapi.AddResponse("1234")

    self.assertEqual(1234, self.client.DeleteInstance("instance", dry_run=True))

    self.assertHandler(rlib2.R_2_instances_name)

    self.assertItems(["instance"])

    self.assertDryRun()

  def testGetInstanceTags(self):

    self.rapi.AddResponse("[]")

    self.assertEqual([], self.client.GetInstanceTags("fooinstance"))

    self.assertHandler(rlib2.R_2_instances_name_tags)

    self.assertItems(["fooinstance"])

  def testAddInstanceTags(self):

    self.rapi.AddResponse("1234")

    self.assertEqual(1234,

        self.client.AddInstanceTags("fooinstance", ["awesome"], dry_run=True))

    self.assertHandler(rlib2.R_2_instances_name_tags)

    self.assertItems(["fooinstance"])

    self.assertDryRun()

    self.assertQuery("tag", ["awesome"])

  def testDeleteInstanceTags(self):

    self.rapi.AddResponse("25826")

    self.assertEqual(25826, self.client.DeleteInstanceTags("foo", ["awesome"],

                                                           dry_run=True))

    self.assertHandler(rlib2.R_2_instances_name_tags)

    self.assertItems(["foo"])

    self.assertDryRun()

    self.assertQuery("tag", ["awesome"])

  def testRebootInstance(self):

    self.rapi.AddResponse("6146")

    job_id = self.client.RebootInstance("i-bar", reboot_type="hard",

                                        ignore_secondaries=True, dry_run=True,

                                        reason="Updates")

    self.assertEqual(6146, job_id)

    self.assertHandler(rlib2.R_2_instances_name_reboot)

    self.assertItems(["i-bar"])

    self.assertDryRun()

    self.assertQuery("type", ["hard"])

    self.assertQuery("ignore_secondaries", ["1"])

    self.assertQuery("reason", ["Updates"])

  def testRebootInstanceDefaultReason(self):

    self.rapi.AddResponse("6146")

    job_id = self.client.RebootInstance("i-bar", reboot_type="hard",

                                        ignore_secondaries=True, dry_run=True)

    self.assertEqual(6146, job_id)

    self.assertHandler(rlib2.R_2_instances_name_reboot)

    self.assertItems(["i-bar"])

    self.assertDryRun()

    self.assertQuery("type", ["hard"])

    self.assertQuery("ignore_secondaries", ["1"])

    self.assertQuery("reason", None)

  def testShutdownInstance(self):

    self.rapi.AddResponse("1487")

    self.assertEqual(1487, self.client.ShutdownInstance("foo-instance",

                                                        dry_run=True,

                                                        reason="NoMore"))

    self.assertHandler(rlib2.R_2_instances_name_shutdown)

    self.assertItems(["foo-instance"])

    self.assertDryRun()

    self.assertQuery("reason", ["NoMore"])

  def testShutdownInstanceDefaultReason(self):

    self.rapi.AddResponse("1487")

    self.assertEqual(1487, self.client.ShutdownInstance("foo-instance",

                                                        dry_run=True))

    self.assertHandler(rlib2.R_2_instances_name_shutdown)

    self.assertItems(["foo-instance"])

    self.assertDryRun()

    self.assertQuery("reason", None)

  def testStartupInstance(self):

    self.rapi.AddResponse("27149")

    self.assertEqual(27149, self.client.StartupInstance("bar-instance",

                                                        dry_run=True,

                                                        reason="New"))

    self.assertHandler(rlib2.R_2_instances_name_startup)

    self.assertItems(["bar-instance"])

    self.assertDryRun()

    self.assertQuery("reason", ["New"])

  def testStartupInstanceDefaultReason(self):

    self.rapi.AddResponse("27149")

    self.assertEqual(27149, self.client.StartupInstance("bar-instance",

                                                        dry_run=True))

    self.assertHandler(rlib2.R_2_instances_name_startup)

    self.assertItems(["bar-instance"])

    self.assertDryRun()

    self.assertQuery("reason", None)

  def testReinstallInstance(self):

    self.rapi.AddResponse(serializer.DumpJson([]))

    self.rapi.AddResponse("19119")

    self.assertEqual(19119, self.client.ReinstallInstance("baz-instance",

                                                          os="DOS",

                                                          no_startup=True))

    self.assertHandler(rlib2.R_2_instances_name_reinstall)

    self.assertItems(["baz-instance"])

    self.assertQuery("os", ["DOS"])

    self.assertQuery("nostartup", ["1"])

    self.assertEqual(self.rapi.CountPending(), 0)

  def testReinstallInstanceNew(self):

    self.rapi.AddResponse(serializer.DumpJson([rlib2._INST_REINSTALL_REQV1]))

    self.rapi.AddResponse("25689")

    self.assertEqual(25689, self.client.ReinstallInstance("moo-instance",

                                                          os="Debian",

                                                          no_startup=True))

    self.assertHandler(rlib2.R_2_instances_name_reinstall)

    self.assertItems(["moo-instance"])

    data = serializer.LoadJson(self.rapi.GetLastRequestData())

    self.assertEqual(len(data), 2)

    self.assertEqual(data["os"], "Debian")

    self.assertEqual(data["start"], False)

    self.assertEqual(self.rapi.CountPending(), 0)

  def testReinstallInstanceWithOsparams1(self):

    self.rapi.AddResponse(serializer.DumpJson([]))

    self.assertRaises(client.GanetiApiError, self.client.ReinstallInstance,

                      "doo-instance", osparams={"x": "y"})

    self.assertEqual(self.rapi.CountPending(), 0)

  def testReinstallInstanceWithOsparams2(self):

    osparams = {

      "Hello": "World",

      "foo": "bar",

      }

    self.rapi.AddResponse(serializer.DumpJson([rlib2._INST_REINSTALL_REQV1]))

    self.rapi.AddResponse("1717")

    self.assertEqual(1717, self.client.ReinstallInstance("zoo-instance",

                                                         osparams=osparams))

    self.assertHandler(rlib2.R_2_instances_name_reinstall)

    self.assertItems(["zoo-instance"])

    data = serializer.LoadJson(self.rapi.GetLastRequestData())

    self.assertEqual(len(data), 2)

    self.assertEqual(data["osparams"], osparams)

    self.assertEqual(data["start"], True)

    self.assertEqual(self.rapi.CountPending(), 0)

  def testReplaceInstanceDisks(self):

    self.rapi.AddResponse("999")

    job_id = self.client.ReplaceInstanceDisks("instance-name",

        disks=[0, 1], iallocator="hail")

    self.assertEqual(999, job_id)

    self.assertHandler(rlib2.R_2_instances_name_replace_disks)

    self.assertItems(["instance-name"])

    self.assertQuery("disks", ["0,1"])

    self.assertQuery("mode", ["replace_auto"])

    self.assertQuery("iallocator", ["hail"])

    self.rapi.AddResponse("1000")

    job_id = self.client.ReplaceInstanceDisks("instance-bar",

        disks=[1], mode="replace_on_secondary", remote_node="foo-node")

    self.assertEqual(1000, job_id)

    self.assertItems(["instance-bar"])

    self.assertQuery("disks", ["1"])

    self.assertQuery("remote_node", ["foo-node"])

    self.rapi.AddResponse("5175")