Synnefo » snf-ganeti

#!/usr/bin/python

#

# Copyright (C) 2008, 2011, 2012, 2013 Google Inc.

#

# This program is free software; you can redistribute it and/or modify

# it under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 2 of the License, or

# (at your option) any later version.

#

# This program is distributed in the hope that it will be useful, but

# WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

# General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with this program; if not, write to the Free Software

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA

# 02110-1301, USA.

"""Script for unittesting the cmdlib module"""

import os

import unittest

import time

import tempfile

import shutil

import operator

import itertools

import copy

from ganeti import constants

from ganeti import mcpu

from ganeti import cmdlib

from ganeti import opcodes

from ganeti import errors

from ganeti import utils

from ganeti import luxi

from ganeti import ht

from ganeti import objects

from ganeti import compat

from ganeti import rpc

from ganeti import locking

from ganeti import pathutils

from ganeti.masterd import iallocator

from ganeti.hypervisor import hv_xen

import testutils

import mocks

class TestCertVerification(testutils.GanetiTestCase):

  def setUp(self):

    testutils.GanetiTestCase.setUp(self)

    self.tmpdir = tempfile.mkdtemp()

  def tearDown(self):

    shutil.rmtree(self.tmpdir)

  def testVerifyCertificate(self):

    cmdlib._VerifyCertificate(testutils.TestDataFilename("cert1.pem"))

    nonexist_filename = os.path.join(self.tmpdir, "does-not-exist")

    (errcode, msg) = cmdlib._VerifyCertificate(nonexist_filename)

    self.assertEqual(errcode, cmdlib.LUClusterVerifyConfig.ETYPE_ERROR)

    # Try to load non-certificate file

    invalid_cert = testutils.TestDataFilename("bdev-net.txt")

    (errcode, msg) = cmdlib._VerifyCertificate(invalid_cert)

    self.assertEqual(errcode, cmdlib.LUClusterVerifyConfig.ETYPE_ERROR)

class TestOpcodeParams(testutils.GanetiTestCase):

  def testParamsStructures(self):

    for op in sorted(mcpu.Processor.DISPATCH_TABLE):

      lu = mcpu.Processor.DISPATCH_TABLE[op]

      lu_name = lu.__name__

      self.failIf(hasattr(lu, "_OP_REQP"),

                  msg=("LU '%s' has old-style _OP_REQP" % lu_name))

      self.failIf(hasattr(lu, "_OP_DEFS"),

                  msg=("LU '%s' has old-style _OP_DEFS" % lu_name))

      self.failIf(hasattr(lu, "_OP_PARAMS"),

                  msg=("LU '%s' has old-style _OP_PARAMS" % lu_name))

class TestIAllocatorChecks(testutils.GanetiTestCase):

  def testFunction(self):

    class TestLU(object):

      def __init__(self, opcode):

        self.cfg = mocks.FakeConfig()

        self.op = opcode

    class OpTest(opcodes.OpCode):

       OP_PARAMS = [

        ("iallocator", None, ht.NoType, None),

        ("node", None, ht.NoType, None),

        ]

    default_iallocator = mocks.FakeConfig().GetDefaultIAllocator()

    other_iallocator = default_iallocator + "_not"

    op = OpTest()

    lu = TestLU(op)

    c_i = lambda: cmdlib._CheckIAllocatorOrNode(lu, "iallocator", "node")

    # Neither node nor iallocator given

    for n in (None, []):

      op.iallocator = None

      op.node = n

      c_i()

      self.assertEqual(lu.op.iallocator, default_iallocator)

      self.assertEqual(lu.op.node, n)

    # Both, iallocator and node given

    for a in ("test", constants.DEFAULT_IALLOCATOR_SHORTCUT):

      op.iallocator = a

      op.node = "test"

      self.assertRaises(errors.OpPrereqError, c_i)

    # Only iallocator given

    for n in (None, []):

      op.iallocator = other_iallocator

      op.node = n

      c_i()

      self.assertEqual(lu.op.iallocator, other_iallocator)

      self.assertEqual(lu.op.node, n)

    # Only node given

    op.iallocator = None

    op.node = "node"

    c_i()

    self.assertEqual(lu.op.iallocator, None)

    self.assertEqual(lu.op.node, "node")

    # Asked for default iallocator, no node given

    op.iallocator = constants.DEFAULT_IALLOCATOR_SHORTCUT

    op.node = None

    c_i()

    self.assertEqual(lu.op.iallocator, default_iallocator)

    self.assertEqual(lu.op.node, None)

    # No node, iallocator or default iallocator

    op.iallocator = None

    op.node = None

    lu.cfg.GetDefaultIAllocator = lambda: None

    self.assertRaises(errors.OpPrereqError, c_i)

class TestLUTestJqueue(unittest.TestCase):

  def test(self):

    self.assert_(cmdlib.LUTestJqueue._CLIENT_CONNECT_TIMEOUT <

                 (luxi.WFJC_TIMEOUT * 0.75),

                 msg=("Client timeout too high, might not notice bugs"

                      " in WaitForJobChange"))

class TestLUQuery(unittest.TestCase):

  def test(self):

    self.assertEqual(sorted(cmdlib._QUERY_IMPL.keys()),

                     sorted(constants.QR_VIA_OP))

    assert constants.QR_NODE in constants.QR_VIA_OP

    assert constants.QR_INSTANCE in constants.QR_VIA_OP

    for i in constants.QR_VIA_OP:

      self.assert_(cmdlib._GetQueryImplementation(i))

    self.assertRaises(errors.OpPrereqError, cmdlib._GetQueryImplementation, "")

    self.assertRaises(errors.OpPrereqError, cmdlib._GetQueryImplementation,

                      "xyz")

class TestLUGroupAssignNodes(unittest.TestCase):

  def testCheckAssignmentForSplitInstances(self):

    node_data = dict((name, objects.Node(name=name, group=group))

                     for (name, group) in [("n1a", "g1"), ("n1b", "g1"),

                                           ("n2a", "g2"), ("n2b", "g2"),

                                           ("n3a", "g3"), ("n3b", "g3"),

                                           ("n3c", "g3"),

                                           ])

    def Instance(name, pnode, snode):

      if snode is None:

        disks = []

        disk_template = constants.DT_DISKLESS

      else:

        disks = [objects.Disk(dev_type=constants.LD_DRBD8,

                              logical_id=[pnode, snode, 1, 17, 17])]

        disk_template = constants.DT_DRBD8

      return objects.Instance(name=name, primary_node=pnode, disks=disks,

                              disk_template=disk_template)

    instance_data = dict((name, Instance(name, pnode, snode))

                         for name, pnode, snode in [("inst1a", "n1a", "n1b"),

                                                    ("inst1b", "n1b", "n1a"),

                                                    ("inst2a", "n2a", "n2b"),

                                                    ("inst3a", "n3a", None),

                                                    ("inst3b", "n3b", "n1b"),

                                                    ("inst3c", "n3b", "n2b"),

                                                    ])

    # Test first with the existing state.

    (new, prev) = \

      cmdlib.LUGroupAssignNodes.CheckAssignmentForSplitInstances([],

                                                                 node_data,

                                                                 instance_data)

    self.assertEqual([], new)

    self.assertEqual(set(["inst3b", "inst3c"]), set(prev))

    # And now some changes.

    (new, prev) = \

      cmdlib.LUGroupAssignNodes.CheckAssignmentForSplitInstances([("n1b",

                                                                   "g3")],

                                                                 node_data,

                                                                 instance_data)

    self.assertEqual(set(["inst1a", "inst1b"]), set(new))

    self.assertEqual(set(["inst3c"]), set(prev))

class TestClusterVerifySsh(unittest.TestCase):

  def testMultipleGroups(self):

    fn = cmdlib.LUClusterVerifyGroup._SelectSshCheckNodes

    mygroupnodes = [

      objects.Node(name="node20", group="my", offline=False),

      objects.Node(name="node21", group="my", offline=False),

      objects.Node(name="node22", group="my", offline=False),

      objects.Node(name="node23", group="my", offline=False),

      objects.Node(name="node24", group="my", offline=False),

      objects.Node(name="node25", group="my", offline=False),

      objects.Node(name="node26", group="my", offline=True),

      ]

    nodes = [

      objects.Node(name="node1", group="g1", offline=True),

      objects.Node(name="node2", group="g1", offline=False),

      objects.Node(name="node3", group="g1", offline=False),

      objects.Node(name="node4", group="g1", offline=True),

      objects.Node(name="node5", group="g1", offline=False),

      objects.Node(name="node10", group="xyz", offline=False),

      objects.Node(name="node11", group="xyz", offline=False),

      objects.Node(name="node40", group="alloff", offline=True),

      objects.Node(name="node41", group="alloff", offline=True),

      objects.Node(name="node50", group="aaa", offline=False),

      ] + mygroupnodes

    assert not utils.FindDuplicates(map(operator.attrgetter("name"), nodes))

    (online, perhost) = fn(mygroupnodes, "my", nodes)

    self.assertEqual(online, ["node%s" % i for i in range(20, 26)])

    self.assertEqual(set(perhost.keys()), set(online))

    self.assertEqual(perhost, {

      "node20": ["node10", "node2", "node50"],

      "node21": ["node11", "node3", "node50"],

      "node22": ["node10", "node5", "node50"],

      "node23": ["node11", "node2", "node50"],

      "node24": ["node10", "node3", "node50"],

      "node25": ["node11", "node5", "node50"],

      })

  def testSingleGroup(self):

    fn = cmdlib.LUClusterVerifyGroup._SelectSshCheckNodes

    nodes = [

      objects.Node(name="node1", group="default", offline=True),

      objects.Node(name="node2", group="default", offline=False),

      objects.Node(name="node3", group="default", offline=False),

      objects.Node(name="node4", group="default", offline=True),

      ]

    assert not utils.FindDuplicates(map(operator.attrgetter("name"), nodes))

    (online, perhost) = fn(nodes, "default", nodes)

    self.assertEqual(online, ["node2", "node3"])

    self.assertEqual(set(perhost.keys()), set(online))

    self.assertEqual(perhost, {

      "node2": [],

      "node3": [],

      })

class TestClusterVerifyFiles(unittest.TestCase):

  @staticmethod

  def _FakeErrorIf(errors, cond, ecode, item, msg, *args, **kwargs):

    assert ((ecode == constants.CV_ENODEFILECHECK and

             ht.TNonEmptyString(item)) or

            (ecode == constants.CV_ECLUSTERFILECHECK and

             item is None))

    if args:

      msg = msg % args

    if cond:

      errors.append((item, msg))

  _VerifyFiles = cmdlib.LUClusterVerifyGroup._VerifyFiles

  def test(self):

    errors = []

    master_name = "master.example.com"

    nodeinfo = [

      objects.Node(name=master_name, offline=False, vm_capable=True),

      objects.Node(name="node2.example.com", offline=False, vm_capable=True),

      objects.Node(name="node3.example.com", master_candidate=True,

                   vm_capable=False),

      objects.Node(name="node4.example.com", offline=False, vm_capable=True),

      objects.Node(name="nodata.example.com", offline=False, vm_capable=True),

      objects.Node(name="offline.example.com", offline=True),

      ]

    cluster = objects.Cluster(modify_etc_hosts=True,

                              enabled_hypervisors=[constants.HT_XEN_HVM])

    files_all = set([

      pathutils.CLUSTER_DOMAIN_SECRET_FILE,

      pathutils.RAPI_CERT_FILE,

      pathutils.RAPI_USERS_FILE,

      ])

    files_opt = set([

      pathutils.RAPI_USERS_FILE,

      hv_xen.XL_CONFIG_FILE,

      pathutils.VNC_PASSWORD_FILE,

      ])

    files_mc = set([

      pathutils.CLUSTER_CONF_FILE,

      ])

    files_vm = set([

      hv_xen.XEND_CONFIG_FILE,

      hv_xen.XL_CONFIG_FILE,

      pathutils.VNC_PASSWORD_FILE,

      ])

    nvinfo = {

      master_name: rpc.RpcResult(data=(True, {

        constants.NV_FILELIST: {

          pathutils.CLUSTER_CONF_FILE: "82314f897f38b35f9dab2f7c6b1593e0",

          pathutils.RAPI_CERT_FILE: "babbce8f387bc082228e544a2146fee4",

          pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",

          hv_xen.XEND_CONFIG_FILE: "b4a8a824ab3cac3d88839a9adeadf310",

          hv_xen.XL_CONFIG_FILE: "77935cee92afd26d162f9e525e3d49b9"

        }})),

      "node2.example.com": rpc.RpcResult(data=(True, {

        constants.NV_FILELIST: {

          pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",

          hv_xen.XEND_CONFIG_FILE: "b4a8a824ab3cac3d88839a9adeadf310",

          }

        })),

      "node3.example.com": rpc.RpcResult(data=(True, {

        constants.NV_FILELIST: {

          pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",

          pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",

          }

        })),

      "node4.example.com": rpc.RpcResult(data=(True, {

        constants.NV_FILELIST: {

          pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",

          pathutils.CLUSTER_CONF_FILE: "conf-a6d4b13e407867f7a7b4f0f232a8f527",

          pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",

          pathutils.RAPI_USERS_FILE: "rapiusers-ea3271e8d810ef3",

          hv_xen.XL_CONFIG_FILE: "77935cee92afd26d162f9e525e3d49b9"

          }

        })),

      "nodata.example.com": rpc.RpcResult(data=(True, {})),

      "offline.example.com": rpc.RpcResult(offline=True),

      }

    assert set(nvinfo.keys()) == set(map(operator.attrgetter("name"), nodeinfo))

    self._VerifyFiles(compat.partial(self._FakeErrorIf, errors), nodeinfo,

                      master_name, nvinfo,

                      (files_all, files_opt, files_mc, files_vm))

    self.assertEqual(sorted(errors), sorted([

      (None, ("File %s found with 2 different checksums (variant 1 on"

              " node2.example.com, node3.example.com, node4.example.com;"

              " variant 2 on master.example.com)" % pathutils.RAPI_CERT_FILE)),

      (None, ("File %s is missing from node(s) node2.example.com" %

              pathutils.CLUSTER_DOMAIN_SECRET_FILE)),

      (None, ("File %s should not exist on node(s) node4.example.com" %

              pathutils.CLUSTER_CONF_FILE)),

      (None, ("File %s is missing from node(s) node4.example.com" %

              hv_xen.XEND_CONFIG_FILE)),

      (None, ("File %s is missing from node(s) node3.example.com" %

              pathutils.CLUSTER_CONF_FILE)),

      (None, ("File %s found with 2 different checksums (variant 1 on"

              " master.example.com; variant 2 on node4.example.com)" %

              pathutils.CLUSTER_CONF_FILE)),

      (None, ("File %s is optional, but it must exist on all or no nodes (not"

              " found on master.example.com, node2.example.com,"

              " node3.example.com)" % pathutils.RAPI_USERS_FILE)),

      (None, ("File %s is optional, but it must exist on all or no nodes (not"

              " found on node2.example.com)" % hv_xen.XL_CONFIG_FILE)),

      ("nodata.example.com", "Node did not return file checksum data"),

      ]))

class _FakeLU:

  def __init__(self, cfg=NotImplemented, proc=NotImplemented,

               rpc=NotImplemented):

    self.warning_log = []

    self.info_log = []

    self.cfg = cfg

    self.proc = proc

    self.rpc = rpc

  def LogWarning(self, text, *args):

    self.warning_log.append((text, args))

  def LogInfo(self, text, *args):

    self.info_log.append((text, args))

class TestLoadNodeEvacResult(unittest.TestCase):

  def testSuccess(self):

    for moved in [[], [

      ("inst20153.example.com", "grp2", ["nodeA4509", "nodeB2912"]),

      ]]:

      for early_release in [False, True]:

        for use_nodes in [False, True]:

          jobs = [

            [opcodes.OpInstanceReplaceDisks().__getstate__()],

            [opcodes.OpInstanceMigrate().__getstate__()],

            ]

          alloc_result = (moved, [], jobs)

          assert iallocator._NEVAC_RESULT(alloc_result)

          lu = _FakeLU()

          result = cmdlib._LoadNodeEvacResult(lu, alloc_result,

                                              early_release, use_nodes)

          if moved:

            (_, (info_args, )) = lu.info_log.pop(0)

            for (instname, instgroup, instnodes) in moved:

              self.assertTrue(instname in info_args)

              if use_nodes:

                for i in instnodes:

                  self.assertTrue(i in info_args)

              else:

                self.assertTrue(instgroup in info_args)

          self.assertFalse(lu.info_log)

          self.assertFalse(lu.warning_log)

          for op in itertools.chain(*result):

            if hasattr(op.__class__, "early_release"):

              self.assertEqual(op.early_release, early_release)

            else:

              self.assertFalse(hasattr(op, "early_release"))

  def testFailed(self):

    alloc_result = ([], [

      ("inst5191.example.com", "errormsg21178"),

      ], [])

    assert iallocator._NEVAC_RESULT(alloc_result)

    lu = _FakeLU()

    self.assertRaises(errors.OpExecError, cmdlib._LoadNodeEvacResult,

                      lu, alloc_result, False, False)

    self.assertFalse(lu.info_log)

    (_, (args, )) = lu.warning_log.pop(0)

    self.assertTrue("inst5191.example.com" in args)

    self.assertTrue("errormsg21178" in args)

    self.assertFalse(lu.warning_log)

class TestUpdateAndVerifySubDict(unittest.TestCase):

  def setUp(self):

    self.type_check = {

        "a": constants.VTYPE_INT,

        "b": constants.VTYPE_STRING,

        "c": constants.VTYPE_BOOL,

        "d": constants.VTYPE_STRING,

        }

  def test(self):

    old_test = {

      "foo": {

        "d": "blubb",

        "a": 321,

        },

      "baz": {

        "a": 678,

        "b": "678",

        "c": True,

        },

      }

    test = {

      "foo": {

        "a": 123,

        "b": "123",

        "c": True,

        },

      "bar": {

        "a": 321,

        "b": "321",

        "c": False,

        },

      }

    mv = {

      "foo": {

        "a": 123,

        "b": "123",

        "c": True,

        "d": "blubb"

        },

      "bar": {

        "a": 321,

        "b": "321",

        "c": False,

        },

      "baz": {

        "a": 678,

        "b": "678",

        "c": True,

        },

      }

    verified = cmdlib._UpdateAndVerifySubDict(old_test, test, self.type_check)

    self.assertEqual(verified, mv)

  def testWrong(self):

    test = {

      "foo": {

        "a": "blubb",

        "b": "123",

        "c": True,

        },

      "bar": {

        "a": 321,

        "b": "321",

        "c": False,

        },

      }

    self.assertRaises(errors.TypeEnforcementError,

                      cmdlib._UpdateAndVerifySubDict, {}, test, self.type_check)

class TestHvStateHelper(unittest.TestCase):

  def testWithoutOpData(self):

    self.assertEqual(cmdlib._MergeAndVerifyHvState(None, NotImplemented), None)

  def testWithoutOldData(self):

    new = {

      constants.HT_XEN_PVM: {

        constants.HVST_MEMORY_TOTAL: 4096,

        },

      }

    self.assertEqual(cmdlib._MergeAndVerifyHvState(new, None), new)

  def testWithWrongHv(self):

    new = {

      "i-dont-exist": {

        constants.HVST_MEMORY_TOTAL: 4096,

        },

      }

    self.assertRaises(errors.OpPrereqError, cmdlib._MergeAndVerifyHvState, new,

                      None)

class TestDiskStateHelper(unittest.TestCase):

  def testWithoutOpData(self):

    self.assertEqual(cmdlib._MergeAndVerifyDiskState(None, NotImplemented),

                     None)

  def testWithoutOldData(self):

    new = {

      constants.LD_LV: {

        "xenvg": {

          constants.DS_DISK_RESERVED: 1024,

          },

        },

      }

    self.assertEqual(cmdlib._MergeAndVerifyDiskState(new, None), new)

  def testWithWrongStorageType(self):

    new = {

      "i-dont-exist": {

        "xenvg": {

          constants.DS_DISK_RESERVED: 1024,

          },

        },

      }

    self.assertRaises(errors.OpPrereqError, cmdlib._MergeAndVerifyDiskState,

                      new, None)

class TestComputeMinMaxSpec(unittest.TestCase):

  def setUp(self):

    self.ispecs = {

      constants.ISPECS_MAX: {

        constants.ISPEC_MEM_SIZE: 512,

        constants.ISPEC_DISK_SIZE: 1024,

        },

      constants.ISPECS_MIN: {

        constants.ISPEC_MEM_SIZE: 128,

        constants.ISPEC_DISK_COUNT: 1,

        },

      }

  def testNoneValue(self):

    self.assertTrue(cmdlib._ComputeMinMaxSpec(constants.ISPEC_MEM_SIZE, None,

                                              self.ispecs, None) is None)

  def testAutoValue(self):

    self.assertTrue(cmdlib._ComputeMinMaxSpec(constants.ISPEC_MEM_SIZE, None,

                                              self.ispecs,

                                              constants.VALUE_AUTO) is None)

  def testNotDefined(self):

    self.assertTrue(cmdlib._ComputeMinMaxSpec(constants.ISPEC_NIC_COUNT, None,

                                              self.ispecs, 3) is None)

  def testNoMinDefined(self):

    self.assertTrue(cmdlib._ComputeMinMaxSpec(constants.ISPEC_DISK_SIZE, None,

                                              self.ispecs, 128) is None)

  def testNoMaxDefined(self):

    self.assertTrue(cmdlib._ComputeMinMaxSpec(constants.ISPEC_DISK_COUNT, None,

                                                self.ispecs, 16) is None)

  def testOutOfRange(self):

    for (name, val) in ((constants.ISPEC_MEM_SIZE, 64),

                        (constants.ISPEC_MEM_SIZE, 768),

                        (constants.ISPEC_DISK_SIZE, 4096),

                        (constants.ISPEC_DISK_COUNT, 0)):

      min_v = self.ispecs[constants.ISPECS_MIN].get(name, val)

      max_v = self.ispecs[constants.ISPECS_MAX].get(name, val)

      self.assertEqual(cmdlib._ComputeMinMaxSpec(name, None,

                                                 self.ispecs, val),

                       "%s value %s is not in range [%s, %s]" %

                       (name, val,min_v, max_v))

      self.assertEqual(cmdlib._ComputeMinMaxSpec(name, "1",

                                                 self.ispecs, val),

                       "%s/1 value %s is not in range [%s, %s]" %

                       (name, val,min_v, max_v))

  def test(self):

    for (name, val) in ((constants.ISPEC_MEM_SIZE, 256),

                        (constants.ISPEC_MEM_SIZE, 128),

                        (constants.ISPEC_MEM_SIZE, 512),

                        (constants.ISPEC_DISK_SIZE, 1024),

                        (constants.ISPEC_DISK_SIZE, 0),

                        (constants.ISPEC_DISK_COUNT, 1),

                        (constants.ISPEC_DISK_COUNT, 5)):

      self.assertTrue(cmdlib._ComputeMinMaxSpec(name, None, self.ispecs, val)

                      is None)

def _ValidateComputeMinMaxSpec(name, *_):

  assert name in constants.ISPECS_PARAMETERS

  return None

def _NoDiskComputeMinMaxSpec(name, *_):

  if name == constants.ISPEC_DISK_COUNT:

    return name

  else:

    return None

class _SpecWrapper:

  def __init__(self, spec):

    self.spec = spec

  def ComputeMinMaxSpec(self, *args):

    return self.spec.pop(0)

class TestComputeIPolicySpecViolation(unittest.TestCase):

  # Minimal policy accepted by _ComputeIPolicySpecViolation()

  _MICRO_IPOL = {

    constants.IPOLICY_DTS: [constants.DT_PLAIN, constants.DT_DISKLESS],

    constants.ISPECS_MINMAX: NotImplemented,

    }

  def test(self):

    compute_fn = _ValidateComputeMinMaxSpec

    ret = cmdlib._ComputeIPolicySpecViolation(self._MICRO_IPOL, 1024, 1, 1, 1,

                                              [1024], 1, constants.DT_PLAIN,

                                              _compute_fn=compute_fn)

    self.assertEqual(ret, [])

  def testDiskFull(self):

    compute_fn = _NoDiskComputeMinMaxSpec

    ret = cmdlib._ComputeIPolicySpecViolation(self._MICRO_IPOL, 1024, 1, 1, 1,

                                              [1024], 1, constants.DT_PLAIN,

                                              _compute_fn=compute_fn)

    self.assertEqual(ret, [constants.ISPEC_DISK_COUNT])

  def testDiskLess(self):

    compute_fn = _NoDiskComputeMinMaxSpec

    ret = cmdlib._ComputeIPolicySpecViolation(self._MICRO_IPOL, 1024, 1, 1, 1,

                                              [1024], 1, constants.DT_DISKLESS,

                                              _compute_fn=compute_fn)

    self.assertEqual(ret, [])

  def testWrongTemplates(self):

    compute_fn = _ValidateComputeMinMaxSpec

    ret = cmdlib._ComputeIPolicySpecViolation(self._MICRO_IPOL, 1024, 1, 1, 1,

                                              [1024], 1, constants.DT_DRBD8,

                                              _compute_fn=compute_fn)

    self.assertEqual(len(ret), 1)

    self.assertTrue("Disk template" in ret[0])

  def testInvalidArguments(self):

    self.assertRaises(AssertionError, cmdlib._ComputeIPolicySpecViolation,

                      self._MICRO_IPOL, 1024, 1, 1, 1, [], 1,

                      constants.DT_PLAIN,)

  def testInvalidSpec(self):

    spec = _SpecWrapper([None, False, "foo", None, "bar", None])

    compute_fn = spec.ComputeMinMaxSpec

    ret = cmdlib._ComputeIPolicySpecViolation(self._MICRO_IPOL, 1024, 1, 1, 1,

                                              [1024], 1, constants.DT_PLAIN,

                                              _compute_fn=compute_fn)

    self.assertEqual(ret, ["foo", "bar"])

    self.assertFalse(spec.spec)

class _StubComputeIPolicySpecViolation:

  def __init__(self, mem_size, cpu_count, disk_count, nic_count, disk_sizes,

               spindle_use, disk_template):

    self.mem_size = mem_size

    self.cpu_count = cpu_count

    self.disk_count = disk_count

    self.nic_count = nic_count

    self.disk_sizes = disk_sizes

    self.spindle_use = spindle_use

    self.disk_template = disk_template

  def __call__(self, _, mem_size, cpu_count, disk_count, nic_count, disk_sizes,

               spindle_use, disk_template):

    assert self.mem_size == mem_size

    assert self.cpu_count == cpu_count

    assert self.disk_count == disk_count

    assert self.nic_count == nic_count

    assert self.disk_sizes == disk_sizes

    assert self.spindle_use == spindle_use

    assert self.disk_template == disk_template

    return []

class _FakeConfigForComputeIPolicyInstanceViolation:

  def __init__(self, be):