« Previous | Next » 

Revision fe482621

IDfe48262190eea55a2e8d5ac3147f0aa6e59ea55b
Parent 5e66b7e6
Child d63e148a

Added by Iustin Pop about 14 years ago

Change the order of config updates in some LUs

In the start and stop instance LUs, the configuration update is done
right at the end. This means that if, for example, the instance shutdown
succeeds, but the drive deactivation fails, the next run of the watcher
will start the instance again, as it's still marked in running mode.

This patch changes these two LUs so that first the update the
configuration to the desired state, and only then we proceed to update
the config. This ensures that the state saved is the desired state.

Because the config might be updated even though the LU failed, this
patch also modifies the mcpu.Processor.ExecOpCode method to run the
RunConfigUpdate hook in a finally: phase while the lu.Exec is done in
its try phase. This ensures that config update hooks (tries to) run at
all times when the config is updated.

Reviewed-by: schreiberal

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences