import/export: Validate remote host/port

[ganeti-local] / test / ganeti.masterd.instance_unittest.py

diff --git a/test/ganeti.masterd.instance_unittest.py b/test/ganeti.masterd.instance_unittest.py
index 05b0183..2daa1a4 100755 (executable)
--- a/test/ganeti.masterd.instance_unittest.py
+++ b/test/ganeti.masterd.instance_unittest.py
@@ -25,11 +25,16 @@ import os
 import sys
 import unittest
 
+from ganeti import constants
+from ganeti import errors
 from ganeti import utils
 from ganeti import masterd
 
 from ganeti.masterd.instance import \
-  ImportExportTimeouts, _TimeoutExpired, _DiskImportExportBase
+  ImportExportTimeouts, _TimeoutExpired, _DiskImportExportBase, \
+  ComputeRemoteExportHandshake, CheckRemoteExportHandshake, \
+  ComputeRemoteImportDiskInfo, CheckRemoteExportDiskInfo, \
+  FormatProgress
 
 import testutils
 
@@ -41,10 +46,19 @@ class TestMisc(unittest.TestCase):
     self.assertEqual(tmo.listen, ImportExportTimeouts.DEFAULT_LISTEN_TIMEOUT)
     self.assertEqual(tmo.ready, ImportExportTimeouts.DEFAULT_READY_TIMEOUT)
     self.assertEqual(tmo.error, ImportExportTimeouts.DEFAULT_ERROR_TIMEOUT)
+    self.assertEqual(tmo.progress,
+                     ImportExportTimeouts.DEFAULT_PROGRESS_INTERVAL)
 
     tmo = ImportExportTimeouts(999)
     self.assertEqual(tmo.connect, 999)
 
+    tmo = ImportExportTimeouts(1, listen=2, error=3, ready=4, progress=5)
+    self.assertEqual(tmo.connect, 1)
+    self.assertEqual(tmo.listen, 2)
+    self.assertEqual(tmo.error, 3)
+    self.assertEqual(tmo.ready, 4)
+    self.assertEqual(tmo.progress, 5)
+
   def testTimeoutExpired(self):
     self.assert_(_TimeoutExpired(100, 300, _time_fn=lambda: 500))
     self.assertFalse(_TimeoutExpired(100, 300, _time_fn=lambda: 0))
@@ -56,5 +70,88 @@ class TestMisc(unittest.TestCase):
                       None, None, None, None, None, None, None)
 
 
+class TestRieHandshake(unittest.TestCase):
+  def test(self):
+    cds = "cd-secret"
+    hs = ComputeRemoteExportHandshake(cds)
+    self.assertEqual(len(hs), 3)
+    self.assertEqual(hs[0], constants.RIE_VERSION)
+
+    self.assertEqual(CheckRemoteExportHandshake(cds, hs), None)
+
+  def testCheckErrors(self):
+    self.assert_(CheckRemoteExportHandshake(None, None))
+    self.assert_(CheckRemoteExportHandshake("", ""))
+    self.assert_(CheckRemoteExportHandshake("", ("xyz", "foo")))
+
+  def testCheckWrongHash(self):
+    cds = "cd-secret999"
+    self.assert_(CheckRemoteExportHandshake(cds, (0, "fakehash", "xyz")))
+
+  def testCheckWrongVersion(self):
+    version = 14887
+    self.assertNotEqual(version, constants.RIE_VERSION)
+    cds = "c28ac99"
+    salt = "a19cf8cc06"
+    msg = "%s:%s" % (version, constants.RIE_HANDSHAKE)
+    hs = (version, utils.Sha1Hmac(cds, msg, salt=salt), salt)
+    self.assert_(CheckRemoteExportHandshake(cds, hs))
+
+
+class TestRieDiskInfo(unittest.TestCase):
+  def test(self):
+    cds = "bbf46ea9a"
+    salt = "ee5ad9"
+    di = ComputeRemoteImportDiskInfo(cds, salt, 0, "node1", 1234)
+    self.assertEqual(CheckRemoteExportDiskInfo(cds, 0, di),
+                     ("node1", 1234))
+
+    for i in range(1, 100):
+      # Wrong disk index
+      self.assertRaises(errors.GenericError, CheckRemoteExportDiskInfo,
+                        cds, i, di)
+
+  def testInvalidHostPort(self):
+    cds = "3ZoJY8KtGJ"
+    salt = "drK5oYiHWD"
+
+    for host in [",", "...", "Hello World", "`", "!", "#", "\\"]:
+      di = ComputeRemoteImportDiskInfo(cds, salt, 0, host, 1234)
+      self.assertRaises(errors.OpPrereqError,
+                        CheckRemoteExportDiskInfo, cds, 0, di)
+
+    for port in [-1, 792825908, "HelloWorld!", "`#", "\\\"", "_?_"]:
+      di = ComputeRemoteImportDiskInfo(cds, salt, 0, "localhost", port)
+      self.assertRaises(errors.OpPrereqError,
+                        CheckRemoteExportDiskInfo, cds, 0, di)
+
+  def testCheckErrors(self):
+    cds = "0776450535a"
+    self.assertRaises(errors.GenericError, CheckRemoteExportDiskInfo,
+                      cds, 0, "")
+    self.assertRaises(errors.GenericError, CheckRemoteExportDiskInfo,
+                      cds, 0, ())
+    self.assertRaises(errors.GenericError, CheckRemoteExportDiskInfo,
+                      cds, 0, ("", 1, 2, 3, 4, 5))
+
+    # No host/port
+    self.assertRaises(errors.GenericError, CheckRemoteExportDiskInfo,
+                      cds, 0, ("", 0, "", ""))
+
+    # Wrong hash
+    self.assertRaises(errors.GenericError, CheckRemoteExportDiskInfo,
+                      cds, 0, ("nodeX", 123, "fakehash", "xyz"))
+
+
+class TestFormatProgress(unittest.TestCase):
+  def test(self):
+    FormatProgress((0, 0, None, None))
+    FormatProgress((100, 3.3, 30, None))
+    FormatProgress((100, 3.3, 30, 900))
+
+    self.assertEqual(FormatProgress((1500, 12, 30, None)),
+                     "1.5G, 12.0 MiB/s, 30%")
+
+
 if __name__ == "__main__":
   testutils.GanetiTestProgram()