Switch RAPI to default ganeti logging and Daemonize it with ganeti.utils

[ganeti-local] / daemons / ganeti-rapi

diff --git a/daemons/ganeti-rapi b/daemons/ganeti-rapi
index 1136959..834c957 100755 (executable)
--- a/daemons/ganeti-rapi
+++ b/daemons/ganeti-rapi
@@ -22,12 +22,13 @@
 """
 
 import glob
-import logging
 import optparse
 import sys
 import os
 
-import ganeti.rapi.RESTHTTPServer
+from ganeti import constants
+from ganeti import utils
+from ganeti.rapi import RESTHTTPServer
 
 RELEASE_VERSION = 0.01
 API_PORT = 5080
@@ -49,7 +50,7 @@ def ParseOptions():
                     default=False, action="store_true")
   parser.add_option("-p", "--port", dest="port",
                     help="Port to run API",
-                    default=API_PORT)
+                    default=API_PORT, type="int")
   parser.add_option("-S", "--https", dest="ssl",
                     help="Secure HTTP protocol with SSL",
                     default=False, action="store_true")
@@ -59,16 +60,20 @@ def ParseOptions():
   parser.add_option("-C", "--ssl-cert", dest="ssl_cert",
                     help="SSL certificate",
                     default=None, type="string")
+  parser.add_option("-f", "--foreground", dest="fork",
+                    help="Don't detach from the current terminal",
+                    default=True, action="store_false")
+
   options, args = parser.parse_args()
 
   if len(args) != 1 or args[0] not in ("start", "stop"):
-    print >>sys.stderr, "Usage: %s [-d] [-p port] start|stop\n" % sys.argv[0]
+    print >> sys.stderr, "Usage: %s [-d] [-p port] start|stop\n" % sys.argv[0]
     sys.exit(1)
 
   if options.ssl:
     if not (options.ssl_cert and options.ssl_key):
-      print >>sys.stderr, "For secure mode please provide " \
-                        "--ssl-key and --ssl-cert arguments"
+      print >> sys.stderr, ("For secure mode please provide "
+                           "--ssl-key and --ssl-cert arguments")
       sys.exit(1)
 
   return options, args
@@ -84,7 +89,7 @@ def Port2PID(port):
     PID number.
   """
 
-  _NET_STAT = ['/proc/net/tcp','/proc/net/udp']
+  _NET_STAT = ['/proc/net/tcp', '/proc/net/udp']
 
   inode2port = {}
   port2pid = {}
@@ -128,50 +133,26 @@ def StartAPI(options):
   Return:
     Exit code.
   """
-  port = int(options.port)
-  # do the UNIX double-fork magic
-  try:
-    pid = os.fork()
-    if pid > 0:
-      # exit first parent
-      sys.exit(0)
-  except OSError, e:
-    print >>sys.stderr, "fork #1 failed: %d (%s)" % (e.errno, e.strerror)
-    return 1
-
-  # decouple from parent environment
-  os.chdir("/")
-  os.setsid()
-  os.umask(0)
-
-  # do second fork
-  try:
-    pid = os.fork()
-    if pid > 0:
-      # exit from second parent, print eventual PID before
-      print "Ganeti-RAPI PID: %d port: %d" % (pid, port)
-      return 0
-  except OSError, e:
-    print >>sys.stderr, "fork #2 failed: %d (%s)" % (e.errno, e.strerror)
-    return 1
-
-  # start the daemon main loop
-  ganeti.rapi.RESTHTTPServer.start(options)
+  if options.fork:
+    utils.Daemonize(logfile=constants.LOG_RAPISERVER)
+  RESTHTTPServer.start(options)
 
 
 def StopAPI(options):
   """Stop the API."""
-  port = int(options.port)
   try:
-    pid = Port2PID(port)
+    pid = Port2PID(options.port)
     if pid:
-      print "Stopping Ganeti-RAPI PID: %d, port: %d.... " % (pid, port),
+      print ("Stopping Ganeti-RAPI PID: %d, port: %d... "
+             % (pid, options.port)),
       os.kill(pid, 9)
       print "done."
     else:
-      print >>sys.stderr, "Unable to locate running Ganeti-RAPI on port: %d" % port
+      print >> sys.stderr, "Unable to locate running Ganeti-RAPI on port: %d" \
+          % options.port
+
   except Exception, ex:
-    print >>sys.stderr, ex
+    print >> sys.stderr, ex
     return 1
   return 0