(
-- * Types
Placement
- , Solution(..)
+ , AllocSolution
, Table(..)
- , Removal
, Score
, IMove(..)
+ , CStats(..)
-- * Generic functions
, totalResources
-- * First phase functions
, computeBadItems
-- * Second phase functions
- , computeSolution
- , applySolution
, printSolution
, printSolutionLine
, formatCmds
, printNodes
-- * Balacing functions
- , applyMove
, checkMove
, compCV
, printStats
-- * IAllocator functions
- , allocateOnSingle
- , allocateOnPair
, tryAlloc
, tryReloc
+ , collapseFailures
) where
import Data.List
-import Data.Maybe (isNothing, fromJust)
import Text.Printf (printf)
import Data.Function
import Control.Monad
-- | The description of an instance placement.
type Placement = (Idx, Ndx, Ndx, Score)
--- | A cluster solution described as the solution delta and the list
--- of placements.
-data Solution = Solution Int [Placement]
- deriving (Eq, Ord, Show)
+-- | Allocation\/relocation solution.
+type AllocSolution = ([FailMode], Int, Maybe (Score, AllocElement))
--- | A removal set.
-data Removal = Removal Node.List [Instance.Instance]
+-- | Allocation\/relocation element.
+type AllocElement = (Node.List, Instance.Instance, [Node.Node])
-- | An instance move definition
data IMove = Failover -- ^ Failover the instance (f)
data Table = Table Node.List Instance.List Score [Placement]
deriving (Show)
--- * Utility functions
-
--- | Returns the delta of a solution or -1 for Nothing.
-solutionDelta :: Maybe Solution -> Int
-solutionDelta sol = case sol of
- Just (Solution d _) -> d
- _ -> -1
+data CStats = CStats { cs_fmem :: Int -- ^ Cluster free mem
+ , cs_fdsk :: Int -- ^ Cluster free disk
+ , cs_amem :: Int -- ^ Cluster allocatable mem
+ , cs_adsk :: Int -- ^ Cluster allocatable disk
+ , cs_acpu :: Int -- ^ Cluster allocatable cpus
+ , cs_mmem :: Int -- ^ Max node allocatable mem
+ , cs_mdsk :: Int -- ^ Max node allocatable disk
+ , cs_mcpu :: Int -- ^ Max node allocatable cpu
+ , cs_imem :: Int -- ^ Instance used mem
+ , cs_idsk :: Int -- ^ Instance used disk
+ , cs_icpu :: Int -- ^ Instance used cpu
+ , cs_tmem :: Double -- ^ Cluster total mem
+ , cs_tdsk :: Double -- ^ Cluster total disk
+ , cs_tcpu :: Double -- ^ Cluster total cpus
+ , cs_xmem :: Int -- ^ Unnacounted for mem
+ , cs_nmem :: Int -- ^ Node own memory
+ , cs_score :: Score -- ^ The cluster score
+ , cs_ninst :: Int -- ^ The total number of instances
+ }
--- | Cap the removal list if needed.
-capRemovals :: [a] -> Int -> [a]
-capRemovals removals max_removals =
- if max_removals > 0 then
- take max_removals removals
- else
- removals
-
--- | Check if the given node list fails the N+1 check.
-verifyN1Check :: [Node.Node] -> Bool
-verifyN1Check nl = any Node.failN1 nl
+-- * Utility functions
-- | Verifies the N+1 status and return the affected nodes.
verifyN1 :: [Node.Node] -> [Node.Node]
-verifyN1 nl = filter Node.failN1 nl
+verifyN1 = filter Node.failN1
{-| Computes the pair of bad nodes and instances.
([Node.Node], [Instance.Instance])
computeBadItems nl il =
let bad_nodes = verifyN1 $ getOnline nl
- bad_instances = map (\idx -> Container.find idx il) $
- sort $ nub $ concat $
- map (\ n -> (Node.slist n) ++ (Node.plist n)) bad_nodes
+ bad_instances = map (\idx -> Container.find idx il) .
+ sort . nub $
+ concatMap (\ n -> Node.slist n ++ Node.plist n) bad_nodes
in
(bad_nodes, bad_instances)
+emptyCStats :: CStats
+emptyCStats = CStats { cs_fmem = 0
+ , cs_fdsk = 0
+ , cs_amem = 0
+ , cs_adsk = 0
+ , cs_acpu = 0
+ , cs_mmem = 0
+ , cs_mdsk = 0
+ , cs_mcpu = 0
+ , cs_imem = 0
+ , cs_idsk = 0
+ , cs_icpu = 0
+ , cs_tmem = 0
+ , cs_tdsk = 0
+ , cs_tcpu = 0
+ , cs_xmem = 0
+ , cs_nmem = 0
+ , cs_score = 0
+ , cs_ninst = 0
+ }
+
+updateCStats :: CStats -> Node.Node -> CStats
+updateCStats cs node =
+ let CStats { cs_fmem = x_fmem, cs_fdsk = x_fdsk,
+ cs_amem = x_amem, cs_acpu = x_acpu, cs_adsk = x_adsk,
+ cs_mmem = x_mmem, cs_mdsk = x_mdsk, cs_mcpu = x_mcpu,
+ cs_imem = x_imem, cs_idsk = x_idsk, cs_icpu = x_icpu,
+ cs_tmem = x_tmem, cs_tdsk = x_tdsk, cs_tcpu = x_tcpu,
+ cs_xmem = x_xmem, cs_nmem = x_nmem, cs_ninst = x_ninst
+ }
+ = cs
+ inc_amem = Node.f_mem node - Node.r_mem node
+ inc_amem' = if inc_amem > 0 then inc_amem else 0
+ inc_adsk = Node.availDisk node
+ inc_imem = truncate (Node.t_mem node) - Node.n_mem node
+ - Node.x_mem node - Node.f_mem node
+ inc_icpu = Node.u_cpu node
+ inc_idsk = truncate (Node.t_dsk node) - Node.f_dsk node
+
+ in cs { cs_fmem = x_fmem + Node.f_mem node
+ , cs_fdsk = x_fdsk + Node.f_dsk node
+ , cs_amem = x_amem + inc_amem'
+ , cs_adsk = x_adsk + inc_adsk
+ , cs_acpu = x_acpu
+ , cs_mmem = max x_mmem inc_amem'
+ , cs_mdsk = max x_mdsk inc_adsk
+ , cs_mcpu = x_mcpu
+ , cs_imem = x_imem + inc_imem
+ , cs_idsk = x_idsk + inc_idsk
+ , cs_icpu = x_icpu + inc_icpu
+ , cs_tmem = x_tmem + Node.t_mem node
+ , cs_tdsk = x_tdsk + Node.t_dsk node
+ , cs_tcpu = x_tcpu + Node.t_cpu node
+ , cs_xmem = x_xmem + Node.x_mem node
+ , cs_nmem = x_nmem + Node.n_mem node
+ , cs_ninst = x_ninst + length (Node.plist node)
+ }
+
-- | Compute the total free disk and memory in the cluster.
-totalResources :: Node.List -> (Int, Int)
+totalResources :: Node.List -> CStats
totalResources nl =
- foldl'
- (\ (mem, dsk) node -> (mem + (Node.f_mem node),
- dsk + (Node.f_dsk node)))
- (0, 0) (Container.elems nl)
+ let cs = foldl' updateCStats emptyCStats . Container.elems $ nl
+ in cs { cs_score = compCV nl }
-- | Compute the mem and disk covariance.
compDetailedCV :: Node.List -> (Double, Double, Double, Double, Double, Double)
mem_cv = varianceCoeff mem_l
dsk_cv = varianceCoeff dsk_l
n1_l = length $ filter Node.failN1 nodes
- n1_score = (fromIntegral n1_l) / (fromIntegral $ length nodes)
+ n1_score = fromIntegral n1_l /
+ fromIntegral (length nodes)::Double
res_l = map Node.p_rem nodes
res_cv = varianceCoeff res_l
offline_inst = sum . map (\n -> (length . Node.plist $ n) +
(length . Node.slist $ n)) $ offline
online_inst = sum . map (\n -> (length . Node.plist $ n) +
(length . Node.slist $ n)) $ nodes
- off_score = (fromIntegral offline_inst) /
- (fromIntegral $ online_inst + offline_inst)
+ off_score = if offline_inst == 0
+ then 0::Double
+ else fromIntegral offline_inst /
+ fromIntegral (offline_inst + online_inst)::Double
cpu_l = map Node.p_cpu nodes
cpu_cv = varianceCoeff cpu_l
in (mem_cv, dsk_cv, n1_score, res_cv, off_score, cpu_cv)
getOnline :: Node.List -> [Node.Node]
getOnline = filter (not . Node.offline) . Container.elems
--- * hn1 functions
-
--- | Add an instance and return the new node and instance maps.
-addInstance :: Node.List -> Instance.Instance ->
- Node.Node -> Node.Node -> Maybe Node.List
-addInstance nl idata pri sec =
- let pdx = Node.idx pri
- sdx = Node.idx sec
- in do
- pnode <- Node.addPri pri idata
- snode <- Node.addSec sec idata pdx
- new_nl <- return $ Container.addTwo sdx snode
- pdx pnode nl
- return new_nl
-
--- | Remove an instance and return the new node and instance maps.
-removeInstance :: Node.List -> Instance.Instance -> Node.List
-removeInstance nl idata =
- let pnode = Instance.pnode idata
- snode = Instance.snode idata
- pn = Container.find pnode nl
- sn = Container.find snode nl
- new_nl = Container.addTwo
- pnode (Node.removePri pn idata)
- snode (Node.removeSec sn idata) nl in
- new_nl
-
--- | Remove an instance and return the new node map.
-removeInstances :: Node.List -> [Instance.Instance] -> Node.List
-removeInstances = foldl' removeInstance
-
-
-{-| Compute a new version of a cluster given a solution.
-
-This is not used for computing the solutions, but for applying a
-(known-good) solution to the original cluster for final display.
-
-It first removes the relocated instances after which it places them on
-their new nodes.
-
- -}
-applySolution :: Node.List -> Instance.List -> [Placement] -> Node.List
-applySolution nl il sol =
- let odxes = map (\ (a, b, c, _) -> (Container.find a il,
- Node.idx (Container.find b nl),
- Node.idx (Container.find c nl))
- ) sol
- idxes = (\ (x, _, _) -> x) (unzip3 odxes)
- nc = removeInstances nl idxes
- in
- foldl' (\ nz (a, b, c) ->
- let new_p = Container.find b nz
- new_s = Container.find c nz in
- fromJust (addInstance nz a new_p new_s)
- ) nc odxes
-
-
--- ** First phase functions
-
-{-| Given a list 1,2,3..n build a list of pairs [(1, [2..n]), (2,
- [3..n]), ...]
-
--}
-genParts :: [a] -> Int -> [(a, [a])]
-genParts l count =
- case l of
- [] -> []
- x:xs ->
- if length l < count then
- []
- else
- (x, xs) : (genParts xs count)
-
--- | Generates combinations of count items from the names list.
-genNames :: Int -> [b] -> [[b]]
-genNames count1 names1 =
- let aux_fn count names current =
- case count of
- 0 -> [current]
- _ ->
- concatMap
- (\ (x, xs) -> aux_fn (count - 1) xs (x:current))
- (genParts names count)
- in
- aux_fn count1 names1 []
-
-{-| Checks if removal of instances results in N+1 pass.
-
-Note: the check removal cannot optimize by scanning only the affected
-nodes, since the cluster is known to be not healthy; only the check
-placement can make this shortcut.
-
--}
-checkRemoval :: Node.List -> [Instance.Instance] -> Maybe Removal
-checkRemoval nl victims =
- let nx = removeInstances nl victims
- failN1 = verifyN1Check (Container.elems nx)
- in
- if failN1 then
- Nothing
- else
- Just $ Removal nx victims
-
-
--- | Computes the removals list for a given depth.
-computeRemovals :: Node.List
- -> [Instance.Instance]
- -> Int
- -> [Maybe Removal]
-computeRemovals nl bad_instances depth =
- map (checkRemoval nl) $ genNames depth bad_instances
-
--- ** Second phase functions
-
--- | Single-node relocation cost.
-nodeDelta :: Ndx -> Ndx -> Ndx -> Int
-nodeDelta i p s =
- if i == p || i == s then
- 0
- else
- 1
-
--- | Compute best solution.
---
--- This function compares two solutions, choosing the minimum valid
--- solution.
-compareSolutions :: Maybe Solution -> Maybe Solution -> Maybe Solution
-compareSolutions a b = case (a, b) of
- (Nothing, x) -> x
- (x, Nothing) -> x
- (x, y) -> min x y
-
--- | Check if a given delta is worse then an existing solution.
-tooHighDelta :: Maybe Solution -> Int -> Int -> Bool
-tooHighDelta sol new_delta max_delta =
- if new_delta > max_delta && max_delta >=0 then
- True
- else
- case sol of
- Nothing -> False
- Just (Solution old_delta _) -> old_delta <= new_delta
-
-{-| Check if placement of instances still keeps the cluster N+1 compliant.
-
- This is the workhorse of the allocation algorithm: given the
- current node and instance maps, the list of instances to be
- placed, and the current solution, this will return all possible
- solution by recursing until all target instances are placed.
-
--}
-checkPlacement :: Node.List -- ^ The current node list
- -> [Instance.Instance] -- ^ List of instances still to place
- -> [Placement] -- ^ Partial solution until now
- -> Int -- ^ The delta of the partial solution
- -> Maybe Solution -- ^ The previous solution
- -> Int -- ^ Abort if the we go above this delta
- -> Maybe Solution -- ^ The new solution
-checkPlacement nl victims current current_delta prev_sol max_delta =
- let target = head victims
- opdx = Instance.pnode target
- osdx = Instance.snode target
- vtail = tail victims
- have_tail = (length vtail) > 0
- nodes = Container.elems nl
- iidx = Instance.idx target
- in
- foldl'
- (\ accu_p pri ->
- let
- pri_idx = Node.idx pri
- upri_delta = current_delta + nodeDelta pri_idx opdx osdx
- new_pri = Node.addPri pri target
- fail_delta1 = tooHighDelta accu_p upri_delta max_delta
- in
- if fail_delta1 || isNothing(new_pri) then accu_p
- else let pri_nl = Container.add pri_idx (fromJust new_pri) nl in
- foldl'
- (\ accu sec ->
- let
- sec_idx = Node.idx sec
- upd_delta = upri_delta +
- nodeDelta sec_idx opdx osdx
- fail_delta2 = tooHighDelta accu upd_delta max_delta
- new_sec = Node.addSec sec target pri_idx
- in
- if sec_idx == pri_idx || fail_delta2 ||
- isNothing new_sec then accu
- else let
- nx = Container.add sec_idx (fromJust new_sec) pri_nl
- upd_cv = compCV nx
- plc = (iidx, pri_idx, sec_idx, upd_cv)
- c2 = plc:current
- result =
- if have_tail then
- checkPlacement nx vtail c2 upd_delta
- accu max_delta
- else
- Just (Solution upd_delta c2)
- in compareSolutions accu result
- ) accu_p nodes
- ) prev_sol nodes
-
-{-| Auxiliary function for solution computation.
-
-We write this in an explicit recursive fashion in order to control
-early-abort in case we have met the min delta. We can't use foldr
-instead of explicit recursion since we need the accumulator for the
-abort decision.
-
--}
-advanceSolution :: [Maybe Removal] -- ^ The removal to process
- -> Int -- ^ Minimum delta parameter
- -> Int -- ^ Maximum delta parameter
- -> Maybe Solution -- ^ Current best solution
- -> Maybe Solution -- ^ New best solution
-advanceSolution [] _ _ sol = sol
-advanceSolution (Nothing:xs) m n sol = advanceSolution xs m n sol
-advanceSolution ((Just (Removal nx removed)):xs) min_d max_d prev_sol =
- let new_sol = checkPlacement nx removed [] 0 prev_sol max_d
- new_delta = solutionDelta $! new_sol
- in
- if new_delta >= 0 && new_delta <= min_d then
- new_sol
- else
- advanceSolution xs min_d max_d new_sol
-
--- | Computes the placement solution.
-solutionFromRemovals :: [Maybe Removal] -- ^ The list of (possible) removals
- -> Int -- ^ Minimum delta parameter
- -> Int -- ^ Maximum delta parameter
- -> Maybe Solution -- ^ The best solution found
-solutionFromRemovals removals min_delta max_delta =
- advanceSolution removals min_delta max_delta Nothing
-
-{-| Computes the solution at the given depth.
-
-This is a wrapper over both computeRemovals and
-solutionFromRemovals. In case we have no solution, we return Nothing.
-
--}
-computeSolution :: Node.List -- ^ The original node data
- -> [Instance.Instance] -- ^ The list of /bad/ instances
- -> Int -- ^ The /depth/ of removals
- -> Int -- ^ Maximum number of removals to process
- -> Int -- ^ Minimum delta parameter
- -> Int -- ^ Maximum delta parameter
- -> Maybe Solution -- ^ The best solution found (or Nothing)
-computeSolution nl bad_instances depth max_removals min_delta max_delta =
- let
- removals = computeRemovals nl bad_instances depth
- removals' = capRemovals removals max_removals
- in
- solutionFromRemovals removals' min_delta max_delta
-
-- * hbal functions
-- | Compute best table. Note that the ordering of the arguments is important.
-- | Applies an instance move to a given node list and instance.
applyMove :: Node.List -> Instance.Instance
- -> IMove -> (Maybe Node.List, Instance.Instance, Ndx, Ndx)
+ -> IMove -> OpResult (Node.List, Instance.Instance, Ndx, Ndx)
-- Failover (f)
applyMove nl inst Failover =
let old_pdx = Instance.pnode inst
new_nl = do -- Maybe monad
new_p <- Node.addPri int_s inst
new_s <- Node.addSec int_p inst old_sdx
- return $ Container.addTwo old_pdx new_s old_sdx new_p nl
- in (new_nl, Instance.setBoth inst old_sdx old_pdx, old_sdx, old_pdx)
+ let new_inst = Instance.setBoth inst old_sdx old_pdx
+ return (Container.addTwo old_pdx new_s old_sdx new_p nl,
+ new_inst, old_sdx, old_pdx)
+ in new_nl
-- Replace the primary (f:, r:np, f)
applyMove nl inst (ReplacePrimary new_pdx) =
let tmp_s' = Node.removePri tmp_s inst
new_p <- Node.addPri tgt_n inst
new_s <- Node.addSec tmp_s' inst new_pdx
- return $ Container.add new_pdx new_p $
- Container.addTwo old_pdx int_p old_sdx new_s nl
- in (new_nl, Instance.setPri inst new_pdx, new_pdx, old_sdx)
+ let new_inst = Instance.setPri inst new_pdx
+ return (Container.add new_pdx new_p $
+ Container.addTwo old_pdx int_p old_sdx new_s nl,
+ new_inst, new_pdx, old_sdx)
+ in new_nl
-- Replace the secondary (r:ns)
applyMove nl inst (ReplaceSecondary new_sdx) =
old_s = Container.find old_sdx nl
tgt_n = Container.find new_sdx nl
int_s = Node.removeSec old_s inst
+ new_inst = Instance.setSec inst new_sdx
new_nl = Node.addSec tgt_n inst old_pdx >>=
- \new_s -> return $ Container.addTwo new_sdx
- new_s old_sdx int_s nl
- in (new_nl, Instance.setSec inst new_sdx, old_pdx, new_sdx)
+ \new_s -> return (Container.addTwo new_sdx
+ new_s old_sdx int_s nl,
+ new_inst, old_pdx, new_sdx)
+ in new_nl
-- Replace the secondary and failover (r:np, f)
applyMove nl inst (ReplaceAndFailover new_pdx) =
new_nl = do -- Maybe monad
new_p <- Node.addPri tgt_n inst
new_s <- Node.addSec int_p inst new_pdx
- return $ Container.add new_pdx new_p $
- Container.addTwo old_pdx new_s old_sdx int_s nl
- in (new_nl, Instance.setBoth inst new_pdx old_pdx, new_pdx, old_pdx)
+ let new_inst = Instance.setBoth inst new_pdx old_pdx
+ return (Container.add new_pdx new_p $
+ Container.addTwo old_pdx new_s old_sdx int_s nl,
+ new_inst, new_pdx, old_pdx)
+ in new_nl
-- Failver and replace the secondary (f, r:ns)
applyMove nl inst (FailoverAndReplace new_sdx) =
new_nl = do -- Maybe monad
new_p <- Node.addPri int_s inst
new_s <- Node.addSec tgt_n inst old_sdx
- return $ Container.add new_sdx new_s $
- Container.addTwo old_sdx new_p old_pdx int_p nl
- in (new_nl, Instance.setBoth inst old_sdx new_sdx, old_sdx, new_sdx)
+ let new_inst = Instance.setBoth inst old_sdx new_sdx
+ return (Container.add new_sdx new_s $
+ Container.addTwo old_sdx new_p old_pdx int_p nl,
+ new_inst, old_sdx, new_sdx)
+ in new_nl
-- | Tries to allocate an instance on one given node.
allocateOnSingle :: Node.List -> Instance.Instance -> Node.Node
- -> (Maybe Node.List, Instance.Instance)
+ -> OpResult AllocElement
allocateOnSingle nl inst p =
let new_pdx = Node.idx p
+ new_inst = Instance.setBoth inst new_pdx Node.noSecondary
new_nl = Node.addPri p inst >>= \new_p ->
- return $ Container.add new_pdx new_p nl
- in (new_nl, Instance.setBoth inst new_pdx Node.noSecondary)
+ return (Container.add new_pdx new_p nl, new_inst, [new_p])
+ in new_nl
-- | Tries to allocate an instance on a given pair of nodes.
allocateOnPair :: Node.List -> Instance.Instance -> Node.Node -> Node.Node
- -> (Maybe Node.List, Instance.Instance)
+ -> OpResult AllocElement
allocateOnPair nl inst tgt_p tgt_s =
let new_pdx = Node.idx tgt_p
new_sdx = Node.idx tgt_s
new_nl = do -- Maybe monad
new_p <- Node.addPri tgt_p inst
new_s <- Node.addSec tgt_s inst new_pdx
- return $ Container.addTwo new_pdx new_p new_sdx new_s nl
- in (new_nl, Instance.setBoth inst new_pdx new_sdx)
+ let new_inst = Instance.setBoth inst new_pdx new_sdx
+ return (Container.addTwo new_pdx new_p new_sdx new_s nl, new_inst,
+ [new_p, new_s])
+ in new_nl
-- | Tries to perform an instance move and returns the best table
-- between the original one and the new one.
checkSingleStep ini_tbl target cur_tbl move =
let
Table ini_nl ini_il _ ini_plc = ini_tbl
- (tmp_nl, new_inst, pri_idx, sec_idx) = applyMove ini_nl target move
+ tmp_resu = applyMove ini_nl target move
in
- if isNothing tmp_nl then cur_tbl
- else
- let tgt_idx = Instance.idx target
- upd_nl = fromJust tmp_nl
- upd_cvar = compCV upd_nl
- upd_il = Container.add tgt_idx new_inst ini_il
- upd_plc = (tgt_idx, pri_idx, sec_idx, upd_cvar):ini_plc
- upd_tbl = Table upd_nl upd_il upd_cvar upd_plc
- in
- compareTables cur_tbl upd_tbl
+ case tmp_resu of
+ OpFail _ -> cur_tbl
+ OpGood (upd_nl, new_inst, pri_idx, sec_idx) ->
+ let tgt_idx = Instance.idx target
+ upd_cvar = compCV upd_nl
+ upd_il = Container.add tgt_idx new_inst ini_il
+ upd_plc = (tgt_idx, pri_idx, sec_idx, upd_cvar):ini_plc
+ upd_tbl = Table upd_nl upd_il upd_cvar upd_plc
+ in
+ compareTables cur_tbl upd_tbl
-- | Given the status of the current secondary as a valid new node
-- and the current candidate target node,
else
best_tbl
--- * Alocation functions
+-- * Allocation functions
+
+-- | Build failure stats out of a list of failures
+collapseFailures :: [FailMode] -> FailStats
+collapseFailures flst =
+ map (\k -> (k, length $ filter ((==) k) flst)) [minBound..maxBound]
+
+-- | Update current Allocation solution and failure stats with new
+-- elements
+concatAllocs :: AllocSolution -> OpResult AllocElement -> AllocSolution
+concatAllocs (flst, succ, sols) (OpFail reason) = (reason:flst, succ, sols)
+
+concatAllocs (flst, succ, osols) (OpGood ns@(nl, _, _)) =
+ let nscore = compCV nl
+ -- Choose the old or new solution, based on the cluster score
+ nsols = case osols of
+ Nothing -> Just (nscore, ns)
+ Just (oscore, _) ->
+ if oscore < nscore
+ then osols
+ else Just (nscore, ns)
+ nsuc = succ + 1
+ -- Note: we force evaluation of nsols here in order to keep the
+ -- memory profile low - we know that we will need nsols for sure
+ -- in the next cycle, so we force evaluation of nsols, since the
+ -- foldl' in the caller will only evaluate the tuple, but not the
+ -- elements of the tuple
+ in nsols `seq` nsuc `seq` (flst, nsuc, nsols)
-- | Try to allocate an instance on the cluster.
tryAlloc :: (Monad m) =>
-> Instance.List -- ^ The instance list
-> Instance.Instance -- ^ The instance to allocate
-> Int -- ^ Required number of nodes
- -> m [(Maybe Node.List, Instance.Instance, [Node.Node])]
- -- ^ Possible solution list
+ -> m AllocSolution -- ^ Possible solution list
tryAlloc nl _ inst 2 =
let all_nodes = getOnline nl
all_pairs = liftM2 (,) all_nodes all_nodes
ok_pairs = filter (\(x, y) -> Node.idx x /= Node.idx y) all_pairs
- sols = map (\(p, s) -> let (mnl, i) = allocateOnPair nl inst p s
- in (mnl, i, [p, s]))
- ok_pairs
+ sols = foldl' (\cstate (p, s) ->
+ concatAllocs cstate $ allocateOnPair nl inst p s
+ ) ([], 0, Nothing) ok_pairs
in return sols
tryAlloc nl _ inst 1 =
let all_nodes = getOnline nl
- sols = map (\p -> let (mnl, i) = allocateOnSingle nl inst p
- in (mnl, i, [p]))
- all_nodes
+ sols = foldl' (\cstate p ->
+ concatAllocs cstate $ allocateOnSingle nl inst p
+ ) ([], 0, Nothing) all_nodes
in return sols
-tryAlloc _ _ _ reqn = fail $ "Unsupported number of alllocation \
- \destinations required (" ++ (show reqn) ++
+tryAlloc _ _ _ reqn = fail $ "Unsupported number of allocation \
+ \destinations required (" ++ show reqn ++
"), only two supported"
-- | Try to allocate an instance on the cluster.
tryReloc :: (Monad m) =>
- Node.List -- ^ The node list
- -> Instance.List -- ^ The instance list
- -> Idx -- ^ The index of the instance to move
- -> Int -- ^ The numver of nodes required
- -> [Ndx] -- ^ Nodes which should not be used
- -> m [(Maybe Node.List, Instance.Instance, [Node.Node])]
- -- ^ Solution list
+ Node.List -- ^ The node list
+ -> Instance.List -- ^ The instance list
+ -> Idx -- ^ The index of the instance to move
+ -> Int -- ^ The number of nodes required
+ -> [Ndx] -- ^ Nodes which should not be used
+ -> m AllocSolution -- ^ Solution list
tryReloc nl il xid 1 ex_idx =
let all_nodes = getOnline nl
inst = Container.find xid il
- ex_idx' = (Instance.pnode inst):ex_idx
+ ex_idx' = Instance.pnode inst:ex_idx
valid_nodes = filter (not . flip elem ex_idx' . Node.idx) all_nodes
valid_idxes = map Node.idx valid_nodes
- sols1 = map (\x -> let (mnl, i, _, _) =
- applyMove nl inst (ReplaceSecondary x)
- in (mnl, i, [Container.find x nl])
- ) valid_idxes
+ sols1 = foldl' (\cstate x ->
+ let elem = do
+ (mnl, i, _, _) <-
+ applyMove nl inst (ReplaceSecondary x)
+ return (mnl, i, [Container.find x mnl])
+ in concatAllocs cstate elem
+ ) ([], 0, Nothing) valid_idxes
in return sols1
tryReloc _ _ _ reqn _ = fail $ "Unsupported number of relocation \
- \destinations required (" ++ (show reqn) ++
+ \destinations required (" ++ show reqn ++
"), only one supported"
-- * Formatting functions
-- either @/f/@ for failover or @/r:name/@ for replace
-- secondary, while the command list holds gnt-instance
-- commands (without that prefix), e.g \"@failover instance1@\"
-computeMoves i a b c d =
- if c == a then {- Same primary -}
- if d == b then {- Same sec??! -}
- ("-", [])
+computeMoves i a b c d
+ -- same primary
+ | c == a =
+ if d == b
+ then {- Same sec??! -} ("-", [])
else {- Change of secondary -}
- (printf "r:%s" d,
- [printf "replace-disks -n %s %s" d i])
- else
- if c == b then {- Failover and ... -}
- if d == a then {- that's all -}
- ("f", [printf "migrate -f %s" i])
- else
- (printf "f r:%s" d,
- [printf "migrate -f %s" i,
- printf "replace-disks -n %s %s" d i])
- else
- if d == a then {- ... and keep primary as secondary -}
- (printf "r:%s f" c,
- [printf "replace-disks -n %s %s" c i,
- printf "migrate -f %s" i])
- else
- if d == b then {- ... keep same secondary -}
- (printf "f r:%s f" c,
- [printf "migrate -f %s" i,
- printf "replace-disks -n %s %s" c i,
- printf "migrate -f %s" i])
-
- else {- Nothing in common -}
- (printf "r:%s f r:%s" c d,
- [printf "replace-disks -n %s %s" c i,
- printf "migrate -f %s" i,
- printf "replace-disks -n %s %s" d i])
+ (printf "r:%s" d, [rep d])
+ -- failover and ...
+ | c == b =
+ if d == a
+ then {- that's all -} ("f", [mig])
+ else (printf "f r:%s" d, [mig, rep d])
+ -- ... and keep primary as secondary
+ | d == a =
+ (printf "r:%s f" c, [rep c, mig])
+ -- ... keep same secondary
+ | d == b =
+ (printf "f r:%s f" c, [mig, rep c, mig])
+ -- nothing in common -
+ | otherwise =
+ (printf "r:%s f r:%s" c d, [rep c, mig, rep d])
+ where mig = printf "migrate -f %s" i::String
+ rep n = printf "replace-disks -n %s %s" n i
-- | Converts a placement to string format.
printSolutionLine :: Node.List -- ^ The node list
opri = Container.nameOf nl $ Instance.pnode inst
osec = Container.nameOf nl $ Instance.snode inst
(moves, cmds) = computeMoves inam opri osec npri nsec
- ostr = (printf "%s:%s" opri osec)::String
- nstr = (printf "%s:%s" npri nsec)::String
+ ostr = printf "%s:%s" opri osec::String
+ nstr = printf "%s:%s" npri nsec::String
in
(printf " %3d. %-*s %-*s => %-*s %.8f a=%s"
pos imlen inam pmlen ostr
-- | Given a list of commands, prefix them with @gnt-instance@ and
-- also beautify the display a little.
formatCmds :: [[String]] -> String
-formatCmds cmd_strs =
- unlines $
- concat $ map (\(a, b) ->
- (printf "echo step %d" (a::Int)):
- (printf "check"):
- (map ("gnt-instance " ++) b)) $
- zip [1..] cmd_strs
+formatCmds =
+ unlines .
+ concatMap (\(a, b) ->
+ printf "echo step %d" (a::Int):
+ printf "check":
+ map ("gnt-instance " ++) b
+ ) .
+ zip [1..]
-- | Converts a solution to string format.
printSolution :: Node.List
nmlen = Container.maxNameLen nl
imlen = Container.maxNameLen il
in
- unzip $ map (uncurry $ printSolutionLine nl il nmlen imlen) $
- zip sol [1..]
+ unzip $ zipWith (printSolutionLine nl il nmlen imlen) sol [1..]
-- | Print the node list.
printNodes :: Node.List -> String
" F" m_name "Name"
"t_mem" "n_mem" "i_mem" "x_mem" "f_mem" "r_mem"
"t_dsk" "f_dsk" "pcpu" "vcpu"
- "pri" "sec" "p_fmem" "p_fdsk" "r_cpu"
- in unlines $ (header:map helper snl)
+ "pri" "sec" "p_fmem" "p_fdsk" "r_cpu"::String
+ in unlines (header:map helper snl)
-- | Shows statistics for a given node list.
printStats :: Node.List -> String
projects / ganeti-local / blobdiff