Split OpCode.hs and add module for opcode parameters
[ganeti-local] / Makefile.am
index 15874a7..9707e7e 100644 (file)
@@ -59,6 +59,7 @@ HTOOLS_DIRS = \
        htools/Ganeti \
        htools/Ganeti/Confd \
        htools/Ganeti/HTools \
+       htools/Ganeti/HTools/Backend \
        htools/Ganeti/HTools/Program \
        htools/Ganeti/Query \
        htest \
@@ -66,6 +67,7 @@ HTOOLS_DIRS = \
        htest/Test/Ganeti \
        htest/Test/Ganeti/Confd \
        htest/Test/Ganeti/HTools \
+       htest/Test/Ganeti/HTools/Backend \
        htest/Test/Ganeti/Query
 
 DIRS = \
@@ -108,6 +110,7 @@ BUILDTIME_DIR_AUTOCREATE = \
        $(APIDOC_HS_DIR)/Ganeti \
        $(APIDOC_HS_DIR)/Ganeti/Confd \
        $(APIDOC_HS_DIR)/Ganeti/HTools \
+       $(APIDOC_HS_DIR)/Ganeti/HTools/Backend \
        $(APIDOC_HS_DIR)/Ganeti/HTools/Program \
        $(APIDOC_HS_DIR)/Ganeti/Query \
        $(APIDOC_PY_DIR) \
@@ -154,7 +157,6 @@ CLEANFILES = \
        $(SHELL_ENV_INIT) \
        daemons/daemon-util \
        daemons/ganeti-cleaner \
-       devel/upload \
        $(BUILT_EXAMPLES) \
        doc/examples/bash_completion \
        doc/examples/bash_completion-debug \
@@ -206,6 +208,8 @@ BUILT_EXAMPLES = \
        doc/examples/ganeti-kvm-poweroff.initd \
        doc/examples/ganeti.cron \
        doc/examples/ganeti.initd \
+       doc/examples/ganeti-master-role.ocf \
+       doc/examples/ganeti-node-role.ocf \
        doc/examples/gnt-config-backup \
        doc/examples/hooks/ipsec
 
@@ -315,7 +319,8 @@ server_PYTHON = \
 
 pytools_PYTHON = \
        lib/tools/__init__.py \
-       lib/tools/ensure_dirs.py
+       lib/tools/ensure_dirs.py \
+       lib/tools/prepare_node_join.py
 
 utils_PYTHON = \
        lib/utils/__init__.py \
@@ -341,6 +346,8 @@ docrst = \
        doc/design-2.3.rst \
        doc/design-2.4.rst \
        doc/design-2.5.rst \
+       doc/design-2.6.rst \
+       doc/design-2.7.rst \
        doc/design-autorepair.rst \
        doc/design-bulk-create.rst \
        doc/design-chained-jobs.rst \
@@ -350,16 +357,19 @@ docrst = \
        doc/design-http-server.rst \
        doc/design-impexp2.rst \
        doc/design-lu-generated-jobs.rst \
+       doc/design-linuxha.rst \
        doc/design-multi-reloc.rst \
        doc/design-network.rst \
-       doc/design-node-state-cache.rst \
+       doc/design-node-add.rst \
        doc/design-oob.rst \
        doc/design-ovf-support.rst \
        doc/design-partitioned.rst \
        doc/design-query-splitting.rst \
        doc/design-query2.rst \
+       doc/design-remote-commands.rst \
        doc/design-resource-model.rst \
        doc/design-shared-storage.rst \
+       doc/design-monitoring-agent.rst \
        doc/design-virtual-clusters.rst \
        doc/design-x509-ca.rst \
        doc/devnotes.rst \
@@ -383,11 +393,22 @@ HS_PROGS = htools/htools
 HS_BIN_ROLES = hbal hscan hspace hinfo hcheck
 HS_HTOOLS_PROGS = $(HS_BIN_ROLES) hail
 
-HS_ALL_PROGS = $(HS_PROGS) htest/test htest/hpc-htools htools/hconfd
+HS_ALL_PROGS = \
+       $(HS_PROGS) \
+       htest/hpc-htools \
+       htest/test \
+       htools/hconfd \
+       htools/rpc-test
+
 HS_PROG_SRCS = $(patsubst %,%.hs,$(HS_ALL_PROGS))
 HS_BUILT_TEST_HELPERS = $(HS_BIN_ROLES:%=htest/%) htest/hail
 
-HFLAGS = -O -Wall -Werror -fwarn-monomorphism-restriction -fwarn-tabs -ihtools
+HFLAGS = \
+       -O -Wall -Werror -ihtools \
+       -fwarn-monomorphism-restriction \
+       -fwarn-tabs \
+       $(GHC_BYVERSION_FLAGS)
+
 # extra flags that can be overriden on the command line (e.g. -Wwarn, etc.)
 HEXTRA =
 # internal extra flags (used for htest/test mainly)
@@ -408,20 +429,24 @@ HS_LIB_SRCS = \
        htools/Ganeti/BasicTypes.hs \
        htools/Ganeti/Common.hs \
        htools/Ganeti/Compat.hs \
-       htools/Ganeti/Confd.hs \
        htools/Ganeti/Confd/Server.hs \
+       htools/Ganeti/Confd/Types.hs \
        htools/Ganeti/Confd/Utils.hs \
        htools/Ganeti/Config.hs \
        htools/Ganeti/Daemon.hs \
+       htools/Ganeti/Errors.hs \
+       htools/Ganeti/HTools/Backend/IAlloc.hs \
+       htools/Ganeti/HTools/Backend/Luxi.hs \
+       htools/Ganeti/HTools/Backend/Rapi.hs \
+       htools/Ganeti/HTools/Backend/Simu.hs \
+       htools/Ganeti/HTools/Backend/Text.hs \
        htools/Ganeti/HTools/CLI.hs \
        htools/Ganeti/HTools/Cluster.hs \
        htools/Ganeti/HTools/Container.hs \
        htools/Ganeti/HTools/ExtLoader.hs \
        htools/Ganeti/HTools/Group.hs \
-       htools/Ganeti/HTools/IAlloc.hs \
        htools/Ganeti/HTools/Instance.hs \
        htools/Ganeti/HTools/Loader.hs \
-       htools/Ganeti/HTools/Luxi.hs \
        htools/Ganeti/HTools/Node.hs \
        htools/Ganeti/HTools/PeerMap.hs \
        htools/Ganeti/HTools/Program.hs \
@@ -431,9 +456,6 @@ HS_LIB_SRCS = \
        htools/Ganeti/HTools/Program/Hinfo.hs \
        htools/Ganeti/HTools/Program/Hscan.hs \
        htools/Ganeti/HTools/Program/Hspace.hs \
-       htools/Ganeti/HTools/Rapi.hs \
-       htools/Ganeti/HTools/Simu.hs \
-       htools/Ganeti/HTools/Text.hs \
        htools/Ganeti/HTools/Types.hs \
        htools/Ganeti/Hash.hs \
        htools/Ganeti/JSON.hs \
@@ -442,6 +464,7 @@ HS_LIB_SRCS = \
        htools/Ganeti/Luxi.hs \
        htools/Ganeti/Objects.hs \
        htools/Ganeti/OpCodes.hs \
+       htools/Ganeti/OpParams.hs \
        htools/Ganeti/Path.hs \
        htools/Ganeti/Query/Common.hs \
        htools/Ganeti/Query/Filter.hs \
@@ -455,13 +478,18 @@ HS_LIB_SRCS = \
        htools/Ganeti/Runtime.hs \
        htools/Ganeti/Ssconf.hs \
        htools/Ganeti/THH.hs \
+       htools/Ganeti/Types.hs \
        htools/Ganeti/Utils.hs
 
 HS_TEST_SRCS = \
+       htest/Test/Ganeti/Attoparsec.hs \
        htest/Test/Ganeti/BasicTypes.hs \
        htest/Test/Ganeti/Common.hs \
        htest/Test/Ganeti/Confd/Utils.hs \
        htest/Test/Ganeti/Daemon.hs \
+       htest/Test/Ganeti/Errors.hs \
+       htest/Test/Ganeti/HTools/Backend/Simu.hs \
+       htest/Test/Ganeti/HTools/Backend/Text.hs \
        htest/Test/Ganeti/HTools/CLI.hs \
        htest/Test/Ganeti/HTools/Cluster.hs \
        htest/Test/Ganeti/HTools/Container.hs \
@@ -469,8 +497,6 @@ HS_TEST_SRCS = \
        htest/Test/Ganeti/HTools/Loader.hs \
        htest/Test/Ganeti/HTools/Node.hs \
        htest/Test/Ganeti/HTools/PeerMap.hs \
-       htest/Test/Ganeti/HTools/Simu.hs \
-       htest/Test/Ganeti/HTools/Text.hs \
        htest/Test/Ganeti/HTools/Types.hs \
        htest/Test/Ganeti/JSON.hs \
        htest/Test/Ganeti/Jobs.hs \
@@ -482,9 +508,11 @@ HS_TEST_SRCS = \
        htest/Test/Ganeti/Query/Query.hs \
        htest/Test/Ganeti/Rpc.hs \
        htest/Test/Ganeti/Ssconf.hs \
+       htest/Test/Ganeti/THH.hs \
        htest/Test/Ganeti/TestCommon.hs \
        htest/Test/Ganeti/TestHTools.hs \
        htest/Test/Ganeti/TestHelper.hs \
+       htest/Test/Ganeti/Types.hs \
        htest/Test/Ganeti/Utils.hs
 
 HS_LIBTEST_SRCS = $(HS_LIB_SRCS) $(HS_TEST_SRCS)
@@ -541,7 +569,6 @@ docpng = $(patsubst %.dot,%.png,$(docdot))
 # Things to build but not to install (add it to EXTRA_DIST if it should be
 # distributed)
 noinst_DATA = \
-       devel/upload \
        doc/html \
        $(BUILT_EXAMPLES) \
        doc/examples/bash_completion \
@@ -567,7 +594,8 @@ PYTHON_BOOTSTRAP_SBIN = \
 
 PYTHON_BOOTSTRAP = \
        $(PYTHON_BOOTSTRAP_SBIN) \
-       tools/ensure-dirs
+       tools/ensure-dirs \
+       tools/prepare-node-join
 
 qa_scripts = \
        qa/__init__.py \
@@ -601,18 +629,15 @@ install-exec-hook:
 endif
 
 $(HS_ALL_PROGS): %: %.hs $(HS_LIBTEST_SRCS) $(HS_BUILT_SRCS) Makefile
-       @if [ -z "$(HTOOLS)" ]; then \
-         echo "Error: htools compilation disabled at configure time" 1>&2 ;\
-         exit 1; \
-       fi
-       @if [ "$(notdir $@)" = "test" ] && [ -z "$(GHC_PKG_QUICKCHECK)" ]; then \
-         echo "Error: cannot run unittests without the QuickCheck library (see devnotes.rst)" 1>&2; \
+       @if [ "$(notdir $@)" = "test" ] && [ "$(HTOOLS_NODEV)" ]; then \
+         echo "Error: cannot run unittests without the development" \
+              " libraries (see devnotes.rst)" 1>&2; \
          exit 1; \
        fi
        @rm -f $(notdir $@).tix
        $(GHC) --make \
          $(HFLAGS) \
-         $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) \
+         $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) $(HTOOLS_REGEX_PCRE) \
          -osuf $(notdir $@).o -hisuf $(notdir $@).hi \
          $(HEXTRA) $(HEXTRA_INT) $@
        @touch "$@"
@@ -665,14 +690,13 @@ python_scripts = \
        tools/lvmstrap \
        tools/move-instance \
        tools/ovfconverter \
-       tools/sanitize-config \
-       tools/setup-ssh
+       tools/sanitize-config
 
 dist_tools_SCRIPTS = \
        $(python_scripts) \
        tools/kvm-console-wrapper \
        tools/master-ip-setup \
-       tools/xm-console-wrapper
+       tools/xen-console-wrapper
 
 nodist_tools_SCRIPTS = \
        tools/vcluster-setup
@@ -682,7 +706,8 @@ pkglib_python_scripts = \
        tools/check-cert-expired
 
 nodist_pkglib_python_scripts = \
-       tools/ensure-dirs
+       tools/ensure-dirs \
+       tools/prepare-node-join
 
 myexeclib_SCRIPTS = \
        daemons/daemon-util \
@@ -716,7 +741,7 @@ EXTRA_DIST = \
        daemons/daemon-util.in \
        daemons/ganeti-cleaner.in \
        $(pkglib_python_scripts) \
-       devel/upload.in \
+       devel/upload \
        tools/kvm-ifup.in \
        tools/vcluster-setup.in \
        $(docdot) \
@@ -745,7 +770,8 @@ EXTRA_DIST = \
        $(HS_PROG_SRCS) \
        htools/lint-hints.hs \
        htest/cli-tests-defs.sh \
-       htest/offline-test.sh
+       htest/offline-test.sh \
+       .ghci
 
 man_MANS = \
        man/ganeti-cleaner.8 \
@@ -788,6 +814,7 @@ TEST_FILES = \
        htest/data/hail-invalid-reloc.json \
        htest/data/hail-node-evac.json \
        htest/data/hail-reloc-drbd.json \
+       htest/data/hbal-excl-tags.data \
        htest/data/hbal-split-insts.data \
        htest/data/invalid-node.data \
        htest/data/missing-resources.data \
@@ -813,6 +840,7 @@ TEST_FILES = \
        test/data/bdev-drbd-net-ip4.txt \
        test/data/bdev-drbd-net-ip6.txt \
        test/data/cert1.pem \
+       test/data/cert2.pem \
        test/data/ip-addr-show-dummy0.txt \
        test/data/ip-addr-show-lo-ipv4.txt \
        test/data/ip-addr-show-lo-ipv6.txt \
@@ -869,11 +897,13 @@ python_tests = \
        test/cfgupgrade_unittest.py \
        test/docs_unittest.py \
        test/ganeti.asyncnotifier_unittest.py \
+       test/ganeti.backend_unittest-runasroot.py \
        test/ganeti.backend_unittest.py \
        test/ganeti.bdev_unittest.py \
        test/ganeti.cli_unittest.py \
        test/ganeti.client.gnt_cluster_unittest.py \
        test/ganeti.client.gnt_instance_unittest.py \
+       test/ganeti.client.gnt_job_unittest.py \
        test/ganeti.cmdlib_unittest.py \
        test/ganeti.compat_unittest.py \
        test/ganeti.confd.client_unittest.py \
@@ -913,9 +943,11 @@ python_tests = \
        test/ganeti.rpc_unittest.py \
        test/ganeti.runtime_unittest.py \
        test/ganeti.serializer_unittest.py \
+       test/ganeti.server.rapi_unittest.py \
        test/ganeti.ssh_unittest.py \
        test/ganeti.storage_unittest.py \
        test/ganeti.tools.ensure_dirs_unittest.py \
+       test/ganeti.tools.prepare_node_join_unittest.py \
        test/ganeti.uidpool_unittest.py \
        test/ganeti.utils.algo_unittest.py \
        test/ganeti.utils.filelock_unittest.py \
@@ -1049,10 +1081,6 @@ tools/kvm-ifup: tools/kvm-ifup.in $(REPLACE_VARS_SED)
        sed -f $(REPLACE_VARS_SED) < $< > $@
        chmod +x $@
 
-devel/upload: devel/upload.in $(REPLACE_VARS_SED)
-       sed -f $(REPLACE_VARS_SED) < $< > $@
-       chmod u+x $@
-
 tools/vcluster-setup: tools/vcluster-setup.in $(REPLACE_VARS_SED)
        sed -f $(REPLACE_VARS_SED) < $< > $@
        chmod +x $@
@@ -1140,11 +1168,14 @@ clean-vcs-version:
 
 .PHONY: regen-vcs-version
 regen-vcs-version:
-       set -e; \
+       @set -e; \
        cd $(srcdir); \
        if test -d .git; then \
-         $(MAKE) $(AM_MAKEFLAGS) clean-vcs-version; \
-         $(MAKE) $(AM_MAKEFLAGS) vcs-version; \
+         T=`mktemp` ; trap 'rm -f $$T' EXIT; \
+         git describe > $$T; \
+         if ! cmp --quiet $$T vcs-version; then \
+           mv $$T vcs-version; \
+         fi; \
        fi
 
 htools/Ganeti/Version.hs: htools/Ganeti/Version.hs.in \
@@ -1234,14 +1265,11 @@ lib/_autoconf.py: Makefile | stamp-directories
          echo "NODED_GROUP = '$(NODED_GROUP)'"; \
          echo "DISK_SEPARATOR = '$(DISK_SEPARATOR)'"; \
          echo "QEMUIMG_PATH = '$(QEMUIMG_PATH)'"; \
-         if [ "$(HTOOLS)" ]; then \
-           echo "HTOOLS = True"; \
-         else \
-           echo "HTOOLS = False"; \
-         fi; \
+         echo "HTOOLS = True"; \
          echo "ENABLE_CONFD = $(ENABLE_CONFD)"; \
          echo "XEN_CMD = '$(XEN_CMD)'"; \
          echo "ENABLE_SPLIT_QUERY = $(ENABLE_SPLIT_QUERY)"; \
+         echo "ENABLE_REMOTE_COMMANDS = $(ENABLE_REMOTE_COMMANDS)"; \
        } > $@
 
 lib/_vcsversion.py: Makefile vcs-version | stamp-directories
@@ -1288,6 +1316,7 @@ $(REPLACE_VARS_SED): $(SHELL_ENV_INIT) Makefile stamp-directories
          echo 's#@LOCALSTATEDIR@#$(localstatedir)#g'; \
          echo 's#@BINDIR@#$(bindir)#g'; \
          echo 's#@SBINDIR@#$(sbindir)#g'; \
+         echo 's#@LIBDIR@#$(libdir)#g'; \
          echo 's#@GANETI_VERSION@#$(PACKAGE_VERSION)#g'; \
          echo 's#@CUSTOM_XEN_BOOTLOADER@#$(XEN_BOOTLOADER)#g'; \
          echo 's#@CUSTOM_XEN_KERNEL@#$(XEN_KERNEL)#g'; \
@@ -1321,6 +1350,7 @@ daemons/ganeti-%: MODULE = ganeti.server.$(patsubst ganeti-%,%,$(notdir $@))
 daemons/ganeti-watcher: MODULE = ganeti.watcher
 scripts/%: MODULE = ganeti.client.$(subst -,_,$(notdir $@))
 tools/ensure-dirs: MODULE = ganeti.tools.ensure_dirs
+tools/prepare-node-join: MODULE = ganeti.tools.prepare_node_join
 $(HS_BUILT_TEST_HELPERS): TESTROLE = $(patsubst htest/%,%,$@)
 
 $(PYTHON_BOOTSTRAP): Makefile | stamp-directories
@@ -1416,13 +1446,21 @@ check-local: check-dirs $(GENERATED_FILES)
                echo "Incorrect version in README, expected $$expver"; \
                exit 1; \
        fi; \
-       for file in doc/iallocator.rst doc/hooks.rst doc/virtual-cluster.rst; do \
+       for file in doc/iallocator.rst doc/hooks.rst doc/virtual-cluster.rst \
+                       doc/security.rst; do \
                if test "`sed -ne '4 p' $(top_srcdir)/$$file`" != \
                        "Documents Ganeti version $$expver"; then \
                        echo "Incorrect version in $$file, expected $$expver"; \
                        exit 1; \
                fi; \
-       done
+       done; \
+       if ! test -f $(top_srcdir)/doc/design-$$expver.rst; then \
+               echo "File $(top_srcdir)/doc/design-$$expver.rst not found"; \
+               exit 1; \
+       fi; \
+       if test $$(wc --max-line-length < $(top_srcdir)/configure.ac) -gt 80; then \
+               echo 'Longest line in configure.ac is longer than 80 characters' >&2; \
+       fi
 
 .PHONY: hs-check
 hs-check: htest/test htest/hpc-htools $(HS_BUILT_TEST_HELPERS)
@@ -1482,7 +1520,7 @@ pep8: $(GENERATED_FILES)
 hlint: $(HS_BUILT_SRCS) htools/lint-hints.hs
        @test -n "$(HLINT)" || { echo 'hlint' not found during configure; exit 1; }
        if tty -s; then C="-c"; else C=""; fi; \
-       $(HLINT) --report=doc/hs-lint.html --cross $$C \
+       $(HLINT) --utf8 --report=doc/hs-lint.html --cross $$C \
          --ignore "Use first" \
          --ignore "Use comparing" \
          --ignore "Use on" \
@@ -1490,7 +1528,7 @@ hlint: $(HS_BUILT_SRCS) htools/lint-hints.hs
          --ignore "Use &&&" \
          --ignore "Use void" \
          --hint htools/lint-hints \
-         $(filter-out htools/Ganeti/THH.hs,$(HS_LIBTEST_SRCS))
+         $(filter-out htools/Ganeti/THH.hs,$(HS_LIBTEST_SRCS) $(HS_PROG_SRCS))
 
 # a dist hook rule for updating the vcs-version file; this is
 # hardcoded due to where it needs to build the file...
@@ -1578,6 +1616,7 @@ hs-apidoc: $(HS_BUILT_SRCS)
        @test -n "$(HADDOCK)" || \
            { echo 'haddock' not found during configure; exit 1; }
        rm -rf $(APIDOC_HS_DIR)/*
+       @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/HTools/Backend
        @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/HTools/Program
        @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/Confd
        @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/Query
@@ -1593,13 +1632,16 @@ hs-apidoc: $(HS_BUILT_SRCS)
        if [ "$(HTOOLS_PARALLEL3)" ]; \
        then OPTGHC="$$OPTGHC --optghc=$(HTOOLS_PARALLEL3)"; \
        fi; \
+       if [ "$(HTOOLS_REGEX_PCRE)" ]; \
+       then OPTGHC="$$OPTGHC --optghc=$(HTOOLS_REGEX_PCRE)"; \
+       fi; \
        RELSRCS="$(HS_LIB_SRCS:htools/%=%) $(patsubst htools/%,%,$(filter htools/%,$(HS_BUILT_SRCS)))"; \
        for file in $$RELSRCS; do \
                hfile=`echo $$file|sed 's/\\.hs$$//'`.html; \
                $(HSCOLOUR) -css -anchor $$file > ../$(APIDOC_HS_DIR)/$$hfile ; \
        done ; \
        $(HADDOCK) --odir ../$(APIDOC_HS_DIR) --html --ignore-all-exports -w \
-               -t ganeti-htools -p haddock-prologue \
+               -t ganeti -p haddock-prologue \
                --source-module="%{MODULE/.//}.html" \
                --source-entity="%{MODULE/.//}.html#%{NAME}" \
                $$OPTGHC \
@@ -1610,7 +1652,7 @@ TAGS: $(GENERATED_FILES)
        rm -f TAGS
        $(GHC) -e ":etags" -v0 \
          $(filter-out -O -Werror,$(HFLAGS)) \
-         $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) \
+         $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) $(HTOOLS_REGEX_PCRE) \
          $(HS_LIBTEST_SRCS)
        find . -path './lib/*.py' -o -path './scripts/gnt-*' -o \
          -path './daemons/ganeti-*' -o -path './tools/*' -o \
@@ -1626,7 +1668,10 @@ endif
 
 .PHONY: py-coverage
 py-coverage: $(GENERATED_FILES) $(python_tests)
+       @test -n "$(PYCOVERAGE)" || \
+           { echo 'python-coverage' not found during configure; exit 1; }
        set -e; \
+       COVERAGE=$(PYCOVERAGE) \
        COVERAGE_FILE=$(CURDIR)/$(COVERAGE_PY_DIR)/data \
        TEXT_COVERAGE=$(CURDIR)/$(COVERAGE_PY_DIR)/report.txt \
        HTML_COVERAGE=$(CURDIR)/$(COVERAGE_PY_DIR) \
@@ -1670,6 +1715,11 @@ gitignore-check:
          exit 1; \
        fi
 
+# Target that builds all binaries (including those that are not
+# rebuilt except when running the tests)
+.PHONY: really-all
+really-all: all $(check_SCRIPTS) $(haskell_tests)
+
 # we don't need the ancient implicit rules:
 %: %,v
 %: RCS/%,v