# pylint: disable-msg=R0903
import logging
+import re
+import operator
from ganeti import constants
from ganeti import errors
# Common opcode attributes
#: output fields for a query operation
-_POutputFields = ("output_fields", ht.NoDefault, ht.TListOf(ht.TNonEmptyString))
+_POutputFields = ("output_fields", ht.NoDefault, ht.TListOf(ht.TNonEmptyString),
+ None)
#: the shutdown timeout
_PShutdownTimeout = ("shutdown_timeout", constants.DEFAULT_SHUTDOWN_TIMEOUT,
- ht.TPositiveInt)
+ ht.TPositiveInt, None)
#: the force parameter
-_PForce = ("force", False, ht.TBool)
+_PForce = ("force", False, ht.TBool, None)
#: a required instance name (for single-instance LUs)
-_PInstanceName = ("instance_name", ht.NoDefault, ht.TNonEmptyString)
+_PInstanceName = ("instance_name", ht.NoDefault, ht.TNonEmptyString, None)
#: Whether to ignore offline nodes
-_PIgnoreOfflineNodes = ("ignore_offline_nodes", False, ht.TBool)
+_PIgnoreOfflineNodes = ("ignore_offline_nodes", False, ht.TBool, None)
#: a required node name (for single-node LUs)
-_PNodeName = ("node_name", ht.NoDefault, ht.TNonEmptyString)
+_PNodeName = ("node_name", ht.NoDefault, ht.TNonEmptyString, None)
#: a required node group name (for single-group LUs)
-_PGroupName = ("group_name", ht.NoDefault, ht.TNonEmptyString)
+_PGroupName = ("group_name", ht.NoDefault, ht.TNonEmptyString, None)
#: Migration type (live/non-live)
_PMigrationMode = ("mode", None,
- ht.TOr(ht.TNone, ht.TElemOf(constants.HT_MIGRATION_MODES)))
+ ht.TOr(ht.TNone, ht.TElemOf(constants.HT_MIGRATION_MODES)),
+ None)
#: Obsolete 'live' migration mode (boolean)
-_PMigrationLive = ("live", None, ht.TMaybeBool)
+_PMigrationLive = ("live", None, ht.TMaybeBool, None)
#: Tag type
-_PTagKind = ("kind", ht.NoDefault, ht.TElemOf(constants.VALID_TAG_TYPES))
+_PTagKind = ("kind", ht.NoDefault, ht.TElemOf(constants.VALID_TAG_TYPES), None)
#: List of tag strings
-_PTags = ("tags", ht.NoDefault, ht.TListOf(ht.TNonEmptyString))
+_PTags = ("tags", ht.NoDefault, ht.TListOf(ht.TNonEmptyString), None)
+
+#: OP_ID conversion regular expression
+_OPID_RE = re.compile("([a-z])([A-Z])")
+
+#: Utility function for L{OpClusterSetParams}
+_TestClusterOsList = ht.TOr(ht.TNone,
+ ht.TListOf(ht.TAnd(ht.TList, ht.TIsLength(2),
+ ht.TMap(ht.WithDesc("GetFirstItem")(operator.itemgetter(0)),
+ ht.TElemOf(constants.DDMS_VALUES)))))
+
+
+def _NameToId(name):
+ """Convert an opcode class name to an OP_ID.
+
+ @type name: string
+ @param name: the class name, as OpXxxYyy
+ @rtype: string
+ @return: the name in the OP_XXXX_YYYY format
+
+ """
+ if not name.startswith("Op"):
+ return None
+ # Note: (?<=[a-z])(?=[A-Z]) would be ideal, since it wouldn't
+ # consume any input, and hence we would just have all the elements
+ # in the list, one by one; but it seems that split doesn't work on
+ # non-consuming input, hence we have to process the input string a
+ # bit
+ name = _OPID_RE.sub(r"\1,\2", name)
+ elems = name.split(",")
+ return "_".join(n.upper() for n in elems)
def RequireFileStorage():
errors.ECODE_INVAL)
-def _CheckDiskTemplate(template):
- """Ensure a given disk template is valid.
+@ht.WithDesc("CheckFileStorage")
+def _CheckFileStorage(value):
+ """Ensures file storage is enabled if used.
"""
- if template not in constants.DISK_TEMPLATES:
- # Using str.join directly to avoid importing utils for CommaJoin
- msg = ("Invalid disk template name '%s', valid templates are: %s" %
- (template, ", ".join(constants.DISK_TEMPLATES)))
- raise errors.OpPrereqError(msg, errors.ECODE_INVAL)
- if template == constants.DT_FILE:
+ if value == constants.DT_FILE:
RequireFileStorage()
return True
+_CheckDiskTemplate = ht.TAnd(ht.TElemOf(constants.DISK_TEMPLATES),
+ _CheckFileStorage)
+
+
def _CheckStorageType(storage_type):
"""Ensure a given storage type is valid.
#: Storage type parameter
-_PStorageType = ("storage_type", ht.NoDefault, _CheckStorageType)
+_PStorageType = ("storage_type", ht.NoDefault, _CheckStorageType, None)
class _AutoOpParamSlots(type):
"""
assert "__slots__" not in attrs, \
"Class '%s' defines __slots__ when it should use OP_PARAMS" % name
- assert "OP_ID" in attrs, "Class '%s' is missing OP_ID attribute" % name
+ assert "OP_ID" not in attrs, "Class '%s' defining OP_ID" % name
+
+ attrs["OP_ID"] = _NameToId(name)
# Always set OP_PARAMS to avoid duplicates in BaseOpCode.GetAllParams
params = attrs.setdefault("OP_PARAMS", [])
# Use parameter names as slots
- slots = [pname for (pname, _, _) in params]
+ slots = [pname for (pname, _, _, _) in params]
assert "OP_DSC_FIELD" not in attrs or attrs["OP_DSC_FIELD"] in slots, \
"Class '%s' uses unknown field in OP_DSC_FIELD" % name
field handling.
"""
+ # pylint: disable-msg=E1101
+ # as OP_ID is dynamically defined
__metaclass__ = _AutoOpParamSlots
- OP_ID = None
-
def __init__(self, **kwargs):
"""Constructor for BaseOpCode.
requirements
"""
- for (attr_name, default, test) in self.GetAllParams():
+ for (attr_name, default, test, _) in self.GetAllParams():
assert test == ht.NoType or callable(test)
if not hasattr(self, attr_name):
@ivar priority: Opcode priority for queue
"""
- OP_ID = "OP_ABSTRACT"
+ # pylint: disable-msg=E1101
+ # as OP_ID is dynamically defined
WITH_LU = True
OP_PARAMS = [
- ("dry_run", None, ht.TMaybeBool),
- ("debug_level", None, ht.TOr(ht.TNone, ht.TPositiveInt)),
+ ("dry_run", None, ht.TMaybeBool, None),
+ ("debug_level", None, ht.TOr(ht.TNone, ht.TPositiveInt), None),
("priority", constants.OP_PRIO_DEFAULT,
- ht.TElemOf(constants.OP_PRIO_SUBMIT_VALID)),
+ ht.TElemOf(constants.OP_PRIO_SUBMIT_VALID), None),
]
def __getstate__(self):
def Summary(self):
"""Generates a summary description of this opcode.
- The summary is the value of the OP_ID attribute (without the "OP_" prefix),
- plus the value of the OP_DSC_FIELD attribute, if one was defined; this field
- should allow to easily identify the operation (for an instance creation job,
- e.g., it would be the instance name).
+ The summary is the value of the OP_ID attribute (without the "OP_"
+ prefix), plus the value of the OP_DSC_FIELD attribute, if one was
+ defined; this field should allow to easily identify the operation
+ (for an instance creation job, e.g., it would be the instance
+ name).
"""
+ assert self.OP_ID is not None and len(self.OP_ID) > 3
# all OP_ID start with OP_, we remove that
txt = self.OP_ID[3:]
field_name = getattr(self, "OP_DSC_FIELD", None)
after the cluster has been initialized.
"""
- OP_ID = "OP_CLUSTER_POST_INIT"
class OpClusterDestroy(OpCode):
lost after the execution of this opcode.
"""
- OP_ID = "OP_CLUSTER_DESTROY"
class OpClusterQuery(OpCode):
"""Query cluster information."""
- OP_ID = "OP_CLUSTER_QUERY"
class OpClusterVerify(OpCode):
only L{constants.VERIFY_NPLUSONE_MEM} can be passed
"""
- OP_ID = "OP_CLUSTER_VERIFY"
OP_PARAMS = [
("skip_checks", ht.EmptyList,
- ht.TListOf(ht.TElemOf(constants.VERIFY_OPTIONAL_CHECKS))),
- ("verbose", False, ht.TBool),
- ("error_codes", False, ht.TBool),
- ("debug_simulate_errors", False, ht.TBool),
+ ht.TListOf(ht.TElemOf(constants.VERIFY_OPTIONAL_CHECKS)), None),
+ ("verbose", False, ht.TBool, None),
+ ("error_codes", False, ht.TBool, None),
+ ("debug_simulate_errors", False, ht.TBool, None),
]
consideration. This might need to be revisited in the future.
"""
- OP_ID = "OP_CLUSTER_VERIFY_DISKS"
class OpClusterRepairDiskSizes(OpCode):
@ivar instances: the list of instances to check, or empty for all instances
"""
- OP_ID = "OP_CLUSTER_REPAIR_DISK_SIZES"
OP_PARAMS = [
- ("instances", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
+ ("instances", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
]
class OpClusterConfigQuery(OpCode):
"""Query cluster configuration values."""
- OP_ID = "OP_CLUSTER_CONFIG_QUERY"
OP_PARAMS = [
_POutputFields
]
address.
"""
- OP_ID = "OP_CLUSTER_RENAME"
OP_DSC_FIELD = "name"
OP_PARAMS = [
- ("name", ht.NoDefault, ht.TNonEmptyString),
+ ("name", ht.NoDefault, ht.TNonEmptyString, None),
]
@ivar vg_name: The new volume group name or None to disable LVM usage.
"""
- OP_ID = "OP_CLUSTER_SET_PARAMS"
OP_PARAMS = [
- ("vg_name", None, ht.TMaybeString),
+ ("vg_name", None, ht.TMaybeString, None),
("enabled_hypervisors", None,
ht.TOr(ht.TAnd(ht.TListOf(ht.TElemOf(constants.HYPER_TYPES)), ht.TTrue),
- ht.TNone)),
+ ht.TNone), None),
("hvparams", None, ht.TOr(ht.TDictOf(ht.TNonEmptyString, ht.TDict),
- ht.TNone)),
- ("beparams", None, ht.TOr(ht.TDict, ht.TNone)),
+ ht.TNone), None),
+ ("beparams", None, ht.TOr(ht.TDict, ht.TNone), None),
("os_hvp", None, ht.TOr(ht.TDictOf(ht.TNonEmptyString, ht.TDict),
- ht.TNone)),
+ ht.TNone), None),
("osparams", None, ht.TOr(ht.TDictOf(ht.TNonEmptyString, ht.TDict),
- ht.TNone)),
- ("candidate_pool_size", None, ht.TOr(ht.TStrictPositiveInt, ht.TNone)),
- ("uid_pool", None, ht.NoType),
- ("add_uids", None, ht.NoType),
- ("remove_uids", None, ht.NoType),
- ("maintain_node_health", None, ht.TMaybeBool),
- ("prealloc_wipe_disks", None, ht.TMaybeBool),
- ("nicparams", None, ht.TOr(ht.TDict, ht.TNone)),
- ("ndparams", None, ht.TOr(ht.TDict, ht.TNone)),
- ("drbd_helper", None, ht.TOr(ht.TString, ht.TNone)),
- ("default_iallocator", None, ht.TOr(ht.TString, ht.TNone)),
- ("master_netdev", None, ht.TOr(ht.TString, ht.TNone)),
- ("reserved_lvs", None, ht.TOr(ht.TListOf(ht.TNonEmptyString), ht.TNone)),
- ("hidden_os", None, ht.TOr(ht.TListOf(
- ht.TAnd(ht.TList,
- ht.TIsLength(2),
- ht.TMap(lambda v: v[0], ht.TElemOf(constants.DDMS_VALUES)))),
- ht.TNone)),
- ("blacklisted_os", None, ht.TOr(ht.TListOf(
- ht.TAnd(ht.TList,
- ht.TIsLength(2),
- ht.TMap(lambda v: v[0], ht.TElemOf(constants.DDMS_VALUES)))),
- ht.TNone)),
+ ht.TNone), None),
+ ("candidate_pool_size", None, ht.TOr(ht.TStrictPositiveInt, ht.TNone),
+ None),
+ ("uid_pool", None, ht.NoType, None),
+ ("add_uids", None, ht.NoType, None),
+ ("remove_uids", None, ht.NoType, None),
+ ("maintain_node_health", None, ht.TMaybeBool, None),
+ ("prealloc_wipe_disks", None, ht.TMaybeBool, None),
+ ("nicparams", None, ht.TMaybeDict, None),
+ ("ndparams", None, ht.TMaybeDict, None),
+ ("drbd_helper", None, ht.TOr(ht.TString, ht.TNone), None),
+ ("default_iallocator", None, ht.TOr(ht.TString, ht.TNone), None),
+ ("master_netdev", None, ht.TOr(ht.TString, ht.TNone), None),
+ ("reserved_lvs", None, ht.TOr(ht.TListOf(ht.TNonEmptyString), ht.TNone), None),
+ ("hidden_os", None, _TestClusterOsList, None),
+ ("blacklisted_os", None, _TestClusterOsList, None),
]
"""Force a full push of the cluster configuration.
"""
- OP_ID = "OP_CLUSTER_REDIST_CONF"
class OpQuery(OpCode):
@ivar filter: Query filter
"""
- OP_ID = "OP_QUERY"
OP_PARAMS = [
- ("what", ht.NoDefault, ht.TElemOf(constants.QR_OP_QUERY)),
- ("fields", ht.NoDefault, ht.TListOf(ht.TNonEmptyString)),
+ ("what", ht.NoDefault, ht.TElemOf(constants.QR_OP_QUERY), None),
+ ("fields", ht.NoDefault, ht.TListOf(ht.TNonEmptyString), None),
("filter", None, ht.TOr(ht.TNone,
- ht.TListOf(ht.TOr(ht.TNonEmptyString, ht.TList)))),
+ ht.TListOf(ht.TOr(ht.TNonEmptyString, ht.TList))), None),
]
@ivar fields: List of fields to retrieve
"""
- OP_ID = "OP_QUERY_FIELDS"
OP_PARAMS = [
- ("what", ht.NoDefault, ht.TElemOf(constants.QR_OP_QUERY)),
- ("fields", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString))),
+ ("what", ht.NoDefault, ht.TElemOf(constants.QR_OP_QUERY), None),
+ ("fields", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString)), None),
]
class OpOobCommand(OpCode):
"""Interact with OOB."""
- OP_ID = "OP_OOB_COMMAND"
OP_PARAMS = [
- _PNodeName,
- ("command", None, ht.TElemOf(constants.OOB_COMMANDS)),
- ("timeout", constants.OOB_TIMEOUT, ht.TInt),
+ ("node_names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("command", None, ht.TElemOf(constants.OOB_COMMANDS), None),
+ ("timeout", constants.OOB_TIMEOUT, ht.TInt, None),
+ ("ignore_status", False, ht.TBool, None),
+ ("force_master", False, ht.TBool, None),
]
# node opcodes
-class OpRemoveNode(OpCode):
+class OpNodeRemove(OpCode):
"""Remove a node.
@type node_name: C{str}
instances on it, the operation will fail.
"""
- OP_ID = "OP_NODE_REMOVE"
OP_DSC_FIELD = "node_name"
OP_PARAMS = [
_PNodeName,
]
-class OpAddNode(OpCode):
+class OpNodeAdd(OpCode):
"""Add a node to the cluster.
@type node_name: C{str}
@ivar master_capable: The master_capable node attribute
"""
- OP_ID = "OP_NODE_ADD"
OP_DSC_FIELD = "node_name"
OP_PARAMS = [
_PNodeName,
- ("primary_ip", None, ht.NoType),
- ("secondary_ip", None, ht.TMaybeString),
- ("readd", False, ht.TBool),
- ("group", None, ht.TMaybeString),
- ("master_capable", None, ht.TMaybeBool),
- ("vm_capable", None, ht.TMaybeBool),
- ("ndparams", None, ht.TOr(ht.TDict, ht.TNone)),
+ ("primary_ip", None, ht.NoType, None),
+ ("secondary_ip", None, ht.TMaybeString, None),
+ ("readd", False, ht.TBool, None),
+ ("group", None, ht.TMaybeString, None),
+ ("master_capable", None, ht.TMaybeBool, None),
+ ("vm_capable", None, ht.TMaybeBool, None),
+ ("ndparams", None, ht.TMaybeDict, None),
]
-class OpQueryNodes(OpCode):
+class OpNodeQuery(OpCode):
"""Compute the list of nodes."""
- OP_ID = "OP_NODE_QUERY"
OP_PARAMS = [
_POutputFields,
- ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("use_locking", False, ht.TBool),
+ ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("use_locking", False, ht.TBool, None),
]
-class OpQueryNodeVolumes(OpCode):
+class OpNodeQueryvols(OpCode):
"""Get list of volumes on node."""
- OP_ID = "OP_NODE_QUERYVOLS"
OP_PARAMS = [
_POutputFields,
- ("nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
+ ("nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
]
-class OpQueryNodeStorage(OpCode):
+class OpNodeQueryStorage(OpCode):
"""Get information on storage for node(s)."""
- OP_ID = "OP_NODE_QUERY_STORAGE"
OP_PARAMS = [
_POutputFields,
_PStorageType,
- ("nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("name", None, ht.TMaybeString),
+ ("nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("name", None, ht.TMaybeString, None),
]
-class OpModifyNodeStorage(OpCode):
+class OpNodeModifyStorage(OpCode):
"""Modifies the properies of a storage unit"""
- OP_ID = "OP_NODE_MODIFY_STORAGE"
OP_PARAMS = [
_PNodeName,
_PStorageType,
- ("name", ht.NoDefault, ht.TNonEmptyString),
- ("changes", ht.NoDefault, ht.TDict),
+ ("name", ht.NoDefault, ht.TNonEmptyString, None),
+ ("changes", ht.NoDefault, ht.TDict, None),
]
class OpRepairNodeStorage(OpCode):
"""Repairs the volume group on a node."""
- OP_ID = "OP_REPAIR_NODE_STORAGE"
OP_DSC_FIELD = "node_name"
OP_PARAMS = [
_PNodeName,
_PStorageType,
- ("name", ht.NoDefault, ht.TNonEmptyString),
- ("ignore_consistency", False, ht.TBool),
+ ("name", ht.NoDefault, ht.TNonEmptyString, None),
+ ("ignore_consistency", False, ht.TBool, None),
]
-class OpSetNodeParams(OpCode):
+class OpNodeSetParams(OpCode):
"""Change the parameters of a node."""
- OP_ID = "OP_NODE_SET_PARAMS"
OP_DSC_FIELD = "node_name"
OP_PARAMS = [
_PNodeName,
_PForce,
- ("master_candidate", None, ht.TMaybeBool),
- ("offline", None, ht.TMaybeBool),
- ("drained", None, ht.TMaybeBool),
- ("auto_promote", False, ht.TBool),
- ("master_capable", None, ht.TMaybeBool),
- ("vm_capable", None, ht.TMaybeBool),
- ("secondary_ip", None, ht.TMaybeString),
- ("ndparams", None, ht.TOr(ht.TDict, ht.TNone)),
- ("powered", None, ht.TMaybeBool),
+ ("master_candidate", None, ht.TMaybeBool, None),
+ ("offline", None, ht.TMaybeBool, None),
+ ("drained", None, ht.TMaybeBool, None),
+ ("auto_promote", False, ht.TBool, None),
+ ("master_capable", None, ht.TMaybeBool, None),
+ ("vm_capable", None, ht.TMaybeBool, None),
+ ("secondary_ip", None, ht.TMaybeString, None),
+ ("ndparams", None, ht.TMaybeDict, None),
+ ("powered", None, ht.TMaybeBool, None),
]
-class OpPowercycleNode(OpCode):
+class OpNodePowercycle(OpCode):
"""Tries to powercycle a node."""
- OP_ID = "OP_NODE_POWERCYCLE"
OP_DSC_FIELD = "node_name"
OP_PARAMS = [
_PNodeName,
]
-class OpMigrateNode(OpCode):
+class OpNodeMigrate(OpCode):
"""Migrate all instances from a node."""
- OP_ID = "OP_NODE_MIGRATE"
OP_DSC_FIELD = "node_name"
OP_PARAMS = [
_PNodeName,
]
-class OpNodeEvacuationStrategy(OpCode):
+class OpNodeEvacStrategy(OpCode):
"""Compute the evacuation strategy for a list of nodes."""
- OP_ID = "OP_NODE_EVAC_STRATEGY"
OP_DSC_FIELD = "nodes"
OP_PARAMS = [
- ("nodes", ht.NoDefault, ht.TListOf(ht.TNonEmptyString)),
- ("remote_node", None, ht.TMaybeString),
- ("iallocator", None, ht.TMaybeString),
+ ("nodes", ht.NoDefault, ht.TListOf(ht.TNonEmptyString), None),
+ ("remote_node", None, ht.TMaybeString, None),
+ ("iallocator", None, ht.TMaybeString, None),
]
(remote import only)
"""
- OP_ID = "OP_INSTANCE_CREATE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("beparams", ht.EmptyDict, ht.TDict),
- ("disks", ht.NoDefault, ht.TListOf(ht.TDict)),
- ("disk_template", ht.NoDefault, _CheckDiskTemplate),
- ("file_driver", None, ht.TOr(ht.TNone, ht.TElemOf(constants.FILE_DRIVER))),
- ("file_storage_dir", None, ht.TMaybeString),
- ("force_variant", False, ht.TBool),
- ("hvparams", ht.EmptyDict, ht.TDict),
- ("hypervisor", None, ht.TMaybeString),
- ("iallocator", None, ht.TMaybeString),
- ("identify_defaults", False, ht.TBool),
- ("ip_check", True, ht.TBool),
- ("mode", ht.NoDefault, ht.TElemOf(constants.INSTANCE_CREATE_MODES)),
- ("name_check", True, ht.TBool),
- ("nics", ht.NoDefault, ht.TListOf(ht.TDict)),
- ("no_install", None, ht.TMaybeBool),
- ("osparams", ht.EmptyDict, ht.TDict),
- ("os_type", None, ht.TMaybeString),
- ("pnode", None, ht.TMaybeString),
- ("snode", None, ht.TMaybeString),
- ("source_handshake", None, ht.TOr(ht.TList, ht.TNone)),
- ("source_instance_name", None, ht.TMaybeString),
+ ("beparams", ht.EmptyDict, ht.TDict, None),
+ ("disks", ht.NoDefault, ht.TListOf(ht.TDict), None),
+ ("disk_template", ht.NoDefault, _CheckDiskTemplate, None),
+ ("file_driver", None, ht.TOr(ht.TNone, ht.TElemOf(constants.FILE_DRIVER)), None),
+ ("file_storage_dir", None, ht.TMaybeString, None),
+ ("force_variant", False, ht.TBool, None),
+ ("hvparams", ht.EmptyDict, ht.TDict, None),
+ ("hypervisor", None, ht.TMaybeString, None),
+ ("iallocator", None, ht.TMaybeString, None),
+ ("identify_defaults", False, ht.TBool, None),
+ ("ip_check", True, ht.TBool, None),
+ ("mode", ht.NoDefault, ht.TElemOf(constants.INSTANCE_CREATE_MODES), None),
+ ("name_check", True, ht.TBool, None),
+ ("nics", ht.NoDefault, ht.TListOf(ht.TDict), None),
+ ("no_install", None, ht.TMaybeBool, None),
+ ("osparams", ht.EmptyDict, ht.TDict, None),
+ ("os_type", None, ht.TMaybeString, None),
+ ("pnode", None, ht.TMaybeString, None),
+ ("snode", None, ht.TMaybeString, None),
+ ("source_handshake", None, ht.TOr(ht.TList, ht.TNone), None),
+ ("source_instance_name", None, ht.TMaybeString, None),
("source_shutdown_timeout", constants.DEFAULT_SHUTDOWN_TIMEOUT,
- ht.TPositiveInt),
- ("source_x509_ca", None, ht.TMaybeString),
- ("src_node", None, ht.TMaybeString),
- ("src_path", None, ht.TMaybeString),
- ("start", True, ht.TBool),
- ("wait_for_sync", True, ht.TBool),
+ ht.TPositiveInt, None),
+ ("source_x509_ca", None, ht.TMaybeString, None),
+ ("src_node", None, ht.TMaybeString, None),
+ ("src_path", None, ht.TMaybeString, None),
+ ("start", True, ht.TBool, None),
+ ("wait_for_sync", True, ht.TBool, None),
]
-class OpReinstallInstance(OpCode):
+class OpInstanceReinstall(OpCode):
"""Reinstall an instance's OS."""
- OP_ID = "OP_INSTANCE_REINSTALL"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("os_type", None, ht.TMaybeString),
- ("force_variant", False, ht.TBool),
- ("osparams", None, ht.TOr(ht.TDict, ht.TNone)),
+ ("os_type", None, ht.TMaybeString, None),
+ ("force_variant", False, ht.TBool, None),
+ ("osparams", None, ht.TMaybeDict, None),
]
-class OpRemoveInstance(OpCode):
+class OpInstanceRemove(OpCode):
"""Remove an instance."""
- OP_ID = "OP_INSTANCE_REMOVE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PShutdownTimeout,
- ("ignore_failures", False, ht.TBool),
+ ("ignore_failures", False, ht.TBool, None),
]
-class OpRenameInstance(OpCode):
+class OpInstanceRename(OpCode):
"""Rename an instance."""
- OP_ID = "OP_INSTANCE_RENAME"
OP_PARAMS = [
_PInstanceName,
- ("new_name", ht.NoDefault, ht.TNonEmptyString),
- ("ip_check", False, ht.TBool),
- ("name_check", True, ht.TBool),
+ ("new_name", ht.NoDefault, ht.TNonEmptyString, None),
+ ("ip_check", False, ht.TBool, None),
+ ("name_check", True, ht.TBool, None),
]
-class OpStartupInstance(OpCode):
+class OpInstanceStartup(OpCode):
"""Startup an instance."""
- OP_ID = "OP_INSTANCE_STARTUP"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PForce,
_PIgnoreOfflineNodes,
- ("hvparams", ht.EmptyDict, ht.TDict),
- ("beparams", ht.EmptyDict, ht.TDict),
+ ("hvparams", ht.EmptyDict, ht.TDict, None),
+ ("beparams", ht.EmptyDict, ht.TDict, None),
]
-class OpShutdownInstance(OpCode):
+class OpInstanceShutdown(OpCode):
"""Shutdown an instance."""
- OP_ID = "OP_INSTANCE_SHUTDOWN"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PIgnoreOfflineNodes,
- ("timeout", constants.DEFAULT_SHUTDOWN_TIMEOUT, ht.TPositiveInt),
+ ("timeout", constants.DEFAULT_SHUTDOWN_TIMEOUT, ht.TPositiveInt, None),
]
-class OpRebootInstance(OpCode):
+class OpInstanceReboot(OpCode):
"""Reboot an instance."""
- OP_ID = "OP_INSTANCE_REBOOT"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PShutdownTimeout,
- ("ignore_secondaries", False, ht.TBool),
- ("reboot_type", ht.NoDefault, ht.TElemOf(constants.REBOOT_TYPES)),
+ ("ignore_secondaries", False, ht.TBool, None),
+ ("reboot_type", ht.NoDefault, ht.TElemOf(constants.REBOOT_TYPES), None),
]
-class OpReplaceDisks(OpCode):
+class OpInstanceReplaceDisks(OpCode):
"""Replace the disks of an instance."""
- OP_ID = "OP_INSTANCE_REPLACE_DISKS"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("mode", ht.NoDefault, ht.TElemOf(constants.REPLACE_MODES)),
- ("disks", ht.EmptyList, ht.TListOf(ht.TPositiveInt)),
- ("remote_node", None, ht.TMaybeString),
- ("iallocator", None, ht.TMaybeString),
- ("early_release", False, ht.TBool),
+ ("mode", ht.NoDefault, ht.TElemOf(constants.REPLACE_MODES), None),
+ ("disks", ht.EmptyList, ht.TListOf(ht.TPositiveInt), None),
+ ("remote_node", None, ht.TMaybeString, None),
+ ("iallocator", None, ht.TMaybeString, None),
+ ("early_release", False, ht.TBool, None),
]
class OpInstanceFailover(OpCode):
"""Failover an instance."""
- OP_ID = "OP_INSTANCE_FAILOVER"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PShutdownTimeout,
- ("ignore_consistency", False, ht.TBool),
+ ("ignore_consistency", False, ht.TBool, None),
]
-class OpMigrateInstance(OpCode):
+class OpInstanceMigrate(OpCode):
"""Migrate an instance.
This migrates (without shutting down an instance) to its secondary
@ivar mode: the migration mode (live, non-live or None for auto)
"""
- OP_ID = "OP_INSTANCE_MIGRATE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PMigrationMode,
_PMigrationLive,
- ("cleanup", False, ht.TBool),
+ ("cleanup", False, ht.TBool, None),
]
-class OpMoveInstance(OpCode):
+class OpInstanceMove(OpCode):
"""Move an instance.
This move (with shutting down an instance and data copying) to an
@ivar target_node: the destination node
"""
- OP_ID = "OP_INSTANCE_MOVE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PShutdownTimeout,
- ("target_node", ht.NoDefault, ht.TNonEmptyString),
+ ("target_node", ht.NoDefault, ht.TNonEmptyString, None),
]
class OpInstanceConsole(OpCode):
"""Connect to an instance's console."""
- OP_ID = "OP_INSTANCE_CONSOLE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName
class OpInstanceActivateDisks(OpCode):
"""Activate an instance's disks."""
- OP_ID = "OP_INSTANCE_ACTIVATE_DISKS"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("ignore_size", False, ht.TBool),
+ ("ignore_size", False, ht.TBool, None),
]
class OpInstanceDeactivateDisks(OpCode):
"""Deactivate an instance's disks."""
- OP_ID = "OP_INSTANCE_DEACTIVATE_DISKS"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
- _PInstanceName
+ _PInstanceName,
+ _PForce,
]
-class OpRecreateInstanceDisks(OpCode):
+class OpInstanceRecreateDisks(OpCode):
"""Deactivate an instance's disks."""
- OP_ID = "OP_INSTANCE_RECREATE_DISKS"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("disks", ht.EmptyList, ht.TListOf(ht.TPositiveInt)),
+ ("disks", ht.EmptyList, ht.TListOf(ht.TPositiveInt), None),
]
-class OpQueryInstances(OpCode):
+class OpInstanceQuery(OpCode):
"""Compute the list of instances."""
- OP_ID = "OP_INSTANCE_QUERY"
OP_PARAMS = [
_POutputFields,
- ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("use_locking", False, ht.TBool),
+ ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("use_locking", False, ht.TBool, None),
]
-class OpQueryInstanceData(OpCode):
+class OpInstanceQueryData(OpCode):
"""Compute the run-time status of instances."""
- OP_ID = "OP_INSTANCE_QUERY_DATA"
OP_PARAMS = [
- ("instances", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("static", False, ht.TBool),
+ ("instances", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("static", False, ht.TBool, None),
]
-class OpSetInstanceParams(OpCode):
+class OpInstanceSetParams(OpCode):
"""Change the parameters of an instance."""
- OP_ID = "OP_INSTANCE_SET_PARAMS"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PForce,
- ("nics", ht.EmptyList, ht.TList),
- ("disks", ht.EmptyList, ht.TList),
- ("beparams", ht.EmptyDict, ht.TDict),
- ("hvparams", ht.EmptyDict, ht.TDict),
- ("disk_template", None, ht.TOr(ht.TNone, _CheckDiskTemplate)),
- ("remote_node", None, ht.TMaybeString),
- ("os_name", None, ht.TMaybeString),
- ("force_variant", False, ht.TBool),
- ("osparams", None, ht.TOr(ht.TDict, ht.TNone)),
+ ("nics", ht.EmptyList, ht.TList, None),
+ ("disks", ht.EmptyList, ht.TList, None),
+ ("beparams", ht.EmptyDict, ht.TDict, None),
+ ("hvparams", ht.EmptyDict, ht.TDict, None),
+ ("disk_template", None, ht.TOr(ht.TNone, _CheckDiskTemplate), None),
+ ("remote_node", None, ht.TMaybeString, None),
+ ("os_name", None, ht.TMaybeString, None),
+ ("force_variant", False, ht.TBool, None),
+ ("osparams", None, ht.TMaybeDict, None),
]
class OpInstanceGrowDisk(OpCode):
"""Grow a disk of an instance."""
- OP_ID = "OP_INSTANCE_GROW_DISK"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("disk", ht.NoDefault, ht.TInt),
- ("amount", ht.NoDefault, ht.TInt),
- ("wait_for_sync", True, ht.TBool),
+ ("disk", ht.NoDefault, ht.TInt, None),
+ ("amount", ht.NoDefault, ht.TInt, None),
+ ("wait_for_sync", True, ht.TBool, None),
]
class OpGroupAdd(OpCode):
"""Add a node group to the cluster."""
- OP_ID = "OP_GROUP_ADD"
OP_DSC_FIELD = "group_name"
OP_PARAMS = [
_PGroupName,
- ("ndparams", None, ht.TOr(ht.TDict, ht.TNone)),
+ ("ndparams", None, ht.TMaybeDict, None),
("alloc_policy", None,
- ht.TOr(ht.TNone, ht.TElemOf(constants.VALID_ALLOC_POLICIES))),
+ ht.TOr(ht.TNone, ht.TElemOf(constants.VALID_ALLOC_POLICIES)), None),
]
class OpGroupAssignNodes(OpCode):
"""Assign nodes to a node group."""
- OP_ID = "OP_GROUP_ASSIGN_NODES"
OP_DSC_FIELD = "group_name"
OP_PARAMS = [
_PGroupName,
_PForce,
- ("nodes", ht.NoDefault, ht.TListOf(ht.TNonEmptyString)),
+ ("nodes", ht.NoDefault, ht.TListOf(ht.TNonEmptyString), None),
]
class OpGroupQuery(OpCode):
"""Compute the list of node groups."""
- OP_ID = "OP_GROUP_QUERY"
OP_PARAMS = [
_POutputFields,
- ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
+ ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
]
class OpGroupSetParams(OpCode):
"""Change the parameters of a node group."""
- OP_ID = "OP_GROUP_SET_PARAMS"
OP_DSC_FIELD = "group_name"
OP_PARAMS = [
_PGroupName,
- ("ndparams", None, ht.TOr(ht.TDict, ht.TNone)),
+ ("ndparams", None, ht.TMaybeDict, None),
("alloc_policy", None, ht.TOr(ht.TNone,
- ht.TElemOf(constants.VALID_ALLOC_POLICIES))),
+ ht.TElemOf(constants.VALID_ALLOC_POLICIES)), None),
]
class OpGroupRemove(OpCode):
"""Remove a node group from the cluster."""
- OP_ID = "OP_GROUP_REMOVE"
OP_DSC_FIELD = "group_name"
OP_PARAMS = [
_PGroupName,
class OpGroupRename(OpCode):
"""Rename a node group in the cluster."""
- OP_ID = "OP_GROUP_RENAME"
OP_DSC_FIELD = "old_name"
OP_PARAMS = [
- ("old_name", ht.NoDefault, ht.TNonEmptyString),
- ("new_name", ht.NoDefault, ht.TNonEmptyString),
+ ("old_name", ht.NoDefault, ht.TNonEmptyString, None),
+ ("new_name", ht.NoDefault, ht.TNonEmptyString, None),
]
# OS opcodes
-class OpDiagnoseOS(OpCode):
+class OpOsDiagnose(OpCode):
"""Compute the list of guest operating systems."""
- OP_ID = "OP_OS_DIAGNOSE"
OP_PARAMS = [
_POutputFields,
- ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
+ ("names", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
]
# Exports opcodes
class OpBackupQuery(OpCode):
"""Compute the list of exported images."""
- OP_ID = "OP_BACKUP_QUERY"
OP_PARAMS = [
- ("nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("use_locking", False, ht.TBool),
+ ("nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("use_locking", False, ht.TBool, None),
]
@ivar mode: Export mode (one of L{constants.EXPORT_MODES})
"""
- OP_ID = "OP_BACKUP_PREPARE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
- ("mode", ht.NoDefault, ht.TElemOf(constants.EXPORT_MODES)),
+ ("mode", ht.NoDefault, ht.TElemOf(constants.EXPORT_MODES), None),
]
only)
"""
- OP_ID = "OP_BACKUP_EXPORT"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
_PShutdownTimeout,
# TODO: Rename target_node as it changes meaning for different export modes
# (e.g. "destination")
- ("target_node", ht.NoDefault, ht.TOr(ht.TNonEmptyString, ht.TList)),
- ("shutdown", True, ht.TBool),
- ("remove_instance", False, ht.TBool),
- ("ignore_remove_failures", False, ht.TBool),
- ("mode", constants.EXPORT_MODE_LOCAL, ht.TElemOf(constants.EXPORT_MODES)),
- ("x509_key_name", None, ht.TOr(ht.TList, ht.TNone)),
- ("destination_x509_ca", None, ht.TMaybeString),
+ ("target_node", ht.NoDefault, ht.TOr(ht.TNonEmptyString, ht.TList), None),
+ ("shutdown", True, ht.TBool, None),
+ ("remove_instance", False, ht.TBool, None),
+ ("ignore_remove_failures", False, ht.TBool, None),
+ ("mode", constants.EXPORT_MODE_LOCAL, ht.TElemOf(constants.EXPORT_MODES), None),
+ ("x509_key_name", None, ht.TOr(ht.TList, ht.TNone), None),
+ ("destination_x509_ca", None, ht.TMaybeString, None),
]
class OpBackupRemove(OpCode):
"""Remove an instance's export."""
- OP_ID = "OP_BACKUP_REMOVE"
OP_DSC_FIELD = "instance_name"
OP_PARAMS = [
_PInstanceName,
# Tags opcodes
-class OpGetTags(OpCode):
+class OpTagsGet(OpCode):
"""Returns the tags of the given object."""
- OP_ID = "OP_TAGS_GET"
OP_DSC_FIELD = "name"
OP_PARAMS = [
_PTagKind,
# Name is only meaningful for nodes and instances
- ("name", ht.NoDefault, ht.TMaybeString),
+ ("name", ht.NoDefault, ht.TMaybeString, None),
]
-class OpSearchTags(OpCode):
+class OpTagsSearch(OpCode):
"""Searches the tags in the cluster for a given pattern."""
- OP_ID = "OP_TAGS_SEARCH"
OP_DSC_FIELD = "pattern"
OP_PARAMS = [
- ("pattern", ht.NoDefault, ht.TNonEmptyString),
+ ("pattern", ht.NoDefault, ht.TNonEmptyString, None),
]
-class OpAddTags(OpCode):
+class OpTagsSet(OpCode):
"""Add a list of tags on a given object."""
- OP_ID = "OP_TAGS_SET"
OP_PARAMS = [
_PTagKind,
_PTags,
# Name is only meaningful for nodes and instances
- ("name", ht.NoDefault, ht.TMaybeString),
+ ("name", ht.NoDefault, ht.TMaybeString, None),
]
-class OpDelTags(OpCode):
+class OpTagsDel(OpCode):
"""Remove a list of tags from a given object."""
- OP_ID = "OP_TAGS_DEL"
OP_PARAMS = [
_PTagKind,
_PTags,
# Name is only meaningful for nodes and instances
- ("name", ht.NoDefault, ht.TMaybeString),
+ ("name", ht.NoDefault, ht.TMaybeString, None),
]
# Test opcodes
generator. The case of duration == 0 will not be treated specially.
"""
- OP_ID = "OP_TEST_DELAY"
OP_DSC_FIELD = "duration"
OP_PARAMS = [
- ("duration", ht.NoDefault, ht.TFloat),
- ("on_master", True, ht.TBool),
- ("on_nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("repeat", 0, ht.TPositiveInt)
+ ("duration", ht.NoDefault, ht.TFloat, None),
+ ("on_master", True, ht.TBool, None),
+ ("on_nodes", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("repeat", 0, ht.TPositiveInt, None),
]
return the allocator output (direction 'out')
"""
- OP_ID = "OP_TEST_ALLOCATOR"
OP_DSC_FIELD = "allocator"
OP_PARAMS = [
("direction", ht.NoDefault,
- ht.TElemOf(constants.VALID_IALLOCATOR_DIRECTIONS)),
- ("mode", ht.NoDefault, ht.TElemOf(constants.VALID_IALLOCATOR_MODES)),
- ("name", ht.NoDefault, ht.TNonEmptyString),
+ ht.TElemOf(constants.VALID_IALLOCATOR_DIRECTIONS), None),
+ ("mode", ht.NoDefault, ht.TElemOf(constants.VALID_IALLOCATOR_MODES), None),
+ ("name", ht.NoDefault, ht.TNonEmptyString, None),
("nics", ht.NoDefault, ht.TOr(ht.TNone, ht.TListOf(
ht.TDictOf(ht.TElemOf(["mac", "ip", "bridge"]),
- ht.TOr(ht.TNone, ht.TNonEmptyString))))),
- ("disks", ht.NoDefault, ht.TOr(ht.TNone, ht.TList)),
- ("hypervisor", None, ht.TMaybeString),
- ("allocator", None, ht.TMaybeString),
- ("tags", ht.EmptyList, ht.TListOf(ht.TNonEmptyString)),
- ("mem_size", None, ht.TOr(ht.TNone, ht.TPositiveInt)),
- ("vcpus", None, ht.TOr(ht.TNone, ht.TPositiveInt)),
- ("os", None, ht.TMaybeString),
- ("disk_template", None, ht.TMaybeString),
- ("evac_nodes", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString))),
+ ht.TOr(ht.TNone, ht.TNonEmptyString)))), None),
+ ("disks", ht.NoDefault, ht.TOr(ht.TNone, ht.TList), None),
+ ("hypervisor", None, ht.TMaybeString, None),
+ ("allocator", None, ht.TMaybeString, None),
+ ("tags", ht.EmptyList, ht.TListOf(ht.TNonEmptyString), None),
+ ("mem_size", None, ht.TOr(ht.TNone, ht.TPositiveInt), None),
+ ("vcpus", None, ht.TOr(ht.TNone, ht.TPositiveInt), None),
+ ("os", None, ht.TMaybeString, None),
+ ("disk_template", None, ht.TMaybeString, None),
+ ("evac_nodes", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString)), None),
]
-class OpTestJobqueue(OpCode):
+class OpTestJqueue(OpCode):
"""Utility opcode to test some aspects of the job queue.
"""
- OP_ID = "OP_TEST_JQUEUE"
OP_PARAMS = [
- ("notify_waitlock", False, ht.TBool),
- ("notify_exec", False, ht.TBool),
- ("log_messages", ht.EmptyList, ht.TListOf(ht.TString)),
- ("fail", False, ht.TBool),
+ ("notify_waitlock", False, ht.TBool, None),
+ ("notify_exec", False, ht.TBool, None),
+ ("log_messages", ht.EmptyList, ht.TListOf(ht.TString), None),
+ ("fail", False, ht.TBool, None),
]
"""Utility opcode used by unittests.
"""
- OP_ID = "OP_TEST_DUMMY"
OP_PARAMS = [
- ("result", ht.NoDefault, ht.NoType),
- ("messages", ht.NoDefault, ht.NoType),
- ("fail", ht.NoDefault, ht.NoType),
+ ("result", ht.NoDefault, ht.NoType, None),
+ ("messages", ht.NoDefault, ht.NoType, None),
+ ("fail", ht.NoDefault, ht.NoType, None),
]
WITH_LU = False