Stricter check for OS modifications passed to OpClusterSetParams
[ganeti-local] / Makefile.am
index 80e4808..d3cefb7 100644 (file)
@@ -140,12 +140,8 @@ CLEANFILES = \
        daemons/daemon-util \
        daemons/ganeti-cleaner \
        devel/upload \
+       $(BUILT_EXAMPLES) \
        doc/examples/bash_completion \
-       doc/examples/ganeti.initd \
-       doc/examples/ganeti-kvm-poweroff.initd \
-       doc/examples/ganeti.cron \
-       doc/examples/gnt-config-backup \
-       doc/examples/hooks/ipsec \
        lib/_generated_rpc.py \
        $(man_MANS) \
        $(manhtml) \
@@ -159,17 +155,35 @@ CLEANFILES = \
 # BUILT_SOURCES should only be used as a dependency on phony targets. Otherwise
 # it'll cause the target to rebuild every time.
 BUILT_SOURCES = \
+  $(built_base_sources) \
+       $(BUILT_PYTHON_SOURCES) \
+       $(PYTHON_BOOTSTRAP)
+
+built_base_sources = \
        ganeti \
        stamp-srclinks \
-       $(all_dirfiles) \
-       $(PYTHON_BOOTSTRAP) \
-       $(BUILT_PYTHON_SOURCES)
+       $(all_dirfiles)
 
-BUILT_PYTHON_SOURCES = \
+built_python_base_sources = \
        lib/_autoconf.py \
-       lib/_vcsversion.py \
+       lib/_vcsversion.py
+
+BUILT_PYTHON_SOURCES = \
+       $(built_python_base_sources) \
        lib/_generated_rpc.py
 
+# Generating the RPC wrappers depends on many things, so make sure it's built at
+# the end of the built sources
+lib/_generated_rpc.py: | $(built_base_sources) $(built_python_base_sources)
+
+# these are all built from the underlying %.in sources
+BUILT_EXAMPLES = \
+       doc/examples/ganeti-kvm-poweroff.initd \
+       doc/examples/ganeti.cron \
+       doc/examples/ganeti.initd \
+       doc/examples/gnt-config-backup \
+       doc/examples/hooks/ipsec
+
 nodist_pkgpython_PYTHON = \
        $(BUILT_PYTHON_SOURCES)
 
@@ -340,6 +354,8 @@ HS_PROG_SRCS = $(patsubst %,%.hs,$(HS_ALL_PROGS))
 HFLAGS = -O -Wall -fwarn-monomorphism-restriction -fwarn-tabs -ihtools
 # extra flags that can be overriden on the command line
 HEXTRA =
+# internal extra flags (used for htools/test mainly)
+HEXTRA_INT =
 # exclude options for coverage reports
 HPCEXCL = --exclude Main \
        --exclude Ganeti.Constants \
@@ -369,10 +385,12 @@ HS_LIB_SRCS = \
        htools/Ganeti/HTools/Text.hs \
        htools/Ganeti/HTools/Types.hs \
        htools/Ganeti/HTools/Utils.hs \
+       htools/Ganeti/HTools/Program.hs \
        htools/Ganeti/HTools/Program/Hail.hs \
        htools/Ganeti/HTools/Program/Hbal.hs \
        htools/Ganeti/HTools/Program/Hscan.hs \
        htools/Ganeti/HTools/Program/Hspace.hs \
+       htools/Ganeti/BasicTypes.hs \
        htools/Ganeti/Jobs.hs \
        htools/Ganeti/Luxi.hs \
        htools/Ganeti/OpCodes.hs \
@@ -428,12 +446,8 @@ docpng = $(patsubst %.dot,%.png,$(docdot))
 noinst_DATA = \
        devel/upload \
        doc/html \
+       $(BUILT_EXAMPLES) \
        doc/examples/bash_completion \
-       doc/examples/ganeti.cron \
-       doc/examples/ganeti.initd \
-       doc/examples/ganeti-kvm-poweroff.initd \
-       doc/examples/gnt-config-backup \
-       doc/examples/hooks/ipsec \
        $(manhtml)
 
 gnt_scripts = \
@@ -452,14 +466,7 @@ PYTHON_BOOTSTRAP_SBIN = \
        daemons/ganeti-noded \
        daemons/ganeti-watcher \
        daemons/ganeti-rapi \
-       scripts/gnt-backup \
-       scripts/gnt-cluster \
-       scripts/gnt-debug \
-       scripts/gnt-group \
-       scripts/gnt-instance \
-       scripts/gnt-job \
-       scripts/gnt-node \
-       scripts/gnt-os
+       $(gnt_scripts)
 
 PYTHON_BOOTSTRAP = \
        $(PYTHON_BOOTSTRAP_SBIN) \
@@ -508,13 +515,27 @@ $(HS_ALL_PROGS): %: %.hs $(HS_LIB_SRCS) $(HS_BUILT_SRCS) Makefile
          $(HFLAGS) \
          $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) \
          -osuf $$BINARY.o -hisuf $$BINARY.hi \
-         $(HEXTRA) $@
+         $(HEXTRA) $(HEXTRA_INT) $@
 
 # for the htools/test binary, we need to enable profiling/coverage
-htools/test: HEXTRA=-fhpc -Wwarn -fno-warn-missing-signatures \
+htools/test: HEXTRA_INT=-fhpc -Wwarn -fno-warn-missing-signatures \
        -fno-warn-monomorphism-restriction -fno-warn-orphans \
        -fno-warn-missing-methods -fno-warn-unused-imports
 
+# rules for building profiling-enabled versions of the haskell
+# programs: hs-prof does the full two-step build, whereas
+# hs-prof-quick does only the final rebuild (hs-prof must have been
+# run before)
+.PHONY: hs-prof hs-prof-quick
+hs-prof:
+       $(MAKE) clean
+       $(MAKE) $(HS_ALL_PROGS) HEXTRA="-osuf .o"
+       rm -f $(HS_ALL_PROGS)
+       $(MAKE) hs-prof-quick
+
+hs-prof-quick:
+       $(MAKE) $(HS_ALL_PROGS) HEXTRA="-osuf .prof_o -prof -auto-all"
+
 dist_sbin_SCRIPTS = \
        tools/ganeti-listrunner
 
@@ -522,13 +543,14 @@ nodist_sbin_SCRIPTS = \
        $(PYTHON_BOOTSTRAP_SBIN) \
        daemons/ganeti-cleaner
 
-dist_tools_PYTHON = \
+python_scripts = \
        tools/burnin \
        tools/cfgshell \
        tools/cfgupgrade \
        tools/cfgupgrade12 \
        tools/cluster-merge \
        tools/confd-client \
+       tools/fmtjson \
        tools/lvmstrap \
        tools/move-instance \
        tools/ovfconverter \
@@ -536,7 +558,7 @@ dist_tools_PYTHON = \
        tools/sanitize-config
 
 dist_tools_SCRIPTS = \
-       $(dist_tools_PYTHON) \
+       $(python_scripts) \
        tools/kvm-console-wrapper \
        tools/xm-console-wrapper \
        tools/master-ip-setup
@@ -585,17 +607,14 @@ EXTRA_DIST = \
        $(docrst) \
        doc/conf.py \
        doc/html \
-       doc/examples/ganeti.initd.in \
-       doc/examples/ganeti-kvm-poweroff.initd.in \
-       doc/examples/ganeti.cron.in \
-       doc/examples/gnt-config-backup.in \
+       $(BUILT_EXAMPLES:%=%.in) \
        doc/examples/ganeti.default \
        doc/examples/ganeti.default-debug \
        doc/examples/hooks/ethers \
-       doc/examples/hooks/ipsec.in \
        doc/examples/gnt-debug/README \
        doc/examples/gnt-debug/delay0.json \
        doc/examples/gnt-debug/delay50.json \
+       test/lockperf.py \
        test/testutils.py \
        test/mocks.py \
        $(dist_TESTS) \
@@ -606,7 +625,8 @@ EXTRA_DIST = \
        qa/qa-sample.json \
        $(qa_scripts) \
        $(HS_LIB_SRCS) $(HS_BUILT_SRCS_IN) \
-       $(HS_PROG_SRCS)
+       $(HS_PROG_SRCS) \
+       htools/lint-hints.hs
 
 man_MANS = \
        man/ganeti.7 \
@@ -659,6 +679,10 @@ TEST_FILES = \
        test/data/proc_drbd83.txt \
        test/data/proc_drbd83_sync.txt \
        test/data/proc_drbd83_sync_krnl2.6.39.txt \
+       test/data/kvm_1.0_help.txt \
+       test/data/kvm_0.15.90_help.txt \
+       test/data/kvm_0.12.5_help.txt \
+       test/data/kvm_0.9.1_help.txt \
        test/data/sys_drbd_usermode_helper.txt \
        test/data/ovfdata/compr_disk.vmdk.gz \
        test/data/ovfdata/config.ini \
@@ -750,6 +774,9 @@ python_tests = \
        test/docs_unittest.py \
        test/pycurl_reset_unittest.py \
        test/tempfile_fork_unittest.py
+if HAS_FAKEROOT
+python_tests += test/ganeti.utils.io_unittest-runasroot.py
+endif
 
 haskell_tests = htools/test
 
@@ -769,7 +796,8 @@ TESTS = $(dist_TESTS) $(nodist_TESTS)
 
 # Environment for all tests
 PLAIN_TESTS_ENVIRONMENT = \
-       PYTHONPATH=. TOP_SRCDIR=$(abs_top_srcdir) PYTHON=$(PYTHON) $(RUN_IN_TEMPDIR)
+       PYTHONPATH=. TOP_SRCDIR=$(abs_top_srcdir) PYTHON=$(PYTHON) \
+       FAKEROOT=$(FAKEROOT_PATH) $(RUN_IN_TEMPDIR)
 
 # Environment for tests run by automake
 TESTS_ENVIRONMENT = \
@@ -777,7 +805,7 @@ TESTS_ENVIRONMENT = \
 
 all_python_code = \
        $(dist_sbin_SCRIPTS) \
-       $(dist_tools_PYTHON) \
+       $(python_scripts) \
        $(pkglib_python_scripts) \
        $(nodist_pkglib_python_scripts) \
        $(python_tests) \
@@ -816,7 +844,7 @@ lint_python_code = \
        ganeti \
        ganeti/http/server.py \
        $(dist_sbin_SCRIPTS) \
-       $(dist_tools_PYTHON) \
+       $(python_scripts) \
        $(pkglib_python_scripts) \
        $(BUILD_BASH_COMPLETION) \
        $(CHECK_IMPORTS) \
@@ -832,7 +860,7 @@ pep8_python_code = \
        ganeti \
        ganeti/http/server.py \
        $(dist_sbin_SCRIPTS) \
-       $(dist_tools_PYTHON) \
+       $(python_scripts) \
        $(pkglib_python_scripts) \
        $(BUILD_BASH_COMPLETION) \
        $(CHECK_HEADER) \
@@ -1029,8 +1057,8 @@ lib/_vcsversion.py: Makefile vcs-version | lib/.dir
          echo "VCS_VERSION = '$$VCSVER'"; \
        } > $@
 
-lib/_generated_rpc.py: lib/rpc_defs.py $(BUILD_RPC) | lib/.dir
-       PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(BUILD_RPC) $< > $@
+lib/_generated_rpc.py: lib/rpc_defs.py $(BUILD_RPC)
+       PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(BUILD_RPC) lib/rpc_defs.py > $@
 
 $(REPLACE_VARS_SED): Makefile
        set -e; \
@@ -1179,9 +1207,16 @@ lint: $(BUILT_SOURCES)
          --rcfile  ../pylintrc $(patsubst qa/%.py,%,$(qa_scripts))
 
 .PHONY: hlint
-hlint: $(HS_BUILT_SRCS)
+hlint: $(HS_BUILT_SRCS) htools/lint-hints.hs
        if tty -s; then C="-c"; else C=""; fi; \
-       hlint --report=doc/hs-lint.html $$C htools
+       hlint --report=doc/hs-lint.html --cross $$C \
+         --ignore "Use first" \
+         --ignore "Use comparing" \
+         --ignore "Use on" \
+         --ignore "Use Control.Exception.catch" \
+         --ignore "Reduce duplication" \
+         --hint htools/lint-hints \
+         $(filter-out htools/Ganeti/THH.hs,$(HS_LIB_SRCS))
 
 # a dist hook rule for updating the vcs-version file; this is
 # hardcoded due to where it needs to build the file...