# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA.
-let problems=0
+set -e
+
+readonly maxlinelen=$(for ((i=0; i<81; ++i)); do echo -n .; done)
+
+if [[ "${#maxlinelen}" != 81 ]]; then
+ echo "Internal error: Check for line length is incorrect" >&2
+ exit 1
+fi
+
+# "[...] If the last ARG evaluates to 0, let returns 1; 0 is returned
+# otherwise.", hence ignoring the return value.
+let problems=0 || :
for script; do
if grep -n -H -F $'\t' "$script"; then
echo "Found end-of-line-whitespace in $script" >&2
fi
- if [[ "$(wc --max-line-length < "$script")" -gt 80 ]]; then
+ # FIXME: This will also match "foo.xrange(...)"
+ if grep -n -H -E '^[^#]*\<xrange\>' "$script"; then
+ let ++problems
+ echo "Forbidden function 'xrange' used in $script" >&2
+ fi
+
+ if grep -n -H -E -i '#[[:space:]]*(vim|Local[[:space:]]+Variables):' "$script"
+ then
+ let ++problems
+ echo "Found editor-specific settings in $script" >&2
+ fi
+
+ if grep -n -H "^$maxlinelen" "$script"; then
let ++problems
echo "Longest line in $script is longer than 80 characters" >&2
fi