serializer: Fail if dictionary uses invalid keys

[ganeti-local] / test / ganeti.serializer_unittest.py

diff --git a/test/ganeti.serializer_unittest.py b/test/ganeti.serializer_unittest.py
index 9d8d656..3e68efa 100755 (executable)
--- a/test/ganeti.serializer_unittest.py
+++ b/test/ganeti.serializer_unittest.py
@@ -23,9 +23,11 @@
 
 
 import unittest
+import warnings
 
 from ganeti import serializer
 from ganeti import errors
+from ganeti import compat
 
 import testutils
 
@@ -107,5 +109,24 @@ class TestSerializer(testutils.GanetiTestCase):
                       serializer.DumpJson(tdata), "mykey")
 
 
+class TestInvalidDictionaryKey(unittest.TestCase):
+  def _Test(self, data):
+    if serializer._OLD_SIMPLEJSON:
+      # Using old "simplejson", can't really test
+      warnings.warn("This test requires Python 2.6 or above to function"
+                    " correctly")
+      self.assertTrue(serializer.DumpJson(data))
+    else:
+      self.assertRaises(ValueError, serializer.DumpJson, data)
+
+  def test(self):
+    for value in [123, 1.1, -1, -9492.1123, -3234e-4]:
+      self._Test({value: ""})
+
+  def testAllowed(self):
+    for value in ["", "Hello World", None, True, False]:
+      self.assertTrue(serializer.DumpJson({value: ""}))
+
+
 if __name__ == '__main__':
   testutils.GanetiTestProgram()