opcodes.OpRenameCluster: cmdlib.LURenameCluster,
opcodes.OpVerifyDisks: cmdlib.LUVerifyDisks,
opcodes.OpSetClusterParams: cmdlib.LUSetClusterParams,
+ opcodes.OpRedistributeConfig: cmdlib.LURedistributeConfig,
+ opcodes.OpRepairDiskSizes: cmdlib.LURepairDiskSizes,
# node lu
opcodes.OpAddNode: cmdlib.LUAddNode,
opcodes.OpQueryNodes: cmdlib.LUQueryNodes,
opcodes.OpQueryNodeVolumes: cmdlib.LUQueryNodeVolumes,
opcodes.OpRemoveNode: cmdlib.LURemoveNode,
+ opcodes.OpSetNodeParams: cmdlib.LUSetNodeParams,
# instance lu
opcodes.OpCreateInstance: cmdlib.LUCreateInstance,
opcodes.OpReinstallInstance: cmdlib.LUReinstallInstance,
opcodes.OpDeactivateInstanceDisks: cmdlib.LUDeactivateInstanceDisks,
opcodes.OpReplaceDisks: cmdlib.LUReplaceDisks,
opcodes.OpFailoverInstance: cmdlib.LUFailoverInstance,
+ opcodes.OpMigrateInstance: cmdlib.LUMigrateInstance,
opcodes.OpConnectConsole: cmdlib.LUConnectConsole,
opcodes.OpQueryInstances: cmdlib.LUQueryInstances,
opcodes.OpQueryInstanceData: cmdlib.LUQueryInstanceData,
"""
self.context = context
self._feedback_fn = None
- self.exclusive_BGL = False
+ self.exclusive_BGL = False # pylint: disable-msg=C0103
self.rpc = rpc.RpcRunner(context.cfg)
def _ExecLU(self, lu):
self.context.glm.add(level, add_locks, acquired=1, shared=share)
except errors.LockError:
raise errors.OpPrereqError(
- "Coudn't add locks (%s), probably because of a race condition"
+ "Couldn't add locks (%s), probably because of a race condition"
" with another job, who added them first" % add_locks)
try:
try:
@type run_notifier: callable (no arguments) or None
@param run_notifier: this function (if callable) will be called when
we are about to call the lu's Exec() method, that
- is, after we have aquired all locks
+ is, after we have acquired all locks
"""
if not isinstance(op, opcodes.OpCode):
logging.debug("Step %d/%d %s", current, total, message)
self._feedback_fn("STEP %d/%d %s" % (current, total, message))
- def LogWarning(self, message, hint=None):
+ def LogWarning(self, message, *args, **kwargs):
"""Log a warning to the logs and the user.
- """
- logging.warning(message)
- self._feedback_fn(" - WARNING: %s" % message)
- if hint:
- self._feedback_fn(" Hint: %s" % hint)
+ The optional keyword argument is 'hint' and can be used to show a
+ hint to the user (presumably related to the warning). If the
+ message is empty, it will not be printed at all, allowing one to
+ show only a hint.
- def LogInfo(self, message):
+ """
+ assert not kwargs or (len(kwargs) == 1 and "hint" in kwargs), \
+ "Invalid keyword arguments for LogWarning (%s)" % str(kwargs)
+ if args:
+ message = message % tuple(args)
+ if message:
+ logging.warning(message)
+ self._feedback_fn(" - WARNING: %s" % message)
+ if "hint" in kwargs:
+ self._feedback_fn(" Hint: %s" % kwargs["hint"])
+
+ def LogInfo(self, message, *args):
"""Log an informational message to the logs and the user.
"""
+ if args:
+ message = message % tuple(args)
logging.info(message)
self._feedback_fn(" - INFO: %s" % message)
This is the main function of the HookMaster.
- Args:
- phase: the hooks phase to run
-
- Returns:
- the result of the hooks multi-node rpc call
+ @param phase: one of L{constants.HOOKS_PHASE_POST} or
+ L{constants.HOOKS_PHASE_PRE}; it denotes the hooks phase
+ @return: the processed results of the hooks multi-node rpc call
+ @raise errors.HooksFailure: on communication failure to the nodes
"""
if not self.node_list[phase]:
raise errors.HooksFailure("Communication failure")
for node_name in results:
res = results[node_name]
- if res is False or not isinstance(res, list):
- self.proc.LogWarning("Communication failure to node %s" % node_name)
+ if res.failed or res.data is False or not isinstance(res.data, list):
+ if not res.offline:
+ self.proc.LogWarning("Communication failure to node %s" %
+ node_name)
continue
- for script, hkr, output in res:
+ for script, hkr, output in res.data:
if hkr == constants.HKR_FAIL:
- output = output.strip().encode("string_escape")
errs.append((node_name, script, output))
if errs:
raise errors.HooksAbort(errs)
phase = constants.HOOKS_PHASE_POST
hpath = constants.HOOKS_NAME_CFGUPDATE
nodes = [self.lu.cfg.GetMasterNode()]
- results = self._RunWrapper(nodes, hpath, phase)
+ self._RunWrapper(nodes, hpath, phase)