(result.cmd, result.exit_code, result.output))
-def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
+def InitCluster(cluster_name, mac_prefix, def_bridge,
master_netdev, file_storage_dir,
secondary_ip=None,
- vg_name=None):
+ vg_name=None, beparams=None, hvparams=None,
+ enabled_hypervisors=None, default_hypervisor=None):
"""Initialise the cluster.
"""
if config.ConfigWriter.IsCluster():
raise errors.OpPrereqError("Cluster is already initialised")
- if hypervisor_type == constants.HT_XEN_HVM:
- if not os.path.exists(constants.VNC_PASSWORD_FILE):
- raise errors.OpPrereqError("Please prepare the cluster VNC"
- "password file %s" %
- constants.VNC_PASSWORD_FILE)
-
hostname = utils.HostInfo()
if hostname.ip.startswith("127."):
if not re.match("^[0-9a-z]{2}:[0-9a-z]{2}:[0-9a-z]{2}$", mac_prefix):
raise errors.OpPrereqError("Invalid mac prefix given '%s'" % mac_prefix)
- if hypervisor_type not in constants.HYPER_TYPES:
- raise errors.OpPrereqError("Invalid hypervisor type given '%s'" %
- hypervisor_type)
-
result = utils.RunCmd(["ip", "link", "show", "dev", master_netdev])
if result.failed:
raise errors.OpPrereqError("Invalid master netdev given (%s): '%s'" %
volume_group_name=vg_name,
default_bridge=def_bridge,
tcpudp_port_pool=set(),
- hypervisor=hypervisor_type,
master_node=hostname.name,
master_ip=clustername.ip,
master_netdev=master_netdev,
cluster_name=clustername.name,
file_storage_dir=file_storage_dir,
+ enabled_hypervisors=enabled_hypervisors,
+ default_hypervisor=default_hypervisor,
+ beparams={constants.BEGR_DEFAULT: beparams},
+ hvparams=hvparams,
)
master_node_config = objects.Node(name=hostname.name,
primary_ip=hostname.ip,
new_master = utils.HostInfo().name
old_master = cfg.GetMasterNode()
+ node_list = cfg.GetNodeList()
if old_master == new_master:
raise errors.OpPrereqError("This commands must be run on the node"
" where you want the new master to be."
" %s is already the master" %
old_master)
+
+ vote_list = GatherMasterVotes(node_list)
+
+ if vote_list:
+ voted_master = vote_list[0][0]
+ if voted_master is None:
+ raise errors.OpPrereqError("Cluster is inconsistent, most nodes did not"
+ " respond.")
+ elif voted_master != old_master:
+ raise errors.OpPrereqError("I have wrong configuration, I believe the"
+ " master is %s but the other nodes voted for"
+ " %s. Please resync the configuration of"
+ " this node." % (old_master, voted_master))
# end checks
rcode = 0
- logging.info("setting master to %s, old master: %s", new_master, old_master)
+ logging.info("Setting master to %s, old master: %s", new_master, old_master)
if not RpcRunner.call_node_stop_master(old_master, True):
- logging.error("could disable the master role on the old master"
+ logging.error("Could not disable the master role on the old master"
" %s, please disable manually", old_master)
cfg.SetMasterNode(new_master)
if not RpcRunner.call_upload_file(cfg.GetNodeList(),
constants.CLUSTER_CONF_FILE):
- logging.error("could not distribute the new simple store master file"
+ logging.error("Could not distribute the new configuration"
" to the other nodes, please check.")
+
if not RpcRunner.call_node_start_master(new_master, True):
- logging.error("could not start the master role on the new master"
+ logging.error("Could not start the master role on the new master"
" %s, please check", new_master)
rcode = 1
return rcode
+
+
+def GatherMasterVotes(node_list):
+ """Check the agreement on who is the master.
+
+ This function will return a list of (node, number of votes), ordered
+ by the number of votes. Errors will be denoted by the key 'None'.
+
+ Note that the sum of votes is the number of nodes this machine
+ knows, whereas the number of entries in the list could be different
+ (if some nodes vote for another master).
+
+ We remove ourselves from the list since we know that (bugs aside)
+ since we use the same source for configuration information for both
+ backend and boostrap, we'll always vote for ourselves.
+
+ @type node_list: list
+ @param node_list: the list of nodes to query for master info; the current
+ node wil be removed if it is in the list
+ @rtype: list
+ @return: list of (node, votes)
+
+ """
+ myself = utils.HostInfo().name
+ try:
+ node_list.remove(myself)
+ except ValueError:
+ pass
+ if not node_list:
+ # no nodes left (eventually after removing myself)
+ return []
+ results = rpc.RpcRunner.call_master_info(node_list)
+ if not isinstance(results, dict):
+ # this should not happen (unless internal error in rpc)
+ logging.critical("Can't complete rpc call, aborting master startup")
+ return [(None, len(node_list))]
+ positive = negative = 0
+ other_masters = {}
+ votes = {}
+ for node in results:
+ if not isinstance(results[node], (tuple, list)) or len(results[node]) < 3:
+ # here the rpc layer should have already logged errors
+ if None not in votes:
+ votes[None] = 0
+ votes[None] += 1
+ continue
+ master_node = results[node][2]
+ if master_node not in votes:
+ votes[master_node] = 0
+ votes[master_node] += 1
+
+ vote_list = [v for v in votes.items()]
+ # sort first on number of votes then on name, since we want None
+ # sorted later if we have the half of the nodes not responding, and
+ # half voting all for the same master
+ vote_list.sort(key=lambda x: (x[1], x[0]), reverse=True)
+
+ return vote_list
projects / ganeti-local / blobdiff