Use utils.ReadFile to read SSL certificate
[ganeti-local] / lib / bootstrap.py
index ae9aad9..8a6ca56 100644 (file)
@@ -38,7 +38,6 @@ from ganeti import constants
 from ganeti import objects
 from ganeti import ssconf
 
-
 def _InitSSHSetup(node):
   """Setup the SSH configuration for the cluster.
 
@@ -104,22 +103,17 @@ def _InitGanetiServerSetup():
                              (result.cmd, result.exit_code, result.output))
 
 
-def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
+def InitCluster(cluster_name, mac_prefix, def_bridge,
                 master_netdev, file_storage_dir,
                 secondary_ip=None,
-                vg_name=None):
+                vg_name=None, beparams=None, hvparams=None,
+                enabled_hypervisors=None, default_hypervisor=None):
   """Initialise the cluster.
 
   """
   if config.ConfigWriter.IsCluster():
     raise errors.OpPrereqError("Cluster is already initialised")
 
-  if hypervisor_type == constants.HT_XEN_HVM31:
-    if not os.path.exists(constants.VNC_PASSWORD_FILE):
-      raise errors.OpPrereqError("Please prepare the cluster VNC"
-                                 "password file %s" %
-                                 constants.VNC_PASSWORD_FILE)
-
   hostname = utils.HostInfo()
 
   if hostname.ip.startswith("127."):
@@ -127,8 +121,7 @@ def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
                                " range (%s). Please fix DNS or %s." %
                                (hostname.ip, constants.ETC_HOSTS))
 
-  if not utils.TcpPing(hostname.ip, constants.DEFAULT_NODED_PORT,
-                       source=constants.LOCALHOST_IP_ADDRESS):
+  if not utils.OwnIpAddress(hostname.ip):
     raise errors.OpPrereqError("Inconsistency: this host's name resolves"
                                " to %s,\nbut this ip address does not"
                                " belong to this host."
@@ -144,8 +137,7 @@ def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
     if not utils.IsValidIP(secondary_ip):
       raise errors.OpPrereqError("Invalid secondary ip given")
     if (secondary_ip != hostname.ip and
-        (not utils.TcpPing(secondary_ip, constants.DEFAULT_NODED_PORT,
-                           source=constants.LOCALHOST_IP_ADDRESS))):
+        not utils.OwnIpAddress(secondary_ip)):
       raise errors.OpPrereqError("You gave %s as secondary IP,"
                                  " but it does not belong to this host." %
                                  secondary_ip)
@@ -181,10 +173,6 @@ def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
   if not re.match("^[0-9a-z]{2}:[0-9a-z]{2}:[0-9a-z]{2}$", mac_prefix):
     raise errors.OpPrereqError("Invalid mac prefix given '%s'" % mac_prefix)
 
-  if hypervisor_type not in constants.HYPER_TYPES:
-    raise errors.OpPrereqError("Invalid hypervisor type given '%s'" %
-                               hypervisor_type)
-
   result = utils.RunCmd(["ip", "link", "show", "dev", master_netdev])
   if result.failed:
     raise errors.OpPrereqError("Invalid master netdev given (%s): '%s'" %
@@ -196,16 +184,6 @@ def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
     raise errors.OpPrereqError("Init.d script '%s' missing or not"
                                " executable." % constants.NODE_INITD_SCRIPT)
 
-  # set up the simple store
-  ss = ssconf.WritableSimpleStore()
-  ss.SetKey(ss.SS_HYPERVISOR, hypervisor_type)
-  ss.SetKey(ss.SS_MASTER_NODE, hostname.name)
-  ss.SetKey(ss.SS_MASTER_IP, clustername.ip)
-  ss.SetKey(ss.SS_MASTER_NETDEV, master_netdev)
-  ss.SetKey(ss.SS_CLUSTER_NAME, clustername.name)
-  ss.SetKey(ss.SS_FILE_STORAGE_DIR, file_storage_dir)
-  ss.SetKey(ss.SS_CONFIG_VERSION, constants.CONFIG_VERSION)
-
   # set up the inter-node password and certificate
   _InitGanetiServerSetup()
 
@@ -229,24 +207,62 @@ def InitCluster(cluster_name, hypervisor_type, mac_prefix, def_bridge,
     volume_group_name=vg_name,
     default_bridge=def_bridge,
     tcpudp_port_pool=set(),
-    hypervisor=hypervisor_type,
     master_node=hostname.name,
     master_ip=clustername.ip,
     master_netdev=master_netdev,
     cluster_name=clustername.name,
     file_storage_dir=file_storage_dir,
+    enabled_hypervisors=enabled_hypervisors,
+    default_hypervisor=default_hypervisor,
+    beparams={constants.BEGR_DEFAULT: beparams},
+    hvparams=hvparams,
     )
   master_node_config = objects.Node(name=hostname.name,
                                     primary_ip=hostname.ip,
                                     secondary_ip=secondary_ip)
-  cfg = config.ConfigWriter()
-  cfg.InitConfig(constants.CONFIG_VERSION, cluster_config, master_node_config)
 
+  cfg = InitConfig(constants.CONFIG_VERSION,
+                   cluster_config, master_node_config)
   ssh.WriteKnownHostsFile(cfg, constants.SSH_KNOWN_HOSTS_FILE)
 
   # start the master ip
   # TODO: Review rpc call from bootstrap
-  rpc.call_node_start_master(hostname.name, True)
+  rpc.RpcRunner.call_node_start_master(hostname.name, True)
+
+
+def InitConfig(version, cluster_config, master_node_config,
+               cfg_file=constants.CLUSTER_CONF_FILE):
+  """Create the initial cluster configuration.
+
+  It will contain the current node, which will also be the master
+  node, and no instances.
+
+  @type version: int
+  @param version: Configuration version
+  @type cluster_config: objects.Cluster
+  @param cluster_config: Cluster configuration
+  @type master_node_config: objects.Node
+  @param master_node_config: Master node configuration
+  @type file_name: string
+  @param file_name: Configuration file path
+
+  @rtype: ssconf.SimpleConfigWriter
+  @returns: Initialized config instance
+
+  """
+  nodes = {
+    master_node_config.name: master_node_config,
+    }
+
+  config_data = objects.ConfigData(version=version,
+                                   cluster=cluster_config,
+                                   nodes=nodes,
+                                   instances={},
+                                   serial_no=1)
+  cfg = ssconf.SimpleConfigWriter.FromDict(config_data.ToDict(), cfg_file)
+  cfg.Save()
+
+  return cfg
 
 
 def FinalizeClusterDestroy(master):
@@ -256,9 +272,9 @@ def FinalizeClusterDestroy(master):
   begun in cmdlib.LUDestroyOpcode.
 
   """
-  if not rpc.call_node_stop_master(master, True):
+  if not rpc.RpcRunner.call_node_stop_master(master, True):
     logging.warning("Could not disable the master role")
-  if not rpc.call_node_leave_cluster(master):
+  if not rpc.RpcRunner.call_node_leave_cluster(master):
     logging.warning("Could not shutdown the node daemon and cleanup the node")
 
 
@@ -274,15 +290,11 @@ def SetupNodeDaemon(node, ssh_key_check):
 
   """
   cfg = ssconf.SimpleConfigReader()
-  sshrunner = ssh.SshRunner(cfg)
+  sshrunner = ssh.SshRunner(cfg.GetClusterName())
   gntpass = utils.GetNodeDaemonPassword()
   if not re.match('^[a-zA-Z0-9.]{1,64}$', gntpass):
     raise errors.OpExecError("ganeti password corruption detected")
-  f = open(constants.SSL_CERT_FILE)
-  try:
-    gntpem = f.read(8192)
-  finally:
-    f.close()
+  gntpem = utils.ReadFile(constants.SSL_CERT_FILE)
   # in the base64 pem encoding, neither '!' nor '.' are valid chars,
   # so we use this to detect an invalid certificate; as long as the
   # cert doesn't contain this, the here-document will be correctly
@@ -328,20 +340,34 @@ def MasterFailover():
 
   new_master = utils.HostInfo().name
   old_master = cfg.GetMasterNode()
+  node_list = cfg.GetNodeList()
 
   if old_master == new_master:
     raise errors.OpPrereqError("This commands must be run on the node"
                                " where you want the new master to be."
                                " %s is already the master" %
                                old_master)
+
+  vote_list = GatherMasterVotes(node_list)
+
+  if vote_list:
+    voted_master = vote_list[0][0]
+    if voted_master is None:
+      raise errors.OpPrereqError("Cluster is inconsistent, most nodes did not"
+                                 " respond.")
+    elif voted_master != old_master:
+      raise errors.OpPrereqError("I have wrong configuration, I believe the"
+                                 " master is %s but the other nodes voted for"
+                                 " %s. Please resync the configuration of"
+                                 " this node." % (old_master, voted_master))
   # end checks
 
   rcode = 0
 
-  logging.info("setting master to %s, old master: %s", new_master, old_master)
+  logging.info("Setting master to %s, old master: %s", new_master, old_master)
 
-  if not rpc.call_node_stop_master(old_master, True):
-    logging.error("could disable the master role on the old master"
+  if not rpc.RpcRunner.call_node_stop_master(old_master, True):
+    logging.error("Could not disable the master role on the old master"
                  " %s, please disable manually", old_master)
 
   cfg.SetMasterNode(new_master)
@@ -349,14 +375,73 @@ def MasterFailover():
 
   # Here we have a phase where no master should be running
 
-  if not rpc.call_upload_file(cfg.GetNodeList(),
-                              constants.CLUSTER_CONF_FILE):
-    logging.error("could not distribute the new simple store master file"
+  if not rpc.RpcRunner.call_upload_file(cfg.GetNodeList(),
+                                    constants.CLUSTER_CONF_FILE):
+    logging.error("Could not distribute the new configuration"
                   " to the other nodes, please check.")
 
-  if not rpc.call_node_start_master(new_master, True):
-    logging.error("could not start the master role on the new master"
+
+  if not rpc.RpcRunner.call_node_start_master(new_master, True):
+    logging.error("Could not start the master role on the new master"
                   " %s, please check", new_master)
     rcode = 1
 
   return rcode
+
+
+def GatherMasterVotes(node_list):
+  """Check the agreement on who is the master.
+
+  This function will return a list of (node, number of votes), ordered
+  by the number of votes. Errors will be denoted by the key 'None'.
+
+  Note that the sum of votes is the number of nodes this machine
+  knows, whereas the number of entries in the list could be different
+  (if some nodes vote for another master).
+
+  We remove ourselves from the list since we know that (bugs aside)
+  since we use the same source for configuration information for both
+  backend and boostrap, we'll always vote for ourselves.
+
+  @type node_list: list
+  @param node_list: the list of nodes to query for master info; the current
+      node wil be removed if it is in the list
+  @rtype: list
+  @return: list of (node, votes)
+
+  """
+  myself = utils.HostInfo().name
+  try:
+    node_list.remove(myself)
+  except ValueError:
+    pass
+  if not node_list:
+    # no nodes left (eventually after removing myself)
+    return []
+  results = rpc.RpcRunner.call_master_info(node_list)
+  if not isinstance(results, dict):
+    # this should not happen (unless internal error in rpc)
+    logging.critical("Can't complete rpc call, aborting master startup")
+    return [(None, len(node_list))]
+  positive = negative = 0
+  other_masters = {}
+  votes = {}
+  for node in results:
+    if not isinstance(results[node], (tuple, list)) or len(results[node]) < 3:
+      # here the rpc layer should have already logged errors
+      if None not in votes:
+        votes[None] = 0
+      votes[None] += 1
+      continue
+    master_node = results[node][2]
+    if master_node not in votes:
+      votes[master_node] = 0
+    votes[master_node] += 1
+
+  vote_list = [v for v in votes.items()]
+  # sort first on number of votes then on name, since we want None
+  # sorted later if we have the half of the nodes not responding, and
+  # half voting all for the same master
+  vote_list.sort(key=lambda x: (x[1], x[0]), reverse=True)
+
+  return vote_list