from ganeti import utils
from ganeti import bootstrap
from ganeti import ssh
+from ganeti import objects
@UsesRPC
return 1
hvparams = dict(opts.hvparams)
-
beparams = opts.beparams
- # check for invalid parameters
- for parameter in beparams:
- if parameter not in constants.BES_PARAMETERS:
- ToStderr("Invalid backend parameter: %s", parameter)
- return 1
+ nicparams = opts.nicparams
# prepare beparams dict
- for parameter in constants.BES_PARAMETERS:
- if parameter not in beparams:
- beparams[parameter] = constants.BEC_DEFAULTS[parameter]
+ beparams = objects.FillDict(constants.BEC_DEFAULTS, beparams)
utils.ForceDictType(beparams, constants.BES_PARAMETER_TYPES)
+ # prepare nicparams dict
+ nicparams = objects.FillDict(constants.NICC_DEFAULTS, nicparams)
+ utils.ForceDictType(nicparams, constants.NICS_PARAMETER_TYPES)
+
# prepare hvparams dict
for hv in constants.HYPER_TYPES:
if hv not in hvparams:
hvparams[hv] = {}
- for parameter in constants.HVC_DEFAULTS[hv]:
- if parameter not in hvparams[hv]:
- hvparams[hv][parameter] = constants.HVC_DEFAULTS[hv][parameter]
+ hvparams[hv] = objects.FillDict(constants.HVC_DEFAULTS[hv], hvparams[hv])
utils.ForceDictType(hvparams[hv], constants.HVS_PARAMETER_TYPES)
for hv in hvlist:
secondary_ip=opts.secondary_ip,
vg_name=vg_name,
mac_prefix=opts.mac_prefix,
- def_bridge=opts.def_bridge,
master_netdev=opts.master_netdev,
file_storage_dir=opts.file_storage_dir,
enabled_hypervisors=hvlist,
default_hypervisor=opts.default_hypervisor,
hvparams=hvparams,
beparams=beparams,
+ nicparams=nicparams,
candidate_pool_size=opts.candidate_pool_size,
+ modify_etc_hosts=opts.modify_etc_hosts,
)
return 0
@return: the desired exit code
"""
- ToStdout("%s", GetClient().QueryConfigValues(["master_node"])[0])
+ master = bootstrap.GetMaster()
+ ToStdout(master)
return 0
+def _PrintGroupedParams(paramsdict):
+ """Print Grouped parameters (be, nic, disk) by group.
+
+ @type paramsdict: dict of dicts
+ @param paramsdict: {group: {param: value, ...}, ...}
+
+ """
+ for gr_name, gr_dict in paramsdict.items():
+ ToStdout(" - %s:", gr_name)
+ for item, val in gr_dict.iteritems():
+ ToStdout(" %s: %s", item, val)
def ShowClusterConfig(opts, args):
"""Shows cluster information.
ToStdout("Enabled hypervisors: %s", ", ".join(result["enabled_hypervisors"]))
ToStdout("Hypervisor parameters:")
- for hv_name, hv_dict in result["hvparams"].items():
- ToStdout(" - %s:", hv_name)
- for item, val in hv_dict.iteritems():
- ToStdout(" %s: %s", item, val)
+ _PrintGroupedParams(result["hvparams"])
ToStdout("Cluster parameters:")
ToStdout(" - candidate pool size: %s", result["candidate_pool_size"])
+ ToStdout(" - master netdev: %s", result["master_netdev"])
+ ToStdout(" - lvm volume group: %s", result["volume_group_name"])
+ ToStdout(" - file storage path: %s", result["file_storage_dir"])
ToStdout("Default instance parameters:")
- for gr_name, gr_dict in result["beparams"].items():
- ToStdout(" - %s:", gr_name)
- for item, val in gr_dict.iteritems():
- ToStdout(" %s: %s", item, val)
+ _PrintGroupedParams(result["beparams"])
+
+ ToStdout("Default nic parameters:")
+ _PrintGroupedParams(result["nicparams"])
return 0
"""
op = opcodes.OpVerifyDisks()
result = SubmitOpCode(op)
- if not isinstance(result, (list, tuple)) or len(result) != 4:
+ if not isinstance(result, (list, tuple)) or len(result) != 3:
raise errors.ProgrammerError("Unknown result type for OpVerifyDisks")
- nodes, nlvm, instances, missing = result
+ bad_nodes, instances, missing = result
- if nodes:
- ToStdout("Nodes unreachable or with bad data:")
- for name in nodes:
- ToStdout("\t%s", name)
retcode = constants.EXIT_SUCCESS
- if nlvm:
- for node, text in nlvm.iteritems():
- ToStdout("Error on node %s: LVM error: %s",
+ if bad_nodes:
+ for node, text in bad_nodes.items():
+ ToStdout("Error gathering data on node %s: %s",
node, utils.SafeEncode(text[-400:]))
retcode |= 1
ToStdout("You need to fix these nodes first before fixing instances")
if missing:
for iname, ival in missing.iteritems():
- all_missing = utils.all(ival, lambda x: x[0] in nlvm)
+ all_missing = utils.all(ival, lambda x: x[0] in bad_nodes)
if all_missing:
ToStdout("Instance %s cannot be verified as it lives on"
" broken nodes", iname)
ToStdout("Instance %s has missing logical volumes:", iname)
ival.sort()
for node, vol in ival:
- if node in nlvm:
+ if node in bad_nodes:
ToStdout("\tbroken node %s /dev/xenvg/%s", node, vol)
else:
ToStdout("\t%s /dev/xenvg/%s", node, vol)
@return: the desired exit code
"""
- return bootstrap.MasterFailover()
+ if opts.no_voting:
+ usertext = ("This will perform the failover even if most other nodes"
+ " are down, or if this node is outdated. This is dangerous"
+ " as it can lead to a non-consistent cluster. Check the"
+ " gnt-cluster(8) man page before proceeding. Continue?")
+ if not AskUser(usertext):
+ return 1
+
+ return bootstrap.MasterFailover(no_voting=opts.no_voting)
def SearchTags(opts, args):
"""
if not (not opts.lvm_storage or opts.vg_name or
opts.enabled_hypervisors or opts.hvparams or
- opts.beparams or opts.candidate_pool_size is not None):
+ opts.beparams or opts.nicparams or
+ opts.candidate_pool_size is not None):
ToStderr("Please give at least one of the parameters.")
return 1
if not opts.lvm_storage and opts.vg_name:
ToStdout("Options --no-lvm-storage and --vg-name conflict.")
return 1
+ elif not opts.lvm_storage:
+ vg_name = ''
hvlist = opts.enabled_hypervisors
if hvlist is not None:
beparams = opts.beparams
utils.ForceDictType(beparams, constants.BES_PARAMETER_TYPES)
- op = opcodes.OpSetClusterParams(vg_name=opts.vg_name,
+ nicparams = opts.nicparams
+ utils.ForceDictType(nicparams, constants.NICS_PARAMETER_TYPES)
+
+ op = opcodes.OpSetClusterParams(vg_name=vg_name,
enabled_hypervisors=hvlist,
hvparams=hvparams,
beparams=beparams,
+ nicparams=nicparams,
candidate_pool_size=opts.candidate_pool_size)
SubmitOpCode(op)
return 0
else:
val = "unset"
ToStdout("The drain flag is %s" % val)
+ else:
+ raise errors.OpPrereqError("Command '%s' is not valid." % command)
+
return 0
# this is an option common to more than one command, so we declare
" (cluster-wide) for disk allocation [xenvg]",
metavar="VG",
default=None,),
- make_option("-b", "--bridge", dest="def_bridge",
- help="Specify the default bridge name (cluster-wide)"
- " to connect the instances to [%s]" %
- constants.DEFAULT_BRIDGE,
- metavar="BRIDGE",
- default=constants.DEFAULT_BRIDGE,),
make_option("--master-netdev", dest="master_netdev",
help="Specify the node interface (cluster-wide)"
" on which the master IP address will be added "
help="No support for lvm based instances"
" (cluster-wide)",
action="store_false", default=True,),
+ make_option("--no-etc-hosts", dest="modify_etc_hosts",
+ help="Don't modify /etc/hosts"
+ " (cluster-wide)",
+ action="store_false", default=True,),
make_option("--enabled-hypervisors", dest="enabled_hypervisors",
help="Comma-separated list of hypervisors",
type="string", default=None),
keyval_option("-B", "--backend-parameters", dest="beparams",
type="keyval", default={},
help="Backend parameters"),
+ keyval_option("-N", "--nic-parameters", dest="nicparams",
+ type="keyval", default={},
+ help="NIC parameters"),
make_option("-C", "--candidate-pool-size",
default=constants.MASTER_POOL_SIZE_DEFAULT,
help="Set the candidate pool size",
"", "Does a check on the cluster configuration"),
'verify-disks': (VerifyDisks, ARGS_NONE, [DEBUG_OPT],
"", "Does a check on the cluster disk status"),
- 'masterfailover': (MasterFailover, ARGS_NONE, [DEBUG_OPT],
+ 'masterfailover': (MasterFailover, ARGS_NONE, [DEBUG_OPT,
+ make_option("--no-voting", dest="no_voting",
+ help="Skip node agreement check (dangerous)",
+ action="store_true",
+ default=False,),
+ ],
"", "Makes the current node the master"),
'version': (ShowClusterVersion, ARGS_NONE, [DEBUG_OPT],
"", "Shows the cluster version"),
keyval_option("-B", "--backend-parameters", dest="beparams",
type="keyval", default={},
help="Backend parameters"),
+ keyval_option("-N", "--nic-parameters", dest="nicparams",
+ type="keyval", default={},
+ help="NIC parameters"),
make_option("-C", "--candidate-pool-size", default=None,
help="Set the candidate pool size",
dest="candidate_pool_size", type="int"),
projects / ganeti-local / blobdiff