Convert manual shell tests to shelltestrunner
authorIustin Pop <iustin@google.com>
Wed, 21 Mar 2012 01:06:29 +0000 (01:06 +0000)
committerIustin Pop <iustin@google.com>
Thu, 22 Mar 2012 14:01:09 +0000 (14:01 +0000)
commit53d4cdf1cd9eb7037f98a608b8c15436f1ad26d4
tree686422bf17be035a9bfe2b9447575650a5c440e0
parentb714ff89872bbeb08f2a0a2e0a324685534435b9
Convert manual shell tests to shelltestrunner

This is more of a RFC… Basically most of the shell-based tests are
converted from exec+grep to shelltestrunner.

Things are not all fine and nice though:

- we have dependencies between tests, as some generate some data files
  needed later; this is not nice, and we depend on serial execution in
  testrunner
- we can still fail with no so nice messages in the offline-test
  script (when we generate most of the data)

But overall, I think the tests are much nicer to
define/read/debug:

- each test is standalone, with the only dependency being an optional
  input data file; this is much better than a single monolithic shell
  script
- in case of failures, the failure is clearly shown by shell test,
  both for exit code and stdout/stderr
- shelltest can run in --debug mode, where the exact details are shown
  much better than the alternative of "set -x" for the shell script

Comments welcome!

Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
14 files changed:
Makefile.am
htools/offline-test.sh
test/htools-balancing.test [new file with mode: 0644]
test/htools-basic.test [new file with mode: 0644]
test/htools-dynutil.test [new file with mode: 0644]
test/htools-excl.test [new file with mode: 0644]
test/htools-hail.test [new file with mode: 0644]
test/htools-hspace.test [new file with mode: 0644]
test/htools-invalid.test [new file with mode: 0644]
test/htools-multi-group.test [new file with mode: 0644]
test/htools-no-backend.test [new file with mode: 0644]
test/htools-rapi.test [new file with mode: 0644]
test/htools-single-group.test [new file with mode: 0644]
test/htools-text-backend.test [new file with mode: 0644]