Fix locking issues in LUClusterVerifyGroup
authorMichael Hanselmann <hansmi@google.com>
Tue, 7 Jun 2011 06:48:55 +0000 (08:48 +0200)
committerMichael Hanselmann <hansmi@google.com>
Wed, 8 Jun 2011 05:44:34 +0000 (07:44 +0200)
commitfceb01fe82785d08a634e75d4251403002ef8a04
treec34dc451792cc080d96ba74d845b053d359a9971
parentc5312a10fae803c1b5fba0cbe9494776ce800fef
Fix locking issues in LUClusterVerifyGroup

- Use functions in ConfigWriter instead of custom loops
- Calculate nodes only once instances locks are acquired, removes one
  potential race condition
- Don't retrieve lists of all node/instance information without locks
- Additionally move the end of the node time check window after the
  first RPC call--the second call isn't involved in checking the
  node time at all

Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: RenĂ© Nussbaumer <rn@google.com>
lib/cmdlib.py