Iustin Pop [Tue, 13 Jan 2009 14:14:18 +0000 (14:14 +0000)]
burnin: redo the output formatting
Since we added many more tests in burnin, the output became almost
unreadable. This patch changes the output to an indented one, so that
the different phases and operations of burnin are more easily
understood.
Reviwed-by: ultrotter
Iustin Pop [Tue, 13 Jan 2009 13:25:58 +0000 (13:25 +0000)]
burnin: move start_stop at the end
Traditionally the start/stop test was the last, so move it back to there
(added as last option in commit 854).
Reviewed-by: amishchenko
Iustin Pop [Tue, 13 Jan 2009 13:25:48 +0000 (13:25 +0000)]
QA: add burnin parameters (parallel, http-check)
This patch adds burnin parameters for --parallel and --http-check
options to the burnin script.
Reviewed-by: ultrotter
Iustin Pop [Tue, 13 Jan 2009 13:16:41 +0000 (13:16 +0000)]
Increase resync speed to 60MB/s
This is a forward-port of commit 2219 on the 1.2 branch.
Reviewed-by: ultrotter
Iustin Pop [Tue, 13 Jan 2009 13:03:44 +0000 (13:03 +0000)]
burnin: introduce instance alive checks
This patch adds instance alive checks after most start operations. The
check is done in a custom way:
- the instance is expected to have an http server up and running
- and it should server the '/hostname.txt' resource containing the
hostname of the instance
This allows checking that:
- creation is working OK
- start after failover (and in the future migrate) is ok
- rename works correctly
By default, the check is disabled since one needs a custom OS for this
check.
The patch also fixes a wrong variable name from a previous burnin patch.
Reviewed-by: ultrotter
Iustin Pop [Tue, 13 Jan 2009 08:04:40 +0000 (08:04 +0000)]
Small typo in ganeti-watcher
Reviewed-by: imsnah
Iustin Pop [Mon, 12 Jan 2009 16:06:14 +0000 (16:06 +0000)]
Skip offline nodes in gnt-cluster commands
This patch makes gnt-cluster copyfile and command skip the offline
nodes.
Reviwed-by: ultrotter, imsnah
Iustin Pop [Mon, 12 Jan 2009 13:25:27 +0000 (13:25 +0000)]
burnin: Add tests for add/remove disks and NICs
This patch adds testing of add/remove disks and NICs to the burnin.
Reviewed-by: imsnah
Iustin Pop [Mon, 12 Jan 2009 12:42:22 +0000 (12:42 +0000)]
Heavy redo of gnt-instance info output
In 2.0, we have more parameters in drbd's logical_id, and passing the
results over json makes them unicode which looks worse with the default
formatting. As such, a redo of the output is needed.
This patch:
- adds a separate function to format the logical_id of devices
- moves the actual indentation format out of _FormatBlockDevInfo,
which now just generates a list of items
- adds a function _FormatList that recursively formats the list
- formats specially key,value tuples
The result is that the output is nicer, and the code in
_FormatBlockDevInfo somewhat cleaner (as it doesn't deal with spacing
and such issues).
Reviewed-by: ultrotter
Iustin Pop [Mon, 12 Jan 2009 12:42:13 +0000 (12:42 +0000)]
Fix some errors in instance modify --disk remove
The RpcResult introduction still left some bugs (after multiple patches):
- we don't correctly check the result type
- rename a variable to prevent a conflict
Reviewed-by: imsnah
Iustin Pop [Mon, 12 Jan 2009 10:27:02 +0000 (10:27 +0000)]
Fix an error handling case in instance info
The checking for invalid instance names in LUQueryInstanceData is broken
since commit 1642.
Reviewed-by: imsnah
Iustin Pop [Mon, 12 Jan 2009 09:14:50 +0000 (09:14 +0000)]
Introduce a very simple LU to force config updates
This LU can be used to force a push of the config in case it's needed,
for example after an upgrade to update the ssconf_release_version file.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 16:24:05 +0000 (16:24 +0000)]
Add a new ssconf file with the ganeti version
The patch adds a new ssconf file containing the ganeti version.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 15:34:25 +0000 (15:34 +0000)]
Work around a DRBD sync speed race condition
This is modified forward-port of commit 1544 on the 1.2 branch:
When DRBD is doing its dance to establish a connection with its
peer, it also sends the synchronization speed over the wire. In
some cases setting the sync speed only after setting up both
sides can race with DRBD connecting, hence we set it here before
telling DRBD anything about its peer.
Reviewed-by: iustinp
The modification we make is that we split SetSyncSpeed in two so that we
don't need to modify our minor temporarily, and the fact that we call
this function from within _AssembleNet (right before enabling network),
instead of Assemble()/Attach().
Original-Author: imsnah
Iustin Pop [Fri, 9 Jan 2009 14:58:29 +0000 (14:58 +0000)]
burnin: Add activate/deactivate disks
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 14:58:19 +0000 (14:58 +0000)]
burnin: use the new replace_disks constants
This patch updates burnin to the latest replace disks constant, and
changes the constants' values to be more accurate.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 14:26:53 +0000 (14:26 +0000)]
burnin: do not use offline nodes
This patch makes burnin skip the offline nodes in it's builtin node
selection. It also removes an extra line.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 14:26:37 +0000 (14:26 +0000)]
Fix gnt-os for offline nodes
We shouldn't query offline nodes in gnt-os. This patch adds an utility
function to ConfigWriter that returns the names of online nodes and uses
it in LUDiagnoseOS to query only the good nodes.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 12:52:28 +0000 (12:52 +0000)]
Silence warning on node list for offline nodes
The warning in node list is meant for nodes that return wrong
information, but for offline nodes this case is normal.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 12:52:17 +0000 (12:52 +0000)]
Rework the daemonization sequence
The current fork+close fds sequence has deficiencies which are hard to
work around:
- logging can start logging before we fork (e.g. if we need to emit
messages related to master checking), and thus use FDs which we
can't track nicely
- the queue locks the queue file, and again this fd needs to be kept
open which is hard from the main loop (and this error is currently
hidden by the fact that we don't log it)
Given the above, it's much simpler, in case we will fork later, to close
file descriptors right at the beginning of the program, and in Daemonize
only close/reopen the stdin/out/err fds.
In addition, we also close() the handlers we remove in SetupLogging so
that the cleanup is more thorough.
Reviewed-by: imsnah
Iustin Pop [Fri, 9 Jan 2009 12:22:51 +0000 (12:22 +0000)]
Cleanup replace-disks modes and options
In 1.2, due to the md+drbd7 legacy, we had a complex choice of replace
modes, and the new drbd8 modes where forced into this syntax, with some
complicated rules of transition from one mode to another (if REPLACE_ALL
but not new node passed, switch to REPLACE_SEC, etc.).
This patch cleans this situation by making a clear separation between
the two main modes:
- replace on current nodes (with the two sub-cases on primary and on
secondary)
- change to a new node (either via manually specified node or via
iallocator)
Reviewed-by: imsnah
Iustin Pop [Thu, 8 Jan 2009 16:39:47 +0000 (16:39 +0000)]
Fix cluster verify/node net test for offline nodes
For offline nodes, we shouldn't add them to the NV_NODELIST and
NV_NODENETTEST tests since they most likely won't succeed.
The patch makes gnt-cluster verify happy again in such cases.
Reviewed-by: imsnah
Iustin Pop [Thu, 8 Jan 2009 16:05:30 +0000 (16:05 +0000)]
rpc: Add a method for easy check of remote results
The patch adds a new method to the rpc.RpcResult class called
"RemoteFailMsg" which is useful for the RPC calls which return a
(status, payload) style result.
Reviewed-by: imsnah
Iustin Pop [Thu, 8 Jan 2009 14:16:44 +0000 (14:16 +0000)]
Add an instance_migratable rpc call
This is a forward-port of commit 1194 on the 1.2 branch:
This call will check whether an instance is up on its primary, and that
it has been started with symlinks. We currently have no on-secondary
checks, nor any hypervisor specific call.
Reviewed-by: iustinp
The difference from the original patch is that we don't include the
cmdlib changes, since those will come as a copy from the 1.2 cmdlib.py,
and not as individual patches.
Original-Author: ultrotter
Iustin Pop [Thu, 8 Jan 2009 12:03:31 +0000 (12:03 +0000)]
bdev: forward-port ReAttachNet/DisconnectNet
This is plain copy of the 1.2 ReAttachNet and DisconnectNet methods on
the DRBD8 device, with the logger to logging module changes and the
ReAttachNet method renamed to AttachNet.
These methods are not used anywhere right now, but will be used for
migration and a simpler disk-replace.
The code was originally committed on the 1.2 branch as revision numbers
1165 and 1204.
Originally-Reviewed-by: imsnah, ultrotter
Iustin Pop [Wed, 7 Jan 2009 17:02:37 +0000 (17:02 +0000)]
backend: Remove symlinks by disk name
This is a modified forward-port of commit 1184 on the 1.2 branch:
backend: Remove symlinks by disk name, not using a wildcard
Reviewed-by: ultrotter
The changes to the original patch are related to the docstring style and
iv_name to index switch.
Original-Author: imsnah
Iustin Pop [Wed, 7 Jan 2009 17:02:26 +0000 (17:02 +0000)]
Pass instance name to rpc call blockdev_close
This is an extract of commit 1166 on the 1.2 branch (Add a rpc call for
drbd network reconfiguration), but only the blockdev_close part.
The patch changes the blockdev_close call to take the instance so that
it can remove the symlinks of the instance.
Originally-Reviewed-by: imsnah
Iustin Pop [Wed, 7 Jan 2009 17:02:12 +0000 (17:02 +0000)]
Fix the _RemoveBlockDevLinks() function
This is a forward-port of commit 1163 on the 1.2 branch:
This fixes the removal of the instance symlinks (probably breakage from
the glob changes).
Reviewed-by: imsnah
Iustin Pop [Wed, 7 Jan 2009 17:01:58 +0000 (17:01 +0000)]
Remove instance's symlinks
This is a forward-port of commits 1150 and 1151 on the 1.2 branch:
Add _RemoveBlockDevLinks auxiliary function, called when an instance
fails to start and when it is shut down.
Reviewed-by: iustinp
and:
Fix cut&paste error when removing symlinks
It's just whitespace... isn't it? uhm... :) Anyway, fixing an error made
when reformatting the code for the new "safer" behaviour.
Reviewed-by: iustinp
Original-Author: ultrotter
Iustin Pop [Wed, 7 Jan 2009 17:01:46 +0000 (17:01 +0000)]
Catch BlockDeviceError when starting instance
This is a forward-port of commit 1149 on the 1.2 branch:
_GatherAndLinkBlockDevs used to raise the errors.BlockDeviceError
exception when it failed to create a block device, and with this patch
set it does so also when it fails to create a symlink to it.
With this patch we move the call to this function into a pre-existing
try-except block in the code, and catch the BlockDeviceError exception,
logging a message and returning a failure state if it happens.
Reviewed-by: iustinp
The changes are related to the new hypervisor and logging syntax.
Original-Author: ultrotter
Iustin Pop [Wed, 7 Jan 2009 17:01:36 +0000 (17:01 +0000)]
Create symlinks to intances' block devices
This is a forward-port of commit 1148 on the 1.2 branch:
Change the _GatherBlockDevs private function, called only one time by
StartInstance, to _GatherAndLinkBlockDevs, and make it transform the
device returned even more by calling the new _SimlinkBlockDev auxiliary
function.
This makes sure that every time an instance is started symlinks to its
block devices are created, and the instance is started off them, rather
than the underlying block devices.
Reviewed-by: iustinp
The changes we make to the patch is related to newer function signatures
in 2.0, and to the fact that iv_name is deprecated and we use instead
disk%d based on the disk index.
Original-Author: ultrotter
Iustin Pop [Wed, 7 Jan 2009 17:01:25 +0000 (17:01 +0000)]
Simplify hypervisor block_devices structure
This is a partial forward-port of commit 1136 on the 1.2 branch:
The hypervisor doesn't need to be passed the whole block device
structure, so we'll just give it the block device name on the local
node, and the name as seen by the instance. This will make it easier to
manipulate it later without messing with the block devices (eg. by
changing the system name to a symlink to the name itself).
Since the HVM hypervisor changes the "virtual" name a note is added
calling for a redesign that doesn't need this change, as different
hypervisors and emulation types will anyway have different names for
exported devices.
Reviewed-by: iustinp
The changes in this patch compared to the original are:
- we keep passing the original disk object, not for its iv_name, but
for it's physical_id which is needed by the file driver (this could
be fixed maybe)
- we don't use the iv_name anymore, since in 2.0 we already use the
index of the device
Original-Author: ultrotter
Iustin Pop [Wed, 7 Jan 2009 14:38:29 +0000 (14:38 +0000)]
_AssembleInstanceDisks: fix rpcresult handling
Commit 2117 changed _AssembleInstanceDisks to correctly parse the
failure status of the new RpcResult structure, but it didn't fix the
storing of only the result payload. Since RpcResult is not JSON
serializable, LUActivateInstanceDisks is failing.
Reviewed-by: ultrotter
Iustin Pop [Tue, 6 Jan 2009 09:57:53 +0000 (09:57 +0000)]
Fix some pylint-detected issues
Two bad indentation cases and a missing variable.
Reviewed-by: imsnah
Michael Hanselmann [Fri, 19 Dec 2008 19:31:17 +0000 (19:31 +0000)]
ganeti.bootstrap: Set permissions on newly uploaded files
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 19:31:04 +0000 (19:31 +0000)]
ganeti.cmdlib: Check remote API certificate on "gnt-cluster verify"
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 19:30:46 +0000 (19:30 +0000)]
ganeti.bootstrap: Upload remote API certificate to new nodes
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 19:30:31 +0000 (19:30 +0000)]
ganeti.bootstrap: Prepare for remote API certificate
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 19:30:17 +0000 (19:30 +0000)]
ganeti.bootstrap: Write SSL key to temporary file and set permissions
Previously, we set the permissions only after writing the key. This
gave other users on the system a small window during which they could
read the key.
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 19:30:05 +0000 (19:30 +0000)]
ganeti.bootstrap: Generate SSL certificate for remote API
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 19:29:50 +0000 (19:29 +0000)]
ganeti.bootstrap: Move SSL certificate generation into separate function
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 12:58:27 +0000 (12:58 +0000)]
ganeti-rapi: Implement HTTP authentication
Passwords are stored in "$localstatedir/lib/ganeti/rapi_users". User
options specify the access permissions of a user (see docstring for
ganeti.http.ReadPasswordFile), for which only "write" is supported
to grant write access. Every other user has read-only access.
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 12:58:10 +0000 (12:58 +0000)]
ganeti-rapi: Introduce per-request context
This will be used to evaluate access permissions to resources.
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 12:57:58 +0000 (12:57 +0000)]
ganeti.http: Function to read password file
Lines in the password file are of the following format:
<username> <password> [options]
Fields are separated by whitespace. Username and password are
mandatory, options are optional and separated by comma (",").
Empty lines and comments ("#") are ignored.
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 12:57:38 +0000 (12:57 +0000)]
ganeti.http: Add support for private data in HTTP requests
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 12:57:22 +0000 (12:57 +0000)]
ganeti.http: Add support for basic HTTP authentication
As per RFC2617.
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 19 Dec 2008 12:57:07 +0000 (12:57 +0000)]
ganeti.http: Prepare authentication for HTTP server
The authentication class will override PreHandleRequest.
Reviewed-by: amishchenko
Michael Hanselmann [Thu, 18 Dec 2008 16:39:04 +0000 (16:39 +0000)]
Job queue: Allow more than one file rename per RPC call
Reviewed-by: ultrotter
Michael Hanselmann [Thu, 18 Dec 2008 16:38:47 +0000 (16:38 +0000)]
ganeti.jqueue: Group job archivals to reduce number of RPC calls
Reducing the actual number of RPC calls will come in another patch.
Reviewed-by: ultrotter
Michael Hanselmann [Thu, 18 Dec 2008 16:38:32 +0000 (16:38 +0000)]
Prevent RPC timeout on auto-archiving jobs
With a large job queue, auto-archiving jobs can take a very long time,
causing timeouts on the luxi RPC layer. With this change, auto-
archive returns after half of the RPC timeout has passed. The user
will see how many jobs are left unchecked.
Reviewed-by: ultrotter
Michael Hanselmann [Thu, 18 Dec 2008 16:38:09 +0000 (16:38 +0000)]
jqueue: When auto-archiving jobs, calculate job status only once
This is done by passing the job object to _ArchiveJobUnlocked instead
of only the job ID. Also return whether job was actually archived.
Reviewed-by: ultrotter
Michael Hanselmann [Thu, 18 Dec 2008 16:23:26 +0000 (16:23 +0000)]
Use subdirectories for job queue archive
As it turned out, having many files in a single directory can be
very painful. With this patch, only 10'000 files are stored in a
directory for the job queue archive. With 10'000 directries, this
allows for up to 100 million jobs be archived without having large
numbers of files in a single directories. Not that it is realistic,
anyway.
Reviewed-by: ultrotter
Michael Hanselmann [Thu, 18 Dec 2008 16:23:05 +0000 (16:23 +0000)]
Add rename function automatically creating directories if needed
Unfortunately, os.makedirs in Python 2.4 is not safe against multiple
processes creating the same directory tree at the same time. This is
only fixed in Python 2.5 and up. Adding more checks in our code doesn't
make it any better.
Reviewed-by: iustinp
Michael Hanselmann [Thu, 18 Dec 2008 16:21:13 +0000 (16:21 +0000)]
ganeti.http: Don't pass poller object around
They're cheap to instantiate and doing this changes makes the code
a bit simpler.
Reviewed-by: ultrotter
Michael Hanselmann [Thu, 18 Dec 2008 13:45:41 +0000 (13:45 +0000)]
Rename http.HttpInternalError to HttpInternalServerError
All other exceptions are named after the error name in RFC2616 (HTTP/1.1).
Reviewed-by: amishchenko
Michael Hanselmann [Thu, 18 Dec 2008 13:45:24 +0000 (13:45 +0000)]
ganeti.http: Add more constants and errors
Reviewed-by: amishchenko
Michael Hanselmann [Thu, 18 Dec 2008 13:45:10 +0000 (13:45 +0000)]
ganeti.http: Ignore ENOTCONN when shutting down the connection
Reviewed-by: amishchenko
Michael Hanselmann [Thu, 18 Dec 2008 13:44:53 +0000 (13:44 +0000)]
Implement support for additional headers with HTTP errors
Reviewed-by: amishchenko
Michael Hanselmann [Wed, 17 Dec 2008 14:30:58 +0000 (14:30 +0000)]
Add simple unittests for ganeti.http
More complex unittests will need some refactoring in the HTTP code.
Reviewed-by: amishchenko
Michael Hanselmann [Wed, 17 Dec 2008 14:09:39 +0000 (14:09 +0000)]
ganeti.bootstrap: Whitespace fix
Reviewed-by: iustinp
Michael Hanselmann [Wed, 17 Dec 2008 13:18:35 +0000 (13:18 +0000)]
Add job queue size limit
A job queue with too many jobs can increase memory usage and/or make
the master daemon slow. The current limit is just an arbitrary number.
A "soft" limit for automatic job archival is prepared.
Reviewed-by: iustinp
Michael Hanselmann [Wed, 17 Dec 2008 11:24:12 +0000 (11:24 +0000)]
utils.KillProcess: Use waitpid() to wait for child processes
Sometimes the proc filesystem doesn't reflect the current status of
a process. By calling waitpid(), we make sure to get the current
information, at least for child processes. The timeout is still
kept for child processes to make sure the proc filesystem is updated.
Reviewed-by: iustinp
Guido Trotter [Tue, 16 Dec 2008 16:24:46 +0000 (16:24 +0000)]
Release ganeti 2.0~alpha1
Reviewed-by: iustinp
Guido Trotter [Tue, 16 Dec 2008 16:24:35 +0000 (16:24 +0000)]
LUConnectConsole: fix primary_node online check
The primary node is part of the instance, not of the opcode.
Reviewed-by: iustinp
Guido Trotter [Tue, 16 Dec 2008 16:24:22 +0000 (16:24 +0000)]
_RunCmdPipe: handle EINTR in poller.poll()
poll() can be interrupted. rather than failing we retry until it
returns.
Reviewed-by: iustinp
Guido Trotter [Tue, 16 Dec 2008 16:24:08 +0000 (16:24 +0000)]
KVM: improve socat interface
Call socat with a full path specified at configure time, rather than
just by its name, and check for the binary to exist at hypervisor
verify.
Reviewed-by: iustinp
Guido Trotter [Tue, 16 Dec 2008 16:23:53 +0000 (16:23 +0000)]
KVM: use a different default kernel path
It makes sense for the default kvm kernel not to be called "xenU".
Reviewed-by: iustinp
Michael Hanselmann [Mon, 15 Dec 2008 10:06:24 +0000 (10:06 +0000)]
ganeti.http: Add three TODOs for improvements
Reviewed-by: iustinp
Michael Hanselmann [Mon, 15 Dec 2008 09:48:25 +0000 (09:48 +0000)]
ganeti.http: Explicitly initiate handshake
Otherwise it would be done on the first read/write operation, making
error handling more difficult (such as EOF during handshake).
Reviewed-by: iustinp
Michael Hanselmann [Mon, 15 Dec 2008 09:40:57 +0000 (09:40 +0000)]
ganeti.http: Implement handshake socket operation
Reviewed-by: iustinp
Michael Hanselmann [Mon, 15 Dec 2008 09:40:42 +0000 (09:40 +0000)]
ganeti.http: Handle SSL_ERROR_ZERO_RETURN
Also add a comment next to the place where the SSL connection is shut
down.
Reviewed-by: iustinp
Iustin Pop [Sun, 14 Dec 2008 12:05:30 +0000 (12:05 +0000)]
cleanup: ConfigWriter, initialize all attributes
We should initialized the _last_cluster_serial in the constructor too (just to
be consistent).
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:05:22 +0000 (12:05 +0000)]
cleanup: rapi v2 instance tags wrong attribute
This was changed in the past, but it seems this class was forgotten.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:05:12 +0000 (12:05 +0000)]
cleanup: http server, line too long
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:05:03 +0000 (12:05 +0000)]
cleanup: http client, line too long
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:54 +0000 (12:04 +0000)]
cleanup: xen hypervisor
Wrong indentation and uniformize one method signature.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:45 +0000 (12:04 +0000)]
cleanup: kvm code likes to redefine names
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:36 +0000 (12:04 +0000)]
lib/ssh.py: import the logging module
This only means most of our error paths in this module were not working
(and generating exceptions).
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:29 +0000 (12:04 +0000)]
SshRunner: add docstring for _BuildSshOptions
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:20 +0000 (12:04 +0000)]
Improve _autoconf.py comments
This adds a docstring to the _autoconf.py file detailing how it's
generated (the other comment it's not visible in pydoc/epydoc).
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:13 +0000 (12:04 +0000)]
cleanup: use _ for unused loop counter
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:04:05 +0000 (12:04 +0000)]
cleanup: WorkerPool, wrong variable name
Quoting Michael: "why is this even working?"
Reviewed-by: imsnah,amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:56 +0000 (12:03 +0000)]
cleanup: TcpPing, wrong variable name
The default value of 'False' wasn't initialized properly. It doesn't
require initialization, but it's cleaner this way.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:47 +0000 (12:03 +0000)]
cleanup: SetEtcHostsEntry unused var
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:38 +0000 (12:03 +0000)]
cleanup: fix IAllocator hypervisor usage
Two problems: the iallocator.hypervisor wasn't initialized to None in
the constructor, so pylint doesn't realize it's initialized later with
setattr.
Second, 'hypervisor' is a module, so we shouldn't use it as a variable.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:30 +0000 (12:03 +0000)]
cleanup: LUReplaceDisks unused vars
And a small whitespace fix.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:20 +0000 (12:03 +0000)]
cleanup: do not hide upper-scope name
hypervisor is a module, so we shouldn't use it as an argument.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:11 +0000 (12:03 +0000)]
cleanup: fix use of _CheckNodeOnline
A few cases of wrong variable name.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:03:03 +0000 (12:03 +0000)]
cleanup: LUAddNode, LUSetNodeParams unused variable
This is a leftover from the abstraction of AdjustCandidatePool, and it
also requires the config lock, so it's better to remove it.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:53 +0000 (12:02 +0000)]
cleanup: LURenameCluster wrong variable name
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:45 +0000 (12:02 +0000)]
cleanup: fix export NIC count the same way as disk
For safety, we use the same algorithm as in disk count.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:36 +0000 (12:02 +0000)]
cleanup: fix backend._RecursiveFindBD
_RecursiveFindBD takes a parameter that isn't used; moreover, nowhere in
the SVN history can I find a case that it has been used.
As such, remove this parameter and fix its callers.
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:27 +0000 (12:02 +0000)]
cleanup: more unused vars
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:18 +0000 (12:02 +0000)]
cleanup: sanitize a default parameter
Instead of relying that the usage of the parameter is ok with mutable
default parameters, let's just make it safer..
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:09 +0000 (12:02 +0000)]
cleanup: exceptions should derive from Exception
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:02:01 +0000 (12:02 +0000)]
cleanup: fix GatherMasterVotes
Remove unused vars
Reviewed-by: amishchenko
Iustin Pop [Sun, 14 Dec 2008 12:01:52 +0000 (12:01 +0000)]
cleanup: _InitSSHSetup doesn't need its argument
Reviewed-by: imsnah
Iustin Pop [Sun, 14 Dec 2008 12:01:41 +0000 (12:01 +0000)]
cleanup: fix 'variable unused' warning
In the iteration we don't care about the node names, so we change the
for loop to be over the values (and not itervalues).
Reviewed-by: amishchenko
Michael Hanselmann [Fri, 12 Dec 2008 16:50:41 +0000 (16:50 +0000)]
ganeti.http: Rename HttpBase._using_ssl to HttpBase.using_ssl
It'll be queried from other classes.
Reviewed-by: iustinp
Michael Hanselmann [Fri, 12 Dec 2008 16:50:27 +0000 (16:50 +0000)]
ganeti.http: Rename HttpSocketBase to HttpBase
It's more appropriate.
Reviewed-by: iustinp