Activity
From 10/18/2007 to 11/16/2007
11/16/2007
- 08:36 pm Revision 6852c52f: Fix a typo in a warning message
- Reviewed-by: schreiberal
- 04:28 pm Revision 6510a58a: Don't remove master's hostname from /etc/hosts on cluster destroy.
- This fixes issue #13.
Reviewed-by: schreiberal - 04:28 pm Revision dfea906f: Use spaces to indent and fix typo in tag.
- Reviewed-by: schreiberal
- 02:43 pm Revision f89f17a8: Fix typo in function name.
- Reviewed-by: schreiberal
11/15/2007
- 08:08 am Revision 1df40cb5: Suggest disabling of automatic xen domain save
- By default xen tries to save running virtual machines at system shutdown and
restore them at reboot. Make sure we sug... - 08:04 am Revision 7ec54942: Complete the apt-get list in the install manual
- The install manual was missing python-pyparsing and python-simplejson from the
apt-get install list. Adding them.
Th...
11/14/2007
- 11:52 pm Revision 20a0c9ef: When an assembly error occurs log it too
- Right now an assembly error produces an exception but not a log message. This
is bad because the exception suggests l... - 05:56 pm Revision ebe8ef17: Use setUp/tearDown for tests using temporary files.
- Reviewed-by: schreiberal
- 05:55 pm Revision 667479d5: Wrap line longer than 80 characters.
- Reviewed-by: ultrotter
- 05:55 pm Revision f0990e0c: Compare file contents directly in unittests.
- Reviewed-by: schreiberal, ultrotter
- 04:05 pm Revision fcb1f331: Give more details on errors when trying to run “lvdisplay”.
- Reviewed-by: schreiberal
- 04:05 pm Revision 2fa9f1dd: Create /var/run/ganeti directory on “make install”.
- Reviewed-by: schreiberal
- 01:03 am Revision 34bf35c0: Bump version numbers.
- Reviewed-by: iustinp
11/13/2007
- 09:31 pm Revision 28a6fbc8: Run ganeti-watcher script from QA code instead of cron.
- This makes the tests much more reliably because it avoids race conditions.
It also helps to speed them up a lot.
Rev... - 09:31 pm Revision 7b195d9b: Small changes and fixes in ganeti-watcher.
- - Use constants for keys.
- Fix bug through which automatic instance restarts wouldn't be limited
Reviewed-by: iustinp - 09:30 pm Revision 6623a5c1: Fix call to TestInstanceConsecutiveFailures.
- Reviewed-by: iustinp
- 05:39 pm Revision 9cd372ad: Fix unittests broken by revision 360.
- Reviewed-by: schreiberal
- 05:04 pm Revision 1e020d1b: Fix --node option for “gnt-backup list”.
- Reviewed-by: iustinp
- 01:11 am Revision 7803d4d3: Fix a wrong comparison in _RecursiveAssembleBD
- We want to prevent sending too many 'None' children to a device.
However, the test as it is today is wrong, as we wan... - 01:11 am Revision 7e3dbb94: Fix another breakage in SetEtcHostsEntry
- The code assumes all lines have at least two elements which are
whitespace separated - i.e. it does not deal with emp...
11/12/2007
- 07:10 pm Revision 2e3e75b7: Call fsync() after modifying /etc/hosts.
- This is a critical file. Breaking it would be very bad. Thus, if the system
crashes before the data is synched to the... - 07:09 pm Revision 9440aeab: Fix functions for /etc/hosts.
- - Combine hostname and aliases on one line
- Fix bug with wrongfully removed newline characters
- Use wrapper for Set... - 07:03 pm Revision 424908c1: Rollback commit 356.
- 06:44 pm Revision 2d6cfa31: Add functions for known_hosts files.
- Reviewed-by: TODO
- 12:57 pm Revision 3e1cdf9f: Add missing descriptions to {Add,Remove}EtcHostsEntry.
- Reviewed-by: schreiberal
- 05:56 am Revision 7df43a76: Relax replace_disks_all meaning for drbd8
- In order to make the replace secondary action to be done via the same
opcode parameters for both remote_raid1 and drb... - 05:36 am Revision 59885275: Change --nodes to --node
- The --nodes option in gnt-backup really accepts only one node at a time.
Change it to --node, for added clarity and c... - 03:19 am Revision 6c4811dc: Update documentation for drbd8 and beta2 release
- This patch does:
- add drbd8 information to the docs (the new disk template, examples,
etc.)
- fixes a sectio...
11/10/2007
- 08:05 pm Revision 0b0dea6a: Fix gnt-instance man page for replace-disks
- This patch documents the new syntax for disk changes with the drbd disk
template.
Reviewed-by: ultrotter - 07:54 pm Revision f69dab6d: Improve the man pages
- This patch does some small fixes to the man pages and adds descriptions
for a few missing options.
Reviewed-by: ultr...
11/09/2007
- 10:13 pm Revision 2395c322: Soften the requirements for hooks execution
- Currently, an unreachable node (or one that return undetermined failure)
in the hooks pre-phase will abort the curren... - 04:54 pm Revision c8a0948f: Use new functions to modify /etc/hosts.
- Reviewed-by: schreiberal
- 04:53 pm Revision 899d2a81: Add functions to modify /etc/hosts.
- Reviewed-by: schreiberal
- 04:52 pm Revision 59f82e3f: Cleanup temporary file in RemoveAuthorizedKey.
- Reviewed-by: schreiberal
- 03:03 pm Revision 084bf7b2: Fix usage of wrong variable in doc/examples/Makefile.am.
- This makes “make distcheck” work again.
Reviewed-by: schreiberal
11/08/2007
- 09:04 pm Revision 21546b1c: Simplify burnin output
- Currently, the burnin output is very verbose (we log the entire output
from LU feedback) and duplicate in some cases ... - 09:04 pm Revision 5bfac263: Changes related to logging
- This patch modifes:
- mcpu.Processor.LogWarning to have its 'hint' parameter as optional
and only log it if not... - 09:02 pm Revision 175f44c2: Refactor burnin to improve disk replacement
- This patch changes the burnin:
- split the code into functions
- add replace2 (replace the secondary) for remote_... - 01:51 pm Revision e42b5307: Insert hook calls.
- Reviewed-by: schreiberal
- 01:51 pm Revision 663ed0ce: Implement sample hook.
- Reviewed-by: schreiberal
- 01:50 pm Revision 1672a0d1: Implement hooks infrastructure.
- Reviewed-by: schreiberal
11/07/2007
- 05:53 pm Revision 0834c866: Enhance secondary node replace for drbd8
- This (big) patch does two things:
- add "local disk status" to the block device checks
(BlockDevice.GetSyncStat... - 04:33 pm Revision e3c826ec: Indentation fixes for docs.
- Reviewed-by: schreiberal
- 02:39 pm Revision 4677a909: Update docs for the removed --secondary-node option.
- Reviewed-by: ultrotter
- 01:48 pm Revision 7dd30006: Check whether init.d script is executable.
- Reviewed-by: schreiberal
11/06/2007
- 07:04 pm Revision 113b8d89: Adapt QA tests for removed --secondary-node option.
- 07:04 pm Revision 60d49723: Remove --secondary-node option.
- Replace --secondary-node option with an optional parameter for --node.
- 07:01 pm Revision cff90b79: Enhance DBRD8 disk replacement (same nodes)
- This patch adds enhanced reporting and much more checks to the disk
replacement (when not switching the secondary).
... - 07:01 pm Revision 9db6dbce: Implement degraded status for logical volumes
- Logical volumes can be 'degraded' in a similar way to mirrored devices,
when their underlying storage has gone away (... - 07:01 pm Revision 0fbbf897: Add better error logging functions for LUs
- Currently, some LUs use logger.Error, others just feedback_fn, etc. This
patch adds three functions to mcpu.Processor... - 07:01 pm Revision 03ece5f3: Enhance mirror operations for DRBD8
- Currently, the mirror operations (add and remove children) test against
the instance's attributes. This patch changes... - 07:00 pm Revision fc1dc9d7: Allow DRBD8 operation without backing storage
- This patch adds the following functionality:
- DRBD8 devices can assemble without local storage (done by allowing
... - 07:00 pm Revision 583e3f6f: Make DRBD8 disks show 'degraded' status if diskless
- This patch enables the bdev.DRBD8 class report a degraded status if the
local disk is missing. This allows `gnt-insta... - 07:00 pm Revision e739bd57: Change the way remove children is called in bdev
- For some cases, we don't have to have access to the children of a device
in order to remove them (e.g. md over lvs, o... - 06:55 pm Revision 222f2dd5: Add a support function to objects.Disk
- This patch adds a function returning the device path if it is computable
from the disk object (and we don't need to i...
11/05/2007
- 11:22 pm Revision e2e521d0: Small cleanup for error formatting
- Reviewed-by: ultrotter
- 07:59 pm Revision c7b46d59: Handle missing init script at cluster init
- This patch adds a check in the prereq of LUInitCluster for the existence
of the init script. This allows a clean abo... - 05:08 pm Revision cf5a8306: Fix a unhandled error case in device creation
- The block device creation process is the following:
- device create
- device assembly (on primary or depending on... - 05:06 pm Revision 65fe4693: Miscellaneous style fixes
- This patch fixes some minor pylint warnings (unused variables, wrong
indentation, etc.) and a real bug in the recover... - 02:19 pm Revision d74c2ca1: Test tag functionality.
- Reviewed-by: schreiberal
- 02:18 pm Revision 62843684: Merge three small cluster tests into one.
- Reviewed-by: schreiberal
- 02:14 pm Revision 24818e8f: Rename utils.GetUUID to utils.NewUUID.
- Reviewed-by: schreiberal
- 02:44 am Revision 8ee53a06: Bump protocol version up
- The OS cleanup patches change the wire protocol. Increment the protocol number
by one.
Reviewed-By: iustinp - 02:43 am Revision dfa96ded: Convert os_get to use OS rather than InvalidOS
- In order to do this for simplicity we leave the OSFromDisk function as-is and
we convert the eventual exception to an... - 02:43 am Revision 4e679f11: Simplify diagnose mangling/unmangling functions
- The functions in ganeti-noded and rpc.py still deal with the fact that an
InvalidOS error could be returned by Diagno... - 02:43 am Revision 8fa42c7c: Make DiagnoseOS use the modified OS objects
- Modify backend.py so that DiagnoseOS only returns OS objects rather than
InvalidOS errors, and make sure gnt-os under... - 02:42 am Revision d2c807e4: Create OS from an InvalidOS error
- Add a new FromInvalidOS static function to objects.OS that makes it easy to
create an object representing a broken OS... - 02:42 am Revision 37482e7b: Make the OS object able to represent broken OSes
- Till now the OS object just represents a correct OS instance. Change it so it
can represent a broken one too, by add... - 01:26 am Revision 519bfbae: Add option to burnin only a given set of nodes
- This patch adds a '-n' option to burnin that takes a comma-separated
list of nodes to perform the burnin on.
Reviewe...
11/04/2007
- 06:10 am Revision 00fe9e38: Make call_os_get a single node function
- call_os_get is never called with a real list of nodes, so there's no point in
it being multi-node. Making it single-n... - 05:37 am Revision 74b4217d: Fix two typos in a doc string
- Remove a wrong "i" and add a missing ")" to the DiagnoseOS function doc string.
Reviewed-By: iustinp
11/03/2007
- 08:55 am Revision 73415719: Implement tag searching
- This patch adds a search command for locating tags on all objects of the
cluster using a regex pattern.
Reviewed-by:...
11/02/2007
- 05:51 pm Revision 830da270: Test “gnt-cluster command”.
- Also check whether file contents are correct for both “gnt-cluster command” and
“gnt-cluster copyfile”.
Reviewed-by:... - 03:44 pm Revision 3f78eef2: Implement device to instance mapping cache
- Currently, troubleshooting DRBD problems involves a manual process of going
backwards from the DRBD device to the ins... - 03:43 pm Revision 79f87a76: Improve burnin with regard to drbd8
- Allow burnin to use the new drbd8 template (for which case one needs to
disable replacement of disks, burnin does yet... - 03:43 pm Revision be345db0: Update the dev_path on LVs on rename
- When renaming a logical volume, we should change the dev_path (and other
internal variables) in order to be consisten... - 03:10 am Revision 25a915d0: Revision 302 is broken, this fixes it
- I forgot a pair of parentheses in that revision which break the common
case. This patch adds them.
Reviewed-by: ultr...
11/01/2007
- 11:40 pm Revision 073ca59e: Fix printing of unconfigured DRBD devices
- If the device is unconfigured (not yet did SetDiskID for it ever), it
might have a physical_id of None. This patch fi... - 07:51 pm Revision d06565e0: Remove two trailing whitespaces
- Ok, I've been battling with those for a while but it seems
in the end I forgot to get rid of them! :( Doing it explic... - 07:48 pm Revision 2527691a: Move blank lines inside function messages
- This patch changes whitespace only. It fixes all the functions in script/gnt-os
by putting a white line at the end of... - 07:48 pm Revision dd96409a: Add empty line after each diagnose OS-Node set
- Reviewed-By: imsnah
- 07:46 pm Revision 107b0ccb: Modify the displayed format for gnt-os diagnose
- Get rid of the tabulated form and create a simplier indented structure.
Now a valid OS looks something like:
OS: foo... - 07:44 pm Revision 48f85f75: Change the way to compute the first os status message
- Use both _DiagnoseOSStatus and _DiagnoseOSPath to calculate the message
associated with the first entry found on a n... - 07:44 pm Revision 5efc50fc: Separate OS status and path
- Make _DiagnoseOSStatus only return a status message for the OS diagnose object
and create a new _DiagnoseOSPath funct... - 07:22 pm Revision 5d0fe286: Whitespace fixes
- Reviewed-by: ultrotter
- 04:31 pm Revision dfe11bad: Cleanup colouring functions.
- Make the code somewhat smaller. Disable disk failure test for master for now.
Reviewed-by: schreiberal - 03:54 pm Revision b1ffe1eb: Cleanup QA scripts.
- - Split main() function into several small ones.
- Current work on disk failure tests. This is not yet finished.
- Fi...
10/31/2007
- 10:12 pm Revision 80de0e3f: Revert "Implement multi-failover options"
- This reverts commit 289, as the node failover functionality was already
implemented in gnt-node (as opposed to gnt-in... - 05:19 pm Revision 22d31e49: Fix usage of OpReplaceDisks.
- Reviewed-by: iustinp
- 04:57 pm Revision bcee9cb4: Small improvements to multi-instance selections
- This patch fixes the documentation in a few cases and adds handling of
the situation where no instance is selected du... - 04:56 pm Revision 36c87212: Implement multi-failover options
- This patch adds the same style of multi-instance selection as in
shutdown/startup to the failover subcommand, with th... - 04:56 pm Revision 24a40d57: More sane handling of errors during failover
- Currently we ignore errors on instance shutdown (on the source node)
during instance failover. We should do this only... - 04:55 pm Revision 50ff9a7a: Fix bridge checking in instance failover
- The current code checks the bridge on the primary node of the instance,
but we need to check it on the destination no...
10/30/2007
- 05:09 pm Revision 4cc2a728: Fix _UpdateEtcHosts to understand empty lines.
- Reviewed-by: schreiberal
10/29/2007
- 10:09 pm Revision 1a8c0ce1: Change the signature of some methods of mcpu.Processor
- This patch moves the passing of the feedback_fn argument from the
(Exec|Chain)OpCode to the initialization of the Pro... - 07:05 pm Revision ce838ee3: Remove a redundant assignment
- The major is declared in the base class, we do not need to overwrite it.
Reviewed-by: imsnah - 07:05 pm Revision 0ede5336: Fix some style issues (whitespace changes only)
- Reviewed-by: imsnah
- 06:02 pm Revision 233d06c5: Fix a non-clear error message
- Reviewed-by: imsnah
- 05:49 pm Revision a9e0c397: Implement replace-disks for drbd8 devices
- This patch adds three modes of disk replacement for drbd8:
- replace the disk on the primary node
- replace the d... - 05:47 pm Revision b00b95dd: Allow drbd8 devices to work without local storage
- This patch adds functionality to drbd8 for:
- removing local storage
- initializing without local storage
- add... - 05:44 pm Revision f3e513ad: Implement block device renaming
- This patch add code for renaming a device; more precisely, for changing
the unique_id of the device. This means:
- ... - 05:20 pm Revision cc0451f3: Convert ListOS to use the all helper function.
- The predicate function gets build by a lambda function.
Also add a bit of debugging information to the 'unknown OS di...
10/28/2007
- 04:32 pm Revision 78feb6fb: Import two itertools recipes
- The two function 'any' and 'all' are copied as-is from the python 2.4
documentation for the itertools module. They ar...
10/26/2007
- 01:25 pm Revision 65a15336: Add a custom str() method for objects.Disk
- This is done in order to easy debugging of disk-related issues.
Reviewed-by: imsnah
10/25/2007
- 02:22 pm Revision 153d9724: Modify two mirror-device related rpc calls
- The two calls mirror_addchild and mirror_removechild take only one child
for addition/removal. While this is enough f...
10/24/2007
- 05:43 pm Revision a1f445d3: Initial implementation of drbd8 template type
- This is a partially working drbd8 template type. It does:
- add/remove
- startup/failover/shutdown
Not working i... - 05:41 pm Revision f38478b2: Allow DRBD8 to sync after sb1-pri with no changes
- Currently the way we shutdown or startup disks seems to make DRBD8
unhappy. Until we rewrite the sequence of (de)acti... - 05:23 pm Revision b352ab5b: Fix a disk handling bug triggered by failover
- This leaves an instance's disks configured for the primary node as after
disk activation we want to start the instanc... - 04:30 pm Revision a2cfdea2: Add DRBD8 class for handling drbd version 8.x
- This duplicates some code from the DRBDev class, but not very much, and
it will be expanded with the new functionalit... - 04:30 pm Revision ae26a287: Move/rename _IsValidMeta to base drbd class
- The DRBDev._IsValidMeta only checks for the metadata device size. Since
this is a useful check (but not complete) for... - 04:24 pm Revision 5a47ad20: More abstractions from DRBD7 to base class
- This moves the _SetFromMinor and _MassageProcData to the base class.
Reviewed-by: imsnah - 04:24 pm Revision 0caf6485: Improve out-of-minors handling
- Currently, the out-of-minors handling is not very good: though both MD
and DRBD functions for finding an unused minor... - 04:23 pm Revision 770fe0f9: Move some methods from DRBDev to BaseDRBD
- Since some of the methods and constants are valid for both 0.7 and 8.x
versions, we move them to the base class.
Rev...
10/19/2007
- 02:49 pm Revision aa4260ca: Some tiny style fixes
- Reviewed-by: imsnah
- 02:48 pm Revision 0f7f32d9: Split some DRBD functionality based on versions
- This is a small split of some functionality from the DRBDev class into a
base drbd class that holds just a few things... - 02:48 pm Revision fe96220b: Abstract more strings values into constants
- Currently, the disk types are defined using constants in the code.
Convert those into constants so that we can easily...
10/18/2007
- 04:02 pm Revision e8ae0c20: Implement disk failure QA test.
- Testing failure on the primary node is currently disabled due to drbd problems.
Reviewed-by: iustinp - 01:26 pm Revision 579d4337: Patch series for reboot feature, part 3
- This patch series implements the reboot command for gnt-instance. It
supports three types of reboot: soft (hypervisor... - 01:25 pm Revision bf6929a2: Patch series for reboot feature, part 2
- This patch series implements the reboot command for gnt-instance. It
supports three types of reboot: soft (hypervisor...
Also available in: Atom