Activity
From 12/07/2008 to 01/05/2009
12/19/2008
- 09:31 pm Revision 5b099da9: ganeti.bootstrap: Set permissions on newly uploaded files
- Reviewed-by: amishchenko
- 09:31 pm Revision 699777f2: ganeti.cmdlib: Check remote API certificate on "gnt-cluster verify"
- Reviewed-by: amishchenko
- 09:30 pm Revision 2438c157: ganeti.bootstrap: Upload remote API certificate to new nodes
- Reviewed-by: amishchenko
- 09:30 pm Revision 5557b04c: ganeti.bootstrap: Prepare for remote API certificate
- Reviewed-by: amishchenko
- 09:30 pm Revision c4415fd5: ganeti.bootstrap: Write SSL key to temporary file and set permissions
- Previously, we set the permissions only after writing the key. This
gave other users on the system a small window dur... - 09:30 pm Revision 61a08fa3: ganeti.bootstrap: Generate SSL certificate for remote API
- Reviewed-by: amishchenko
- 09:29 pm Revision 40a97d80: ganeti.bootstrap: Move SSL certificate generation into separate function
- Reviewed-by: amishchenko
- 02:58 pm Revision b5b67ef9: ganeti-rapi: Implement HTTP authentication
- Passwords are stored in "$localstatedir/lib/ganeti/rapi_users". User
options specify the access permissions of a user... - 02:58 pm Revision 7e9760c3: ganeti-rapi: Introduce per-request context
- This will be used to evaluate access permissions to resources.
Reviewed-by: amishchenko - 02:57 pm Revision e6e94655: ganeti.http: Function to read password file
- Lines in the password file are of the following format:
<username> <password> [options]
Fields are separated by w... - 02:57 pm Revision 68fa9caf: ganeti.http: Add support for private data in HTTP requests
- Reviewed-by: amishchenko
- 02:57 pm Revision be500c29: ganeti.http: Add support for basic HTTP authentication
- As per RFC2617.
Reviewed-by: amishchenko - 02:57 pm Revision f8bd7df3: ganeti.http: Prepare authentication for HTTP server
- The authentication class will override PreHandleRequest.
Reviewed-by: amishchenko
12/18/2008
- 06:39 pm Revision dd875d32: Job queue: Allow more than one file rename per RPC call
- Reviewed-by: ultrotter
- 06:38 pm Revision d7fd1f28: ganeti.jqueue: Group job archivals to reduce number of RPC calls
- Reducing the actual number of RPC calls will come in another patch.
Reviewed-by: ultrotter - 06:38 pm Revision f8ad5591: Prevent RPC timeout on auto-archiving jobs
- With a large job queue, auto-archiving jobs can take a very long time,
causing timeouts on the luxi RPC layer. With t... - 06:38 pm Revision 78d12585: jqueue: When auto-archiving jobs, calculate job status only once
- This is done by passing the job object to _ArchiveJobUnlocked instead
of only the job ID. Also return whether job was... - 06:23 pm Revision 58b22b6e: Use subdirectories for job queue archive
- As it turned out, having many files in a single directory can be
very painful. With this patch, only 10'000 files are... - 06:23 pm Revision 6e797216: Add rename function automatically creating directories if needed
- Unfortunately, os.makedirs in Python 2.4 is not safe against multiple
processes creating the same directory tree at t... - 06:21 pm Revision aea0ed67: ganeti.http: Don't pass poller object around
- They're cheap to instantiate and doing this changes makes the code
a bit simpler.
Reviewed-by: ultrotter - 03:45 pm Revision 79589f25: Rename http.HttpInternalError to HttpInternalServerError
- All other exceptions are named after the error name in RFC2616 (HTTP/1.1).
Reviewed-by: amishchenko - 03:45 pm Revision b3660886: ganeti.http: Add more constants and errors
- Reviewed-by: amishchenko
- 03:45 pm Revision 45eac583: ganeti.http: Ignore ENOTCONN when shutting down the connection
- Reviewed-by: amishchenko
- 03:44 pm Revision a8e01e9f: Implement support for additional headers with HTTP errors
- Reviewed-by: amishchenko
12/17/2008
- 04:30 pm Revision f30ca1e6: Add simple unittests for ganeti.http
- More complex unittests will need some refactoring in the HTTP code.
Reviewed-by: amishchenko - 04:09 pm Revision e38220e4: ganeti.bootstrap: Whitespace fix
- Reviewed-by: iustinp
- 03:18 pm Revision f87b405e: Add job queue size limit
- A job queue with too many jobs can increase memory usage and/or make
the master daemon slow. The current limit is jus... - 01:24 pm Revision 7167159a: utils.KillProcess: Use waitpid() to wait for child processes
- Sometimes the proc filesystem doesn't reflect the current status of
a process. By calling waitpid(), we make sure to ...
12/16/2008
- 06:24 pm Revision 26de0cf1: Release ganeti 2.0~alpha1
- Reviewed-by: iustinp
- 06:24 pm Revision 513e896d: LUConnectConsole: fix primary_node online check
- The primary node is part of the instance, not of the opcode.
Reviewed-by: iustinp - 06:24 pm Revision bf988c29: _RunCmdPipe: handle EINTR in poller.poll()
- poll() can be interrupted. rather than failing we retry until it
returns.
Reviewed-by: iustinp - 06:24 pm Revision 14aa53cb: KVM: improve socat interface
- Call socat with a full path specified at configure time, rather than
just by its name, and check for the binary to ex... - 06:23 pm Revision dd71f05b: KVM: use a different default kernel path
- It makes sense for the default kvm kernel not to be called "xenU".
Reviewed-by: iustinp
12/15/2008
- 12:06 pm Revision f088165d: ganeti.http: Add three TODOs for improvements
- Reviewed-by: iustinp
- 11:48 am Revision f2e13d55: ganeti.http: Explicitly initiate handshake
- Otherwise it would be done on the first read/write operation, making
error handling more difficult (such as EOF durin... - 11:40 am Revision d7fa9982: ganeti.http: Implement handshake socket operation
- Reviewed-by: iustinp
- 11:40 am Revision 39cfc25b: ganeti.http: Handle SSL_ERROR_ZERO_RETURN
- Also add a comment next to the place where the SSL connection is shut
down.
Reviewed-by: iustinp
12/14/2008
- 02:05 pm Revision 3c7f6c44: cleanup: ConfigWriter, initialize all attributes
- We should initialized the _last_cluster_serial in the constructor too (just to
be consistent).
Reviewed-by: amishchenko - 02:05 pm Revision f6f91001: cleanup: rapi v2 instance tags wrong attribute
- This was changed in the past, but it seems this class was forgotten.
Reviewed-by: amishchenko - 02:05 pm Revision 3f3dfc15: cleanup: http server, line too long
- Reviewed-by: amishchenko
- 02:05 pm Revision 5a9c3f46: cleanup: http client, line too long
- Reviewed-by: amishchenko
- 02:04 pm Revision 5661b908: cleanup: xen hypervisor
- Wrong indentation and uniformize one method signature.
Reviewed-by: amishchenko - 02:04 pm Revision 08137f9e: cleanup: kvm code likes to redefine names
- Reviewed-by: amishchenko
- 02:04 pm Revision 9c034cbe: lib/ssh.py: import the logging module
- This only means most of our error paths in this module were not working
(and generating exceptions).
Reviewed-by: am... - 02:04 pm Revision bf75f132: SshRunner: add docstring for _BuildSshOptions
- Reviewed-by: amishchenko
- 02:04 pm Revision 67047322: Improve _autoconf.py comments
- This adds a docstring to the _autoconf.py file detailing how it's
generated (the other comment it's not visible in py... - 02:04 pm Revision ad1bf20c: cleanup: use _ for unused loop counter
- Reviewed-by: amishchenko
- 02:04 pm Revision 805f0c07: cleanup: WorkerPool, wrong variable name
- Quoting Michael: "why is this even working?"
Reviewed-by: imsnah,amishchenko - 02:03 pm Revision 0b5ad33e: cleanup: TcpPing, wrong variable name
- The default value of 'False' wasn't initialized properly. It doesn't
require initialization, but it's cleaner this wa... - 02:03 pm Revision cd34e7bf: cleanup: SetEtcHostsEntry unused var
- Reviewed-by: amishchenko
- 02:03 pm Revision a0add446: cleanup: fix IAllocator hypervisor usage
- Two problems: the iallocator.hypervisor wasn't initialized to None in
the constructor, so pylint doesn't realize it's... - 02:03 pm Revision 4504c3d6: cleanup: LUReplaceDisks unused vars
- And a small whitespace fix.
Reviewed-by: amishchenko - 02:03 pm Revision 9ca87a96: cleanup: do not hide upper-scope name
- hypervisor is a module, so we shouldn't use it as an argument.
Reviewed-by: amishchenko - 02:03 pm Revision 43017d26: cleanup: fix use of _CheckNodeOnline
- A few cases of wrong variable name.
Reviewed-by: amishchenko - 02:03 pm Revision 8153e7e3: cleanup: LUAddNode, LUSetNodeParams unused variable
- This is a leftover from the abstraction of AdjustCandidatePool, and it
also requires the config lock, so it's better ... - 02:02 pm Revision d1dc3548: cleanup: LURenameCluster wrong variable name
- Reviewed-by: amishchenko
- 02:02 pm Revision 95268cc3: cleanup: fix export NIC count the same way as disk
- For safety, we use the same algorithm as in disk count.
Reviewed-by: amishchenko - 02:02 pm Revision bca2e7f4: cleanup: fix backend._RecursiveFindBD
- _RecursiveFindBD takes a parameter that isn't used; moreover, nowhere in
the SVN history can I find a case that it ha... - 02:02 pm Revision 9a4e6f41: cleanup: more unused vars
- Reviewed-by: amishchenko
- 02:02 pm Revision 3bc6be5c: cleanup: sanitize a default parameter
- Instead of relying that the usage of the parameter is ok with mutable
default parameters, let's just make it safer..
... - 02:02 pm Revision 9728ae5d: cleanup: exceptions should derive from Exception
- Reviewed-by: amishchenko
- 02:02 pm Revision 7bc9e58f: cleanup: fix GatherMasterVotes
- Remove unused vars
Reviewed-by: amishchenko - 02:01 pm Revision 531baf8e: cleanup: _InitSSHSetup doesn't need its argument
- Reviewed-by: imsnah
- 02:01 pm Revision fab1e3a4: cleanup: fix 'variable unused' warning
- In the iteration we don't care about the node names, so we change the
for loop to be over the values (and not iterval...
12/12/2008
- 06:50 pm Revision 22692e48: ganeti.http: Rename HttpBase._using_ssl to HttpBase.using_ssl
- It'll be queried from other classes.
Reviewed-by: iustinp - 06:50 pm Revision f4322a1e: ganeti.http: Rename HttpSocketBase to HttpBase
- It's more appropriate.
Reviewed-by: iustinp
12/11/2008
- 07:13 pm Revision c41eea6e: Fix epydoc format warnings
- This patch should fix all outstanding epydoc parsing errors; as such, we
switch epydoc into verbose mode so that any ... - 04:58 pm Revision 16f323ce: Switch epydoc to parse only
- epydoc seems to be mightily confused by decorators and how they change
functions (it starts mixing the parameters of ...
12/10/2008
- 02:11 pm Revision 52e2f66e: ganeti.backend: Improve compression check
- Reviewed-by: iustinp
- 02:06 pm Revision 358a8811: ganeti.http: Docstring updates
- Reviewed-by: iustinp
12/09/2008
- 08:42 pm Revision 13b63666: ganeti.http: Remove _HttpClientError
- This is a leftover from old code.
Reviewed-by: iustinp - 07:35 pm Revision 59305197: ganeti.http.server: Increase connection backlog to 1024
- This solves a problem with many concurrent requests. By default, 1024
is the maximum backlog on Linux kernels. We lim... - 03:24 pm Revision 12bce260: RPC: Compress file upload data
- Adding compression to larger amounts of data is more efficient than
transferring it (len(nodes) - 1) times over the n... - 11:33 am Revision 832261fd: Warn for instances living on offline nodes
- The patch also changes the result to error for non-reachable secondary nodes
(as for primary nodes).
Reviewed-by: ul...
12/08/2008
- 07:45 pm Revision ee513a66: Fix _AdjustCandidatePool
- Currently the ConfigWriter.MaintainCandidatePool returns node names, and
_AdjustCandidatePool uses them as such, but ... - 01:46 pm Revision 3a5ba66a: gnt-node modify: add the offline attribute
- This patch changes gnt-node modify and the associated opcode/lu to allow
modification of the node offline attribute.
... - 11:10 am Revision ed83f5cc: RPC: do not make calls to offline nodes
- This patch changes the _MultNodeCall and _SingleNodeCall helpers to not
actually make calls to offline nodes, but ins...
12/07/2008
- 01:01 pm Revision c6286afc: chmod ganeti.initd before uploading it
- When an upload is done to a node which doesn't have any version of
ganeti installed, this prevents a non-executable-i...
Also available in: Atom