Activity
From 01/04/2010 to 02/02/2010
02/02/2010
- 04:39 pm Revision e18def2a: ganeti-cleaner: does 'echo 0' instead of 'exit 0'
- This is from Debian Bug#568105.
ganeti-cleaner in one case erroneously calls "echo 0" instead of "exit
0". As ganeti...
02/01/2010
- 04:55 pm Revision 72456eb2: Bump RPC protocol version to 30
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:42 pm Revision 82ad3594: Find OpenSSL program at configure time
- Otherwise we depend on PATH at runtime.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Tro... - 04:42 pm Revision a55474c7: Move function generating SSL certs into utils
- Also add unittest.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@googl... - 03:20 pm Revision 5b2069a9: Initial design for inter-cluster instance moves
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:01 pm Revision e7307f08: Merge branch 'devel-2.1'
- * devel-2.1:
Bump version to 2.1.0~rc5
Makefile.am: Targets used directly should depend on BUILT_SOURCES
Make t... - 02:55 pm Revision 9f53d9ce: Merge remote branch 'origin/stable-2.1' into devel-2.1
- * origin/stable-2.1:
Bump version to 2.1.0~rc5
Fix missing bridge for xen instances
Fix flipping MC flag bug
... - 02:32 pm Revision 8432c491: Bump version to 2.1.0~rc5
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:08 pm Revision eb732fb5: Makefile.am: Targets used directly should depend on BUILT_SOURCES
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:44 pm Revision 9b3b6845: Merge branch 'devel-2.0' into devel-2.1
- * devel-2.0:
Three small typos in man pages
Conflicts:
man/gnt-cluster.sgml (trivial)
Signed-off-by: Iustin Pop ... - 12:37 pm Revision 433c63aa: Make the snapshot decision based on disk type
- … instead of disk size, which is not as reliable. This actually
simplifies the code; but it still leaves the possibil... - 12:10 pm Revision ba0b05fe: Three small typos in man pages
- The credit goes again to Lintian.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <han...
01/29/2010
- 01:58 pm Revision 0183a697: Fix missing bridge for xen instances
- Xen instances nic definitions miss the target bridge.
This bug was introduced in commit 503b97a9.
Signed-off-by: Al...
01/28/2010
- 04:46 pm Revision cea0534a: Fix flipping MC flag bug
- Currently unofflining or undraining an already functional master
candidate node, can cause it to demote itself. In or... - 01:44 pm Revision 7369e826: ganeti-watcher: ensure confd is running as well
- Ganeti-confd should be running on all 2.1 nodes.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iu... - 11:43 am Revision 551b6283: Add capability to use syslog for logging
- This patch adds a configure-time parameter that will set the defaults
used by all programs, and command-line paramete...
01/27/2010
- 06:26 pm Revision 8388e9ff: Initial KVM security improvement design for 2.2
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:35 pm Revision 81198f6e: node daemon: allow working with broken queue dir
- In case the queue dir cannot be create/initialized, currently
ganeti-noded exits. This means that a read-only filesys... - 03:35 pm Revision aac3fbf0: utils.FileLock: handle init errors properly
- If the open of the lock file fails (due to whatever reason), 'self'
won't have the 'fd' attribute, and thus we fail i... - 03:35 pm Revision 8645ff83: daemon-utils: remove usage of here-docs
- In some versions of bash, here-docs and here-strings use temporary
files, which means daemon-util needs a writable te... - 02:17 pm Revision 7a8da378: Fix typo in ganeti-os-interface(7)
- The variable is called “IMPORT_INDEX”, not “IMPORT_IDX”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie... - 12:19 pm Revision ec44d893: locking: add/fix @type information
- This patch missing @type information for all public methods, modifies
one to conform to the rest, and removes some in... - 11:17 am Revision 154b9580: Fix __slots__ definitions
- According to http://docs.python.org/reference/datamodel.html#slots
* The action of a __slots__ declaration is limite...
01/26/2010
- 02:58 pm Revision 4c1a504b: Merge branch 'devel-2.0' into devel-2.1
- * devel-2.0:
Fix the mocks.py for 2.0 unittests
LURemoveNode safety in face of wrong node list
Fix an unsafe fo... - 11:53 am Revision 825e13df: Fix the mocks.py for 2.0 unittests
- The recent change to use LogWarning with multiple arguments in
mpcu.py/HooksMaster broke the (simple) mock we have in...
01/25/2010
- 06:23 pm Revision 89b70f39: Add a crude disable for DRBD barriers
- Ideally we want to/will have per-device DRBD controls of disk/metadata
flushes. In the meantime, we want at least a d... - 06:17 pm Revision 9bb31ea8: LURemoveNode safety in face of wrong node list
- LURemoveNode runs under the BGL, which means we're guaranteed that the
list of nodes as retrieved in CheckPrereq is s... - 06:16 pm Revision 62579388: Fix an unsafe formatting bug
- This might fix issue 84; in any case, the current situation is that we
have a potentially unsafe formatting, which sh... - 06:16 pm Revision 691744c4: Ensure all int/float conversions are handled right
- int()/float() can raise either ValueError (in case of int("a")), or
TypeError (in case of int(None)). We had many bug...
01/22/2010
- 06:38 pm Revision b9f8d18f: Merge branch 'devel-2.1'
- * devel-2.1: (38 commits)
Bump version to 2.1.0~rc4
Update man page of gnt-instance
KVM: fix pylint warning
K... - 06:38 pm Revision d80cb8c4: Merge branch 'stable-2.1' into devel-2.1
- * stable-2.1:
Bump version to 2.1.0~rc4
KVM: fix pylint warning
KVM: be more resilient on broken migration answ... - 06:21 pm Revision 0ea0ce20: Bump version to 2.1.0~rc4
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:08 pm Revision 2feecf12: Fix lint warnings after my last changes
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:36 pm Revision 16b037a9: Remove http.HttpJsonConverter
- With the move of the content-type handling to the various users of the HTTP
layer, this class isn't really useful any... - 04:36 pm Revision 627ad739: rapi: Don't access request's private object directly
- This way the request handlers don't need as much knowledge
about the inside of the request and context objects and it... - 04:17 pm Revision ab221ddf: http.server: No longer enfore JSON encoding for body
- The HTTP layer shouldn't care about the contents of the request data or
responses. This requires further changes in t... - 04:17 pm Revision 200e38ac: http.server: Refuse HTTP/1.1 request without Host header
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:17 pm Revision c10e2751: ganeti-rapi: Remove serial number/ETag code
- It was never used as intended.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin... - 04:17 pm Revision 580558a3: http: Add two new exceptions, one constant
- These will be useful in the future in case we don't enfore JSON encoding
anymore in the http.server module. The HTTP ... - 04:17 pm Revision 231db3a5: Factorize LUXI parsing and handling code
- Also fix a typo in http/__init__.py and add unittests
for the LUXI parsing and formatting functions.
Signed-off-by: ... - 04:16 pm Revision 797506fc: Simplify LUXI exceptions
- Having only one exception hierarchy makes catching them simpler. Before
ProtocolError would derive directly from Exce... - 03:55 pm Revision c7c568b4: Update man page of gnt-instance
- This patch updates the man page of gnt-instance to include the newly
added tags filtering.
Signed-off-by: René Nussb... - 03:45 pm Revision e4dd2299: KVM: fix pylint warning
- Specify string format arguments as logging function parameters
Signed-off-by: Guido Trotter <ultrotter@google.com> - 03:05 pm Revision c4e388a5: KVM: be more resilient on broken migration answers
- Before, when doing kvm live migrations we use to accept an "unknown
status" but to reject anything that didn't match ...
01/21/2010
- 05:38 pm Revision 39dfd93e: Allow filtering for (node-)tags
- This change introduces startup, shutdown, reboot, reinstall by using
instance respectively node tags as a selection c...
01/20/2010
- 03:47 pm Revision 2ebf1568: Add unittests for cli.GenerateTable
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:47 pm Revision ec39d63c: cli: Fix bug when not using headers
- Commit 9fe72672 added code to not write spaces at the end of each line.
Unfortunately it didn't work properly when no...
01/19/2010
- 06:18 pm Revision 03956d39: daemon-util: Fix quoting issue
- This patch fixes a quoting issue in daemon-util:
$ EXTRA_MASTERD_ARGS=--no-voting /etc/init.d/ganeti restart
[…]
* g...
01/15/2010
- 02:17 pm Revision 0175fd8c: Bump version to 2.1.0~rc3
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: ... - 01:23 pm Revision f9d0783b: Merge branch 'stable-2.1' into devel-2.1
- * stable-2.1: (22 commits)
Fix long-standing race condition bug in locking unittest
confd client: copy the peers ... - 01:22 pm Revision 1b3a7656: Switch the SplitKeyVal function to accept escapes
- This tiny patch switches the SplitKeyVal function (and thus the command
line options like -H, -B, etc.) to UnescapeAn... - 12:16 pm Revision 51e3bb92: Fix long-standing race condition bug in locking unittest
- Every once in a while we saw failures in the locking unittest, but
weren't able to determine the cause. This patch fi...
01/14/2010
- 07:07 pm Revision db169865: confd client: copy the peers in UpdatePeerList
- Since the peer list is shuffled by the client, we don't keep a reference
to the list which was passed in, but copy it... - 06:38 pm Revision a804261a: Move instance relocation test upper in the chain
- Currently we test each instance for relocation in checkMove; however, it
is a little more clear if we pass only the r... - 06:05 pm Revision 5ad86777: Split the balancing function in two parts
- Currently in the balancing function we do two thing:
- take the decision where to do a new balancing round or not
- ... - 04:15 pm Revision 210ed839: Small update to the Makefile
- 04:09 pm Revision 0d478754: Makefile: Switch from subshell to $(MAKE) -C
- It seems that set -e does not affect subshell (only simple commands),
and thus we don't actually get failures from ma... - 02:17 pm Revision 43983a88: testutils: Print name of test program before running it
- While the name can be looked up in Makefile.am, this
is useful when an automated test just hangs and needs
to be kill... - 02:17 pm Revision 6d7cc5ff: Don't use hardcoded name for pylint
- Look it up at configure time instead.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop ... - 02:16 pm Revision f60d352e: Partially revert "Makefile.am: Run pylint on all Python code"
- This partially reverts commit e4e7c7df3a2356103c2442a91d628ca0470fb267,
which made newer pylint versions fail.
Signe... - 02:16 pm Revision b4086ce8: build-bash-completion: Take care of pylint warnings
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:26 am Revision 5b69bc7c: Add an UnescapeAndSplit function
- In many cases, where we accept (usually from the command line) a list of
parameters, we remove the use of the separat...
01/13/2010
- 07:09 pm Revision 5548de18: Small improvements for release script
- - Print usage if no tree-ish (tag, branch or commit) was
specified.
- Use “gntrelease.XXXXXXXXXX” as temporary dire... - 07:09 pm Revision e4e7c7df: Makefile.am: Run pylint on all Python code
- That is, all Python code except unittests. In particular,
autotool/build-bash-completion was missing from the
previou... - 07:08 pm Revision f59418db: build-bash-completion: Fix a few pylint warnings
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 07:08 pm Revision bdba4757: check-python-code: Use “set -e” to abort on errors
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:45 pm Revision e2e92ea0: Generate hmac file with a newline at the end
- This makes it slightly easier to cut&paste its content.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed... - 05:47 pm Revision d2c8afb1: jqueue: Don't return negative number for unchecked jobs when archiving
- When the queue was empty, the calculation for unchecked jobs while
archiving would return -1. ``last_touched`` is set... - 03:03 pm Revision 9fe72672: cli.GenerateTable: Don't write EOL spaces
- With this change, there won't be unnecessary space characters
at the end of lines.
Signed-off-by: Michael Hanselmann... - 03:03 pm Revision 9fa2e150: Improve logging for workerpool tasks by providing __repr__
- Before it would log something like “starting task
(<ganeti.http.client._HttpClientPendingRequest object at 0x2aaaad17... - 03:03 pm Revision 02fc74da: workerpool: Simplify log messages
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:03 pm Revision d16e6fd9: workerpool: Use worker name as thread name
- This way it shows up in debug logs.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <i... - 03:02 pm Revision 89e2b4d2: workerpool: Make worker ID alphanumeric
- Having a proper name instead of just a number makes debugging
easier.
Signed-off-by: Michael Hanselmann <hansmi@goog... - 03:02 pm Revision 71e1863e: locking: Fix race condition in LockSet
- This patch fixes a race condition when acquiring all locks in
a LockSet instance. The list of lock names needs to be ... - 03:02 pm Revision 4776e022: mcpu: Log lock status with sorted names
- Reading and comparing sorted lists is easier when debugging locking problems.
Signed-off-by: Michael Hanselmann <han... - 03:02 pm Revision 9b154270: locking: Append to list outside error handling block
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 03:02 pm Revision 56452af7: locking: Don't fail in error handling if lock isn't owned
- In case an exception was thrown while acquiring the lock, not necessarily all
owned locks are also really acquired. B...
01/12/2010
- 12:45 pm Revision 752a8ca8: Provide example default files and install one for development
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:24 pm Revision b13dfb92: Merge branch 'devel-2.1' into stable-2.1
- 12:18 pm Revision 71e635f3: Fixing a typo in option description
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Ius...
01/11/2010
- 02:25 pm Revision 82187135: Normalize MAC addresses to all lower.
- This change will normalize the MAC to all lower after validation.
Signed-off-by: René Nussbaumer <rn@google.com>
Sig...
01/07/2010
- 02:58 pm Revision 9f4b0931: live-test fixes for the text backend changes
- 01:57 pm Revision 66ea8434: Update hscan to generate new-format text files
- This also updates its manpage, some information were really old.
- 01:57 pm Revision 16c2369c: Switch the text file format to single-file
- This patch changes from the two separate files to a single file, with
sections separated by a blank line. Currently o... - 12:44 pm Revision f5197d89: Change the signatures of the text loader slightly
- This is in preparation for the text format changes.
01/05/2010
- 02:56 pm Revision 7699c3af: Introduce a Luxi call for GetTags
- This changes from submitting jobs to get the tags (in cli scripts) to
queries, which (since the tags query is a cheap... - 02:39 pm Revision 47a72f18: LURenameCluster: run post hook on all nodes
- Since the cluster name might be used for various purposes on nodes, we
should let all nodes "know" about a cluster re... - 09:23 am Revision 1cd5bc89: Allow passing options to pylint in the lint rule
- This allows automated builders to override the format, for example.
Signed-off-by: Iustin Pop <iustin@google.com>
Re...
01/04/2010
- 12:55 pm Revision 24cd3744: Merge remote branch 'devel-2.1'
- * devel-2.1: (40 commits)
Fix unused imports or add silences where needed
bdev: Add a TODO and a pylint silence
... - 11:20 am Revision 30e4e741: Fix unused imports or add silences where needed
- In some cases pylint doesn't parse the import correctly, so we add
silences; but there are also many cases of unused ... - 11:17 am Revision 527a15ac: bdev: Add a TODO and a pylint silence
- A piece of old code in bdev.py uses a for loop over a single variable
because we can 'break' out of the loop or exit ... - 11:17 am Revision c9ca81c9: confd: add a TODO and a pylint disable
- Two variables are used in a strange way in ExecConfd. Until that is
clarified, add a TODO and a silence for the unuse... - 11:17 am Revision 460bb584: pylint: Temporarily disable W0201
- There seems to be a bug in pylint relating to W0201 (“Attribute '%r'
defined outside __init__”) being re-enabled by s... - 11:17 am Revision 16bef045: Disable R0922 in pylint
- R0922, “Abstract class is only referenced 1 times”, cannot be disabled
in the source code, and thus
lib/http/auth.py:... - 11:17 am Revision 2d54e29c: Further pylint disables, mostly for Unused args
- Many of our functions have to follow a given API, and thus we have to
keep a given signature, but pylint doesn't unde... - 11:17 am Revision 0dda8696: pylint: disable the similarities checker
- This is a very slow checker, estimated to be O(n²) by its author; so
using it all the time is not good. It can be re-... - 11:16 am Revision 857121ad: LUDiagnoseOS._DiagnoseByOS: remove unused arg
- The node_list argument to _DiagnoseByOS is not used, and is obsoleted by
the fact that the rlist argument already has... - 11:16 am Revision f93427cd: daemons: handle arguments correctly and uniformly
- Of all daemons, only rapi did abort when given argument. None of our
daemons use any arguments, but they accepted the... - 11:16 am Revision 7ed85ffe: hv_xen/_GetConfigFileDiskData: remove unused arg
- The disk template is not needed, all that's used is the disk data. As
such, remove this parameter from the function.
... - 11:16 am Revision 45e0d704: jqueue/_CheckRpcResult: log the whole operation
- Currently only the rpc call, but not its description (which also shows
the argument) is logged. We change this to log... - 11:16 am Revision 8929d28c: Optparse extenders have to obey a given API
- So we just silence the warning.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@goo... - 11:16 am Revision c19f9810: backend._OSOndiskAPIVersion: remove obsolete arg
- The 'name' argument is not used anymore, probably since before 2.0.
Since this is an internal function, we can just r... - 11:16 am Revision e11ddf13: pylint cleanups: dangerous initializers
- Plus a silence for a wrong "uninitialized var".
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier T... - 11:16 am Revision 7e950d31: Convert to static methods (where appropriate)
- Many methods are simple pure functions, and not depending on the object
state. We convert these to staticmethods.
Si... - 11:15 am Revision f4ad2ef0: Remove more unused variables
- This removes unused variables in the rest of the code (outside lib/).
Signed-off-by: Iustin Pop <iustin@google.com>
... - 11:15 am Revision 7260cfbe: Add targeted pylint disables
- This patch should have only:
- pylint disables
- docstring changes
- whitespace changes
Signed-off-by: Iustin Pop <... - 11:15 am Revision e7beaa02: burnin: move decorators out of classes
- Similar to commit c881c5, we move the decorators out of classes, such
that they become simple functions instead of me... - 11:15 am Revision e2e10467: Rename an ConfdInotifyEventHandler init argument
- 'file' is a builtin keyword/type. Like many others, it should not be
used as a variable/argument name.
No code is ac... - 11:15 am Revision e0098923: Introduce a makefile lint rule
- This runs pylint over all the python files. Yes, it takes a long while,
but it's the only way to properly analyze the... - 11:15 am Revision 94fed7da: Implement all hv functions in hv_chroot/hv_fake
- The chroot and fake hypervisors were missing:
- the powercycle node functionality
- proper handling of migration req... - 11:12 am Revision 0a4e7f24: Update the _autoconf.py make rule for pylint
- This adds targeted pylint disables, but since _autoconf.py is
autogenerated we need to do this in Makefile.am (hence ... - 11:12 am Revision dfe879ce: Disable TODO warnings in pylint
- We don't get any useful out of this - a git grep is as effective, and
these only pollute the pylint output.
Signed-o... - 11:12 am Revision bbe4cc16: Add some stubs to bdev.FileStorage
- This patch adds explicit errors (instead of notimplemented) in
FileStorage (and the associated TODOs).
Signed-off-by... - 11:11 am Revision 6af8a903: Fix indentation issues
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 11:11 am Revision be0fc05d: Fix two bugs in ConfigWriter._EnsureUUID
- Wrong argument name and wrong number of arguments in string formatting.
Signed-off-by: Iustin Pop <iustin@google.com... - 11:11 am Revision 5905901c: KVM: Abstract/rework instance up checks
- This patch abstract the check "is instance stopped" into a separate
function, and thus simplifies a couple of higher-... - 11:10 am Revision 98ec75d6: KVM: Split out the pidfile computation
- In some cases we only need the pidfile, but not the pid or the alive
status.
Signed-off-by: Iustin Pop <iustin@googl... - 11:10 am Revision d1b83918: Fix an error message
- Detected by an 'Unused variable' warning.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan ... - 11:10 am Revision 1122eb25: Remove many 'Unused variable' warnings
- Note there are some cases left which need extra cleanup.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ... - 10:42 am Revision 07b8a2b5: Fix use of the logging functions
- The logging functions expand the arguments themselves, thus it's safer
to let them do it rather than manual string fo...
Also available in: Atom