Activity
From 06/14/2011 to 07/13/2011
07/13/2011
- 07:45 pm Revision 22fac87d: htools: simplify select tests
- Rather than running all possible tests in one go, split them out in
three cases: "normal", undefined default value, u... - 07:07 pm Revision 82bc21e2: Set startup_paused to False when restarting
- This fixes the lint error:
E1120:1220:InstanceReboot: No value passed for parameter
'startup_paused' in function cal... - 05:09 pm Revision 424ec11d: htools: lookup instance names in select/exclude
- Currently we just match the passed name with fqdns. With this change we
do a proper search for either the fqdn or the... - 04:52 pm Revision efe98965: htools: infrastructure for looking up names
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:52 pm Revision bfe6c954: htools: Add if' and select as functions
- if' is just a functional version of the if-then-else construct. Using it
we can manipulate ifs as functions, and also... - 01:46 pm Revision 043a3929: htools: remove obsolete option INodes
- hspace no longer uses it, hence it can be removed.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michae... - 01:45 pm Revision 1cc97b7f: hspace: also report the disk template
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:45 pm Revision 9ef605a6: hspace: ask for the disk_template not number of nodes
- This makes more sense, as the disk template is more meaningful than
the number of nodes.
Signed-off-by: Iustin Pop <... - 01:45 pm Revision a10a476a: htools: add an utility function for disk templates
- In the future we'll use this instead of requiring the number of nodes
from the user.
Signed-off-by: Iustin Pop <iust... - 01:44 pm Revision c4bb977b: htools: define the --disk-template option
- Also sorts the export list correctly.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann ... - 01:40 pm Revision 6429e8d8: htools: read/save the disk template in Text backend
- This requires that we change the signature of loadInst in order to
properly annotate the error messages, which in tur... - 01:38 pm Revision b3c5e8de: htools: read the disk_template in the Luxi backend
- We need to request the disk template in the Luxi query and then use it
when parsing the response.
Signed-off-by: Ius... - 01:37 pm Revision 5a4a3b7f: htools: read the disk template in Luxi and Rapi
- Both these backends already have the data, we just need to use it.
Signed-off-by: Iustin Pop <iustin@google.com>
Rev... - 01:37 pm Revision d25643d1: htools: add DiskTemplate to instance definition
- Currently always fixed to DRBD8, as that is what we assume already.
Signed-off-by: Iustin Pop <iustin@google.com>
Re... - 01:37 pm Revision 3c002a13: htools: add some unittests for Types.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:36 pm Revision cc25e437: htools: add a DiskTemplate type
- This will be used later in the Instance type.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trott... - 01:15 pm Revision ca848e2a: htools: small simplification to parseUtilisation
- We eliminate the local variable as it's used only once.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: G... - 01:14 pm Revision 0e09422b: htools: rename Instance.auto_balance
- … to autoBalance, per the recommended style.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotte... - 01:13 pm Revision 34c5a24a: htools: simplify some JSON-related code
- Instead of manually encoding the JSValue(s), we can use showJSON as
long as we use data types that can be auto-conver... - 01:13 pm Revision 7c14b50a: htools: allow different result types
- This patch extends the previous patch changes to allow that each
Cluster function returns a different result type, as... - 01:09 pm Revision d6cf394e: htools: start reorganising the IAllocator workflow
- Currently, all IAllocator requests return the same result type: a list
of strings (usually nodes, but can also be ins... - 01:08 pm Revision 00152519: htools: split more code from hail/main
- The logic of request processing is not separated into its own
function, and (beside CLI interaction, e.g. verbosity h... - 01:05 pm Revision cabce2f4: htools: move code from hail.hs to IAllocator.hs
- This will make it easier to unittest the code, and keeps all login in a
single module.
Signed-off-by: Iustin Pop <iu... - 01:03 pm Revision 4e84ca27: htools: add parsing of input node-evac messages
- This is a lot of duplication with modeMreloc, which will get sorted
out once we convert mreloc to change-group.
Sign... - 01:03 pm Revision 3667467d: htools: remove pre-2.4 compatibility from RAPI
- This was potentially hiding issues in the group query, so let's remove
it since we're now bound to the current Ganeti... - 01:02 pm Revision 1fe412bb: htools: introduce new data type for node-evac
- The evac-mode goes into the Types.hs module since it needs to be
available to Cluster.hs too.
Signed-off-by: Iustin ... - 01:01 pm Revision 525bfb36: htools: docstring fixes and improvements
- No code changes (except one definition being moved around in QC.hs)
are contained in this patch.
Signed-off-by: Iust... - 01:00 pm Revision 606e71d3: Fix some issues in htools apidoc generation
- First, auto-generated files were not processed if HsColour thus the
'source' link in Haddock documentation was dangli... - 01:00 pm Revision 48f12e73: Replace an mkdir -p with @mkdir_p@ in Makefile.am
- Oops, this shouldn't have gone in in the first place…
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mic... - 01:00 pm Revision 98b33d0e: Exclude auto-generated Haskell code from coverage
- Especially for Ganeti.Constants, which has many declarations, it
doesn't make sense to check for coverage.
Signed-of...
07/12/2011
- 07:17 pm Revision 0b71067a: Update multi-reloc design doc with enhanced results
- In order to increase the amount of information returned from the
IAllocator plugin, we enhance the return values from... - 06:23 pm Revision b6e88032: gnt-cluster {command|copyfile}: Support per-group operations
- This patch allows commands to be run on and files to be copied to all
nodes within a specific group.
Signed-off-by: ... - 06:23 pm Revision 05484a24: cli.GetOnlineNodes: Support node group filter, use query2
- This patc changes cli.GetOnlineNodes to use query2, which does the
filtering in the master daemon, and adds a new par... - 06:23 pm Revision 172679c9: Remove references to multi-relocate from iallocator doc
- For some reason these were still in tere.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin ... - 06:22 pm Revision 7fc548e9: ht.WithDesc: Work around pylint warning
- Explicitely defining “__call__” silences a pylint warning when wrapped
type check functions are used directly. I had ...
07/11/2011
- 05:53 pm Revision b795a775: Merge branch 'devel-2.4'
- * devel-2.4:
ht: Add new check for numbers
Fix off-by-one bug in job serial generation
Shorten some unbreakable... - 05:28 pm Revision 697f49d5: ht: Add new check for numbers
- Places which receive floats can usually also deal with integers, e.g.
OpTestDelay. Tests are added and the new check ... - 05:28 pm Revision 3c88bf36: Fix off-by-one bug in job serial generation
- Commit 009e73d0 (September 2009) changed the job queue to generate
multiple job serials at once. Ever since it would ... - 05:16 pm Revision 7238edb5: Reverts the patch series about console wrappers
- This reverts commits 030a9cb8022b83bf43ec14dfbafd943299bc01c4 and
ae082df0000a785b693b2f4aa434650a81a94bdf.
There ar...
07/08/2011
- 03:15 pm Revision 323f9095: Add gnt-instance start --pause
- Creates the instance, but pauses execution before booting. This combined
with 'gnt-instance console' unpausing instan... - 03:15 pm Revision ae082df0: Adding a wrapper around connecting to kvm console
- The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as neces... - 03:15 pm Revision 030a9cb8: Adding a wrapper around "xm console"
- The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as neces...
07/06/2011
- 05:37 pm Revision a5566394: Fix lint error
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 12:31 am Revision b4fcee5b: RAPI: Document all feature strings
- - Use constants and an assertion
- Update documentation for node migration
Signed-off-by: Michael Hanselmann <hansmi... - 12:31 am Revision 21d70642: Remove old node evacuation opcode
- LUNodeEvacStrategy has been replaced with LUNodeEvacuate.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revi... - 12:31 am Revision de40437a: Change RAPI for new node evacuation opcode
- The change is not backwards compatible, see the updated NEWS file.
Signed-off-by: Michael Hanselmann <hansmi@google.... - 12:31 am Revision aafee533: Change “gnt-node evacuate” to use new opcode
- By default it'll now evacuate all instances from the node, not
just secondaries.
Signed-off-by: Michael Hanselmann <... - 12:31 am Revision e1f23243: Add new opcode to evacuate node
- This new opcode will replace LUNodeEvacStrategy, which used to return a
list of instances and new secondary nodes. Wi...
07/05/2011
- 08:24 pm Revision 029fe503: Alias gnt-job show to gnt-job info
- Am I the only one to make that mistake 10 times a week?
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed...
07/01/2011
- 06:06 pm Revision 7034694d: One Haskell and integer sizes fix
- Haskell has two main integer types:
- Int, which is a native-type, and is guaranteed to have at least
[-2²⁹, 2²⁹-1... - 05:43 pm Revision d748d9a7: Fix cluster verify for empty node groups
- There were some implicit assertions in the code that all node groups
have nodes, which is not necessarily true.
Addi... - 05:20 pm Revision 1e98bac2: Fix a typo and punctuation in iallocator.rst
- Beside the 'dscription' typo, also make the punctuation more
consistent.
Signed-off-by: Iustin Pop <iustin@google.co... - 05:17 pm Revision 56a1d5cc: Shorten some unbreakable lines in man pages
- In order to make the display right on 80-columns terminals.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b... - 05:17 pm Revision f7b769b1: Correct some spelling mistakes
- New lintian is even smarter:
- overriden → overridden
- allows to → allows one to
Signed-off-by: Iustin Pop <iustin...
06/28/2011
- 07:35 pm Revision e5f6768c: Fix htools, QuickCheck library detection and tests
- Just saw this while testing the migration to QuickCheck v2: while
configure.ac detects that QuickCheck-2.x is not ava... - 06:37 pm Revision a1cd7c1e: htools: improve more unittests
- Using new functionality in QuickCheck 2 (the suchThat function), we
generate now better test cases, such that (heh) w... - 06:37 pm Revision 00c75986: htools: more fixes to unsatisfiable tests
- Currently the way we generate nodes in some cases is by creating a
totally random node, then restricting the test bas... - 06:37 pm Revision 41085bd3: htools: Rework some unittests
- The new scaffolding which replaced the batch driver of QuickCheck 1 now
shows how many passes we have for incomplete ... - 06:37 pm Revision 509809db: htools: allow unittest to be replayed
- This just adds glue to allow replaying of tests using a given RNG state
and test size (both are needed for exact repl... - 06:37 pm Revision 309e7c9a: htools: fix corner case in prop_Text_Load_Instance
- This unittest had a corner case where it could fail if the same
primary/secondary node names were generated.
Signed-... - 06:37 pm Revision 752635d3: htools: fix prop_Node_rMem corner case
- This patch fixes a bug in the test specification where we allowed nodes
with zero free memory (hence no instance can ... - 06:37 pm Revision 8e4f6d56: htools: Switch to QuickCheck 2.x
- Since current distros don't package anymore QuickCheck 1.x, let's move
to 2.x.
This requires also a few changes to t... - 06:35 pm Revision cc532bdd: htools: some lint fixes
- Removal of duplicate parantheses, removal of extra 'do', conversion from
nested if to guards, use hierarchical import... - 06:35 pm Revision 88253d03: htools: rewrite Cluster.filterMGResults
- filterMGResults was built using a sequence of map and filter calls;
while this was logically correct, it used some in... - 06:35 pm Revision e4491427: htools: use the new Group.isAllocable
- … instead of the hardcoded test against AllocUnallocable.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by:... - 06:35 pm Revision 0ec6344e: htools: add a helper function
- … that checks if a group is allocable.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann... - 06:02 pm Revision 78ff9e8f: Fix a lint warning
- Patch db8e5f1c removed the use of feedback_fn, hence pylint warn
now.
Signed-off-by: Iustin Pop <iustin@google.com>
... - 06:02 pm Revision b768099e: Fix bug in recreate-disks for DRBD instances
- The new functionality in 2.4.2 for recreate-disks to change nodes is
broken for DRBD instances: it simply changes the... - 12:56 am Revision cc8a8ed7: KVM: configure bridged NICs at migration start
- Commit 5d9bfd870 moved tap interface handling from KVM to Ganeti, partly
to also solve the problem of routed interfac...
06/27/2011
- 04:35 pm Revision 96747bda: Fix RAPI documentation regarding master role
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 01:53 pm Revision db8e5f1c: Fix bug in drbd8 replace disks on current nodes
- Currently the drbd8 replace-disks on the same node (i.e. -p or -s) has
a bug in that it does modify the instance disk...
06/24/2011
- 05:19 pm Revision 1d66efbe: Enable using ghc parallel version 3
- Currently htools cannot be compiled under sid because the parallel
haskell library is version 3. Using it issues a fe...
06/23/2011
- 05:47 pm Revision de2b0d1d: Merge branch 'devel-2.4'
- * devel-2.4:
LUInstanceCreate: use opcodes.RequireFileStorage
Don't add ",boot=on" to disks on kvm >= 0.14
KVM:... - 04:53 pm Revision 0376655e: remove bootstrap._InitSharedFileStorage
- This function is a copy of bootstrap._InitFileStorage with the following
differences:
- check constants.ENABLE_SHAR... - 04:51 pm Revision 7afca87f: LUInstanceCreate: use opcodes.RequireFileStorage
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:51 pm Revision 4304964a: Don't add ",boot=on" to disks on kvm >= 0.14
- Under newer kvm this prevents the vm from starting.
Ah, change!
Signed-off-by: Guido Trotter <ultrotter@google.com>
...
06/22/2011
- 07:16 pm Revision 3af16328: KVM: fix per-instance stored UID value
- When using the pool security model, _ExecuteKVMRuntime was storing the
instance's UID using str(uid), which would res...
06/17/2011
- 03:57 pm Revision 2492231f: Merge branch 'devel-2.4'
- * devel-2.4:
Add one forgotten element to the file disk path
Signed-off-by: Guido Trotter <ultrotter@google.com>
R... - 03:57 pm Revision 00ca374a: Add one forgotten element to the file disk path
- This was left out during the fix/refactoring
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René N... - 02:36 pm Revision 08b000be: Merge branch 'devel-2.4'
- * devel-2.4:
LUInstanceCreate: fix file storage dir calculation
Check that filestorage is enabled when requested
... - 02:26 pm Revision c16915bd: Add DTS_FILEBASED constant
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 02:26 pm Revision d2129ac4: LUInstanceCreate: fix file storage dir calculation
- - Move the calculation at the beginning of CheckPrereq, since it doesn't
modify any state, but still keeps locks
- ... - 02:26 pm Revision 1bb1e297: Check that filestorage is enabled when requested
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 02:25 pm Revision 2112772e: Remove self.op.file_storage_dir isabs check
- As the manpage says, and the code does, self.op.file_storage_dir is an
additional relative path under the cluster fil... - 11:41 am Revision 9afa0de1: htools live test: test instance selection as well
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:41 am Revision bcd87e22: --select-instances hbal manpage update
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:41 am Revision fcd731d9: Check that the selected instances are known
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:38 am Revision c6ccc073: Loader.updateMovable: evaluate selected instances
- This also adds docstrings for the function arguments and renames exinst
to exinsts, which is how it is called in othe... - 11:38 am Revision 2d1708e0: Add instance selection list to Loader.mergeData
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:38 am Revision ddef0585: Add --select-instances hbal flag
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:38 am Revision 6c30ce16: Remove double whitespace in help string
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:19 am Revision eec83a95: Add gnt-network design doc
- This design covers high level network block definition and pool
management.
Signed-off-by: Apollon Oikonomopoulos <a...
06/15/2011
- 06:11 pm Revision 60152bbe: Replace iallocator's mreloc w/ change-group and node-evac
- This patch removes all occurrences of the “multi-relocate” iallocator
mode. Commit 25ee7fd845 updated the design docu...
06/14/2011
- 03:46 pm Revision fa23cc50: Fix a couple of typos
- Signed-off-by: Stephen Shirley <diamond@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Also available in: Atom